Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API
Thanks Alex, added the clarification to the FLIP doc. It will return a kv pairs of id to value following the conventions of other metric endpoints, by extending `AbstractMetricsHandler`. On Wed, Feb 14, 2024 at 9:38 AM Maximilian Michels wrote: > No objections. > > -Max > > On Wed, Feb 14, 2024 at 1:49 PM Alexander Fedulov > wrote: > > > > Hi Mason, > > > > the adjustments of not requiring the operator ID make sense to me since > > this is the more prevalent expected usage pattern. I guess one small > > clarification that might be needed is the mention of the return data > type. > > I assume since there are potentially multiple coordinators that can > belong > > to the same vertex, the proposed new endpoint will return an array. Is > that > > the plan? > > > > Overall +1 from my side. > > > > Best, > > Alex > > > > On Tue, 13 Feb 2024 at 22:49, Mason Chen wrote: > > > > > Hi voters and devs, > > > > > > I'm inclined to close the voting thread with the additional minor > details > > > to the FLIP. Please chime in if there are any objections! > > > > > > Best, > > > Mason > > > > > > On Wed, Feb 7, 2024 at 11:49 AM Mason Chen > wrote: > > > > > > > Hi Voters, > > > > > > > > JFYI, I have modified the proposed REST API path and added changes > to the > > > > metric scope configuration--you can find the reasoning and > discussion in > > > > the `[DISCUSS]` thread and FLIP doc. Please let me know if there are > any > > > > concerns. > > > > > > > > Best, > > > > Mason > > > > > > > > On Mon, Jan 29, 2024 at 5:32 AM Thomas Weise wrote: > > > > > > > >> +1 (binding) > > > >> > > > >> > > > >> On Mon, Jan 29, 2024 at 5:45 AM Maximilian Michels > > > >> wrote: > > > >> > > > >> > +1 (binding) > > > >> > > > > >> > On Fri, Jan 26, 2024 at 6:03 AM Rui Fan <1996fan...@gmail.com> > wrote: > > > >> > > > > > >> > > +1(binding) > > > >> > > > > > >> > > Best, > > > >> > > Rui > > > >> > > > > > >> > > On Fri, Jan 26, 2024 at 11:55 AM Xuyang > wrote: > > > >> > > > > > >> > > > +1 (non-binding) > > > >> > > > > > > >> > > > > > > >> > > > -- > > > >> > > > > > > >> > > > Best！ > > > >> > > > Xuyang > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > 在 2024-01-26 10:12:34，"Hang Ruan" > 写道： > > > >> > > > >Thanks for the FLIP. > > > >> > > > > > > > >> > > > >+1 (non-binding) > > > >> > > > > > > > >> > > > >Best, > > > >> > > > >Hang > > > >> > > > > > > > >> > > > >Mason Chen 于2024年1月26日周五 04:51写道： > > > >> > > > > > > > >> > > > >> Hi Devs, > > > >> > > > >> > > > >> > > > >> I would like to start a vote on FLIP-417: Expose > > > >> > > > JobManagerOperatorMetrics > > > >> > > > >> via REST API [1] which has been discussed in this thread > [2]. > > > >> > > > >> > > > >> > > > >> The vote will be open for at least 72 hours unless there > is an > > > >> > > > objection or > > > >> > > > >> not enough votes. > > > >> > > > >> > > > >> > > > >> [1] > > > >> > > > >> > > > >> > > > >> > > > >> > > > > > > >> > > > > >> > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-417%3A+Expose+JobManagerOperatorMetrics+via+REST+API > > > >> > > > >> [2] > > > >> > https://lists.apache.org/thread/tt0hf6kf5lcxd7g62v9dhpn3z978pxw0 > > > >> > > > >> > > > >> > > > >> Best, > > > >> > > > >> Mason > > > >> > > > >> > > > >> > > > > > > >> > > > > >> > > > > > > > >
Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API
No objections. -Max On Wed, Feb 14, 2024 at 1:49 PM Alexander Fedulov wrote: > > Hi Mason, > > the adjustments of not requiring the operator ID make sense to me since > this is the more prevalent expected usage pattern. I guess one small > clarification that might be needed is the mention of the return data type. > I assume since there are potentially multiple coordinators that can belong > to the same vertex, the proposed new endpoint will return an array. Is that > the plan? > > Overall +1 from my side. > > Best, > Alex > > On Tue, 13 Feb 2024 at 22:49, Mason Chen wrote: > > > Hi voters and devs, > > > > I'm inclined to close the voting thread with the additional minor details > > to the FLIP. Please chime in if there are any objections! > > > > Best, > > Mason > > > > On Wed, Feb 7, 2024 at 11:49 AM Mason Chen wrote: > > > > > Hi Voters, > > > > > > JFYI, I have modified the proposed REST API path and added changes to the > > > metric scope configuration--you can find the reasoning and discussion in > > > the `[DISCUSS]` thread and FLIP doc. Please let me know if there are any > > > concerns. > > > > > > Best, > > > Mason > > > > > > On Mon, Jan 29, 2024 at 5:32 AM Thomas Weise wrote: > > > > > >> +1 (binding) > > >> > > >> > > >> On Mon, Jan 29, 2024 at 5:45 AM Maximilian Michels > > >> wrote: > > >> > > >> > +1 (binding) > > >> > > > >> > On Fri, Jan 26, 2024 at 6:03 AM Rui Fan <1996fan...@gmail.com> wrote: > > >> > > > > >> > > +1(binding) > > >> > > > > >> > > Best, > > >> > > Rui > > >> > > > > >> > > On Fri, Jan 26, 2024 at 11:55 AM Xuyang wrote: > > >> > > > > >> > > > +1 (non-binding) > > >> > > > > > >> > > > > > >> > > > -- > > >> > > > > > >> > > > Best！ > > >> > > > Xuyang > > >> > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > 在 2024-01-26 10:12:34，"Hang Ruan" 写道： > > >> > > > >Thanks for the FLIP. > > >> > > > > > > >> > > > >+1 (non-binding) > > >> > > > > > > >> > > > >Best, > > >> > > > >Hang > > >> > > > > > > >> > > > >Mason Chen 于2024年1月26日周五 04:51写道： > > >> > > > > > > >> > > > >> Hi Devs, > > >> > > > >> > > >> > > > >> I would like to start a vote on FLIP-417: Expose > > >> > > > JobManagerOperatorMetrics > > >> > > > >> via REST API [1] which has been discussed in this thread [2]. > > >> > > > >> > > >> > > > >> The vote will be open for at least 72 hours unless there is an > > >> > > > objection or > > >> > > > >> not enough votes. > > >> > > > >> > > >> > > > >> [1] > > >> > > > >> > > >> > > > >> > > >> > > > > > >> > > > >> > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-417%3A+Expose+JobManagerOperatorMetrics+via+REST+API > > >> > > > >> [2] > > >> > https://lists.apache.org/thread/tt0hf6kf5lcxd7g62v9dhpn3z978pxw0 > > >> > > > >> > > >> > > > >> Best, > > >> > > > >> Mason > > >> > > > >> > > >> > > > > > >> > > > >> > > > > >
Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API
Hi Mason, the adjustments of not requiring the operator ID make sense to me since this is the more prevalent expected usage pattern. I guess one small clarification that might be needed is the mention of the return data type. I assume since there are potentially multiple coordinators that can belong to the same vertex, the proposed new endpoint will return an array. Is that the plan? Overall +1 from my side. Best, Alex On Tue, 13 Feb 2024 at 22:49, Mason Chen wrote: > Hi voters and devs, > > I'm inclined to close the voting thread with the additional minor details > to the FLIP. Please chime in if there are any objections! > > Best, > Mason > > On Wed, Feb 7, 2024 at 11:49 AM Mason Chen wrote: > > > Hi Voters, > > > > JFYI, I have modified the proposed REST API path and added changes to the > > metric scope configuration--you can find the reasoning and discussion in > > the `[DISCUSS]` thread and FLIP doc. Please let me know if there are any > > concerns. > > > > Best, > > Mason > > > > On Mon, Jan 29, 2024 at 5:32 AM Thomas Weise wrote: > > > >> +1 (binding) > >> > >> > >> On Mon, Jan 29, 2024 at 5:45 AM Maximilian Michels > >> wrote: > >> > >> > +1 (binding) > >> > > >> > On Fri, Jan 26, 2024 at 6:03 AM Rui Fan <1996fan...@gmail.com> wrote: > >> > > > >> > > +1(binding) > >> > > > >> > > Best, > >> > > Rui > >> > > > >> > > On Fri, Jan 26, 2024 at 11:55 AM Xuyang wrote: > >> > > > >> > > > +1 (non-binding) > >> > > > > >> > > > > >> > > > -- > >> > > > > >> > > > Best！ > >> > > > Xuyang > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > 在 2024-01-26 10:12:34，"Hang Ruan" 写道： > >> > > > >Thanks for the FLIP. > >> > > > > > >> > > > >+1 (non-binding) > >> > > > > > >> > > > >Best, > >> > > > >Hang > >> > > > > > >> > > > >Mason Chen 于2024年1月26日周五 04:51写道： > >> > > > > > >> > > > >> Hi Devs, > >> > > > >> > >> > > > >> I would like to start a vote on FLIP-417: Expose > >> > > > JobManagerOperatorMetrics > >> > > > >> via REST API [1] which has been discussed in this thread [2]. > >> > > > >> > >> > > > >> The vote will be open for at least 72 hours unless there is an > >> > > > objection or > >> > > > >> not enough votes. > >> > > > >> > >> > > > >> [1] > >> > > > >> > >> > > > >> > >> > > > > >> > > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-417%3A+Expose+JobManagerOperatorMetrics+via+REST+API > >> > > > >> [2] > >> > https://lists.apache.org/thread/tt0hf6kf5lcxd7g62v9dhpn3z978pxw0 > >> > > > >> > >> > > > >> Best, > >> > > > >> Mason > >> > > > >> > >> > > > > >> > > >> > > >
Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API
Hi voters and devs, I'm inclined to close the voting thread with the additional minor details to the FLIP. Please chime in if there are any objections! Best, Mason On Wed, Feb 7, 2024 at 11:49 AM Mason Chen wrote: > Hi Voters, > > JFYI, I have modified the proposed REST API path and added changes to the > metric scope configuration--you can find the reasoning and discussion in > the `[DISCUSS]` thread and FLIP doc. Please let me know if there are any > concerns. > > Best, > Mason > > On Mon, Jan 29, 2024 at 5:32 AM Thomas Weise wrote: > >> +1 (binding) >> >> >> On Mon, Jan 29, 2024 at 5:45 AM Maximilian Michels >> wrote: >> >> > +1 (binding) >> > >> > On Fri, Jan 26, 2024 at 6:03 AM Rui Fan <1996fan...@gmail.com> wrote: >> > > >> > > +1(binding) >> > > >> > > Best, >> > > Rui >> > > >> > > On Fri, Jan 26, 2024 at 11:55 AM Xuyang wrote: >> > > >> > > > +1 (non-binding) >> > > > >> > > > >> > > > -- >> > > > >> > > > Best！ >> > > > Xuyang >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > 在 2024-01-26 10:12:34，"Hang Ruan" 写道： >> > > > >Thanks for the FLIP. >> > > > > >> > > > >+1 (non-binding) >> > > > > >> > > > >Best, >> > > > >Hang >> > > > > >> > > > >Mason Chen 于2024年1月26日周五 04:51写道： >> > > > > >> > > > >> Hi Devs, >> > > > >> >> > > > >> I would like to start a vote on FLIP-417: Expose >> > > > JobManagerOperatorMetrics >> > > > >> via REST API [1] which has been discussed in this thread [2]. >> > > > >> >> > > > >> The vote will be open for at least 72 hours unless there is an >> > > > objection or >> > > > >> not enough votes. >> > > > >> >> > > > >> [1] >> > > > >> >> > > > >> >> > > > >> > >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-417%3A+Expose+JobManagerOperatorMetrics+via+REST+API >> > > > >> [2] >> > https://lists.apache.org/thread/tt0hf6kf5lcxd7g62v9dhpn3z978pxw0 >> > > > >> >> > > > >> Best, >> > > > >> Mason >> > > > >> >> > > > >> > >> >
Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API
Hi Voters, JFYI, I have modified the proposed REST API path and added changes to the metric scope configuration--you can find the reasoning and discussion in the `[DISCUSS]` thread and FLIP doc. Please let me know if there are any concerns. Best, Mason On Mon, Jan 29, 2024 at 5:32 AM Thomas Weise wrote: > +1 (binding) > > > On Mon, Jan 29, 2024 at 5:45 AM Maximilian Michels wrote: > > > +1 (binding) > > > > On Fri, Jan 26, 2024 at 6:03 AM Rui Fan <1996fan...@gmail.com> wrote: > > > > > > +1(binding) > > > > > > Best, > > > Rui > > > > > > On Fri, Jan 26, 2024 at 11:55 AM Xuyang wrote: > > > > > > > +1 (non-binding) > > > > > > > > > > > > -- > > > > > > > > Best！ > > > > Xuyang > > > > > > > > > > > > > > > > > > > > > > > > 在 2024-01-26 10:12:34，"Hang Ruan" 写道： > > > > >Thanks for the FLIP. > > > > > > > > > >+1 (non-binding) > > > > > > > > > >Best, > > > > >Hang > > > > > > > > > >Mason Chen 于2024年1月26日周五 04:51写道： > > > > > > > > > >> Hi Devs, > > > > >> > > > > >> I would like to start a vote on FLIP-417: Expose > > > > JobManagerOperatorMetrics > > > > >> via REST API [1] which has been discussed in this thread [2]. > > > > >> > > > > >> The vote will be open for at least 72 hours unless there is an > > > > objection or > > > > >> not enough votes. > > > > >> > > > > >> [1] > > > > >> > > > > >> > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-417%3A+Expose+JobManagerOperatorMetrics+via+REST+API > > > > >> [2] > > https://lists.apache.org/thread/tt0hf6kf5lcxd7g62v9dhpn3z978pxw0 > > > > >> > > > > >> Best, > > > > >> Mason > > > > >> > > > > > > >
Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API
+1 (binding) On Mon, Jan 29, 2024 at 5:45 AM Maximilian Michels wrote: > +1 (binding) > > On Fri, Jan 26, 2024 at 6:03 AM Rui Fan <1996fan...@gmail.com> wrote: > > > > +1(binding) > > > > Best, > > Rui > > > > On Fri, Jan 26, 2024 at 11:55 AM Xuyang wrote: > > > > > +1 (non-binding) > > > > > > > > > -- > > > > > > Best！ > > > Xuyang > > > > > > > > > > > > > > > > > > 在 2024-01-26 10:12:34，"Hang Ruan" 写道： > > > >Thanks for the FLIP. > > > > > > > >+1 (non-binding) > > > > > > > >Best, > > > >Hang > > > > > > > >Mason Chen 于2024年1月26日周五 04:51写道： > > > > > > > >> Hi Devs, > > > >> > > > >> I would like to start a vote on FLIP-417: Expose > > > JobManagerOperatorMetrics > > > >> via REST API [1] which has been discussed in this thread [2]. > > > >> > > > >> The vote will be open for at least 72 hours unless there is an > > > objection or > > > >> not enough votes. > > > >> > > > >> [1] > > > >> > > > >> > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-417%3A+Expose+JobManagerOperatorMetrics+via+REST+API > > > >> [2] > https://lists.apache.org/thread/tt0hf6kf5lcxd7g62v9dhpn3z978pxw0 > > > >> > > > >> Best, > > > >> Mason > > > >> > > > >
Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API
+1 (binding) On Fri, Jan 26, 2024 at 6:03 AM Rui Fan <1996fan...@gmail.com> wrote: > > +1(binding) > > Best, > Rui > > On Fri, Jan 26, 2024 at 11:55 AM Xuyang wrote: > > > +1 (non-binding) > > > > > > -- > > > > Best！ > > Xuyang > > > > > > > > > > > > 在 2024-01-26 10:12:34，"Hang Ruan" 写道： > > >Thanks for the FLIP. > > > > > >+1 (non-binding) > > > > > >Best, > > >Hang > > > > > >Mason Chen 于2024年1月26日周五 04:51写道： > > > > > >> Hi Devs, > > >> > > >> I would like to start a vote on FLIP-417: Expose > > JobManagerOperatorMetrics > > >> via REST API [1] which has been discussed in this thread [2]. > > >> > > >> The vote will be open for at least 72 hours unless there is an > > objection or > > >> not enough votes. > > >> > > >> [1] > > >> > > >> > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-417%3A+Expose+JobManagerOperatorMetrics+via+REST+API > > >> [2] https://lists.apache.org/thread/tt0hf6kf5lcxd7g62v9dhpn3z978pxw0 > > >> > > >> Best, > > >> Mason > > >> > >
Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API
+1(binding) Best, Rui On Fri, Jan 26, 2024 at 11:55 AM Xuyang wrote: > +1 (non-binding) > > > -- > > Best！ > Xuyang > > > > > > 在 2024-01-26 10:12:34，"Hang Ruan" 写道： > >Thanks for the FLIP. > > > >+1 (non-binding) > > > >Best, > >Hang > > > >Mason Chen 于2024年1月26日周五 04:51写道： > > > >> Hi Devs, > >> > >> I would like to start a vote on FLIP-417: Expose > JobManagerOperatorMetrics > >> via REST API [1] which has been discussed in this thread [2]. > >> > >> The vote will be open for at least 72 hours unless there is an > objection or > >> not enough votes. > >> > >> [1] > >> > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-417%3A+Expose+JobManagerOperatorMetrics+via+REST+API > >> [2] https://lists.apache.org/thread/tt0hf6kf5lcxd7g62v9dhpn3z978pxw0 > >> > >> Best, > >> Mason > >> >
Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API
Thanks for the FLIP. +1 (non-binding) Best, Hang Mason Chen 于2024年1月26日周五 04:51写道： > Hi Devs, > > I would like to start a vote on FLIP-417: Expose JobManagerOperatorMetrics > via REST API [1] which has been discussed in this thread [2]. > > The vote will be open for at least 72 hours unless there is an objection or > not enough votes. > > [1] > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-417%3A+Expose+JobManagerOperatorMetrics+via+REST+API > [2] https://lists.apache.org/thread/tt0hf6kf5lcxd7g62v9dhpn3z978pxw0 > > Best, > Mason >
