Re: flink-connector-kafka weekly CI job failing
Hi, all. I see there is already an issue[1] about this problem. We could copy the new class `TypeSerializerConditions` into kafka connector like the issue[2], which fixed the failure for 1.18-SNAPSHOT. I would like to help it. Best, Hang [1] https://issues.apache.org/jira/browse/FLINK-35109 [2] https://issues.apache.org/jira/browse/FLINK-32455 Hang Ruan 于2024年5月11日周六 09:44写道： > Hi, all. > > The class `TypeSerializerMatchers` has been deleted in Flink version > 1.20-SNAPSHOT. > If we need to compile kafka connector with both 1.19 and 1.20, I think we > have to copy `TypeSerializerMatchers` to kafka connector. But it is not a > good idea. > Besides this, I find that the flink-core test-jar does not contain the > classes like `TypeSerializer`. We have to add the flink-core with the > provided scope. > > I am not sure what is the best way to fix this. > > Best, > Hang > > Danny Cranmer 于2024年5月11日周六 04:30写道： > >> Hello, >> >> Is there a reason we cannot fix the code rather than disabling the test? >> If >> we skip the tests this will likely be missed and cause delays for 1.20 >> support down the road. >> >> Thanks, >> Danny >> >> On Wed, 8 May 2024, 23:35 Robert Young, wrote: >> >> > Hi, >> > >> > I noticed the flink-connector-kafka weekly CI job is failing: >> > >> > https://github.com/apache/flink-connector-kafka/actions/runs/8954222477 >> > >> > Looks like flink-connector-kafka main has a compile error against flink >> > 1.20-SNAPSHOT, I tried locally and get a different compile failure >> > >> > KafkaSerializerUpgradeTest.java:[23,45] cannot find symbol >> > [ERROR] symbol: class TypeSerializerMatchers >> > [ERROR] location: package org.apache.flink.api.common.typeutils >> > >> > Should 1.20-SNAPSHOT be removed from the weekly tests for now? >> > >> > Thanks >> > Rob >> > >> >
Re: flink-connector-kafka weekly CI job failing
Hi, all. The class `TypeSerializerMatchers` has been deleted in Flink version 1.20-SNAPSHOT. If we need to compile kafka connector with both 1.19 and 1.20, I think we have to copy `TypeSerializerMatchers` to kafka connector. But it is not a good idea. Besides this, I find that the flink-core test-jar does not contain the classes like `TypeSerializer`. We have to add the flink-core with the provided scope. I am not sure what is the best way to fix this. Best, Hang Danny Cranmer 于2024年5月11日周六 04:30写道： > Hello, > > Is there a reason we cannot fix the code rather than disabling the test? If > we skip the tests this will likely be missed and cause delays for 1.20 > support down the road. > > Thanks, > Danny > > On Wed, 8 May 2024, 23:35 Robert Young, wrote: > > > Hi, > > > > I noticed the flink-connector-kafka weekly CI job is failing: > > > > https://github.com/apache/flink-connector-kafka/actions/runs/8954222477 > > > > Looks like flink-connector-kafka main has a compile error against flink > > 1.20-SNAPSHOT, I tried locally and get a different compile failure > > > > KafkaSerializerUpgradeTest.java:[23,45] cannot find symbol > > [ERROR] symbol: class TypeSerializerMatchers > > [ERROR] location: package org.apache.flink.api.common.typeutils > > > > Should 1.20-SNAPSHOT be removed from the weekly tests for now? > > > > Thanks > > Rob > > >
Re: flink-connector-kafka weekly CI job failing
Hello, Is there a reason we cannot fix the code rather than disabling the test? If we skip the tests this will likely be missed and cause delays for 1.20 support down the road. Thanks, Danny On Wed, 8 May 2024, 23:35 Robert Young, wrote: > Hi, > > I noticed the flink-connector-kafka weekly CI job is failing: > > https://github.com/apache/flink-connector-kafka/actions/runs/8954222477 > > Looks like flink-connector-kafka main has a compile error against flink > 1.20-SNAPSHOT, I tried locally and get a different compile failure > > KafkaSerializerUpgradeTest.java:[23,45] cannot find symbol > [ERROR] symbol: class TypeSerializerMatchers > [ERROR] location: package org.apache.flink.api.common.typeutils > > Should 1.20-SNAPSHOT be removed from the weekly tests for now? > > Thanks > Rob >
flink-connector-kafka weekly CI job failing
Hi, I noticed the flink-connector-kafka weekly CI job is failing: https://github.com/apache/flink-connector-kafka/actions/runs/8954222477 Looks like flink-connector-kafka main has a compile error against flink 1.20-SNAPSHOT, I tried locally and get a different compile failure KafkaSerializerUpgradeTest.java:[23,45] cannot find symbol [ERROR] symbol: class TypeSerializerMatchers [ERROR] location: package org.apache.flink.api.common.typeutils Should 1.20-SNAPSHOT be removed from the weekly tests for now? Thanks Rob
