Re: https://cwiki.apache.org/confluence/display/FLUME/Index
Hi Arvind, Thanks, I'm done. For the record Flume wiki: - copied Index into Home - edited Index as deprecated (https://cwiki.apache.org/FLUME/) and added a link to the confluence space (https://cwiki.apache.org/confluence/display/FLUME/Home) space (picked up from Sqoop wiki) -- the installed Auto Export Plugin, which can't be disabled, do the HTML export. If you click the link all other pages will be rendered in HTML too, so I want that the search engines will update the main page into the confluence page (link follow, update) - added our Flume Logo as Space logo - added FLUME-1725 Sqoop Wiki: - Added SQOOP-709 cheers, Alex On Nov 18, 2012, at 8:10 PM, Arvind Prabhakar wrote: > Hi Alex, > > I have granted you temporary administrator privileges for both the spaces. > Please let me know as soon as you are done with the changes as I will have > to revert the privileges back to normal. > > Regards, > Arvind Prabhakar > > On Thu, Nov 15, 2012 at 10:40 PM, Alexander Alten-Lorenz < > wget.n...@gmail.com> wrote: > >> Hi Arvid, >> >> Can I please have Space Admin rights for Sqoop and Flume Confluence spaces >> to configure the index as well the favicon? >> >> Thanks, >> Alex >> >> Begin forwarded message: >> >>> From: Alexander Alten-Lorenz >>> Subject: Re: https://cwiki.apache.org/confluence/display/FLUME/Index >>> Date: November 15, 2012 10:11:53 AM GMT+01:00 >>> To: dev@flume.apache.org >>> >>> I did some changes today, but I guess confluence has a bug: >>> >>> https://cwiki.apache.org/FLUME/index.html - the h1. line is missing, >> and the layout was bad. I did a ugly hack (adding 5 spaces as a own column). >>> https://cwiki.apache.org/confluence/display/FLUME/Index - looks much >> better, but will not shown as the index.html >>> >>> I didn't figured out what the heck is going on there, I guess a bug in >> the html exporter (parser)? >>> >>> Anyway, looks now cleaner and I moved Mike's both article into the blog >> section and linked that together to get better search engines results. >>> >>> Thanks, >>> Alex >>> >>> >>> On Nov 15, 2012, at 3:21 AM, Brock Noland wrote: >>> Big +1 Thank you very much! On Wed, Nov 14, 2012 at 6:05 PM, Hari Shreedharan wrote: > Excellent work! This was something I heard from many people - the wiki >> is the top result if you search for Flume docs, and it pointed to OG stuff. >> Thanks to you, now that is taken care of. > > Thanks a lot for this effort! > > > Hari > > -- > Hari Shreedharan > > > On Wednesday, November 14, 2012 at 3:52 PM, Mike Percy wrote: > >> Alex, this looks great! Thanks so much for spending the time to >> reorganize >> the Wiki. It is way more useful. >> >> Regards, >> Mike >> >> On Wed, Nov 14, 2012 at 6:27 AM, Alexander Alten-Lorenz < >> wget.n...@gmail.com (mailto:wget.n...@gmail.com) >>> wrote: >> >> >>> Guys, >>> >>> I've spent most of my day today to reorganize the wiki, please have >> a look >>> and ping me with all stuff you miss or what we should organize >> better. >>> >>> I was moving all the OG stuff into a new section, called Flume OG >> (pre >>> 1.0), the same I did with all Flume NG stuff. Also I added a >> blogpost about >>> flume's memory consumption and will add some from time time with >> topics we >>> figured out in our mailing list. Of course, add own stuff too! >>> >>> I did some cosmetic changes too (include our logo as example). >>> >>> best, >>> Alex >>> >>> >>> >>> -- >>> Alexander Alten-Lorenz >>> http://mapredit.blogspot.com >>> German Hadoop LinkedIn Group: http://goo.gl/N8pCF >>> >> >> >> > > -- Apache MRUnit - Unit testing MapReduce - >> http://incubator.apache.org/mrunit/ >>> >>> -- >>> Alexander Alten-Lorenz >>> http://mapredit.blogspot.com >>> German Hadoop LinkedIn Group: http://goo.gl/N8pCF >>> >> >> -- >> Alexander Alten-Lorenz >> http://mapredit.blogspot.com >> German Hadoop LinkedIn Group: http://goo.gl/N8pCF >> >> -- Alexander Alten-Lorenz http://mapredit.blogspot.com German Hadoop LinkedIn Group: http://goo.gl/N8pCF
[jira] [Updated] (FLUME-1726) SpoolingFileLineReader must close the reader before renaming.
[ https://issues.apache.org/jira/browse/FLUME-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-1726: Description: This fails on Windows when the reader is still open. > SpoolingFileLineReader must close the reader before renaming. > - > > Key: FLUME-1726 > URL: https://issues.apache.org/jira/browse/FLUME-1726 > Project: Flume > Issue Type: Bug > Components: Node, Sinks+Sources >Affects Versions: v1.3.0 >Reporter: Hari Shreedharan >Assignee: Hari Shreedharan > Fix For: v1.3.0 > > Attachments: FLUME-1726.patch > > > This fails on Windows when the reader is still open. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1726) SpoolingFileLineReader must close the reader before renaming.
[ https://issues.apache.org/jira/browse/FLUME-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-1726: Attachment: FLUME-1726.patch > SpoolingFileLineReader must close the reader before renaming. > - > > Key: FLUME-1726 > URL: https://issues.apache.org/jira/browse/FLUME-1726 > Project: Flume > Issue Type: Bug > Components: Node, Sinks+Sources >Affects Versions: v1.3.0 >Reporter: Hari Shreedharan >Assignee: Hari Shreedharan > Fix For: v1.3.0 > > Attachments: FLUME-1726.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Review Request: FLUME-1726. SpoolingFileLineReader must close the reader before renaming.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8124/ --- Review request for Flume. Description --- Moved the reader.close call before the rename calls. This addresses bug FLUME-1726. https://issues.apache.org/jira/browse/FLUME-1726 Diffs - flume-ng-core/src/main/java/org/apache/flume/client/avro/SpoolingFileLineReader.java b37b730 Diff: https://reviews.apache.org/r/8124/diff/ Testing --- Thanks, Hari Shreedharan
[jira] [Created] (FLUME-1726) SpoolingFileLineReader must close the reader before renaming.
Hari Shreedharan created FLUME-1726: --- Summary: SpoolingFileLineReader must close the reader before renaming. Key: FLUME-1726 URL: https://issues.apache.org/jira/browse/FLUME-1726 Project: Flume Issue Type: Bug Components: Node, Sinks+Sources Affects Versions: v1.3.0 Reporter: Hari Shreedharan Assignee: Hari Shreedharan Fix For: v1.3.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1725) Add Quick Hack Sheet into Flume Wiki
[ https://issues.apache.org/jira/browse/FLUME-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500074#comment-13500074 ] Alexander Alten-Lorenz commented on FLUME-1725: --- https://cwiki.apache.org/confluence/display/FLUME/Developers+Quick+Hack+Sheet Please leave comments here to improve > Add Quick Hack Sheet into Flume Wiki > > > Key: FLUME-1725 > URL: https://issues.apache.org/jira/browse/FLUME-1725 > Project: Flume > Issue Type: Task > Components: Docs >Reporter: Alexander Alten-Lorenz >Assignee: Alexander Alten-Lorenz >Priority: Minor > > Add a short dev description into the wiki's corner to guide new contributors > in a short way -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FLUME-1725) Add Quick Hack Sheet into Flume Wiki
Alexander Alten-Lorenz created FLUME-1725: - Summary: Add Quick Hack Sheet into Flume Wiki Key: FLUME-1725 URL: https://issues.apache.org/jira/browse/FLUME-1725 Project: Flume Issue Type: Task Components: Docs Reporter: Alexander Alten-Lorenz Assignee: Alexander Alten-Lorenz Priority: Minor Add a short dev description into the wiki's corner to guide new contributors in a short way -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FLUME-1724) Flume should support writing in HFile format to HDFS
Hari Shreedharan created FLUME-1724: --- Summary: Flume should support writing in HFile format to HDFS Key: FLUME-1724 URL: https://issues.apache.org/jira/browse/FLUME-1724 Project: Flume Issue Type: Bug Reporter: Hari Shreedharan -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: FLUME-1699. Make the rename of the meta file platform neutral
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8087/ --- (Updated Nov. 19, 2012, 4:53 a.m.) Review request for Flume and Brock Noland. Description --- If atomic rename fails, rename the current meta file to old, rename tmp to meta and then delete old. This addresses bug FLUME-1699. https://issues.apache.org/jira/browse/FLUME-1699 Diffs - flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java 82e14b0 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java f768d23 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java 6b0eeb3 flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogFile.java 4b69698 Diff: https://reviews.apache.org/r/8087/diff/ Testing --- All unit tests pass Thanks, Hari Shreedharan
[jira] [Updated] (FLUME-1699) Make the rename of the meta file platform neutral
[ https://issues.apache.org/jira/browse/FLUME-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-1699: Attachment: FLUME-1699-1.patch > Make the rename of the meta file platform neutral > - > > Key: FLUME-1699 > URL: https://issues.apache.org/jira/browse/FLUME-1699 > Project: Flume > Issue Type: Bug >Reporter: Hari Shreedharan >Assignee: Hari Shreedharan > Attachments: FLUME-1699-1.patch, FLUME-1699.patch > > > File.renameTo() may not work correctly on some platforms, notably Windows. We > should strive to keep all out code platform neutral, so we don't have to do a > lot of work at some point for porting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: FLUME-1699. Make the rename of the meta file platform neutral
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8087/ --- (Updated Nov. 19, 2012, 4:42 a.m.) Review request for Flume. Changes --- Added code to handle picking up the temp or old files during startup. Also added unit tests for this. Description --- If atomic rename fails, rename the current meta file to old, rename tmp to meta and then delete old. This addresses bug FLUME-1699. https://issues.apache.org/jira/browse/FLUME-1699 Diffs (updated) - flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java 82e14b0 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java f768d23 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java 6b0eeb3 flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogFile.java 4b69698 Diff: https://reviews.apache.org/r/8087/diff/ Testing --- All unit tests pass Thanks, Hari Shreedharan
Re: [VOTE] Release Apache Flume version 1.3.0-rc3
If we're doing another RC, I'd like it if we could squeeze in FLUME-1660 too as I've seen several users inquiring about closing tmp files, and I think it provides the best solution for many of them. I believe it was bumped out of 1.3 due to time constraints but it looks like that shouldn't be an issue now? Personally, +0 on the release, haven't found the time to do a thorough check. On 11/19/2012 01:36 AM, Jarek Jarcec Cecho wrote: Thank you sir, greatly appreciated! Jarcec On Sat, Nov 17, 2012 at 07:39:57PM -0800, Mike Percy wrote: Done. Regards Mike On Sat, Nov 17, 2012 at 7:27 PM, Jarek Jarcec Cecho wrote: Might I humbly ask for review & commit FLUME-1719 for next RC? Jarcec On Sat, Nov 17, 2012 at 07:13:26PM -0800, Hari Shreedharan wrote: Done! Thanks Mike, Brock! Hari -- Hari Shreedharan On Saturday, November 17, 2012 at 7:05 PM, Brock Noland wrote: Ok, let's do another rc since the same lobs with different versions is probably bad. Also I think it's fine to commit to 1.3 without another rc since we are voting on a tag, not the branch. -- Brock Noland Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Saturday, November 17, 2012 at 8:45 PM, Mike Percy wrote: Hari, You're correct that a -1 vote does not veto a release. A savvy user could delete one of the jars before deploying to production, but why make them do that. Thanks for the commit. Regards, Mike On Sat, Nov 17, 2012 at 6:12 PM, Hari Shreedharan < hshreedha...@cloudera.com (mailto:hshreedha...@cloudera.com) wrote: Mike, I committed your patch for flume-1.4, and trunk. Brock: As I posted on the jira, if you want it committed to flume-1.3. the RM should decide if another RC is required (looks like there are 3 PMC +1 already, unless someone withdraws the +1). If required, please cherry-pick the patch to flume-1.3.0 and roll another RC. Thanks, Hari -- Hari Shreedharan On Saturday, November 17, 2012 at 5:58 PM, Mike Percy wrote: When I was reviewing the libs I noticed that netty is in there twice with 2 different versions. I don't think we should ship like that. So, -1 from me on this RC. Details and a patch are here: https://issues.apache.org/jira/browse/FLUME-1723 Regards, Mike On Sat, Nov 17, 2012 at 3:33 PM, Brock Noland < br...@cloudera.com (mailto:br...@cloudera.com)(mailto: br...@cloudera.com (mailto:br...@cloudera.com))> wrote: Thanks Hari, I have created FLUME-1722 for this purpose. https://issues.apache.org/jira/browse/FLUME-1722 Brock On Sat, Nov 17, 2012 at 5:29 PM, Hari Shreedharan mailto:hshreedha...@cloudera.com)> wrote: +1. Here is what I checked: 1. Checksums and signatures look good. 2. Verified license file, readme, change log and notice file (more on this below). 3. Built, ran unit tests, ran an agent with the sample config - looks good. Additional notes: The LICENSE file seems to list three libraries which we do not pull in: commons logging http-client http-core We probably should remove these from the license file too. Thanks, Hari -- Hari Shreedharan On Saturday, November 17, 2012 at 12:57 AM, Alexander Alten-Lorenz wrote: +1 - Alex On Nov 17, 2012, at 4:10 AM, Will McQueen < w...@cloudera.com (mailto:w...@cloudera.com)(mailto: w...@cloudera.com (mailto:w...@cloudera.com)) (mailto: w...@cloudera.com (mailto:w...@cloudera.com))> wrote: +1 on the release On Nov 16, 2012, at 6:56 PM, Brock Noland < br...@cloudera.com (mailto:br...@cloudera.com)(mailto: br...@cloudera.com (mailto:br...@cloudera.com))(mailto: br...@cloudera.com (mailto:br...@cloudera.com))> wrote: Thanks Jarek, I don't think it's a blocker but we should definitely fix it. FWIW, hadoop's LICENSE.txt doesn't even list the licenses of binaries and Crunch was just released with many defects to this file. On Fri, Nov 16, 2012 at 8:42 PM, Jarek Jarcec Cecho < jar...@apache.org (mailto:jar...@apache.org)> wrote: I've noticed that LICENSE file contains entry protobuf-.jar whereas our binary artifacts seems to be pulling protobuf-java-.jar (filled FLUME-1720 [1]). It do need seems as a blocker to me, but it would be great if someone else with more deeper licensing knowledge would confirm that. As long as this is fine, I'm +1 on the release. Checked: * Checksums, signatures seems fine * "mvn clean compile test verify package" passes for source artifact * "mvn verify" passes for binary artifact * CHANGELOG, NOTICE, README, DEVNOTES files seems fine to me Notes: * Filled FLUME-1719: Example export command in README do not properly close the string * Filled FLUME-1720: LICENSE file contain entry for protobuf-.jar, however proper artifact name is protobuf-java-.jar Jarcec Links: 1: https://issues.apache.org/jira/browse/FLUME-1720 On Fri, Nov 16, 2012 at 07:49:13AM +0100, Alexander Alten-Lorenz wrote: looks good to me, thanks. +1 cheers, Alex On Nov 16, 2012, at 12:21 AM, Brock Noland < br...@cloudera.
Re: https://cwiki.apache.org/confluence/display/FLUME/Index
Hi Alex, I have granted you temporary administrator privileges for both the spaces. Please let me know as soon as you are done with the changes as I will have to revert the privileges back to normal. Regards, Arvind Prabhakar On Thu, Nov 15, 2012 at 10:40 PM, Alexander Alten-Lorenz < wget.n...@gmail.com> wrote: > Hi Arvid, > > Can I please have Space Admin rights for Sqoop and Flume Confluence spaces > to configure the index as well the favicon? > > Thanks, > Alex > > Begin forwarded message: > > > From: Alexander Alten-Lorenz > > Subject: Re: https://cwiki.apache.org/confluence/display/FLUME/Index > > Date: November 15, 2012 10:11:53 AM GMT+01:00 > > To: dev@flume.apache.org > > > > I did some changes today, but I guess confluence has a bug: > > > > https://cwiki.apache.org/FLUME/index.html - the h1. line is missing, > and the layout was bad. I did a ugly hack (adding 5 spaces as a own column). > > https://cwiki.apache.org/confluence/display/FLUME/Index - looks much > better, but will not shown as the index.html > > > > I didn't figured out what the heck is going on there, I guess a bug in > the html exporter (parser)? > > > > Anyway, looks now cleaner and I moved Mike's both article into the blog > section and linked that together to get better search engines results. > > > > Thanks, > > Alex > > > > > > On Nov 15, 2012, at 3:21 AM, Brock Noland wrote: > > > >> Big +1 > >> > >> Thank you very much! > >> > >> On Wed, Nov 14, 2012 at 6:05 PM, Hari Shreedharan > >> wrote: > >>> Excellent work! This was something I heard from many people - the wiki > is the top result if you search for Flume docs, and it pointed to OG stuff. > Thanks to you, now that is taken care of. > >>> > >>> Thanks a lot for this effort! > >>> > >>> > >>> Hari > >>> > >>> -- > >>> Hari Shreedharan > >>> > >>> > >>> On Wednesday, November 14, 2012 at 3:52 PM, Mike Percy wrote: > >>> > Alex, this looks great! Thanks so much for spending the time to > reorganize > the Wiki. It is way more useful. > > Regards, > Mike > > On Wed, Nov 14, 2012 at 6:27 AM, Alexander Alten-Lorenz < > wget.n...@gmail.com (mailto:wget.n...@gmail.com) > > wrote: > > > > Guys, > > > > I've spent most of my day today to reorganize the wiki, please have > a look > > and ping me with all stuff you miss or what we should organize > better. > > > > I was moving all the OG stuff into a new section, called Flume OG > (pre > > 1.0), the same I did with all Flume NG stuff. Also I added a > blogpost about > > flume's memory consumption and will add some from time time with > topics we > > figured out in our mailing list. Of course, add own stuff too! > > > > I did some cosmetic changes too (include our logo as example). > > > > best, > > Alex > > > > > > > > -- > > Alexander Alten-Lorenz > > http://mapredit.blogspot.com > > German Hadoop LinkedIn Group: http://goo.gl/N8pCF > > > > > > >>> > >>> > >> > >> > >> > >> -- > >> Apache MRUnit - Unit testing MapReduce - > http://incubator.apache.org/mrunit/ > > > > -- > > Alexander Alten-Lorenz > > http://mapredit.blogspot.com > > German Hadoop LinkedIn Group: http://goo.gl/N8pCF > > > > -- > Alexander Alten-Lorenz > http://mapredit.blogspot.com > German Hadoop LinkedIn Group: http://goo.gl/N8pCF > >
Re: [VOTE] Release Apache Flume version 1.3.0-rc3
Thank you sir, greatly appreciated! Jarcec On Sat, Nov 17, 2012 at 07:39:57PM -0800, Mike Percy wrote: > Done. > > Regards > Mike > > On Sat, Nov 17, 2012 at 7:27 PM, Jarek Jarcec Cecho wrote: > > > Might I humbly ask for review & commit FLUME-1719 for next RC? > > > > Jarcec > > > > On Sat, Nov 17, 2012 at 07:13:26PM -0800, Hari Shreedharan wrote: > > > Done! Thanks Mike, Brock! > > > > > > > > > Hari > > > > > > -- > > > Hari Shreedharan > > > > > > > > > On Saturday, November 17, 2012 at 7:05 PM, Brock Noland wrote: > > > > > > > Ok, let's do another rc since the same lobs with different versions is > > probably bad. > > > > > > > > Also I think it's fine to commit to 1.3 without another rc since we > > are voting on a tag, not the branch. > > > > > > > > -- > > > > Brock Noland > > > > Sent with Sparrow (http://www.sparrowmailapp.com/?sig) > > > > > > > > > > > > On Saturday, November 17, 2012 at 8:45 PM, Mike Percy wrote: > > > > > > > > > Hari, > > > > > You're correct that a -1 vote does not veto a release. A savvy user > > could > > > > > delete one of the jars before deploying to production, but why make > > them do > > > > > that. > > > > > > > > > > Thanks for the commit. > > > > > > > > > > Regards, > > > > > Mike > > > > > > > > > > On Sat, Nov 17, 2012 at 6:12 PM, Hari Shreedharan < > > hshreedha...@cloudera.com (mailto:hshreedha...@cloudera.com) > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Mike, > > > > > > > > > > > > I committed your patch for flume-1.4, and trunk. > > > > > > > > > > > > > > > > > > Brock: As I posted on the jira, if you want it committed to > > flume-1.3. the > > > > > > RM should decide if another RC is required (looks like there are 3 > > PMC +1 > > > > > > already, unless someone withdraws the +1). If required, please > > cherry-pick > > > > > > the patch to flume-1.3.0 and roll another RC. > > > > > > > > > > > > > > > > > > Thanks, > > > > > > Hari > > > > > > > > > > > > -- > > > > > > Hari Shreedharan > > > > > > > > > > > > > > > > > > On Saturday, November 17, 2012 at 5:58 PM, Mike Percy wrote: > > > > > > > > > > > > > When I was reviewing the libs I noticed that netty is in there > > twice > > > > > > with 2 > > > > > > > different versions. I don't think we should ship like that. > > > > > > > > > > > > > > So, -1 from me on this RC. > > > > > > > > > > > > > > Details and a patch are here: > > > > > > > https://issues.apache.org/jira/browse/FLUME-1723 > > > > > > > > > > > > > > Regards, > > > > > > > Mike > > > > > > > > > > > > > > On Sat, Nov 17, 2012 at 3:33 PM, Brock Noland < > > br...@cloudera.com (mailto:br...@cloudera.com)(mailto: > > > > > > br...@cloudera.com (mailto:br...@cloudera.com))> wrote: > > > > > > > > > > > > > > > Thanks Hari, I have created FLUME-1722 for this purpose. > > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/FLUME-1722 > > > > > > > > > > > > > > > > Brock > > > > > > > > > > > > > > > > On Sat, Nov 17, 2012 at 5:29 PM, Hari Shreedharan > > > > > > > > mailto:hshreedha...@cloudera.com)> > > wrote: > > > > > > > > > +1. > > > > > > > > > > > > > > > > > > Here is what I checked: > > > > > > > > > 1. Checksums and signatures look good. > > > > > > > > > 2. Verified license file, readme, change log and notice file > > (more on > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > this below). > > > > > > > > > 3. Built, ran unit tests, ran an agent with the sample > > config - looks > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > good. > > > > > > > > > > > > > > > > > > > > > > > > > > > Additional notes: > > > > > > > > > The LICENSE file seems to list three libraries which we do > > not pull > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > in: > > > > > > > > > > > > > > > > > > commons logging > > > > > > > > > http-client > > > > > > > > > http-core > > > > > > > > > > > > > > > > > > > > > > > > > > > We probably should remove these from the license file too. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > Hari > > > > > > > > > -- > > > > > > > > > Hari Shreedharan > > > > > > > > > > > > > > > > > > > > > > > > > > > On Saturday, November 17, 2012 at 12:57 AM, Alexander > > Alten-Lorenz > > > > > > wrote: > > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > > > - Alex > > > > > > > > > > > > > > > > > > > > On Nov 17, 2012, at 4:10 AM, Will McQueen < > > w...@cloudera.com (mailto:w...@cloudera.com)(mailto: > > > > > > w...@cloudera.com (mailto:w...@cloudera.com)) (mailto: > > > > > > > > w...@cloudera.com (mailto:w...@cloudera.com))> wrote: > > > > > > > > > > > > > > > > > > > > > +1 on the release > > > > > > > > > > > > > > > > > > > > > > On Nov 16, 2012, at 6:56 PM, Brock Noland < > > br...@cloudera.com (mailto:br...@cloudera.com)(mailto: > > > > > > br...@cloudera.com (mailto:br...@cloudera.com))
