Re: [VOTE] Release Apache Flume 1.5.1 RC1

2014-11-09 Thread Roshan Naik
Seems to be done correctly in AvroSource though. have not tested it.

Would be good to have a simple unit test for this setting.

-roshan

On Sun, Nov 9, 2014 at 11:07 PM, Roshan Naik  wrote:

> The documentation for the new "exclude-protocols" settings is states:
>
>
> Default = SSLv2Hello  SSLv3
> Description = Space-separated list of SSL/TLS protocols to exclude
>
>
> Which seems to indicate that  it is possible to override the defaults
> protocols that are listed there.
> However the implementation completely disables the SSLv2Hello  & SSLv3
> no matter what.
> AFAICT .. the exclude-protocols does not appear to be used anywhere in the
> code at least for HTTPSource.
>
> -roshan
>
>
>
>
>
> On Sun, Nov 9, 2014 at 8:46 PM, Arvind Prabhakar 
> wrote:
>
>> +1
>>
>> * Verified signatures
>> * Verified checksums
>> * Verified the tag (minor issues noted below - would be good to address if
>> there is RC2)
>> * Builds correctly
>> * All tests run with default profile and avro version set to 1.7.5 (to
>> avoid an issue with snappy on Mac OS)
>>
>> Nits:
>> * The tag and sources match except that the src tarball contains the iml
>> files and does not contain the dev-support directory. Since both the iml
>> files and dev-support files are not related to product functionality, it
>> is
>> OK for the tarball to not include them. However, if there is a respin it
>> would be good to address that.
>> * It is time we updated the avro version in the system to a newer release,
>> which among other things will allow people to build on Mac OS without
>> running into the JDK7+Snappy 1.0.4 problem where tests because native
>> library does not load.
>>
>> Regards,
>> Arvind
>>
>> On Thu, Nov 6, 2014 at 3:17 PM, Hari Shreedharan <
>> hshreedha...@cloudera.com>
>> wrote:
>>
>> > This is the seventh release for Apache Flume as a top-level project,
>> > version 1.5.1. We are voting on release candidate RC1.
>> >
>> > It fixes the following issues:
>> >
>> >
>> https://git-wip-us.apache.org/repos/asf?p=flume.git;a=blob_plain;f=CHANGELOG;hb=c74804226bcee59823c0cbc09cdf803a3d9e6920
>> >
>> > *** Please cast your vote within the next 72 hours ***
>> >
>> > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1)
>> > for the source and binary artifacts can be found here:
>> >   https://people.apache.org/~hshreedharan/apache-flume-1.5.1-rc1/
>> >
>> > Maven staging repo:
>> >
>> https://repository.apache.org/content/repositories/orgapacheflume-1006/
>> >
>> > The tag to be voted on:
>> >
>> >
>> https://git-wip-us.apache.org/repos/asf?p=flume.git;a=commit;h=c74804226bcee59823c0cbc09cdf803a3d9e6920
>> >
>> > Flume's KEYS file containing PGP keys we use to sign the release:
>> >   http://www.apache.org/dist/flume/KEYS
>> >
>> > Thanks,
>> > Hari
>>
>
>

-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.


Re: [VOTE] Release Apache Flume 1.5.1 RC1

2014-11-09 Thread Roshan Naik
The documentation for the new "exclude-protocols" settings is states:


Default = SSLv2Hello  SSLv3
Description = Space-separated list of SSL/TLS protocols to exclude


Which seems to indicate that  it is possible to override the defaults
protocols that are listed there.
However the implementation completely disables the SSLv2Hello  & SSLv3   no
matter what.
AFAICT .. the exclude-protocols does not appear to be used anywhere in the
code at least for HTTPSource.

-roshan





On Sun, Nov 9, 2014 at 8:46 PM, Arvind Prabhakar  wrote:

> +1
>
> * Verified signatures
> * Verified checksums
> * Verified the tag (minor issues noted below - would be good to address if
> there is RC2)
> * Builds correctly
> * All tests run with default profile and avro version set to 1.7.5 (to
> avoid an issue with snappy on Mac OS)
>
> Nits:
> * The tag and sources match except that the src tarball contains the iml
> files and does not contain the dev-support directory. Since both the iml
> files and dev-support files are not related to product functionality, it is
> OK for the tarball to not include them. However, if there is a respin it
> would be good to address that.
> * It is time we updated the avro version in the system to a newer release,
> which among other things will allow people to build on Mac OS without
> running into the JDK7+Snappy 1.0.4 problem where tests because native
> library does not load.
>
> Regards,
> Arvind
>
> On Thu, Nov 6, 2014 at 3:17 PM, Hari Shreedharan <
> hshreedha...@cloudera.com>
> wrote:
>
> > This is the seventh release for Apache Flume as a top-level project,
> > version 1.5.1. We are voting on release candidate RC1.
> >
> > It fixes the following issues:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=flume.git;a=blob_plain;f=CHANGELOG;hb=c74804226bcee59823c0cbc09cdf803a3d9e6920
> >
> > *** Please cast your vote within the next 72 hours ***
> >
> > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1)
> > for the source and binary artifacts can be found here:
> >   https://people.apache.org/~hshreedharan/apache-flume-1.5.1-rc1/
> >
> > Maven staging repo:
> >
> https://repository.apache.org/content/repositories/orgapacheflume-1006/
> >
> > The tag to be voted on:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=flume.git;a=commit;h=c74804226bcee59823c0cbc09cdf803a3d9e6920
> >
> > Flume's KEYS file containing PGP keys we use to sign the release:
> >   http://www.apache.org/dist/flume/KEYS
> >
> > Thanks,
> > Hari
>

-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.


Re: [VOTE] Release Apache Flume 1.5.1 RC1

2014-11-09 Thread Arvind Prabhakar
+1

* Verified signatures
* Verified checksums
* Verified the tag (minor issues noted below - would be good to address if
there is RC2)
* Builds correctly
* All tests run with default profile and avro version set to 1.7.5 (to
avoid an issue with snappy on Mac OS)

Nits:
* The tag and sources match except that the src tarball contains the iml
files and does not contain the dev-support directory. Since both the iml
files and dev-support files are not related to product functionality, it is
OK for the tarball to not include them. However, if there is a respin it
would be good to address that.
* It is time we updated the avro version in the system to a newer release,
which among other things will allow people to build on Mac OS without
running into the JDK7+Snappy 1.0.4 problem where tests because native
library does not load.

Regards,
Arvind

On Thu, Nov 6, 2014 at 3:17 PM, Hari Shreedharan 
wrote:

> This is the seventh release for Apache Flume as a top-level project,
> version 1.5.1. We are voting on release candidate RC1.
>
> It fixes the following issues:
>
> https://git-wip-us.apache.org/repos/asf?p=flume.git;a=blob_plain;f=CHANGELOG;hb=c74804226bcee59823c0cbc09cdf803a3d9e6920
>
> *** Please cast your vote within the next 72 hours ***
>
> The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1)
> for the source and binary artifacts can be found here:
>   https://people.apache.org/~hshreedharan/apache-flume-1.5.1-rc1/
>
> Maven staging repo:
>   https://repository.apache.org/content/repositories/orgapacheflume-1006/
>
> The tag to be voted on:
>
> https://git-wip-us.apache.org/repos/asf?p=flume.git;a=commit;h=c74804226bcee59823c0cbc09cdf803a3d9e6920
>
> Flume's KEYS file containing PGP keys we use to sign the release:
>   http://www.apache.org/dist/flume/KEYS
>
> Thanks,
> Hari