Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/#review177301 --- Ship it! LGTM, +1 - Denes Arvay On Oct. 24, 2016, 1:27 p.m., Lior Zeno wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53056/ > --- > > (Updated Oct. 24, 2016, 1:27 p.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > --- > > We should move to Java 8 as a minimum requirement. > > 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html. > 2. Many projects are adopting java 8 as a minimum requirement, for instance: > > * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722 > * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624 > * elasticsearch 5: > https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html > > > Diffs > - > > .travis.yml befc2c9 > DEVNOTES 83cdf89 > README.md 9ebb2a3 > conf/flume-env.sh.template 07182ca > flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 > flume-ng-sources/flume-taildir-source/pom.xml 96c2468 > pom.xml f62c99a > > > Diff: https://reviews.apache.org/r/53056/diff/6/ > > > Testing > --- > > The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91". > All unit tests, except for the known flaky ones, successfully passed. > > > Thanks, > > Lior Zeno > >
Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/ --- (Updated Oct. 24, 2016, 11:27 a.m.) Review request for Flume. Changes --- Udpate MAVEN_OPTS in travis.yml Repository: flume-git Description --- We should move to Java 8 as a minimum requirement. 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html. 2. Many projects are adopting java 8 as a minimum requirement, for instance: * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722 * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624 * elasticsearch 5: https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html Diffs (updated) - .travis.yml befc2c9 DEVNOTES 83cdf89 README.md 9ebb2a3 conf/flume-env.sh.template 07182ca flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 flume-ng-sources/flume-taildir-source/pom.xml 96c2468 pom.xml f62c99a Diff: https://reviews.apache.org/r/53056/diff/ Testing --- The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91". All unit tests, except for the known flaky ones, successfully passed. Thanks, Lior Zeno
Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/ --- (Updated Oct. 23, 2016, 8:57 p.m.) Review request for Flume. Changes --- Update the recommended MAVEN_OPTS in DEVNOTES Repository: flume-git Description --- We should move to Java 8 as a minimum requirement. 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html. 2. Many projects are adopting java 8 as a minimum requirement, for instance: * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722 * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624 * elasticsearch 5: https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html Diffs (updated) - DEVNOTES 83cdf89 README.md 9ebb2a3 conf/flume-env.sh.template 07182ca flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 flume-ng-sources/flume-taildir-source/pom.xml 96c2468 pom.xml f62c99a Diff: https://reviews.apache.org/r/53056/diff/ Testing --- The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91". All unit tests, except for the known flaky ones, successfully passed. Thanks, Lior Zeno
Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8
> On Oct. 21, 2016, 10:57 a.m., Attila Simon wrote: > > Hi Lior, > > conf/flume-env.sh.template#22 is still referenceing to java-6-sun. Could > > you please include that as well. Thanks. BTW, do you think we should continue recommending Oracle's JVM? The default-jdk/jre in variuos distributions is OpenJDK (e.g. Ubuntu). - Lior --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/#review153527 --- On Oct. 21, 2016, 3:56 p.m., Lior Zeno wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53056/ > --- > > (Updated Oct. 21, 2016, 3:56 p.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > --- > > We should move to Java 8 as a minimum requirement. > > 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html. > 2. Many projects are adopting java 8 as a minimum requirement, for instance: > > * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722 > * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624 > * elasticsearch 5: > https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html > > > Diffs > - > > README.md 9ebb2a3 > conf/flume-env.sh.template 07182ca > flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 > flume-ng-sources/flume-taildir-source/pom.xml 96c2468 > pom.xml f62c99a > > Diff: https://reviews.apache.org/r/53056/diff/ > > > Testing > --- > > The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91". > All unit tests, except for the known flaky ones, successfully passed. > > > Thanks, > > Lior Zeno > >
Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/ --- (Updated Oct. 21, 2016, 3:56 p.m.) Review request for Flume. Changes --- Update flume env file Repository: flume-git Description --- We should move to Java 8 as a minimum requirement. 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html. 2. Many projects are adopting java 8 as a minimum requirement, for instance: * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722 * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624 * elasticsearch 5: https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html Diffs (updated) - README.md 9ebb2a3 conf/flume-env.sh.template 07182ca flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 flume-ng-sources/flume-taildir-source/pom.xml 96c2468 pom.xml f62c99a Diff: https://reviews.apache.org/r/53056/diff/ Testing --- The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91". All unit tests, except for the known flaky ones, successfully passed. Thanks, Lior Zeno
Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/#review153527 --- Hi Lior, conf/flume-env.sh.template#22 is still referenceing to java-6-sun. Could you please include that as well. - Attila Simon On Oct. 20, 2016, 4:50 p.m., Lior Zeno wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53056/ > --- > > (Updated Oct. 20, 2016, 4:50 p.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > --- > > We should move to Java 8 as a minimum requirement. > > 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html. > 2. Many projects are adopting java 8 as a minimum requirement, for instance: > > * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722 > * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624 > * elasticsearch 5: > https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html > > > Diffs > - > > README.md 9ebb2a3 > flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 > flume-ng-sources/flume-taildir-source/pom.xml 96c2468 > pom.xml f62c99a > > Diff: https://reviews.apache.org/r/53056/diff/ > > > Testing > --- > > The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91". > All unit tests, except for the known flaky ones, successfully passed. > > > Thanks, > > Lior Zeno > >
Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8
> On Oct. 20, 2016, 4:46 p.m., Denes Arvay wrote: > > There is still a reference to Java 1.7 in > > `flume-ng-sources/flume-taildir-source/pom.xml`: > > https://github.com/apache/flume/blob/trunk/flume-ng-sources/flume-taildir-source/pom.xml#L40-L41 > > In fact we should get rid of the whole `...` block as it > > should inherit from the parent pom. > > Otherwise thanks for the patch, looks good to me. Thanks, good catch. - Lior --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/#review153413 --- On Oct. 20, 2016, 4:50 p.m., Lior Zeno wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53056/ > --- > > (Updated Oct. 20, 2016, 4:50 p.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > --- > > We should move to Java 8 as a minimum requirement. > > 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html. > 2. Many projects are adopting java 8 as a minimum requirement, for instance: > > * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722 > * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624 > * elasticsearch 5: > https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html > > > Diffs > - > > README.md 9ebb2a3 > flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 > flume-ng-sources/flume-taildir-source/pom.xml 96c2468 > pom.xml f62c99a > > Diff: https://reviews.apache.org/r/53056/diff/ > > > Testing > --- > > The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91". > All unit tests, except for the known flaky ones, successfully passed. > > > Thanks, > > Lior Zeno > >
Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/ --- (Updated Oct. 20, 2016, 4:50 p.m.) Review request for Flume. Changes --- Remove maven-compiler-plugin from taildir source Repository: flume-git Description --- We should move to Java 8 as a minimum requirement. 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html. 2. Many projects are adopting java 8 as a minimum requirement, for instance: * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722 * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624 * elasticsearch 5: https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html Diffs (updated) - README.md 9ebb2a3 flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 flume-ng-sources/flume-taildir-source/pom.xml 96c2468 pom.xml f62c99a Diff: https://reviews.apache.org/r/53056/diff/ Testing --- The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91". All unit tests, except for the known flaky ones, successfully passed. Thanks, Lior Zeno
Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/#review153413 --- There is still a reference to Java 1.7 in `flume-ng-sources/flume-taildir-source/pom.xml`: https://github.com/apache/flume/blob/trunk/flume-ng-sources/flume-taildir-source/pom.xml#L40-L41 In fact we should get rid of the whole `...` block as it should inherit from the parent pom. Otherwise thanks for the patch, looks good to me. - Denes Arvay On Oct. 20, 2016, 5:15 p.m., Lior Zeno wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53056/ > --- > > (Updated Oct. 20, 2016, 5:15 p.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > --- > > We should move to Java 8 as a minimum requirement. > > 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html. > 2. Many projects are adopting java 8 as a minimum requirement, for instance: > > * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722 > * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624 > * elasticsearch 5: > https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html > > > Diffs > - > > README.md 9ebb2a3 > flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 > pom.xml f62c99a > > Diff: https://reviews.apache.org/r/53056/diff/ > > > Testing > --- > > The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91". > All unit tests, except for the known flaky ones, successfully passed. > > > Thanks, > > Lior Zeno > >
Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/ --- (Updated Oct. 20, 2016, 3:15 p.m.) Review request for Flume. Changes --- Removed deprecated java options: ``` OpenJDK 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0 OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0 ``` Repository: flume-git Description --- We should move to Java 8 as a minimum requirement. 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html. 2. Many projects are adopting java 8 as a minimum requirement, for instance: * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722 * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624 * elasticsearch 5: https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html Diffs (updated) - README.md 9ebb2a3 flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 pom.xml f62c99a Diff: https://reviews.apache.org/r/53056/diff/ Testing --- The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91". All unit tests, except for the known flaky ones, successfully passed. Thanks, Lior Zeno
Review Request 53056: FLUME-2945: Bump java target version to 1.8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/ --- Review request for Flume. Repository: flume-git Description --- We should move to Java 8 as a minimum requirement. 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html. 2. Many projects are adopting java 8 as a minimum requirement, for instance: * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722 * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624 * elasticsearch 5: https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html Diffs - README.md 9ebb2a3 flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 pom.xml f62c99a Diff: https://reviews.apache.org/r/53056/diff/ Testing --- The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91". All unit tests, except for the known flaky ones, successfully passed. Thanks, Lior Zeno
