[jira] Commented: (FOR-514) Do not limit status.xml contexts in project info plugin
[
http://issues.apache.org/jira/browse/FOR-514?page=comments#action_12312845 ]
Cyriaque Dupoirieux commented on FOR-514:
-
OK for everything,
Do you want I send another patch ?
I may have the time today...
Do not limit status.xml contexts in project info plugin
---
Key: FOR-514
URL: http://issues.apache.org/jira/browse/FOR-514
Project: Forrest
Type: Improvement
Components: Plugin: projectInfo
Reporter: Ross Gardler
Priority: Minor
Attachments: 514-patch.txt
(This comment brought over from FOR-487)
This improvement of changes page is nice.
I have my own version based on xsl:key definition in order to be able to
simply manage as many contexts as you can define (My Dtd is not limited to
build|docs|code|admin|design.
The advantage - on my opinion - is that my own contexts are very various and
not developpement oriented nor language dependant.
here a short example - using releaseNote... :
http://cyriaque.dupoirieux.free.fr/changes_6.2.1.html
The following code replace the 5 blocks xsl:if test=[EMAIL
PROTECTED]'build'] :
titleVersion xsl:value-of select=@version/ (xsl:value-of
select=@date/)/title
+ xsl:for-each
select=action[generate-id()=generate-id(key('contextes',concat(../@version,
'_', @context)))]
+ xsl:sort select=@context/
+ section
+ titlexsl:value-of select=@context//title
+ ul
+ xsl:apply-templates select=key('contextes',concat(../@version, '_',
@context) )
+ xsl:sort select=@type/
+ /xsl:apply-templates
+ /ul
+ /section
+ /xsl:for-each
Hope you'll like the idea...
Regards,
Cyriaque,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-514) Do not limit status.xml contexts in project info plugin
[
http://issues.apache.org/jira/browse/FOR-514?page=comments#action_12312723 ]
Juan Jose Pablos commented on FOR-514:
--
In order to get this validated with actuall dtd, we need to change:
1) remove the contexts entity:
===
--- common-elems-v10.mod(revisin: 180256)
+++ common-elems-v10.mod(copia de trabajo)
@@ -47,7 +47,6 @@
!-- === --
!ENTITY % types add|remove|update|fix
-!ENTITY % contexts build|docs|code|admin|design
!ENTITY % importances high|medium|low
2) use a IDREF instead of an entity:
!-- === --
@@ -61,7 +60,7 @@
!ATTLIST action %common.att;
dev IDREF #REQUIRED
type (%types;) #IMPLIED
- context (%contexts;) #IMPLIED
+ context IDREF #REQUIRED
importance (%importances;) medium
due-to CDATA #IMPLIED
due-to-email CDATA #IMPLIED
3) create context id=docs title=Changes to the documentation element on
the status file.
But: This seem to collapse with the dev IDREF. We can live with it ( It is
unusual that a person has the same id than a context)
Please let me know what do you think, so I can apply this patch.
Do not limit status.xml contexts in project info plugin
---
Key: FOR-514
URL: http://issues.apache.org/jira/browse/FOR-514
Project: Forrest
Type: Improvement
Components: Plugin: projectInfo
Reporter: Ross Gardler
Priority: Minor
Attachments: 514-patch.txt
(This comment brought over from FOR-487)
This improvement of changes page is nice.
I have my own version based on xsl:key definition in order to be able to
simply manage as many contexts as you can define (My Dtd is not limited to
build|docs|code|admin|design.
The advantage - on my opinion - is that my own contexts are very various and
not developpement oriented nor language dependant.
here a short example - using releaseNote... :
http://cyriaque.dupoirieux.free.fr/changes_6.2.1.html
The following code replace the 5 blocks xsl:if test=[EMAIL
PROTECTED]'build'] :
titleVersion xsl:value-of select=@version/ (xsl:value-of
select=@date/)/title
+ xsl:for-each
select=action[generate-id()=generate-id(key('contextes',concat(../@version,
'_', @context)))]
+ xsl:sort select=@context/
+ section
+ titlexsl:value-of select=@context//title
+ ul
+ xsl:apply-templates select=key('contextes',concat(../@version, '_',
@context) )
+ xsl:sort select=@type/
+ /xsl:apply-templates
+ /ul
+ /section
+ /xsl:for-each
Hope you'll like the idea...
Regards,
Cyriaque,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-514) Do not limit status.xml contexts in project info plugin
[
http://issues.apache.org/jira/browse/FOR-514?page=comments#action_12312729 ]
Cyriaque Dupoirieux commented on FOR-514:
-
Answers to Juan Jose :
1) The patch already updates the common-elems-v10.mod file :
Index: main/webapp/resources/schema/dtd/common-elems-v10.mod
===
--- main/webapp/resources/schema/dtd/common-elems-v10.mod (revision
179778)
+++ main/webapp/resources/schema/dtd/common-elems-v10.mod (working copy)
@@ -61,7 +61,7 @@
!ATTLIST action %common.att;
dev IDREF #REQUIRED
type (%types;) #IMPLIED
- context (%contexts;) #IMPLIED
+ context CDATA #IMPLIED
importance (%importances;) medium
due-to CDATA #IMPLIED
due-to-email CDATA #IMPLIED
It's nice you think about the no more used contexts entity, I forgot it...
2) For context, I want to stay open, that's why I used CDATA and not IDREF. But
I'm Ok for IDREF...
3) The patch already updates all the status.xml I've found adding the following
lines :
!-- Define here the Title of the Context you want to display in the Changes
pages.
id = the context value of actions
title = Title of the Context
--
actionContexts
context id=code title=Changes to the Code Base/
context id=docs title=Changes to Documentation/
context id=admin title=Changes to Project Administration/
context id=design title=Changes to Design/
context id=build title=Changes to Build/
/actionContexts
Do not limit status.xml contexts in project info plugin
---
Key: FOR-514
URL: http://issues.apache.org/jira/browse/FOR-514
Project: Forrest
Type: Improvement
Components: Plugin: projectInfo
Reporter: Ross Gardler
Priority: Minor
Attachments: 514-patch.txt
(This comment brought over from FOR-487)
This improvement of changes page is nice.
I have my own version based on xsl:key definition in order to be able to
simply manage as many contexts as you can define (My Dtd is not limited to
build|docs|code|admin|design.
The advantage - on my opinion - is that my own contexts are very various and
not developpement oriented nor language dependant.
here a short example - using releaseNote... :
http://cyriaque.dupoirieux.free.fr/changes_6.2.1.html
The following code replace the 5 blocks xsl:if test=[EMAIL
PROTECTED]'build'] :
titleVersion xsl:value-of select=@version/ (xsl:value-of
select=@date/)/title
+ xsl:for-each
select=action[generate-id()=generate-id(key('contextes',concat(../@version,
'_', @context)))]
+ xsl:sort select=@context/
+ section
+ titlexsl:value-of select=@context//title
+ ul
+ xsl:apply-templates select=key('contextes',concat(../@version, '_',
@context) )
+ xsl:sort select=@type/
+ /xsl:apply-templates
+ /ul
+ /section
+ /xsl:for-each
Hope you'll like the idea...
Regards,
Cyriaque,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-514) Do not limit status.xml contexts in project info plugin
[
http://issues.apache.org/jira/browse/FOR-514?page=comments#action_12312710 ]
David Crossley commented on FOR-514:
(Bringing over a comment and a patch from Cyriaque Dupoirieux which were added
during the move of our Jira.)
- Udpate of the Status DTD 1.3 in order to be able to add the following
information :
actionContexts
context id=code title=Changes to the Code Base/
context id=docs title=Changes to the Documentation/
!-- ... --
/actionContexts
- Update of changes2document.xsl in order to take into account the context
title or by default the context ID.
- Update of status.xml files (with documentation associated in comments)
Do not limit status.xml contexts in project info plugin
---
Key: FOR-514
URL: http://issues.apache.org/jira/browse/FOR-514
Project: Forrest
Type: Improvement
Components: Plugin: projectInfo
Reporter: Ross Gardler
Priority: Minor
(This comment brought over from FOR-487)
This improvement of changes page is nice.
I have my own version based on xsl:key definition in order to be able to
simply manage as many contexts as you can define (My Dtd is not limited to
build|docs|code|admin|design.
The advantage - on my opinion - is that my own contexts are very various and
not developpement oriented nor language dependant.
here a short example - using releaseNote... :
http://cyriaque.dupoirieux.free.fr/changes_6.2.1.html
The following code replace the 5 blocks xsl:if test=[EMAIL
PROTECTED]'build'] :
titleVersion xsl:value-of select=@version/ (xsl:value-of
select=@date/)/title
+ xsl:for-each
select=action[generate-id()=generate-id(key('contextes',concat(../@version,
'_', @context)))]
+ xsl:sort select=@context/
+ section
+ titlexsl:value-of select=@context//title
+ ul
+ xsl:apply-templates select=key('contextes',concat(../@version, '_',
@context) )
+ xsl:sort select=@type/
+ /xsl:apply-templates
+ /ul
+ /section
+ /xsl:for-each
Hope you'll like the idea...
Regards,
Cyriaque,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[JIRA] Commented: (FOR-514) Do not limit status.xml contexts in project info plugin
The following comment has been added to this issue:
Author: Ross Gardler
Created: Wed, 1 Jun 2005 6:07 AM
Body:
In one sense you change is a big improvement on my original code. However, it
prevents the ability to add a meningful title to each section since the title
becomes the value of the context attribute.
Perhaps we can provide an (optional) lookup table in the status.xml file that
will give a title, for example:
status
actionContexts
context id=code description=Changes to the Code Base
context id=docs description=Changes to the Documentation
/action
...
status
If no entry is found for //actionContexts/[EMAIL PROTECTED]CONTEXT] then we
would use the @id value in titles otherwise we would use
//actionContexts/[EMAIL PROTECTED]CONTEXT]/@description
In later versions this would allow for internationalisation of the status
contexts.
WDYT?
[NB try to submite changes as patched, it makes it much easier for us to apply
and therefore increases the chance of it being applied in a timely fashion. If
you don't know how ask us on the dev list.]
-
View this comment:
http://issues.cocoondev.org//browse/FOR-514?page=comments#action_12460
-
View the issue:
http://issues.cocoondev.org//browse/FOR-514
Here is an overview of the issue:
-
Key: FOR-514
Summary: Do not limit status.xml contexts in project info plugin
Type: Improvement
Status: Unassigned
Priority: Minor
Project: Forrest
Components:
Plugin: projectInfo
Assignee:
Reporter: Ross Gardler
Created: Wed, 1 Jun 2005 6:02 AM
Updated: Wed, 1 Jun 2005 6:07 AM
Description:
(This comment brought over from FOR-487)
This improvement of changes page is nice.
I have my own version based on xsl:key definition in order to be able to simply
manage as many contexts as you can define (My Dtd is not limited to
build|docs|code|admin|design.
The advantage - on my opinion - is that my own contexts are very various and
not developpement oriented nor language dependant.
here a short example - using releaseNote... :
http://cyriaque.dupoirieux.free.fr/changes_6.2.1.html
The following code replace the 5 blocks xsl:if test=[EMAIL
PROTECTED]'build'] :
titleVersion xsl:value-of select=@version/ (xsl:value-of
select=@date/)/title
+ xsl:for-each
select=action[generate-id()=generate-id(key('contextes',concat(../@version,
'_', @context)))]
+ xsl:sort select=@context/
+ section
+ titlexsl:value-of select=@context//title
+ ul
+ xsl:apply-templates select=key('contextes',concat(../@version, '_',
@context) )
+ xsl:sort select=@type/
+ /xsl:apply-templates
+ /ul
+ /section
+ /xsl:for-each
Hope you'll like the idea...
Regards,
Cyriaque,
-
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.cocoondev.org//secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[JIRA] Commented: (FOR-514) Do not limit status.xml contexts in project info plugin
The following comment has been added to this issue:
Author: Cyriaque Dupoirieux
Created: Wed, 1 Jun 2005 8:45 AM
Body:
Good Ross,
I can work on it with your idea :
actionContexts
context id=code description=Changes to the Code Base
context id=docs description=Changes to the Documentation
/actionContexts
And I will send a patch.
By the way, I could not - in my previous comment - send a patch because the
issue were closed... (that's why I send a code sample in the text...)
-
View this comment:
http://issues.cocoondev.org//browse/FOR-514?page=comments#action_12462
-
View the issue:
http://issues.cocoondev.org//browse/FOR-514
Here is an overview of the issue:
-
Key: FOR-514
Summary: Do not limit status.xml contexts in project info plugin
Type: Improvement
Status: Unassigned
Priority: Minor
Project: Forrest
Components:
Plugin: projectInfo
Assignee:
Reporter: Ross Gardler
Created: Wed, 1 Jun 2005 6:02 AM
Updated: Wed, 1 Jun 2005 8:45 AM
Description:
(This comment brought over from FOR-487)
This improvement of changes page is nice.
I have my own version based on xsl:key definition in order to be able to simply
manage as many contexts as you can define (My Dtd is not limited to
build|docs|code|admin|design.
The advantage - on my opinion - is that my own contexts are very various and
not developpement oriented nor language dependant.
here a short example - using releaseNote... :
http://cyriaque.dupoirieux.free.fr/changes_6.2.1.html
The following code replace the 5 blocks xsl:if test=[EMAIL
PROTECTED]'build'] :
titleVersion xsl:value-of select=@version/ (xsl:value-of
select=@date/)/title
+ xsl:for-each
select=action[generate-id()=generate-id(key('contextes',concat(../@version,
'_', @context)))]
+ xsl:sort select=@context/
+ section
+ titlexsl:value-of select=@context//title
+ ul
+ xsl:apply-templates select=key('contextes',concat(../@version, '_',
@context) )
+ xsl:sort select=@type/
+ /xsl:apply-templates
+ /ul
+ /section
+ /xsl:for-each
Hope you'll like the idea...
Regards,
Cyriaque,
-
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.cocoondev.org//secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
