[jira] [Created] (GEARPUMP-266) Add Docker file

2017-02-07 Thread Manu Zhang (JIRA)
Manu Zhang created GEARPUMP-266:
---

 Summary: Add Docker file
 Key: GEARPUMP-266
 URL: https://issues.apache.org/jira/browse/GEARPUMP-266
 Project: Apache Gearpump
  Issue Type: New Feature
  Components: integrationtest
Reporter: Manu Zhang
Assignee: Manu Zhang


It's currently hosted at https://github.com/stanleyxu2005/gearpump-launcher and 
should be moved over to sources repo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (GEARPUMP-16) Define and document milestones, roadmaps, release calendars quarterly

2017-02-07 Thread Manu Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEARPUMP-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manu Zhang resolved GEARPUMP-16.

Resolution: Fixed

> Define and document milestones, roadmaps, release calendars quarterly 
> --
>
> Key: GEARPUMP-16
> URL: https://issues.apache.org/jira/browse/GEARPUMP-16
> Project: Apache Gearpump
>  Issue Type: New Feature
>Reporter: Sean Zhong
>Assignee: Kam Kasravi
>
> It requires a consensus from the community first, after that, we should 
> define and document milestones, roadmaps, release calendars in, for example, 
> 3 months. Then everyone have a clear expectation on what is coming next in 
> the community.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (GEARPUMP-1) Gearpump bootup

2017-02-07 Thread Manu Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEARPUMP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manu Zhang resolved GEARPUMP-1.
---
Resolution: Fixed

> Gearpump bootup
> ---
>
> Key: GEARPUMP-1
> URL: https://issues.apache.org/jira/browse/GEARPUMP-1
> Project: Apache Gearpump
>  Issue Type: New Feature
>Reporter: Sean Zhong
>Assignee: Sean Zhong
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Here are some initial steps that need tracking. Welcome to add more in this 
> list:
> 1. Sign the SGA and CCLA, (Done)
> 2. Setup Git repo at git://git.apache.org/incubator-gearpupm.git (Open) 
> Tracked by https://issues.apache.org/jira/browse/INFRA-11435 (Done)
> 3. Setup Github integration. (Done)
> 4. Import initial source code of SGA donation at commits 
> d5343681edde427022bf4c225ce6022a6904ae88 to the Apache git repo. (Done)
> 5. Merge additional code change after commits 
> d5343681edde427022bf4c225ce6022a6904ae88 to the Apache git repo. (Done)
> 6. Setup the OSS Sonatype repo with new artifact org.apache.gearpump  
> INFRA-11607 (Done)
> 7. Setup mail lists, User, Dev, and Private (Done)
>   - Subscribe link to User list: 
> [mailto:user-subscr...@gearpump.incubator.apache.org]
>   - Subscribe link to Dev list: 
> [mailto:dev-subscr...@gearpump.incubator.apache.org]
>   - Subscribe link to Private list: 
> [mailto:private-subscr...@gearpump.incubator.apache.org]
>   - Subscribe link to commits list: 
> [mailto:commits-subscr...@gearpump.incubator.apache.org]
>   
> 8. If using the Apache Jira for issue tracking, and Github integration for 
> code contribution, 
> we need to write a How-To to document how to make contributation. (Open)
> 9. Import issues from [github 
> issue|https://github.com/gearpump/gearpump/issues] to Apache Jira. (Done)
> 10. Fix the code style by following [Style 
> Guide|https://github.com/gearpump/gearpump/issues/2011] (Done)
> 11. Make the first release with new artifact org.apache.gearpump  (Open)
> 12. Prepare the documentation site in new domain (Open) 
> 13. Discuss and get out first roadmap.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] incubator-gearpump issue #140: [GEARPUMP-23] Add SessionWindows

2017-02-07 Thread huafengw
Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/140
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump pull request #140: [GEARPUMP-23] Add SessionWindows

2017-02-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/140


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump pull request #140: [GEARPUMP-23] Add SessionWindows

2017-02-07 Thread manuzhang
Github user manuzhang commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/140#discussion_r99816656
  
--- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala
 ---
@@ -33,11 +33,19 @@ object WindowFunction {
 }
 
 trait WindowFunction[T] {
+
   def apply(context: WindowFunction.Context[T]): Array[Window]
+
+  def isNonMerging: Boolean
+}
+
+abstract class NonMergingWindowFunction[T] extends WindowFunction[T] {
+
+  override def isNonMerging: Boolean = true
--- End diff --

They are free to **not** extend `NonMergingWindowFunction`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump pull request #140: [GEARPUMP-23] Add SessionWindows

2017-02-07 Thread huafengw
Github user huafengw commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/140#discussion_r99815386
  
--- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala
 ---
@@ -33,11 +33,19 @@ object WindowFunction {
 }
 
 trait WindowFunction[T] {
+
   def apply(context: WindowFunction.Context[T]): Array[Window]
+
+  def isNonMerging: Boolean
+}
+
+abstract class NonMergingWindowFunction[T] extends WindowFunction[T] {
+
+  override def isNonMerging: Boolean = true
--- End diff --

But if user's WindowFunction is not able to be merged, extending 
`NonMergingWindowFunction` would suffice, otherwise extending `WindowFunction`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump pull request #140: [GEARPUMP-23] Add SessionWindows

2017-02-07 Thread manuzhang
Github user manuzhang commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/140#discussion_r99814058
  
--- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala
 ---
@@ -33,11 +33,19 @@ object WindowFunction {
 }
 
 trait WindowFunction[T] {
+
   def apply(context: WindowFunction.Context[T]): Array[Window]
+
+  def isNonMerging: Boolean
+}
+
+abstract class NonMergingWindowFunction[T] extends WindowFunction[T] {
+
+  override def isNonMerging: Boolean = true
--- End diff --

users are free to extend `WindowFunction`, which can not be matched 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #140: [GEARPUMP-23] Add SessionWindows

2017-02-07 Thread manuzhang
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/140
  
R: @huafengw 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump pull request #140: [GEARPUMP-23] Add SessionWindows

2017-02-07 Thread manuzhang
GitHub user manuzhang opened a pull request:

https://github.com/apache/incubator-gearpump/pull/140

[GEARPUMP-23] Add SessionWindows

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuzhang/incubator-gearpump sessions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #140


commit 36997ab86c820479ad7b9ed1f2e4f8c42e10c2c7
Author: manuzhang 
Date:   2017-02-07T11:54:05Z

[GEARPUMP-23] Add SessionWindows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump pull request #140: [GEARPUMP-23] Add SessionWindows

2017-02-07 Thread huafengw
Github user huafengw commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/140#discussion_r99813902
  
--- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala
 ---
@@ -33,11 +33,19 @@ object WindowFunction {
 }
 
 trait WindowFunction[T] {
+
   def apply(context: WindowFunction.Context[T]): Array[Window]
+
+  def isNonMerging: Boolean
+}
+
+abstract class NonMergingWindowFunction[T] extends WindowFunction[T] {
+
+  override def isNonMerging: Boolean = true
--- End diff --

why not use `case match`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump pull request #139: [GEARPUMP-23] Do not group by windows ...

2017-02-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/139


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #139: [GEARPUMP-23] Do not group by windows in Grou...

2017-02-07 Thread huafengw
Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/139
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump pull request #139: [GEARPUMP-23] Do not group by windows ...

2017-02-07 Thread manuzhang
GitHub user manuzhang opened a pull request:

https://github.com/apache/incubator-gearpump/pull/139

[GEARPUMP-23] Do not group by windows in GroupByPartitioner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuzhang/incubator-gearpump group_by

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #139


commit f176f6d973e8ee53bf1d080f147bcdfc5a3c6a7e
Author: manuzhang 
Date:   2017-02-07T11:53:23Z

[GEARPUMP-23] Do not group by windows in GroupByPartitioner




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #139: [GEARPUMP-23] Do not group by windows in Grou...

2017-02-07 Thread manuzhang
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/139
  
R: @huafengw 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (GEARPUMP-23) Add DSL window (time series) support

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855962#comment-15855962
 ] 

ASF GitHub Bot commented on GEARPUMP-23:


Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/140
  
+1


> Add DSL window (time series) support 
> -
>
> Key: GEARPUMP-23
> URL: https://issues.apache.org/jira/browse/GEARPUMP-23
> Project: Apache Gearpump
>  Issue Type: Sub-task
>  Components: streaming
>Affects Versions: 0.8.0
>Reporter: Kam Kasravi
>Assignee: Manu Zhang
>
> Time series support is need for both GEARPUMP-21 and GEARPUMP-22. This was 
> originally github issue  
> [1917|https://github.com/gearpump/gearpump/issues/1917]. Other realtime 
> streaming engines support time windows such as 
> [Flink|https://flink.apache.org/news/2015/12/04/Introducing-windows.html], 
> [Beam|https://www.oreilly.com/ideas/the-world-beyond-batch-streaming-101] and 
> a future release of 
> [Spark|https://issues.apache.org/jira/secure/attachment/12793410/StructuredStreamingProgrammingAbstractionSemanticsandAPIs-ApacheJIRA.pdf].
>  A comparison matrix is found 
> [here|https://docs.google.com/spreadsheets/d/1OM077lZBARrtUi6g0X0O0PHaIbFKCD6v0djRefQRE1I/edit#gid=995660187]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEARPUMP-23) Add DSL window (time series) support

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855969#comment-15855969
 ] 

ASF GitHub Bot commented on GEARPUMP-23:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/140


> Add DSL window (time series) support 
> -
>
> Key: GEARPUMP-23
> URL: https://issues.apache.org/jira/browse/GEARPUMP-23
> Project: Apache Gearpump
>  Issue Type: Sub-task
>  Components: streaming
>Affects Versions: 0.8.0
>Reporter: Kam Kasravi
>Assignee: Manu Zhang
>
> Time series support is need for both GEARPUMP-21 and GEARPUMP-22. This was 
> originally github issue  
> [1917|https://github.com/gearpump/gearpump/issues/1917]. Other realtime 
> streaming engines support time windows such as 
> [Flink|https://flink.apache.org/news/2015/12/04/Introducing-windows.html], 
> [Beam|https://www.oreilly.com/ideas/the-world-beyond-batch-streaming-101] and 
> a future release of 
> [Spark|https://issues.apache.org/jira/secure/attachment/12793410/StructuredStreamingProgrammingAbstractionSemanticsandAPIs-ApacheJIRA.pdf].
>  A comparison matrix is found 
> [here|https://docs.google.com/spreadsheets/d/1OM077lZBARrtUi6g0X0O0PHaIbFKCD6v0djRefQRE1I/edit#gid=995660187]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEARPUMP-23) Add DSL window (time series) support

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855934#comment-15855934
 ] 

ASF GitHub Bot commented on GEARPUMP-23:


Github user manuzhang commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/140#discussion_r99816656
  
--- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala
 ---
@@ -33,11 +33,19 @@ object WindowFunction {
 }
 
 trait WindowFunction[T] {
+
   def apply(context: WindowFunction.Context[T]): Array[Window]
+
+  def isNonMerging: Boolean
+}
+
+abstract class NonMergingWindowFunction[T] extends WindowFunction[T] {
+
+  override def isNonMerging: Boolean = true
--- End diff --

They are free to **not** extend `NonMergingWindowFunction`


> Add DSL window (time series) support 
> -
>
> Key: GEARPUMP-23
> URL: https://issues.apache.org/jira/browse/GEARPUMP-23
> Project: Apache Gearpump
>  Issue Type: Sub-task
>  Components: streaming
>Affects Versions: 0.8.0
>Reporter: Kam Kasravi
>Assignee: Manu Zhang
>
> Time series support is need for both GEARPUMP-21 and GEARPUMP-22. This was 
> originally github issue  
> [1917|https://github.com/gearpump/gearpump/issues/1917]. Other realtime 
> streaming engines support time windows such as 
> [Flink|https://flink.apache.org/news/2015/12/04/Introducing-windows.html], 
> [Beam|https://www.oreilly.com/ideas/the-world-beyond-batch-streaming-101] and 
> a future release of 
> [Spark|https://issues.apache.org/jira/secure/attachment/12793410/StructuredStreamingProgrammingAbstractionSemanticsandAPIs-ApacheJIRA.pdf].
>  A comparison matrix is found 
> [here|https://docs.google.com/spreadsheets/d/1OM077lZBARrtUi6g0X0O0PHaIbFKCD6v0djRefQRE1I/edit#gid=995660187]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEARPUMP-23) Add DSL window (time series) support

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855928#comment-15855928
 ] 

ASF GitHub Bot commented on GEARPUMP-23:


Github user huafengw commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/140#discussion_r99815386
  
--- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala
 ---
@@ -33,11 +33,19 @@ object WindowFunction {
 }
 
 trait WindowFunction[T] {
+
   def apply(context: WindowFunction.Context[T]): Array[Window]
+
+  def isNonMerging: Boolean
+}
+
+abstract class NonMergingWindowFunction[T] extends WindowFunction[T] {
+
+  override def isNonMerging: Boolean = true
--- End diff --

But if user's WindowFunction is not able to be merged, extending 
`NonMergingWindowFunction` would suffice, otherwise extending `WindowFunction`


> Add DSL window (time series) support 
> -
>
> Key: GEARPUMP-23
> URL: https://issues.apache.org/jira/browse/GEARPUMP-23
> Project: Apache Gearpump
>  Issue Type: Sub-task
>  Components: streaming
>Affects Versions: 0.8.0
>Reporter: Kam Kasravi
>Assignee: Manu Zhang
>
> Time series support is need for both GEARPUMP-21 and GEARPUMP-22. This was 
> originally github issue  
> [1917|https://github.com/gearpump/gearpump/issues/1917]. Other realtime 
> streaming engines support time windows such as 
> [Flink|https://flink.apache.org/news/2015/12/04/Introducing-windows.html], 
> [Beam|https://www.oreilly.com/ideas/the-world-beyond-batch-streaming-101] and 
> a future release of 
> [Spark|https://issues.apache.org/jira/secure/attachment/12793410/StructuredStreamingProgrammingAbstractionSemanticsandAPIs-ApacheJIRA.pdf].
>  A comparison matrix is found 
> [here|https://docs.google.com/spreadsheets/d/1OM077lZBARrtUi6g0X0O0PHaIbFKCD6v0djRefQRE1I/edit#gid=995660187]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEARPUMP-23) Add DSL window (time series) support

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855919#comment-15855919
 ] 

ASF GitHub Bot commented on GEARPUMP-23:


Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/140
  
R: @huafengw 


> Add DSL window (time series) support 
> -
>
> Key: GEARPUMP-23
> URL: https://issues.apache.org/jira/browse/GEARPUMP-23
> Project: Apache Gearpump
>  Issue Type: Sub-task
>  Components: streaming
>Affects Versions: 0.8.0
>Reporter: Kam Kasravi
>Assignee: Manu Zhang
>
> Time series support is need for both GEARPUMP-21 and GEARPUMP-22. This was 
> originally github issue  
> [1917|https://github.com/gearpump/gearpump/issues/1917]. Other realtime 
> streaming engines support time windows such as 
> [Flink|https://flink.apache.org/news/2015/12/04/Introducing-windows.html], 
> [Beam|https://www.oreilly.com/ideas/the-world-beyond-batch-streaming-101] and 
> a future release of 
> [Spark|https://issues.apache.org/jira/secure/attachment/12793410/StructuredStreamingProgrammingAbstractionSemanticsandAPIs-ApacheJIRA.pdf].
>  A comparison matrix is found 
> [here|https://docs.google.com/spreadsheets/d/1OM077lZBARrtUi6g0X0O0PHaIbFKCD6v0djRefQRE1I/edit#gid=995660187]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEARPUMP-23) Add DSL window (time series) support

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855921#comment-15855921
 ] 

ASF GitHub Bot commented on GEARPUMP-23:


Github user huafengw commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/140#discussion_r99813902
  
--- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala
 ---
@@ -33,11 +33,19 @@ object WindowFunction {
 }
 
 trait WindowFunction[T] {
+
   def apply(context: WindowFunction.Context[T]): Array[Window]
+
+  def isNonMerging: Boolean
+}
+
+abstract class NonMergingWindowFunction[T] extends WindowFunction[T] {
+
+  override def isNonMerging: Boolean = true
--- End diff --

why not use `case match`?


> Add DSL window (time series) support 
> -
>
> Key: GEARPUMP-23
> URL: https://issues.apache.org/jira/browse/GEARPUMP-23
> Project: Apache Gearpump
>  Issue Type: Sub-task
>  Components: streaming
>Affects Versions: 0.8.0
>Reporter: Kam Kasravi
>Assignee: Manu Zhang
>
> Time series support is need for both GEARPUMP-21 and GEARPUMP-22. This was 
> originally github issue  
> [1917|https://github.com/gearpump/gearpump/issues/1917]. Other realtime 
> streaming engines support time windows such as 
> [Flink|https://flink.apache.org/news/2015/12/04/Introducing-windows.html], 
> [Beam|https://www.oreilly.com/ideas/the-world-beyond-batch-streaming-101] and 
> a future release of 
> [Spark|https://issues.apache.org/jira/secure/attachment/12793410/StructuredStreamingProgrammingAbstractionSemanticsandAPIs-ApacheJIRA.pdf].
>  A comparison matrix is found 
> [here|https://docs.google.com/spreadsheets/d/1OM077lZBARrtUi6g0X0O0PHaIbFKCD6v0djRefQRE1I/edit#gid=995660187]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEARPUMP-23) Add DSL window (time series) support

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855910#comment-15855910
 ] 

ASF GitHub Bot commented on GEARPUMP-23:


GitHub user manuzhang opened a pull request:

https://github.com/apache/incubator-gearpump/pull/140

[GEARPUMP-23] Add SessionWindows

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuzhang/incubator-gearpump sessions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #140


commit 36997ab86c820479ad7b9ed1f2e4f8c42e10c2c7
Author: manuzhang 
Date:   2017-02-07T11:54:05Z

[GEARPUMP-23] Add SessionWindows




> Add DSL window (time series) support 
> -
>
> Key: GEARPUMP-23
> URL: https://issues.apache.org/jira/browse/GEARPUMP-23
> Project: Apache Gearpump
>  Issue Type: Sub-task
>  Components: streaming
>Affects Versions: 0.8.0
>Reporter: Kam Kasravi
>Assignee: Manu Zhang
>
> Time series support is need for both GEARPUMP-21 and GEARPUMP-22. This was 
> originally github issue  
> [1917|https://github.com/gearpump/gearpump/issues/1917]. Other realtime 
> streaming engines support time windows such as 
> [Flink|https://flink.apache.org/news/2015/12/04/Introducing-windows.html], 
> [Beam|https://www.oreilly.com/ideas/the-world-beyond-batch-streaming-101] and 
> a future release of 
> [Spark|https://issues.apache.org/jira/secure/attachment/12793410/StructuredStreamingProgrammingAbstractionSemanticsandAPIs-ApacheJIRA.pdf].
>  A comparison matrix is found 
> [here|https://docs.google.com/spreadsheets/d/1OM077lZBARrtUi6g0X0O0PHaIbFKCD6v0djRefQRE1I/edit#gid=995660187]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEARPUMP-23) Add DSL window (time series) support

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855856#comment-15855856
 ] 

ASF GitHub Bot commented on GEARPUMP-23:


Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/139
  
+1


> Add DSL window (time series) support 
> -
>
> Key: GEARPUMP-23
> URL: https://issues.apache.org/jira/browse/GEARPUMP-23
> Project: Apache Gearpump
>  Issue Type: Sub-task
>  Components: streaming
>Affects Versions: 0.8.0
>Reporter: Kam Kasravi
>Assignee: Manu Zhang
>
> Time series support is need for both GEARPUMP-21 and GEARPUMP-22. This was 
> originally github issue  
> [1917|https://github.com/gearpump/gearpump/issues/1917]. Other realtime 
> streaming engines support time windows such as 
> [Flink|https://flink.apache.org/news/2015/12/04/Introducing-windows.html], 
> [Beam|https://www.oreilly.com/ideas/the-world-beyond-batch-streaming-101] and 
> a future release of 
> [Spark|https://issues.apache.org/jira/secure/attachment/12793410/StructuredStreamingProgrammingAbstractionSemanticsandAPIs-ApacheJIRA.pdf].
>  A comparison matrix is found 
> [here|https://docs.google.com/spreadsheets/d/1OM077lZBARrtUi6g0X0O0PHaIbFKCD6v0djRefQRE1I/edit#gid=995660187]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEARPUMP-23) Add DSL window (time series) support

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855853#comment-15855853
 ] 

ASF GitHub Bot commented on GEARPUMP-23:


GitHub user manuzhang opened a pull request:

https://github.com/apache/incubator-gearpump/pull/139

[GEARPUMP-23] Do not group by windows in GroupByPartitioner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuzhang/incubator-gearpump group_by

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #139


commit f176f6d973e8ee53bf1d080f147bcdfc5a3c6a7e
Author: manuzhang 
Date:   2017-02-07T11:53:23Z

[GEARPUMP-23] Do not group by windows in GroupByPartitioner




> Add DSL window (time series) support 
> -
>
> Key: GEARPUMP-23
> URL: https://issues.apache.org/jira/browse/GEARPUMP-23
> Project: Apache Gearpump
>  Issue Type: Sub-task
>  Components: streaming
>Affects Versions: 0.8.0
>Reporter: Kam Kasravi
>Assignee: Manu Zhang
>
> Time series support is need for both GEARPUMP-21 and GEARPUMP-22. This was 
> originally github issue  
> [1917|https://github.com/gearpump/gearpump/issues/1917]. Other realtime 
> streaming engines support time windows such as 
> [Flink|https://flink.apache.org/news/2015/12/04/Introducing-windows.html], 
> [Beam|https://www.oreilly.com/ideas/the-world-beyond-batch-streaming-101] and 
> a future release of 
> [Spark|https://issues.apache.org/jira/secure/attachment/12793410/StructuredStreamingProgrammingAbstractionSemanticsandAPIs-ApacheJIRA.pdf].
>  A comparison matrix is found 
> [here|https://docs.google.com/spreadsheets/d/1OM077lZBARrtUi6g0X0O0PHaIbFKCD6v0djRefQRE1I/edit#gid=995660187]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)