[GitHub] incubator-gearpump issue #151: [GEARPUMP-274] Set lower bound of time to Lon...
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/151 That's it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (GEARPUMP-274) Set lower bound of time to Long.MinValue milliseconds
[ https://issues.apache.org/jira/browse/GEARPUMP-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872940#comment-15872940 ] ASF GitHub Bot commented on GEARPUMP-274: - Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/151 That's it? > Set lower bound of time to Long.MinValue milliseconds > - > > Key: GEARPUMP-274 > URL: https://issues.apache.org/jira/browse/GEARPUMP-274 > Project: Apache Gearpump > Issue Type: Bug >Reporter: Manu Zhang >Assignee: Manu Zhang > > The requirement actually comes from Beam whose time bound is from > *Long.MinValue microseconds* to *Long.MaxValue microseconds*. Setting the > lower bound to *Long.MinValue milliseconds* would accommodate Beam's lower > bound without any harm. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-gearpump issue #151: [GEARPUMP-274] Set lower bound of time to Lon...
Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/151 # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=h1) Report > Merging [#151](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/df40cbdbd6e289f6a7ee8456e033ebc3db605b83?src=pr&el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `100%`. ```diff @@Coverage Diff @@ ## master #151 +/- ## == + Coverage 71.56% 71.63% +0.06% == Files 191 191 Lines6070 6070 Branches 510 510 == + Hits 4344 4348 +4 + Misses 1726 1722 -4 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=footer). Last update [df40cbd...73a08d5](https://codecov.io/gh/apache/incubator-gearpump/compare/df40cbdbd6e289f6a7ee8456e033ebc3db605b83...73a08d537780d5f5dd050e813a178466e0469229?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (GEARPUMP-274) Set lower bound of time to Long.MinValue milliseconds
[ https://issues.apache.org/jira/browse/GEARPUMP-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872683#comment-15872683 ] ASF GitHub Bot commented on GEARPUMP-274: - Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/151 # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=h1) Report > Merging [#151](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/df40cbdbd6e289f6a7ee8456e033ebc3db605b83?src=pr&el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `100%`. ```diff @@Coverage Diff @@ ## master #151 +/- ## == + Coverage 71.56% 71.63% +0.06% == Files 191 191 Lines6070 6070 Branches 510 510 == + Hits 4344 4348 +4 + Misses 1726 1722 -4 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=footer). Last update [df40cbd...73a08d5](https://codecov.io/gh/apache/incubator-gearpump/compare/df40cbdbd6e289f6a7ee8456e033ebc3db605b83...73a08d537780d5f5dd050e813a178466e0469229?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > Set lower bound of time to Long.MinValue milliseconds > - > > Key: GEARPUMP-274 > URL: https://issues.apache.org/jira/browse/GEARPUMP-274 > Project: Apache Gearpump > Issue Type: Bug >Reporter: Manu Zhang >Assignee: Manu Zhang > > The requirement actually comes from Beam whose time bound is from > *Long.MinValue microseconds* to *Long.MaxValue microseconds*. Setting the > lower bound to *Long.MinValue milliseconds* would accommodate Beam's lower > bound without any harm. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-gearpump pull request #151: [GEARPUMP-274] Set lower bound of time...
GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/151 [GEARPUMP-274] Set lower bound of time to Long.MinValue milliseconds Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit message is formatted like: `[GEARPUMP-] Meaningful description of pull request` - [ ] Make sure tests pass via `sbt clean test`. - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuzhang/incubator-gearpump time Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #151 commit 73a08d537780d5f5dd050e813a178466e0469229 Author: manuzhang Date: 2017-02-17T08:58:33Z [GEARPUMP-274] Set lower bound of time to Long.MinValue milliseconds --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (GEARPUMP-274) Set lower bound of time to Long.MinValue milliseconds
[ https://issues.apache.org/jira/browse/GEARPUMP-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871478#comment-15871478 ] ASF GitHub Bot commented on GEARPUMP-274: - GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/151 [GEARPUMP-274] Set lower bound of time to Long.MinValue milliseconds Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit message is formatted like: `[GEARPUMP-] Meaningful description of pull request` - [ ] Make sure tests pass via `sbt clean test`. - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuzhang/incubator-gearpump time Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #151 commit 73a08d537780d5f5dd050e813a178466e0469229 Author: manuzhang Date: 2017-02-17T08:58:33Z [GEARPUMP-274] Set lower bound of time to Long.MinValue milliseconds > Set lower bound of time to Long.MinValue milliseconds > - > > Key: GEARPUMP-274 > URL: https://issues.apache.org/jira/browse/GEARPUMP-274 > Project: Apache Gearpump > Issue Type: Bug >Reporter: Manu Zhang >Assignee: Manu Zhang > > The requirement actually comes from Beam whose time bound is from > *Long.MinValue microseconds* to *Long.MaxValue microseconds*. Setting the > lower bound to *Long.MinValue milliseconds* would accommodate Beam's lower > bound without any harm. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (GEARPUMP-274) Set lower bound of time to Long.MinValue milliseconds
Manu Zhang created GEARPUMP-274: --- Summary: Set lower bound of time to Long.MinValue milliseconds Key: GEARPUMP-274 URL: https://issues.apache.org/jira/browse/GEARPUMP-274 Project: Apache Gearpump Issue Type: Bug Reporter: Manu Zhang Assignee: Manu Zhang The requirement actually comes from Beam whose time bound is from *Long.MinValue microseconds* to *Long.MaxValue microseconds*. Setting the lower bound to *Long.MinValue milliseconds* would accommodate Beam's lower bound without any harm. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEARPUMP-236) java.lang.VerifyError after assembly gearpump-core
[ https://issues.apache.org/jira/browse/GEARPUMP-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871371#comment-15871371 ] Karol Brejna commented on GEARPUMP-236: --- WIll do. > java.lang.VerifyError after assembly gearpump-core > -- > > Key: GEARPUMP-236 > URL: https://issues.apache.org/jira/browse/GEARPUMP-236 > Project: Apache Gearpump > Issue Type: Bug >Reporter: Manu Zhang >Assignee: Karol Brejna > > {{java.lang.VerifyError}} exceptions are thrown in all main processes > (master, worker, executor, etc) after we assembly {{gearpump-core}}. I added > {{-noverify}} to all of their jvm options as a work-around. We should find > the root cause and remove it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)