[GitHub] incubator-gearpump issue #170: [GEARPUMP-291] Refactor TaskActor
Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/170 # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/170?src=pr&el=h1) Report > Merging [#170](https://codecov.io/gh/apache/incubator-gearpump/pull/170?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/aebc09a8deba2c68a0664f0035d9e68e5c4219a6?src=pr&el=desc) will **decrease** coverage by `0.29%`. > The diff coverage is `78.26%`. ```diff @@Coverage Diff@@ ## master #170 +/- ## = - Coverage 71.91% 71.62% -0.3% = Files 191 191 Lines6079 6086 +7 Branches 509 527 +18 = - Hits 4372 4359 -13 - Misses 1707 1727 +20 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/170?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/170?src=pr&el=footer). Last update [aebc09a...38c8de1](https://codecov.io/gh/apache/incubator-gearpump/compare/aebc09a8deba2c68a0664f0035d9e68e5c4219a6...38c8de1b09d5d1b630ae7d1ebaf348abe4417cfa?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (GEARPUMP-291) TaskActor refactoring
[ https://issues.apache.org/jira/browse/GEARPUMP-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905974#comment-15905974 ] ASF GitHub Bot commented on GEARPUMP-291: - Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/170 # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/170?src=pr&el=h1) Report > Merging [#170](https://codecov.io/gh/apache/incubator-gearpump/pull/170?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/aebc09a8deba2c68a0664f0035d9e68e5c4219a6?src=pr&el=desc) will **decrease** coverage by `0.29%`. > The diff coverage is `78.26%`. ```diff @@Coverage Diff@@ ## master #170 +/- ## = - Coverage 71.91% 71.62% -0.3% = Files 191 191 Lines6079 6086 +7 Branches 509 527 +18 = - Hits 4372 4359 -13 - Misses 1707 1727 +20 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/170?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/170?src=pr&el=footer). Last update [aebc09a...38c8de1](https://codecov.io/gh/apache/incubator-gearpump/compare/aebc09a8deba2c68a0664f0035d9e68e5c4219a6...38c8de1b09d5d1b630ae7d1ebaf348abe4417cfa?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > TaskActor refactoring > - > > Key: GEARPUMP-291 > URL: https://issues.apache.org/jira/browse/GEARPUMP-291 > Project: Apache Gearpump > Issue Type: Improvement > Components: streaming >Affects Versions: 0.8.2 >Reporter: Manu Zhang >Assignee: Manu Zhang > > To fix warnings and styles, avoid tricky codes, and decompose "big" function > into "smaller" modules. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-gearpump pull request #169: [GEARPUMP-285] fix false alarm of shut...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request #170: [GEARPUMP-291] Refactor TaskActor
Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request #170: [GEARPUMP-291] Refactor TaskActor
GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/170 [GEARPUMP-291] Refactor TaskActor Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit message is formatted like: `[GEARPUMP-] Meaningful description of pull request` - [ ] Make sure tests pass via `sbt clean test`. - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuzhang/incubator-gearpump refactor_task Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/170.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #170 commit 991b4fa4c73dc3cdc53e4f495871cc0dd0764fdc Author: manuzhang Date: 2017-03-10T07:48:47Z [GEARPUMP-291] Refactor TaskActor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump issue #169: [GEARPUMP-285] fix false alarm of shutting do...
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/169 +1, merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump issue #170: [GEARPUMP-291] Refactor TaskActor
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/170 R: @huafengw test passes https://travis-ci.org/manuzhang/incubator-gearpump/builds/209659694 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump issue #170: [GEARPUMP-291] Refactor TaskActor
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/170 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (GEARPUMP-291) TaskActor refactoring
[ https://issues.apache.org/jira/browse/GEARPUMP-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905215#comment-15905215 ] ASF GitHub Bot commented on GEARPUMP-291: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/170 > TaskActor refactoring > - > > Key: GEARPUMP-291 > URL: https://issues.apache.org/jira/browse/GEARPUMP-291 > Project: Apache Gearpump > Issue Type: Improvement > Components: streaming >Affects Versions: 0.8.2 >Reporter: Manu Zhang >Assignee: Manu Zhang > > To fix warnings and styles, avoid tricky codes, and decompose "big" function > into "smaller" modules. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEARPUMP-291) TaskActor refactoring
[ https://issues.apache.org/jira/browse/GEARPUMP-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904871#comment-15904871 ] ASF GitHub Bot commented on GEARPUMP-291: - Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/170 +1 > TaskActor refactoring > - > > Key: GEARPUMP-291 > URL: https://issues.apache.org/jira/browse/GEARPUMP-291 > Project: Apache Gearpump > Issue Type: Improvement > Components: streaming >Affects Versions: 0.8.2 >Reporter: Manu Zhang >Assignee: Manu Zhang > > To fix warnings and styles, avoid tricky codes, and decompose "big" function > into "smaller" modules. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEARPUMP-291) TaskActor refactoring
[ https://issues.apache.org/jira/browse/GEARPUMP-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904697#comment-15904697 ] ASF GitHub Bot commented on GEARPUMP-291: - Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/170 R: @huafengw test passes https://travis-ci.org/manuzhang/incubator-gearpump/builds/209659694 > TaskActor refactoring > - > > Key: GEARPUMP-291 > URL: https://issues.apache.org/jira/browse/GEARPUMP-291 > Project: Apache Gearpump > Issue Type: Improvement > Components: streaming >Affects Versions: 0.8.2 >Reporter: Manu Zhang >Assignee: Manu Zhang > > To fix warnings and styles, avoid tricky codes, and decompose "big" function > into "smaller" modules. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (GEARPUMP-285) AppManager shut down executor time out
[
https://issues.apache.org/jira/browse/GEARPUMP-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manu Zhang resolved GEARPUMP-285.
-
Resolution: Fixed
Fix Version/s: 0.8.3
Issue resolved by pull request 169
[https://github.com/apache/incubator-gearpump/pull/169]
> AppManager shut down executor time out
> --
>
> Key: GEARPUMP-285
> URL: https://issues.apache.org/jira/browse/GEARPUMP-285
> Project: Apache Gearpump
> Issue Type: Bug
>Affects Versions: 0.8.2
>Reporter: Manu Zhang
>Assignee: Huafeng Wang
>Priority: Minor
> Fix For: 0.8.3
>
>
> When running Beam tests for about 10 seconds with {{EmbeddedCluster}}, I saw
> the "Shut down executor time out" error log which should be trigger only
> after 30 seconds.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEARPUMP-285) AppManager shut down executor time out
[
https://issues.apache.org/jira/browse/GEARPUMP-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904660#comment-15904660
]
ASF GitHub Bot commented on GEARPUMP-285:
-
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/169
> AppManager shut down executor time out
> --
>
> Key: GEARPUMP-285
> URL: https://issues.apache.org/jira/browse/GEARPUMP-285
> Project: Apache Gearpump
> Issue Type: Bug
>Affects Versions: 0.8.2
>Reporter: Manu Zhang
>Assignee: Huafeng Wang
>Priority: Minor
> Fix For: 0.8.3
>
>
> When running Beam tests for about 10 seconds with {{EmbeddedCluster}}, I saw
> the "Shut down executor time out" error log which should be trigger only
> after 30 seconds.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
