[GitHub] incubator-gearpump pull request #222: [GEARPUMP-348] Allow application total...

2017-09-01 Thread huafengw 
GitHub user huafengw opened a pull request:

https://github.com/apache/incubator-gearpump/pull/222

[GEARPUMP-348] Allow application total number of retries to be config…

…urable

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/huafengw/incubator-gearpump restart

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/222.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #222


commit 1ff5ac05904320fd64580529897822524edb349a
Author: huafengw 
Date:   2017-09-01T06:21:19Z

[GEARPUMP-348] Allow application total number of retries to be configurable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #222: [GEARPUMP-348] Allow application total number...

2017-09-01 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/222
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/222?src=pr=h1)
 Report
> Merging 
[#222](https://codecov.io/gh/apache/incubator-gearpump/pull/222?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/995c8cc0cc0b18dd30cbbe218972b0bded297ff0?src=pr=desc)
 will **increase** coverage by `0.13%`.
> The diff coverage is `100%`.



```diff
@@Coverage Diff @@
##   master #222  +/-   ##
==
+ Coverage   69.42%   69.56%   +0.13% 
==
  Files 191  191  
  Lines6103 6104   +1 
  Branches  362  350  -12 
==
+ Hits 4237 4246   +9 
+ Misses   1866 1858   -8
```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #222: [GEARPUMP-348] Allow application total...

2017-09-01 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/222


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #222: [GEARPUMP-348] Allow application total number...

2017-09-01 Thread manuzhang 
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/222
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEARPUMP-348) Allow application total number of retries to be configurable

2017-09-01 Thread Manu Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEARPUMP-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manu Zhang resolved GEARPUMP-348.
-
   Resolution: Fixed
Fix Version/s: 0.8.5

Issue resolved by pull request 222
[https://github.com/apache/incubator-gearpump/pull/222]

> Allow application total number of retries to be configurable
> 
>
> Key: GEARPUMP-348
> URL: https://issues.apache.org/jira/browse/GEARPUMP-348
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Huafeng Wang
>Priority: Minor
> Fix For: 0.8.5
>
>
> Currently, total number of retries for an application is hardcoded to 5. 
> There are cases we want it to fail as soon as possible (e.g. tests)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-348) Allow application total number of retries to be configurable

2017-09-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151359#comment-16151359
 ] 

ASF GitHub Bot commented on GEARPUMP-348:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/222


> Allow application total number of retries to be configurable
> 
>
> Key: GEARPUMP-348
> URL: https://issues.apache.org/jira/browse/GEARPUMP-348
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Huafeng Wang
>Priority: Minor
>
> Currently, total number of retries for an application is hardcoded to 5. 
> There are cases we want it to fail as soon as possible (e.g. tests)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-348) Allow application total number of retries to be configurable

2017-09-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151357#comment-16151357
 ] 

ASF GitHub Bot commented on GEARPUMP-348:
-

Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/222
  
LGTM


> Allow application total number of retries to be configurable
> 
>
> Key: GEARPUMP-348
> URL: https://issues.apache.org/jira/browse/GEARPUMP-348
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Huafeng Wang
>Priority: Minor
>
> Currently, total number of retries for an application is hardcoded to 5. 
> There are cases we want it to fail as soon as possible (e.g. tests)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-348) Allow application total number of retries to be configurable

2017-09-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150118#comment-16150118
 ] 

ASF GitHub Bot commented on GEARPUMP-348:
-

Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/222
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/222?src=pr=h1)
 Report
> Merging 
[#222](https://codecov.io/gh/apache/incubator-gearpump/pull/222?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/995c8cc0cc0b18dd30cbbe218972b0bded297ff0?src=pr=desc)
 will **increase** coverage by `0.13%`.
> The diff coverage is `100%`.



```diff
@@Coverage Diff @@
##   master #222  +/-   ##
==
+ Coverage   69.42%   69.56%   +0.13% 
==
  Files 191  191  
  Lines6103 6104   +1 
  Branches  362  350  -12 
==
+ Hits 4237 4246   +9 
+ Misses   1866 1858   -8
```




> Allow application total number of retries to be configurable
> 
>
> Key: GEARPUMP-348
> URL: https://issues.apache.org/jira/browse/GEARPUMP-348
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Huafeng Wang
>Priority: Minor
>
> Currently, total number of retries for an application is hardcoded to 5. 
> There are cases we want it to fail as soon as possible (e.g. tests)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-348) Allow application total number of retries to be configurable

2017-09-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150105#comment-16150105
 ] 

ASF GitHub Bot commented on GEARPUMP-348:
-

GitHub user huafengw opened a pull request:

https://github.com/apache/incubator-gearpump/pull/222

[GEARPUMP-348] Allow application total number of retries to be config…

…urable

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/huafengw/incubator-gearpump restart

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/222.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #222


commit 1ff5ac05904320fd64580529897822524edb349a
Author: huafengw 
Date:   2017-09-01T06:21:19Z

[GEARPUMP-348] Allow application total number of retries to be configurable




> Allow application total number of retries to be configurable
> 
>
> Key: GEARPUMP-348
> URL: https://issues.apache.org/jira/browse/GEARPUMP-348
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Huafeng Wang
>Priority: Minor
>
> Currently, total number of retries for an application is hardcoded to 5. 
> There are cases we want it to fail as soon as possible (e.g. tests)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)