[GitHub] incubator-gearpump issue #234: [GEARPUMP-359] Fix OutputWatermark advancing ...

2017-10-26 Thread manuzhang 
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/234
  
LGTM. Merged with fixing the nitpick


---

[GitHub] incubator-gearpump pull request #234: [GEARPUMP-359] Fix OutputWatermark adv...

2017-10-26 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/234


---

[jira] [Commented] (GEARPUMP-359) The premature OutputWatermark advancing logic in Subscription is not right

2017-10-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221373#comment-16221373
 ] 

ASF GitHub Bot commented on GEARPUMP-359:
-

Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/234
  
LGTM. Merged with fixing the nitpick


> The premature OutputWatermark advancing logic in Subscription is not right
> --
>
> Key: GEARPUMP-359
> URL: https://issues.apache.org/jira/browse/GEARPUMP-359
> Project: Apache Gearpump
>  Issue Type: Bug
>Reporter: Huafeng Wang
>Assignee: Huafeng Wang
> Fix For: 0.8.5
>
>
> {{Subscription}} will update processingWatermark when sending a message and 
> update outputWatermark when receiving an Ack message. It will cause 
> prematurely updating the outputWatermark in such scenario: the 
> {{Subscription}} already sent 200 messages to downstream and now the 
> processingWatermark is 200th message's watermark, then it receives the first 
> 100 messages' Ack and it will advance the outputWatermark to 200th message's 
> watermark, not the 100th one, which is wrong.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEARPUMP-359) The premature OutputWatermark advancing logic in Subscription is not right

2017-10-26 Thread Manu Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manu Zhang resolved GEARPUMP-359.
-
   Resolution: Fixed
Fix Version/s: 0.8.5

Issue resolved by pull request 234
[https://github.com/apache/incubator-gearpump/pull/234]

> The premature OutputWatermark advancing logic in Subscription is not right
> --
>
> Key: GEARPUMP-359
> URL: https://issues.apache.org/jira/browse/GEARPUMP-359
> Project: Apache Gearpump
>  Issue Type: Bug
>Reporter: Huafeng Wang
>Assignee: Huafeng Wang
> Fix For: 0.8.5
>
>
> {{Subscription}} will update processingWatermark when sending a message and 
> update outputWatermark when receiving an Ack message. It will cause 
> prematurely updating the outputWatermark in such scenario: the 
> {{Subscription}} already sent 200 messages to downstream and now the 
> processingWatermark is 200th message's watermark, then it receives the first 
> 100 messages' Ack and it will advance the outputWatermark to 200th message's 
> watermark, not the 100th one, which is wrong.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-359) The premature OutputWatermark advancing logic in Subscription is not right

2017-10-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221366#comment-16221366
 ] 

ASF GitHub Bot commented on GEARPUMP-359:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/234


> The premature OutputWatermark advancing logic in Subscription is not right
> --
>
> Key: GEARPUMP-359
> URL: https://issues.apache.org/jira/browse/GEARPUMP-359
> Project: Apache Gearpump
>  Issue Type: Bug
>Reporter: Huafeng Wang
>Assignee: Huafeng Wang
> Fix For: 0.8.5
>
>
> {{Subscription}} will update processingWatermark when sending a message and 
> update outputWatermark when receiving an Ack message. It will cause 
> prematurely updating the outputWatermark in such scenario: the 
> {{Subscription}} already sent 200 messages to downstream and now the 
> processingWatermark is 200th message's watermark, then it receives the first 
> 100 messages' Ack and it will advance the outputWatermark to 200th message's 
> watermark, not the 100th one, which is wrong.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-gearpump issue #233: [GEARPUMP-361] Build gearpump docker image lo...

2017-10-26 Thread manuzhang 
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/233
  
@karol-brejna-i @huafengw rebased. Please help to verify again


---

[GitHub] incubator-gearpump pull request #234: [GEARPUMP-359] Fix OutputWatermark adv...

2017-10-26 Thread manuzhang 
Github user manuzhang commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/234#discussion_r147105502
  
--- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/task/Subscription.scala 
---
@@ -209,7 +202,8 @@ class Subscription(
 // to throttle the number of unacked AckRequest
 incrementMessageCount(partition, ackOnceEveryMessageCount)
 val targetTask = TaskId(processorId, partition)
-val ackRequest = AckRequest(taskId, messageCount(partition), sessionId)
+val processingWaterMark = publisher.getProcessingWatermark.toEpochMilli
--- End diff --

nitpick: processingWaterMark => processingWatermark


---

[GitHub] incubator-gearpump issue #233: [WIP] Fix integration test

2017-10-26 Thread karol-brejna-i 
Github user karol-brejna-i commented on the issue:

https://github.com/apache/incubator-gearpump/pull/233
  
Docker image problem solved with 
https://github.com/apache/incubator-gearpump/pull/235.


---

[GitHub] incubator-gearpump issue #235: Use alpine-based image for gearpump-runner

2017-10-26 Thread karol-brejna-i 
Github user karol-brejna-i commented on the issue:

https://github.com/apache/incubator-gearpump/pull/235
  
done!


---

[GitHub] incubator-gearpump issue #235: Use alpine-based image for gearpump-runner

2017-10-26 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/235
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/235?src=pr=h1)
 Report
> Merging 
[#235](https://codecov.io/gh/apache/incubator-gearpump/pull/235?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/8064313afeee1d966ef033a637cfd58d1cca6617?src=pr=desc)
 will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.



```diff
@@Coverage Diff@@
##   master#235  +/-   ##
=
- Coverage   69.16%   69.1%   -0.07% 
=
  Files 191 191  
  Lines61236123  
  Branches  357 357  
=
- Hits 42354231   -4 
- Misses   18881892   +4
```




---

[GitHub] incubator-gearpump pull request #235: Use alpine-based image for gearpump-ru...

2017-10-26 Thread karol-brejna-i 
GitHub user karol-brejna-i opened a pull request:

https://github.com/apache/incubator-gearpump/pull/235

Use alpine-based image for gearpump-runner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 

To verify:
1. build the image (`docker build --build-arg HTTP_PROXY=$http_proxy 
--build-arg HTTPS_PROXY=$https_proxy -t gearpump/gearpump-launcher 
integrationtest/docker/gearpump/
`)
2. run the master (`docker run -d -h master0 -v 
/etc/localtime:/etc/localtime:ro -p 8090:8090 -e 
JAVA_OPTS=-Dgearpump.cluster.masters.0=master0:3000 -v 
$GEARPUMP_HOME:/opt/gearpump -v /tmp/gearpump:/var/log/gearpump --name master0 
gearpump/gearpump-launcher master -ip master0 -port 3000` - please, mind it 
tries to use the port 8090)
3. run the worker (`docker run -d -h worker0 -v 
/etc/localtime:/etc/localtime:ro -e 
JAVA_OPTS=-Dgearpump.cluster.masters.0=master0:3000 -v 
$GEARPUMP_HOME:/opt/gearpump -v /tmp/gearpump:/var/log/gearpump --link master0 
--name worker0 gearpump/gearpump-launcher worker`)
4. verify it works (`docker logs master0`, `docker logs worker0`, open 
localhost:8090 in the browser)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karol-brejna-i/incubator-gearpump 
GEARPUMP-360-fix-dockerfile

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #235


commit 6a85a6a1b362cbaafd85cd7b02439b58272a59e1
Author: karol-brejna-i 
Date:   2017-10-26T09:20:08Z

Use alpine-based image for gearpump-runner




---

[GitHub] incubator-gearpump issue #235: Use alpine-based image for gearpump-runner

2017-10-26 Thread manuzhang 
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/235
  
Great ! Could you create a JIRA issue and update your commit comment 
accordingly ?


---

[GitHub] incubator-gearpump pull request #227: [GEARPUMP-350] Fix the not started app...

2017-10-26 Thread huafengw 
Github user huafengw commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/227#discussion_r147065810
  
--- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskActor.scala ---
@@ -361,10 +358,11 @@ class TaskActor(
   }
 
   private def getSubscriptionWatermark(subs: List[(Int, Subscription)], 
wmk: Instant): Instant = {
+val wmkInMilli = wmk.toEpochMilli
--- End diff --

To avoid multiple `toEpochMilli` calls


---

[GitHub] incubator-gearpump issue #234: [GEARPUMP-359] Fix OutputWatermark advancing ...

2017-10-26 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/234
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/234?src=pr=h1)
 Report
> Merging 
[#234](https://codecov.io/gh/apache/incubator-gearpump/pull/234?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/8064313afeee1d966ef033a637cfd58d1cca6617?src=pr=desc)
 will **decrease** coverage by `0.04%`.
> The diff coverage is `86.66%`.



```diff
@@Coverage Diff @@
##   master #234  +/-   ##
==
- Coverage   69.16%   69.12%   -0.05% 
==
  Files 191  191  
  Lines6123 6124   +1 
  Branches  357  362   +5 
==
- Hits 4235 4233   -2 
- Misses   1888 1891   +3
```




---

[GitHub] incubator-gearpump pull request #234: [GEARPUMP-359] Fix OutputWatermark adv...

2017-10-26 Thread huafengw 
GitHub user huafengw opened a pull request:

https://github.com/apache/incubator-gearpump/pull/234

[GEARPUMP-359] Fix OutputWatermark advancing logic in Subscription

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/huafengw/incubator-gearpump subs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #234


commit 311e09b28ebe8ac8525b447e831615065dcc541c
Author: huafengw 
Date:   2017-10-26T05:52:39Z

[GEARPUMP-359] Fix OutputWatermark advancing logic in Subscription




---

[jira] [Commented] (GEARPUMP-361) Build Gearpump Docker Image locally for integration test

2017-10-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220308#comment-16220308
 ] 

ASF GitHub Bot commented on GEARPUMP-361:
-

Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/233
  
@karol-brejna-i @huafengw rebased. Please help to verify again


> Build Gearpump Docker Image locally for integration test
> 
>
> Key: GEARPUMP-361
> URL: https://issues.apache.org/jira/browse/GEARPUMP-361
> Project: Apache Gearpump
>  Issue Type: Improvement
>  Components: integrationtest
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Manu Zhang
> Fix For: 0.8.5
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEARPUMP-361) Build Gearpump Docker Image locally for integration test

2017-10-26 Thread Manu Zhang (JIRA) 
Manu Zhang created GEARPUMP-361:
---

 Summary: Build Gearpump Docker Image locally for integration test
 Key: GEARPUMP-361
 URL: https://issues.apache.org/jira/browse/GEARPUMP-361
 Project: Apache Gearpump
  Issue Type: Improvement
  Components: integrationtest
Affects Versions: 0.8.4
Reporter: Manu Zhang
Assignee: Manu Zhang
 Fix For: 0.8.5






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-359) The premature OutputWatermark advancing logic in Subscription is not right

2017-10-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220294#comment-16220294
 ] 

ASF GitHub Bot commented on GEARPUMP-359:
-

Github user manuzhang commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/234#discussion_r147105502
  
--- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/task/Subscription.scala 
---
@@ -209,7 +202,8 @@ class Subscription(
 // to throttle the number of unacked AckRequest
 incrementMessageCount(partition, ackOnceEveryMessageCount)
 val targetTask = TaskId(processorId, partition)
-val ackRequest = AckRequest(taskId, messageCount(partition), sessionId)
+val processingWaterMark = publisher.getProcessingWatermark.toEpochMilli
--- End diff --

nitpick: processingWaterMark => processingWatermark


> The premature OutputWatermark advancing logic in Subscription is not right
> --
>
> Key: GEARPUMP-359
> URL: https://issues.apache.org/jira/browse/GEARPUMP-359
> Project: Apache Gearpump
>  Issue Type: Bug
>Reporter: Huafeng Wang
>Assignee: Huafeng Wang
>
> {{Subscription}} will update processingWatermark when sending a message and 
> update outputWatermark when receiving an Ack message. It will cause 
> prematurely updating the outputWatermark in such scenario: the 
> {{Subscription}} already sent 200 messages to downstream and now the 
> processingWatermark is 200th message's watermark, then it receives the first 
> 100 messages' Ack and it will advance the outputWatermark to 200th message's 
> watermark, not the 100th one, which is wrong.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEARPUMP-360) gearpump-launcher image broken

2017-10-26 Thread Karol Brejna (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEARPUMP-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karol Brejna updated GEARPUMP-360:
--
Fix Version/s: 0.8.5

> gearpump-launcher image broken
> --
>
> Key: GEARPUMP-360
> URL: https://issues.apache.org/jira/browse/GEARPUMP-360
> Project: Apache Gearpump
>  Issue Type: Bug
>  Components: integrationtest
>Affects Versions: 0.8.4
>Reporter: Karol Brejna
>Assignee: Karol Brejna
> Fix For: 0.8.5
>
>
> Building docker image for integration tests fails:
> {code}
> > docker build --no-cache -t gearpump/gearpump-launcher 
> > integrationtest/docker/gearpump
> Sending build context to Docker daemon  8.192kB
> Step 1/7 : FROM grubykarol/jre:8u121b13_server
>  ---> f7e482e81614
> Step 2/7 : RUN opkg-install python
>  ---> Running in 0939e0c36efc
> Downloading 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/base/Packages.gz.
> Inflating 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/base/Packages.gz.
> Updated list of available packages in /var/opkg-lists/base.
> Downloading 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/packages/Packages.gz.
> Inflating 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/packages/Packages.gz.
> Updated list of available packages in /var/opkg-lists/packages.
> Unknown package 'python'.
> Collected errors:
>  *opkg_install_cmd: Cannot install package python.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-360) gearpump-launcher image broken

2017-10-26 Thread Manu Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220288#comment-16220288
 ] 

Manu Zhang commented on GEARPUMP-360:
-

Fixed in https://github.com/apache/incubator-gearpump/pull/235

> gearpump-launcher image broken
> --
>
> Key: GEARPUMP-360
> URL: https://issues.apache.org/jira/browse/GEARPUMP-360
> Project: Apache Gearpump
>  Issue Type: Bug
>  Components: integrationtest
>Affects Versions: 0.8.4
>Reporter: Karol Brejna
>Assignee: Karol Brejna
>
> Building docker image for integration tests fails:
> {code}
> > docker build --no-cache -t gearpump/gearpump-launcher 
> > integrationtest/docker/gearpump
> Sending build context to Docker daemon  8.192kB
> Step 1/7 : FROM grubykarol/jre:8u121b13_server
>  ---> f7e482e81614
> Step 2/7 : RUN opkg-install python
>  ---> Running in 0939e0c36efc
> Downloading 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/base/Packages.gz.
> Inflating 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/base/Packages.gz.
> Updated list of available packages in /var/opkg-lists/base.
> Downloading 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/packages/Packages.gz.
> Inflating 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/packages/Packages.gz.
> Updated list of available packages in /var/opkg-lists/packages.
> Unknown package 'python'.
> Collected errors:
>  *opkg_install_cmd: Cannot install package python.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEARPUMP-360) gearpump-launcher image broken

2017-10-26 Thread Manu Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEARPUMP-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manu Zhang resolved GEARPUMP-360.
-
Resolution: Fixed

> gearpump-launcher image broken
> --
>
> Key: GEARPUMP-360
> URL: https://issues.apache.org/jira/browse/GEARPUMP-360
> Project: Apache Gearpump
>  Issue Type: Bug
>  Components: integrationtest
>Affects Versions: 0.8.4
>Reporter: Karol Brejna
>Assignee: Karol Brejna
>
> Building docker image for integration tests fails:
> {code}
> > docker build --no-cache -t gearpump/gearpump-launcher 
> > integrationtest/docker/gearpump
> Sending build context to Docker daemon  8.192kB
> Step 1/7 : FROM grubykarol/jre:8u121b13_server
>  ---> f7e482e81614
> Step 2/7 : RUN opkg-install python
>  ---> Running in 0939e0c36efc
> Downloading 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/base/Packages.gz.
> Inflating 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/base/Packages.gz.
> Updated list of available packages in /var/opkg-lists/base.
> Downloading 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/packages/Packages.gz.
> Inflating 
> http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/packages/Packages.gz.
> Updated list of available packages in /var/opkg-lists/packages.
> Unknown package 'python'.
> Collected errors:
>  *opkg_install_cmd: Cannot install package python.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEARPUMP-360) gearpump-launcher image broken

2017-10-26 Thread Karol Brejna (JIRA) 
Karol Brejna created GEARPUMP-360:
-

 Summary: gearpump-launcher image broken
 Key: GEARPUMP-360
 URL: https://issues.apache.org/jira/browse/GEARPUMP-360
 Project: Apache Gearpump
  Issue Type: Bug
  Components: integrationtest
Affects Versions: 0.8.4
Reporter: Karol Brejna
Assignee: Karol Brejna


Building docker image for integration tests fails:

{code}
> docker build --no-cache -t gearpump/gearpump-launcher 
> integrationtest/docker/gearpump


Sending build context to Docker daemon  8.192kB
Step 1/7 : FROM grubykarol/jre:8u121b13_server
 ---> f7e482e81614
Step 2/7 : RUN opkg-install python
 ---> Running in 0939e0c36efc
Downloading 
http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/base/Packages.gz.
Inflating 
http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/base/Packages.gz.
Updated list of available packages in /var/opkg-lists/base.
Downloading 
http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/packages/Packages.gz.
Inflating 
http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/packages/Packages.gz.
Updated list of available packages in /var/opkg-lists/packages.
Unknown package 'python'.
Collected errors:
 *opkg_install_cmd: Cannot install package python.
{code}





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-350) the app Clock is not started

2017-10-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220112#comment-16220112
 ] 

ASF GitHub Bot commented on GEARPUMP-350:
-

Github user huafengw commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/227#discussion_r147065810
  
--- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskActor.scala ---
@@ -361,10 +358,11 @@ class TaskActor(
   }
 
   private def getSubscriptionWatermark(subs: List[(Int, Subscription)], 
wmk: Instant): Instant = {
+val wmkInMilli = wmk.toEpochMilli
--- End diff --

To avoid multiple `toEpochMilli` calls


> the app Clock is not started
> 
>
> Key: GEARPUMP-350
> URL: https://issues.apache.org/jira/browse/GEARPUMP-350
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.4
>Reporter: Pan Xue
> Attachments: gearpump0.8.4.PNG
>
>
> When I submitted an app in the web,  in the DAG display page, I found that 
> the application clock has been not started, the source processor's color will 
> turn red, I use the example is 0.8.4 version of the example / wordcount
> !gearpump0.8.4.PNG|thumbnail!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-359) The premature OutputWatermark advancing logic in Subscription is not right

2017-10-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220074#comment-16220074
 ] 

ASF GitHub Bot commented on GEARPUMP-359:
-

Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/234
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/234?src=pr=h1)
 Report
> Merging 
[#234](https://codecov.io/gh/apache/incubator-gearpump/pull/234?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/8064313afeee1d966ef033a637cfd58d1cca6617?src=pr=desc)
 will **decrease** coverage by `0.04%`.
> The diff coverage is `86.66%`.



```diff
@@Coverage Diff @@
##   master #234  +/-   ##
==
- Coverage   69.16%   69.12%   -0.05% 
==
  Files 191  191  
  Lines6123 6124   +1 
  Branches  357  362   +5 
==
- Hits 4235 4233   -2 
- Misses   1888 1891   +3
```




> The premature OutputWatermark advancing logic in Subscription is not right
> --
>
> Key: GEARPUMP-359
> URL: https://issues.apache.org/jira/browse/GEARPUMP-359
> Project: Apache Gearpump
>  Issue Type: Bug
>Reporter: Huafeng Wang
>Assignee: Huafeng Wang
>
> {{Subscription}} will update processingWatermark when sending a message and 
> update outputWatermark when receiving an Ack message. It will cause 
> prematurely updating the outputWatermark in such scenario: the 
> {{Subscription}} already sent 200 messages to downstream and now the 
> processingWatermark is 200th message's watermark, then it receives the first 
> 100 messages' Ack and it will advance the outputWatermark to 200th message's 
> watermark, not the 100th one, which is wrong.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)