[GitHub] incubator-gearpump issue #125: [GEARPUMP-256] Camel-Case as variable name

2016-12-26 Thread darionyaphet
Github user darionyaphet commented on the issue:

https://github.com/apache/incubator-gearpump/pull/125
  
@manuzhang I have repush this one thanks  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #125: [GEARPUMP-256] Camel-Case as variable name

2016-12-26 Thread manuzhang
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/125
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #125: [GEARPUMP-256] Camel-Case as variable name

2016-12-23 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/125
  
## [Current 
coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/125?src=pr) is 
70.37% (diff: 25.00%)
> Merging 
[#125](https://codecov.io/gh/apache/incubator-gearpump/pull/125?src=pr) into 
[master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) 
will decrease coverage by **1.00%**


```diff
@@ master   #125   diff @@
==
  Files   186186  
  Lines  5985   5985  
  Methods5471   5471  
  Messages  0  0  
  Branches512512  
==
- Hits   4272   4212-60   
- Misses 1713   1773+60   
  Partials  0  0  
```


![Sunburst](https://codecov.io/gh/apache/incubator-gearpump/pull/125/graphs/sunburst.svg?size=150&src=pr)

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[177a1d4...26520ef](https://codecov.io/gh/apache/incubator-gearpump/compare/177a1d4436dc88ade5283efcd483e5fdd6128f00...26520eff34d00e7a77e0a9ed5e985470947811f9?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #125: [GEARPUMP-256] Camel-Case as variable name

2016-12-23 Thread manuzhang
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/125
  
Could you refine your commit message to `[GEARPUMP-256] Use camel case as 
variable name in HBaseSink` with `git commit --amend` ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---