[GitHub] incubator-gearpump issue #200: [GEARPUMP-330] Allow examples to run in `sbt ...

2017-07-25 Thread manuzhang
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/200
  
@darionyaphet please open new jira/pr if you find other build settings 
require change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #200: [GEARPUMP-330] Allow examples to run in `sbt ...

2017-07-25 Thread huafengw
Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/200
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #200: [GEARPUMP-330] Allow examples to run in `sbt ...

2017-07-25 Thread manuzhang
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/200
  
@huafengw Added docs to quick start with `sbt run`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #200: [GEARPUMP-330] Allow examples to run in `sbt ...

2017-07-25 Thread darionyaphet
Github user darionyaphet commented on the issue:

https://github.com/apache/incubator-gearpump/pull/200
  
maybe not only *gearpump-core* and *gearpump-streaming* should change to 
**compile** . 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #200: [GEARPUMP-330] Allow examples to run in `sbt ...

2017-07-25 Thread manuzhang
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/200
  
@darionyaphet what else then ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #200: [GEARPUMP-330] Allow examples to run in `sbt ...

2017-07-25 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/200
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/200?src=pr=h1)
 Report
> Merging 
[#200](https://codecov.io/gh/apache/incubator-gearpump/pull/200?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/50316ce31db34785c4af8261dd66d8a1740a5601?src=pr=desc)
 will **not change** coverage.
> The diff coverage is `n/a`.



```diff
@@   Coverage Diff   @@
##   master #200   +/-   ##
===
  Coverage   71.55%   71.55%   
===
  Files 189  189   
  Lines6104 6104   
  Branches  539  539   
===
  Hits 4368 4368   
  Misses   1736 1736
```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #200: [GEARPUMP-330] Allow examples to run in `sbt ...

2017-07-25 Thread manuzhang
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/200
  
which part do you mean ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump issue #200: [GEARPUMP-330] Allow examples to run in `sbt ...

2017-07-25 Thread huafengw
Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/200
  
Document update?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---