[GitHub] incubator-gearpump issue #35: fix GEARPUMP-139 correct shaded libraries's pa...
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/35 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump issue #35: fix GEARPUMP-139 correct shaded libraries's pa...
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/35 I think it's not necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump issue #35: fix GEARPUMP-139 correct shaded libraries's pa...
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/35 how about ```scala addSbtPlugin("io.gearpump.sbt" % "sbt-pack" % "0.7.6") ``` in https://github.com/apache/incubator-gearpump/blob/master/project/plugins.sbt ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump issue #35: fix GEARPUMP-139 correct shaded libraries's pa...
Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/35 ## [Current coverage][cc-pull] is **64.69%** > Merging [#35][cc-pull] into [master][cc-base-branch] will increase coverage by **1.18%** 1. 2 files (not in diff) in `...rpump/cluster/master` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/80706bc27cf9ee16b0f182795f66d2802378a8b1/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F6D6173746572) - Misses `+75` - Hits `-75` 1. 1 files (not in diff) in `...che/gearpump/cluster` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/80706bc27cf9ee16b0f182795f66d2802378a8b1/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C7573746572) - Misses `-6` - Hits `+6` 1. 1 files (not in diff) in `.../org/apache/gearpump` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/80706bc27cf9ee16b0f182795f66d2802378a8b1/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D70) - Misses `+8` - Hits `-8` 1. 7 files (not in diff) in `...apache/gearpump/util` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/80706bc27cf9ee16b0f182795f66d2802378a8b1/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F7574696C) - Misses `-53` - Hits `+53` 1. 2 files (not in diff) in `...rpump/cluster/client` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/80706bc27cf9ee16b0f182795f66d2802378a8b1/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F636C69656E74) - Misses `-43` - Hits `+43` 1. 2 files (not in diff) in `...mp/cluster/appmaster` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/80706bc27cf9ee16b0f182795f66d2802378a8b1/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F6170706D6173746572) - Misses `-9` - Hits `+9` 1. 7 files (not in diff) in `...che/gearpump/cluster` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/80706bc27cf9ee16b0f182795f66d2802378a8b1/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C7573746572) - Misses `-39` - Hits `+39` 1. File `...ntStoreFactory.scala` (not in diff) was modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/80706bc27cf9ee16b0f182795f66d2802378a8b1/changes?src=pr#65787465726E616C2F6861646F6F7066732F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6861646F6F702F4861646F6F70436865636B706F696E7453746F7265466163746F72792E7363616C61) - Misses `-2` - Partials `0` - Hits `+2` 1. File `...cutor/Executor.scala` (not in diff) was modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/80706bc27cf9ee16b0f182795f66d2802378a8b1/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6578656375746F722F4578656375746F722E7363616C61) - Misses `-1` - Partials `0` - Hits `+1` ```diff @@ master#35 diff @@ == Files 178178 Lines 5922 5922 Methods5644 5644 Messages 0 0 Branches278278 == + Hits 3761 3831+70 + Misses 2161 2091-70 Partials 0 0 ``` [![Sunburst](https://codecov.io/gh/apache/incubator-gearpump/pull/35/graphs/sunburst.svg?size=150&src=pr)][cc-pull] > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [ec04cf7...80706bc][cc-compare] [cc-base-branch]: https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr [cc-compare]: https://codecov.io/gh/apache/incubator-gearpump/compare/ec04cf7666020ba15764611ac872344549f5200c...80706bc27cf9ee16b0f182795f66d2802378a8b1 [cc-pull]: https://codecov.io/gh/apache/incubator-gearpump/pull/35?src=pr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---