[GitHub] incubator-gearpump pull request: fix #121 DataSourceProcessor and ...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix #121 DataSourceProcessor and ...
Github user codecov-io commented on the pull request: https://github.com/apache/incubator-gearpump/pull/13#issuecomment-220271618 ## [Current coverage][cc-pull] is **62.40%** > Merging [#13][cc-pull] into [master][cc-base-branch] will decrease coverage by **1.55%** 1. 2 files (not in diff) in `...rpump/cluster/master` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/f3b2c17f2af5e8a0e46d7515b51a46c813f9f63d/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F6D6173746572) - Misses `+75` - Hits `-75` 1. 1 files (not in diff) in `...che/gearpump/cluster` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/f3b2c17f2af5e8a0e46d7515b51a46c813f9f63d/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C7573746572) - Misses `+1` - Hits `-1` 1. 1 files (not in diff) in `.../org/apache/gearpump` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/f3b2c17f2af5e8a0e46d7515b51a46c813f9f63d/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D70) - Misses `+8` - Hits `-8` 1. 2 files (not in diff) in `...apache/gearpump/util` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/f3b2c17f2af5e8a0e46d7515b51a46c813f9f63d/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F7574696C) - Misses `+10` - Hits `-10` 1. 2 files (not in diff) in `...rpump/cluster/client` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/f3b2c17f2af5e8a0e46d7515b51a46c813f9f63d/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F636C69656E74) - Misses `+1` - Hits `-1` 1. 2 files (not in diff) in `...che/gearpump/cluster` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/f3b2c17f2af5e8a0e46d7515b51a46c813f9f63d/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C7573746572) 1. File `...ntStoreFactory.scala` (not in diff) was modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/f3b2c17f2af5e8a0e46d7515b51a46c813f9f63d/changes?src=pr#65787465726E616C2F6861646F6F7066732F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6861646F6F702F4861646F6F70436865636B706F696E7453746F7265466163746F72792E7363616C61) - Misses `-2` - Partials `0` - Hits `+2` 1. File `...cutor/Executor.scala` (not in diff) was modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/f3b2c17f2af5e8a0e46d7515b51a46c813f9f63d/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6578656375746F722F4578656375746F722E7363616C61) - Misses `-1` - Partials `0` - Hits `+1` ```diff @@ master#13 diff @@ == Files 180180 Lines 5950 5950 Methods5671 5671 Messages 0 0 Branches279279 == - Hits 3805 3713-92 - Misses 2145 2237+92 Partials 0 0 ``` [][cc-pull] > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [f6f8903...f3b2c17][cc-compare] [cc-base-branch]: https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr [cc-compare]: https://codecov.io/gh/apache/incubator-gearpump/compare/f6f8903bf54c5a5e49e60543986410d24df57b71...f3b2c17f2af5e8a0e46d7515b51a46c813f9f63d [cc-pull]: https://codecov.io/gh/apache/incubator-gearpump/pull/13?src=pr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix #121 DataSourceProcessor and ...
Github user huafengw commented on the pull request: https://github.com/apache/incubator-gearpump/pull/13#issuecomment-220235782 Hi, @darionyaphet please rebase your pr and I will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix #121 DataSourceProcessor and ...
Github user manuzhang commented on the pull request: https://github.com/apache/incubator-gearpump/pull/13#issuecomment-218007120 @darionyaphet IMO, users should know and take care of their parallelism so we'd better it explicit. They are free to add another layer with default value which make sense for their applications but we'd better assume nothing for them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix #121 DataSourceProcessor and ...
Github user darionyaphet commented on the pull request: https://github.com/apache/incubator-gearpump/pull/13#issuecomment-217900186 @manuzhang When I using some processors to build a DAG , it's just to describe how to process the input stream , parallelism is the attribute of this processor . It should have a default value and one is suitable . thank you for you reply :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix #121 DataSourceProcessor and ...
Github user manuzhang commented on the pull request: https://github.com/apache/incubator-gearpump/pull/13#issuecomment-217769608 +0. I think users should be aware of the parallelism of processors to run and I don't see the benefit this change brings. Meanwhile, it's inconsistent with the Processor API now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix #121 DataSourceProcessor and ...
Github user whjiang commented on the pull request: https://github.com/apache/incubator-gearpump/pull/13#issuecomment-217760739 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix #121 DataSourceProcessor and ...
GitHub user darionyaphet opened a pull request: https://github.com/apache/incubator-gearpump/pull/13 fix #121 DataSourceProcessor and DataSinkProcessor default parallelism Set DataSourceProcessor and DataSinkProcessor's default parallelism value to 1. When user startup a processor could don't set parallelism . [GEARPUMP-121](https://issues.apache.org/jira/browse/GEARPUMP-121) You can merge this pull request into a Git repository by running: $ git pull https://github.com/darionyaphet/incubator-gearpump GEARPUMP-121 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit c29071fb991e3b6286038dc64618c04f46a4ba04 Author: darionyaphet Date: 2016-05-07T13:00:28Z fix #121 DataSourceProcessor and DataSinkProcessor default parallelism --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix #121 DataSourceProcessor and ...
GitHub user darionyaphet opened a pull request: https://github.com/apache/incubator-gearpump/pull/12 fix #121 DataSourceProcessor and DataSinkProcessor default parallelism Set DataSourceProcessor and DataSinkProcessor's default parallelism value to 1. When user startup a processor could don't set parallelism . [GEARPUMP-121](https://issues.apache.org/jira/browse/GEARPUMP-121) You can merge this pull request into a Git repository by running: $ git pull https://github.com/darionyaphet/incubator-gearpump GEARPUMP-121 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit cb3a5c88fd360af71f2ab320ed66ada2dbcdbba9 Author: yaphet Date: 2016-05-06T16:48:25Z Merge pull request #1 from apache/master merge request commit 2194ab289e40b282632028e29244da3f6615b517 Author: darionyaphet Date: 2016-05-07T12:31:35Z fix #106 DataSourceProcessor and DataSinkProcessor default parallelism --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix #121 DataSourceProcessor and ...
Github user darionyaphet closed the pull request at: https://github.com/apache/incubator-gearpump/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
