[GitHub] incubator-gearpump pull request: fix GEARPUMP-141 Remove useless m...
Github user manuzhang commented on the pull request: https://github.com/apache/incubator-gearpump/pull/20#issuecomment-222576991 @darionyaphet yes, I already did --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix GEARPUMP-141 Remove useless m...
Github user darionyaphet commented on the pull request: https://github.com/apache/incubator-gearpump/pull/20#issuecomment-222503486 @huafengw @manuzhang Could add some comment about this functions ? This functions is very confuse to others . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix GEARPUMP-141 Remove useless m...
Github user darionyaphet closed the pull request at: https://github.com/apache/incubator-gearpump/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix GEARPUMP-141 Remove useless m...
Github user huafengw commented on the pull request: https://github.com/apache/incubator-gearpump/pull/20#issuecomment-219916439 That's overriding Java's default serialization implementation: ``` There is, however, a strange yet crafty solution. By using a built-in feature of the serialization mechanism, developers can enhance the normal process by providing two methods inside their class files. Those methods are: private void writeObject(ObjectOutputStream out) throws IOException; private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException; ``` From http://www.oracle.com/technetwork/articles/java/javaserial-1536170.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix GEARPUMP-141 Remove useless m...
Github user darionyaphet commented on the pull request: https://github.com/apache/incubator-gearpump/pull/20#issuecomment-219914766 @manuzhang but the method was decorate with `private` . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix GEARPUMP-141 Remove useless m...
Github user manuzhang commented on the pull request: https://github.com/apache/incubator-gearpump/pull/20#issuecomment-219869261 @darionyaphet these are not useless methods but for custom java serialization/deserialization. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request: fix GEARPUMP-141 Remove useless m...
Github user darionyaphet commented on the pull request: https://github.com/apache/incubator-gearpump/pull/20#issuecomment-219773664 conflicts ?? I can't found any conflicts ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
