[GitHub] incubator-gearpump pull request #160: [GEARPUMP-282] Allow user to configure...
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/160#discussion_r102893853
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -48,8 +48,12 @@ class RunningApplication(val appId: Int, master:
ActorRef, timeout: Timeout) {
* If failed, an exception will be thrown out
*/
def waitUntilFinish(): Unit = {
+this.waitUntilFinish(INF_TIMEOUT)
+ }
+
+ def waitUntilFinish(timeout: Timeout): Unit = {
--- End diff --
better to use `java.time.Duration`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #160: [GEARPUMP-282] Allow user to configure...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request #160: [GEARPUMP-282] Allow user to configure...
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/160 [GEARPUMP-282] Allow user to configure wait duration for a running ap⦠â¦plication Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit message is formatted like: `[GEARPUMP-] Meaningful description of pull request` - [ ] Make sure tests pass via `sbt clean test`. - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/huafengw/incubator-gearpump fix282 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #160 commit 4aba8ac553e8e10be7bbd1f0f3372818c7a1825e Author: huafengw Date: 2017-02-24T07:47:20Z [GEARPUMP-282] Allow user to configure wait duration for a running application --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
