[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/196#discussion_r128453676 --- Diff: project/BuildExperiments.scala --- @@ -46,7 +46,8 @@ object BuildExperiments extends sbt.Build { "org.apache.hadoop" % "hadoop-mapreduce-client-core" % hadoopVersion, "org.apache.hadoop" % "hadoop-yarn-server-resourcemanager" % hadoopVersion % "provided", "org.apache.hadoop" % "hadoop-yarn-server-nodemanager" % hadoopVersion % "provided" -) +).map(_.exclude("org.slf4j", "slf4j-api")) --- End diff -- From gearpump-core --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/196#discussion_r128451485 --- Diff: project/BuildExperiments.scala --- @@ -46,7 +46,8 @@ object BuildExperiments extends sbt.Build { "org.apache.hadoop" % "hadoop-mapreduce-client-core" % hadoopVersion, "org.apache.hadoop" % "hadoop-yarn-server-resourcemanager" % hadoopVersion % "provided", "org.apache.hadoop" % "hadoop-yarn-server-nodemanager" % hadoopVersion % "provided" -) +).map(_.exclude("org.slf4j", "slf4j-api")) --- End diff -- Then where will the yarn load `slf4j` libraries ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/196 [GEARPUMP-322] Fix multiple SLF4J bindings on classpath Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit message is formatted like: `[GEARPUMP-] Meaningful description of pull request` - [ ] Make sure tests pass via `sbt clean test`. - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/huafengw/incubator-gearpump fix322 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/196.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #196 commit 0b972a4c0492257fb7263035483db653d2018d89 Author: huafengw Date: 2017-07-20T07:06:28Z [GEARPUMP-322] Fix multiple SLF4J bindings on classpath --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---