[GitHub] incubator-gearpump pull request #224: [GEARPUMP-345] Add getLogger(Class ...

2017-09-06 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/224


---

[GitHub] incubator-gearpump pull request #224: [GEARPUMP-345] Add getLogger(Class ...

2017-09-06 Thread buddhiayesha2015 
Github user buddhiayesha2015 commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/224#discussion_r137191236
  
--- Diff: core/src/main/scala/org/apache/gearpump/util/LogUtil.scala ---
@@ -67,6 +67,11 @@ object LogUtil {
 }
   }
 
+  /** getLogger(Class ) implementation for Java */
--- End diff --

I will fix it.


---

[GitHub] incubator-gearpump pull request #224: [GEARPUMP-345] Add getLogger(Class ...

2017-09-05 Thread manuzhang 
Github user manuzhang commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/224#discussion_r137138995
  
--- Diff: core/src/main/scala/org/apache/gearpump/util/LogUtil.scala ---
@@ -67,6 +67,11 @@ object LogUtil {
 }
   }
 
+  /** getLogger(Class ) implementation for Java */
--- End diff --

`` happens to fail scala documentation verification. It's ok to leave it 
out.


---

[GitHub] incubator-gearpump pull request #224: [GEARPUMP-345] Add getLogger(Class ...

2017-09-05 Thread buddhiayesha2015 
GitHub user buddhiayesha2015 opened a pull request:

https://github.com/apache/incubator-gearpump/pull/224

[GEARPUMP-345] Add getLogger(Class ) implementation for Java

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BuddhiAR/incubator-gearpump master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #224


commit 5c061b359e5aefee13410cd895a8a75f04992334
Author: Buddhi Ayesha 
Date:   2017-09-05T11:23:33Z

[GEARPUMP-345] Add getLogger(Class ) implementation for Java




---