[GitHub] incubator-gearpump pull request #241: [WiP][GEARPUMP-368] Restore setting ru...

2018-04-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/241


---


[GitHub] incubator-gearpump pull request #241: [WiP][GEARPUMP-368] Restore setting ru...

2018-04-23 Thread manuzhang
Github user manuzhang commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/241#discussion_r183404919
  
--- Diff: 
core/src/main/scala/org/apache/gearpump/cluster/main/AppSubmitter.scala ---
@@ -21,12 +21,12 @@ import java.io.File
 import java.net.{URL, URLClassLoader}
 import java.util.jar.JarFile
 
-import org.apache.gearpump.util.{AkkaApp, Constants, LogUtil, Util}
+import org.apache.gearpump.util._
--- End diff --

We'd better not use wildcard imports unless necessaery


---