[jira] [Commented] (GEARPUMP-188) use java.time.Instant for Task start time
[
https://issues.apache.org/jira/browse/GEARPUMP-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421109#comment-15421109
]
ASF GitHub Bot commented on GEARPUMP-188:
-
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/74
> use java.time.Instant for Task start time
> -
>
> Key: GEARPUMP-188
> URL: https://issues.apache.org/jira/browse/GEARPUMP-188
> Project: Apache Gearpump
> Issue Type: Improvement
> Components: streaming
>Affects Versions: 0.8.1
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>
> Current start time type is of {{TimeStamp}} or {{Long}}, whose unit (e.g.
> milliseconds, microseconds or nanoseconds) is unclear for users. Instead, we
> could use {{java.time.Instant}} introduced in Java 8.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEARPUMP-188) use java.time.Instant for Task start time
[
https://issues.apache.org/jira/browse/GEARPUMP-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421091#comment-15421091
]
ASF GitHub Bot commented on GEARPUMP-188:
-
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/74
+1
> use java.time.Instant for Task start time
> -
>
> Key: GEARPUMP-188
> URL: https://issues.apache.org/jira/browse/GEARPUMP-188
> Project: Apache Gearpump
> Issue Type: Improvement
> Components: streaming
>Affects Versions: 0.8.1
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>
> Current start time type is of {{TimeStamp}} or {{Long}}, whose unit (e.g.
> milliseconds, microseconds or nanoseconds) is unclear for users. Instead, we
> could use {{java.time.Instant}} introduced in Java 8.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEARPUMP-188) use java.time.Instant for Task start time
[
https://issues.apache.org/jira/browse/GEARPUMP-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421073#comment-15421073
]
ASF GitHub Bot commented on GEARPUMP-188:
-
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/74
No. I'd rather we break things now than later or leave users confused.
> use java.time.Instant for Task start time
> -
>
> Key: GEARPUMP-188
> URL: https://issues.apache.org/jira/browse/GEARPUMP-188
> Project: Apache Gearpump
> Issue Type: Improvement
> Components: streaming
>Affects Versions: 0.8.1
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>
> Current start time type is of {{TimeStamp}} or {{Long}}, whose unit (e.g.
> milliseconds, microseconds or nanoseconds) is unclear for users. Instead, we
> could use {{java.time.Instant}} introduced in Java 8.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEARPUMP-188) use java.time.Instant for Task start time
[
https://issues.apache.org/jira/browse/GEARPUMP-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421063#comment-15421063
]
ASF GitHub Bot commented on GEARPUMP-188:
-
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/74
So we are not considering backward compatibility?
> use java.time.Instant for Task start time
> -
>
> Key: GEARPUMP-188
> URL: https://issues.apache.org/jira/browse/GEARPUMP-188
> Project: Apache Gearpump
> Issue Type: Improvement
> Components: streaming
>Affects Versions: 0.8.1
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>
> Current start time type is of {{TimeStamp}} or {{Long}}, whose unit (e.g.
> milliseconds, microseconds or nanoseconds) is unclear for users. Instead, we
> could use {{java.time.Instant}} introduced in Java 8.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEARPUMP-188) use java.time.Instant for Task start time
[
https://issues.apache.org/jira/browse/GEARPUMP-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420724#comment-15420724
]
ASF GitHub Bot commented on GEARPUMP-188:
-
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/74
## [Current
coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/74?src=pr) is
70.69% (diff: 68.75%)
> Merging
[#74](https://codecov.io/gh/apache/incubator-gearpump/pull/74?src=pr) into
[master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr)
will decrease coverage by **0.65%**
```diff
@@ master#74 diff @@
==
Files 177177
Lines 5931 5928 -3
Methods5611 5609 -2
Messages 0 0
Branches320319 -1
==
- Hits 4232 4191-41
- Misses 1699 1737+38
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update
[6d919ec...e55595f](https://codecov.io/gh/apache/incubator-gearpump/compare/6d919ec977e772d9d51fe2f35741f67d00af5c98...e55595f79a05d9540e65af42d6240293d81d5549?src=pr)
> use java.time.Instant for Task start time
> -
>
> Key: GEARPUMP-188
> URL: https://issues.apache.org/jira/browse/GEARPUMP-188
> Project: Apache Gearpump
> Issue Type: Improvement
> Components: streaming
>Affects Versions: 0.8.1
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>
> Current start time type is of {{TimeStamp}} or {{Long}}, whose unit (e.g.
> milliseconds, microseconds or nanoseconds) is unclear for users. Instead, we
> could use {{java.time.Instant}} introduced in Java 8.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEARPUMP-188) use java.time.Instant for Task start time
[
https://issues.apache.org/jira/browse/GEARPUMP-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420667#comment-15420667
]
ASF GitHub Bot commented on GEARPUMP-188:
-
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/74
[GEARPUMP-188] use java.time.Instant for Task start time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump
replace_timestamp_with_instant
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
commit 36593c49f53e50ff918561e0aa8dfc4aebe598d9
Author: manuzhang
Date: 2016-05-31T05:10:24Z
[GEARPUMP-188] use java.time.Instant for Task start time
> use java.time.Instant for Task start time
> -
>
> Key: GEARPUMP-188
> URL: https://issues.apache.org/jira/browse/GEARPUMP-188
> Project: Apache Gearpump
> Issue Type: Improvement
> Components: streaming
>Affects Versions: 0.8.1
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>
> Current start time type is of {{TimeStamp}} or {{Long}}, whose unit (e.g.
> milliseconds, microseconds or nanoseconds) is unclear for users. Instead, we
> could use {{java.time.Instant}} introduced in Java 8.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
