[jira] [Commented] (GEARPUMP-256) Camel-Case as variable name

2016-12-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15778264#comment-15778264
 ] 

ASF GitHub Bot commented on GEARPUMP-256:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/125


> Camel-Case as variable name
> ---
>
> Key: GEARPUMP-256
> URL: https://issues.apache.org/jira/browse/GEARPUMP-256
> Project: Apache Gearpump
>  Issue Type: Improvement
>  Components: hbase 
>Affects Versions: 0.8.2
>Reporter: darion yaphet
>Assignee: darion yaphet
>
> Fix HBaseSink's naming  and using Camel-Case as the variable name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEARPUMP-256) Camel-Case as variable name

2016-12-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15778252#comment-15778252
 ] 

ASF GitHub Bot commented on GEARPUMP-256:
-

Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/125
  
+1


> Camel-Case as variable name
> ---
>
> Key: GEARPUMP-256
> URL: https://issues.apache.org/jira/browse/GEARPUMP-256
> Project: Apache Gearpump
>  Issue Type: Improvement
>  Components: hbase 
>Affects Versions: 0.8.2
>Reporter: darion yaphet
>Assignee: darion yaphet
>
> Fix HBaseSink's naming  and using Camel-Case as the variable name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEARPUMP-256) Camel-Case as variable name

2016-12-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15778089#comment-15778089
 ] 

ASF GitHub Bot commented on GEARPUMP-256:
-

Github user darionyaphet commented on the issue:

https://github.com/apache/incubator-gearpump/pull/125
  
@manuzhang I have repush this one thanks  :)


> Camel-Case as variable name
> ---
>
> Key: GEARPUMP-256
> URL: https://issues.apache.org/jira/browse/GEARPUMP-256
> Project: Apache Gearpump
>  Issue Type: Improvement
>  Components: hbase 
>Affects Versions: 0.8.2
>Reporter: darion yaphet
>Assignee: darion yaphet
>
> Fix HBaseSink's naming  and using Camel-Case as the variable name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEARPUMP-256) Camel-Case as variable name

2016-12-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772785#comment-15772785
 ] 

ASF GitHub Bot commented on GEARPUMP-256:
-

Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/125
  
Could you refine your commit message to `[GEARPUMP-256] Use camel case as 
variable name in HBaseSink` with `git commit --amend` ? 


> Camel-Case as variable name
> ---
>
> Key: GEARPUMP-256
> URL: https://issues.apache.org/jira/browse/GEARPUMP-256
> Project: Apache Gearpump
>  Issue Type: Improvement
>  Components: hbase 
>Affects Versions: 0.8.2
>Reporter: darion yaphet
>Assignee: darion yaphet
>
> Fix HBaseSink's naming  and using Camel-Case as the variable name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEARPUMP-256) Camel-Case as variable name

2016-12-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772324#comment-15772324
 ] 

ASF GitHub Bot commented on GEARPUMP-256:
-

Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/125
  
## [Current 
coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/125?src=pr) is 
70.37% (diff: 25.00%)
> Merging 
[#125](https://codecov.io/gh/apache/incubator-gearpump/pull/125?src=pr) into 
[master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) 
will decrease coverage by **1.00%**


```diff
@@ master   #125   diff @@
==
  Files   186186  
  Lines  5985   5985  
  Methods5471   5471  
  Messages  0  0  
  Branches512512  
==
- Hits   4272   4212-60   
- Misses 1713   1773+60   
  Partials  0  0  
```


![Sunburst](https://codecov.io/gh/apache/incubator-gearpump/pull/125/graphs/sunburst.svg?size=150&src=pr)

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[177a1d4...26520ef](https://codecov.io/gh/apache/incubator-gearpump/compare/177a1d4436dc88ade5283efcd483e5fdd6128f00...26520eff34d00e7a77e0a9ed5e985470947811f9?src=pr)


> Camel-Case as variable name
> ---
>
> Key: GEARPUMP-256
> URL: https://issues.apache.org/jira/browse/GEARPUMP-256
> Project: Apache Gearpump
>  Issue Type: Improvement
>  Components: hbase 
>Affects Versions: 0.8.2
>Reporter: darion yaphet
>Assignee: darion yaphet
>
> Fix HBaseSink's naming  and using Camel-Case as the variable name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEARPUMP-256) Camel-Case as variable name

2016-12-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEARPUMP-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772297#comment-15772297
 ] 

ASF GitHub Bot commented on GEARPUMP-256:
-

GitHub user darionyaphet opened a pull request:

https://github.com/apache/incubator-gearpump/pull/125

[GEARPUMP-256] Camel-Case as variable name

[Camel-Case as variable 
name](https://issues.apache.org/jira/browse/GEARPUMP-256) HBaseSink's naming 
and using Camel-Case as the variable name.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/darionyaphet/incubator-gearpump GEARPUMP-256

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #125


commit 26520eff34d00e7a77e0a9ed5e985470947811f9
Author: darionyaphet 
Date:   2016-12-23T08:14:10Z

fix : GEARPUMP-256 Camel-Case as variable name




> Camel-Case as variable name
> ---
>
> Key: GEARPUMP-256
> URL: https://issues.apache.org/jira/browse/GEARPUMP-256
> Project: Apache Gearpump
>  Issue Type: Improvement
>  Components: hbase 
>Affects Versions: 0.8.2
>Reporter: darion yaphet
>Assignee: darion yaphet
>
> Fix HBaseSink's naming  and using Camel-Case as the variable name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)