Re: Review Request 56398: use function to implement waitUntilFlushed

2017-02-07 Thread xiaojian zhou

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56398/
---

(Updated Feb. 8, 2017, 7:53 a.m.)


Review request for geode and Dan Smith.


Changes
---

add 2 junit tests


Bugs: geode-2400
https://issues.apache.org/jira/browse/geode-2400


Repository: geode


Description
---

1) move the waitUntilFlushed from LuceneIndex into LuceneService.
2) use function
3) handle cacheClosedException


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/internal/DSFIDFactory.java bb29239 
  
geode-core/src/main/java/org/apache/geode/internal/DataSerializableFixedID.java 
84eb8e9 
  
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegionQueue.java 
4830912 
  
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java
 1f8704c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/WaitUntilParallelGatewaySenderFlushedCoordinator.java
 a4c03a9 
  
geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest.java
 c8b8ba1 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java 
802b21a 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java 
0ff5f0e 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
 8d24a83 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
 70061eb 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
 PRE-CREATION 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunctionContext.java
 PRE-CREATION 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/xml/LuceneIndexCreation.java
 030 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
 e6c4503 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesBase.java 
a56fff7 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
 d11ea91 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
 c877f93 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
 a9772eb 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java
 5ec09f1 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexImplJUnitTest.java
 aaa6dbd 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java
 d194081 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneServiceImplJUnitTest.java
 1815663 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsDUnitTest.java
 2bb5b4b 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
 5c47e13 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunctionJUnitTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/IndexRepositorySpy.java
 d363903 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
 9f062bb 

Diff: https://reviews.apache.org/r/56398/diff/


Testing
---


Thanks,

xiaojian zhou



Re: Contributor Permissions in Jira

2017-02-07 Thread Dan Smith
Hmm, you seem to be in there already so either you were added at point in
the past or someone just added you. Let me know if you have any access
issues.

-Dan

On Tue, Feb 7, 2017 at 5:19 PM, Michael William Dodge 
wrote:

> PivotalSarge
>
> > On 7 Feb, 2017, at 14:57, Dan Smith  wrote:
> >
> > Hi Sarge,
> >
> > What's your JIRA username?
> >
> > -Dan
> >
> > On Tue, Feb 7, 2017 at 2:46 PM, Michael William Dodge  >
> > wrote:
> >
> >> As I'm working on the native code, may I have contributor permission in
> >> Jira so that I may resolve things that I've fixed. Thanks.
> >>
> >> Sarge
>
>


[jira] [Resolved] (GEODE-2437) Integrate native client with travis-ci

2017-02-07 Thread Anthony Baker (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker resolved GEODE-2437.
--
Resolution: Fixed

> Integrate native client with travis-ci
> --
>
> Key: GEODE-2437
> URL: https://issues.apache.org/jira/browse/GEODE-2437
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Anthony Baker
>
> We should integrate the native client branch with travis-ci so we can tell if 
> PR's  or other code changes are good.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2437) Integrate native client with travis-ci

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857427#comment-15857427
 ] 

ASF GitHub Bot commented on GEODE-2437:
---

Github user metatype closed the pull request at:

https://github.com/apache/geode/pull/394


> Integrate native client with travis-ci
> --
>
> Key: GEODE-2437
> URL: https://issues.apache.org/jira/browse/GEODE-2437
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Anthony Baker
>
> We should integrate the native client branch with travis-ci so we can tell if 
> PR's  or other code changes are good.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread metatype
Github user metatype closed the pull request at:

https://github.com/apache/geode/pull/394


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Review Request 56425: GEODE-2272: do not use a new method to start locator with pulse

2017-02-07 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56425/
---

Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

GEODE-2272: do not use a new method to start locator with pulse


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java
 b5472909eec8d5ca124e7bfd5c6cb71864d9bbee 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 1f0cd9e720e732c2ce06515c16601e1df173ff4f 

Diff: https://reviews.apache.org/r/56425/diff/


Testing
---


Thanks,

Jinmei Liao



Regarding region.putAll()

2017-02-07 Thread Goutam Tadi
Hi Team,

What is the difference between

((LocalRegion) region).basicImportPutAll(map)

​
and

region.putAll(map)

​
where regionis a PartitionedRegion ?


Thanks,
Goutam and Bradford.
-- 
Regards,
*Goutam Tadi.*


Re: Contributor Permissions in Jira

2017-02-07 Thread Michael William Dodge
PivotalSarge

> On 7 Feb, 2017, at 14:57, Dan Smith  wrote:
> 
> Hi Sarge,
> 
> What's your JIRA username?
> 
> -Dan
> 
> On Tue, Feb 7, 2017 at 2:46 PM, Michael William Dodge 
> wrote:
> 
>> As I'm working on the native code, may I have contributor permission in
>> Jira so that I may resolve things that I've fixed. Thanks.
>> 
>> Sarge



Re: Nightly build broken

2017-02-07 Thread Bruce Schuchardt
It's very strange to me though because I ran that exact gradle sequence 
from a Linux shell, though with a single unit test, and it passed 
multiple times using each of the three different BC unit tests.


Le 2/7/2017 à 1:32 PM, Hitesh Khamesra a écrit :

Thanks Dan. Lets merge this fix into 1.1 release branch.
-Hitesh


   From: Dan Smith 
  To: dev@geode.apache.org
  Sent: Tuesday, February 7, 2017 1:12 PM
  Subject: Re: Nightly build broken

Actually, now that I think about it GEODE-2434 was probably the cause of

these backwards compatibility test failures. The build was generating the
geodeOldVersionClasspaths file during the configuration phase. What that
means is if you run './gradlew clean precheckin', the file gets generated
*before* the clean, which will then delete it. Just doing this without the
fix for GEODE-2434 will also fail with that error:

./gradlew clean geode-core:distributedTest --tests
'*ClientServerMiscBCDUnitTest*'

We should merge the fix for GEODE-2434 to the release branch as well.

-Dan

On Tue, Feb 7, 2017 at 12:59 PM, Kirk Lund  wrote:


The BC tests are failing with this RuntimeException (it ends up being an
initializationError):

java.lang.RuntimeException: No older versions of Geode were found to test
against
at
org.apache.geode.internal.cache.tier.sockets.ClientServerMiscBCDUnitTest.
data(ClientServerMiscBCDUnitTest.java:37)


On Tue, Feb 7, 2017 at 12:55 PM, Udo Kohlmeyer 
wrote:


Looking at some of the failures, it seems it is complaining about not
finding diskstores to delete.



On 2/7/17 12:53, Kirk Lund wrote:


Last night's nightly build is pretty horrible. 121 dunit test failures.
Cluster config accounts for 13 of them and we already have a fix for

those

13 only.

Anyone else want to look into the other failures? Looks like some of the
other failures are diskstore related.

https://builds.apache.org/job/Geode-nightly/ws/geode-core/bu
ild/reports/distributedTest/index.html

Failures:

DistTXDebugDUnitTest. testTXDestroy_invalidate
DistTXDebugDUnitTest. testTXPR
DistTXDebugDUnitTest. testTXPR2
DistTXDebugDUnitTest. testTXPRRR2_create
DistTXDebugDUnitTest. testTXPRRR2_putall
DistTXDebugDUnitTest. testTXPR_RR
DistTXDebugDUnitTest. testTXPR_putall
DistTXDebugDUnitTest. testTXPR_removeAll
DistTXDebugDUnitTest. testTXRR2
DistTXDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
DistTXDebugDUnitTest. testTXRR_removeAll
DistTXDebugDUnitTest. testTXRR_removeAll_dataNodeAsCoordinator
DistTXOrderDUnitTest. testBug43353
DistTXOrderDUnitTest. testFarSideIndexOnDestroy
DistTXOrderDUnitTest. testFarSideIndexOnInvalidate
DistTXOrderDUnitTest. testFarSideIndexOnPut
DistTXPersistentDebugDUnitTest. testBasicDistributedTX
DistTXPersistentDebugDUnitTest. testTXDestroy_invalidate
DistTXPersistentDebugDUnitTest. testTXPR
DistTXPersistentDebugDUnitTest. testTXPR2
DistTXPersistentDebugDUnitTest. testTXPRRR2_create
DistTXPersistentDebugDUnitTest. testTXPRRR2_putall
DistTXPersistentDebugDUnitTest. testTXPR_RR
DistTXPersistentDebugDUnitTest. testTXPR_putall
DistTXPersistentDebugDUnitTest. testTXPR_removeAll
DistTXPersistentDebugDUnitTest. testTXRR2
DistTXPersistentDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
DistTXPersistentDebugDUnitTest. testTXRR_removeAll
DistTXPersistentDebugDUnitTest. testTXRR_removeAll_

dataNodeAsCoordinator

DistTXRestrictionsDUnitTest. testPersistentRestriction
DistTXWithDeltaDUnitTest. testClientServerDelta
DistTXWithDeltaDUnitTest. testExceptionThrown
DistTXWithDeltaDUnitTest. testTxWithCloning
DistributedTransactionDUnitTest. testBasicDistributedTX
DistributedTransactionDUnitTest. testCommitAndRollback
DistributedTransactionDUnitTest. testCommitConflicts_PR
DistributedTransactionDUnitTest. testCommitConflicts_PR_after_l
ocks_acquired
DistributedTransactionDUnitTest. testCommitConflicts_RR
DistributedTransactionDUnitTest. testCommitNoConflicts_PR
DistributedTransactionDUnitTest. testCommitNoConflicts_RR
DistributedTransactionDUnitTest. testCommitOnPartitionedAndRepl
icatedRegions
DistributedTransactionDUnitTest. testGetIsolated
DistributedTransactionDUnitTest. testMultipleOpsOnSameKeyInTx
DistributedTransactionDUnitTest. testNonColocatedPutByPartitioning
DistributedTransactionDUnitTest. testPutAllWithTransactions
DistributedTransactionDUnitTest. testRegionAndEntryVersionsPR
DistributedTransactionDUnitTest. testRegionAndEntryVersionsRR
DistributedTransactionDUnitTest. testRemoveAllWithTransactions
DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_PR
DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_RR
DistributedTransactionDUnitTest. testTransactionalKeyBasedUpdates
DistributedTransactionDUnitTest. testTransactionalPutOnPartitio

nedRegion

DistributedTransactionDUnitTest. testTransactionalPutOnReplicatedRegion
DistributedTransactionDUnitTest. testTransactionalUpdates
DistributedTransactionDUnitTest. testTxWithSingleDataStore
PRDistTXDUnitTest. 

[jira] [Created] (GEODE-2452) invalidateRegion on a CACHING_PROXY region throws NPE

2017-02-07 Thread Swapnil Bawaskar (JIRA)
Swapnil Bawaskar created GEODE-2452:
---

 Summary: invalidateRegion on a CACHING_PROXY region throws NPE
 Key: GEODE-2452
 URL: https://issues.apache.org/jira/browse/GEODE-2452
 Project: Geode
  Issue Type: Bug
  Components: regions
Reporter: Swapnil Bawaskar


Calling invalidateRegion on a CACHING_PROXY threw the following Exception:
{noformat}
Exception in thread "main" java.lang.NullPointerException
at 
org.apache.geode.cache.client.internal.InvalidateOp$InvalidateOpImpl.(InvalidateOp.java:67)
at 
org.apache.geode.cache.client.internal.InvalidateOp.execute(InvalidateOp.java:47)
at 
org.apache.geode.cache.client.internal.ServerRegionProxy.invalidate(ServerRegionProxy.java:221)
at 
org.apache.geode.internal.cache.LocalRegion.serverInvalidate(LocalRegion.java:3149)
at 
org.apache.geode.internal.cache.AbstractRegionMap.invalidate(AbstractRegionMap.java:2134)
at 
org.apache.geode.internal.cache.LocalRegionDataView.invalidateExistingEntry(LocalRegionDataView.java:67)
at 
org.apache.geode.internal.cache.LocalRegion.basicInvalidate(LocalRegion.java:5223)
at 
org.apache.geode.internal.cache.LocalRegion.basicInvalidate(LocalRegion.java:5187)
at 
org.apache.geode.internal.cache.LocalRegion.invalidateAllEntries(LocalRegion.java:8045)
at 
org.apache.geode.internal.cache.LocalRegion.basicInvalidateRegion(LocalRegion.java:7398)
at 
org.apache.geode.internal.cache.LocalRegion.invalidateRegion(LocalRegion.java:1647)
at 
org.apache.geode.internal.cache.AbstractRegion.invalidateRegion(AbstractRegion.java:342)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Review Request 56396: Refactor test rules

2017-02-07 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56396/#review164597
---


Ship it!




- Kirk Lund


On Feb. 7, 2017, 5:28 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56396/
> ---
> 
> (Updated Feb. 7, 2017, 5:28 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk 
> Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * Refactor GfshShellConnectorRule so that it's easier to use it either as a 
> rule or classRule
> * Refactor LocatorServerStartupRule so that tests using it do not need to 
> extend from Junit4DUnitTest and can be used as a class rule.
> * add NetstatDUnitTest
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java
>  28d50da61669746145c143d33947da6b8564ca9d 
>   
> geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
>  9d678e1a8bd419e66e9dd79e8f7db5dbeeb0890b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java
>  3a3c74cd9d10b617a12c38c1fdd500ebe83a5707 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java
>  79f0128ecb87b7e1334f35cb4c0c703cd07af544 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDistributionDUnitTest.java
>  f362d4c679d391b50b9ce297d8e31ba9887024e1 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
>  f68015e5e4f70c91e3329a53134562b128745fd7 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
>  388fd9d40ccae21d58ea966e4c9c9fd71c46e873 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java
>  ac3d1dee3a76e2fa884f826291f88ccbd05d10fa 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
>  dbbe0dbc5dd04e06e4876ebcb15ece1cb018d56d 
>   
> geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
>  fe37f9e2becb46c448a97fa2ac4ed7a9548ff4f9 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
>  a7752aeb90da46071aa1ded17ef32c36f8b6208b 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerSecurityWithEmbeddedLocatorDUnitTest.java
>  66c5be6de9c33226f3ad4d93e9c16dcfbe674c1e 
>   
> geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java
>  ca209a73b247cd422b93864e7de841620140f996 
>   
> geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java
>  72654cb868f8a62212825eba72aa4fdf8bc7e39e 
>   
> geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java
>  24d0db5c123c221b9cff59ef7d91b3d6d2d9b3eb 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  49c141413909b1b31e9d148576832bbf788878eb 
>   geode-core/src/test/java/org/apache/geode/test/dunit/rules/Locator.java 
> 0350ffd06d09dfa742033baf0fb1c2afff1ee158 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  ac9221cab6ec9a56f269ac90f881049e0ef770de 
>   geode-core/src/test/java/org/apache/geode/test/dunit/rules/Member.java 
> 129fe681c918a15f0927846fb19c469a0ac683a7 
>   geode-core/src/test/java/org/apache/geode/test/dunit/rules/Server.java 
> bc4c5d614caa0d1555e84fc483af3fa74f9e52ef 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
>  0b0e936652444f0171e37fa52653f5a4e9a63c87 
> 
> Diff: https://reviews.apache.org/r/56396/diff/
> 
> 
> Testing
> ---
> 
> precheckin pending
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



[jira] [Commented] (GEODE-2430) Remove binary files from test resources

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857081#comment-15857081
 ] 

ASF subversion and git services commented on GEODE-2430:


Commit f637dc6a5145e6e331189efab8dd2e854889c67c in geode's branch 
refs/heads/release/1.1.0 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f637dc6 ]

GEODE-2430: Refactor ZipUtils

(cherry picked from commit 50aebcc)


> Remove binary files from test resources
> ---
>
> Key: GEODE-2430
> URL: https://issues.apache.org/jira/browse/GEODE-2430
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> We have some tests which rely on the following binary files:
> {code}
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group1.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group2.jar
> {code}
> We need to convert our tests to generate these files dynamically instead so 
> that we don't have binary files checked into our repository.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2430) Remove binary files from test resources

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857083#comment-15857083
 ] 

ASF subversion and git services commented on GEODE-2430:


Commit 2286fd064a52173eab8fdcfadfb89a01e81ef728 in geode's branch 
refs/heads/release/1.1.0 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=2286fd0 ]

GEODE-2430: Fix failing tests

* this closes #395

(cherry picked from commit 147eb7c)


> Remove binary files from test resources
> ---
>
> Key: GEODE-2430
> URL: https://issues.apache.org/jira/browse/GEODE-2430
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> We have some tests which rely on the following binary files:
> {code}
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group1.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group2.jar
> {code}
> We need to convert our tests to generate these files dynamically instead so 
> that we don't have binary files checked into our repository.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857079#comment-15857079
 ] 

ASF GitHub Bot commented on GEODE-1887:
---

Github user sbawaska commented on the issue:

https://github.com/apache/geode/pull/390
  
Hi Avinash,
Thanks for the pull request and adding the tests. Since the only difference 
in the two tests is the type of region created on the server (REPLICATED vs 
PARTITION) can you please please refactor the tests to take the region type as 
a parameter?


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2411) Remove references to Gemfire from include guards

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857055#comment-15857055
 ] 

ASF subversion and git services commented on GEODE-2411:


Commit 8b53f0a165b10dd4f3669c26b1cbd16ca89c8cf4 in geode's branch 
refs/heads/next-gen-native-client-software-grant from [~PivotalSarge]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8b53f0a ]

GEODE-2411: Remove references to Gemfire from include guards.

This closes #387

- Replace Gemfire-related include guards with #pragma once.
- Add Geode-related, Google-style-guide-compliant
  include guards for feature-poor compilers.


> Remove references to Gemfire from include guards
> 
>
> Key: GEODE-2411
> URL: https://issues.apache.org/jira/browse/GEODE-2411
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> Many of the macro definitions used as include guards in the C++ header files 
> refer to Gemfire. These references should be replaced at least with 
> references to Geode but preferably using pragmas instead of defines.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Geode February Project report, final

2017-02-07 Thread Dave Barnes
All,
The report below includes all corrections I've received.
I elected to keep the Markdown-style link to the release notes on the
theory that it's readable as plain text, too.

Mark,
Please submit this report for me. I seem to lack credentials to put it in
the specified posting sites (Apache private repo, Whimsy project site).

Thanks,
-Dave

## Description:

 - Apache Geode provides a database-like consistency model, reliable
   transaction processing and a shared-nothing architecture to maintain
   very low latency performance with high concurrency processing.

## Issues:

 - There are no issues requiring board attention at this time.

## Activity:

 - Geode was promoted to TLP status in the November 2016 board meeting.
Since that time:
   -  A new TLP repo was created and populated
   -  Work on the first TLP-level release has been underway.
 - Release candidate 2 for Version 1.1.0 is nearly complete; voting will
likely begin before the upcoming board meeting.
The release addresses 252 JIRA tickets. For a complete list, please see the
[Geode Release Notes](
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12338352
).
 - A new code contribution is in progress for C++ and C# native clients and
their accompanying documentation. After a lively discussion on the dev
list, it was decided to create a separate Git repo to house this code.

## Health report:

 - Mailing lists remain active and productive.
 - JIRA tickets show that issues continue to be identified and resolved.
 - We’re continuing to work on attracting new contributors and making it
easier to participate in the community.

## PMC changes:
 - Currently 32 PMC members.
 - New PMC members:
- Kevin Duling was added to the PMC on Wed Jan 18 2017
- Ken Howe was added to the PMC on Wed Jan 18 2017

## Committer base changes:

- Currently 77 committers. New committers:
- Kevin Duling was added as a committer on Sat Jan 14 2017

## Releases:

 - Last release was 1.0.0-incubating issued on October 25, 2016.
 - Version 1.1.0 is imminent. See "Activity," above.

## Mailing list activity:

Following an initial ramp-up in subscriber ship corresponding to TLP
acceptance, mailing lists have remained active and have maintained
consistent usage levels.

 - dev@geode.apache.org:
- 155 subscribers (down -4 in the last 3 months):
- 4562 emails sent to list (1761 in previous quarter)

 - iss...@geode.apache.org:
- 56 subscribers (up 1 in the last 3 months):
- 1042 emails sent to list (3050 in previous quarter)

 - u...@geode.apache.org:
- 206 subscribers (up 12 in the last 3 months):
- 306 emails sent to list (149 in previous quarter)

## JIRA activity:
 - 344 JIRA tickets created in the last 3 months
 - 278 JIRA tickets closed/resolved in the last 3 months


[jira] [Commented] (GEODE-2411) Remove references to Gemfire from include guards

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857021#comment-15857021
 ] 

ASF GitHub Bot commented on GEODE-2411:
---

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/387
  
Built and ran unit tests.  I'll merge this in.


> Remove references to Gemfire from include guards
> 
>
> Key: GEODE-2411
> URL: https://issues.apache.org/jira/browse/GEODE-2411
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> Many of the macro definitions used as include guards in the C++ header files 
> refer to Gemfire. These references should be replaced at least with 
> references to Geode but preferably using pragmas instead of defines.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] geode issue #387: GEODE-2411: Remove references to Gemfire from include guar...

2017-02-07 Thread metatype
Github user metatype commented on the issue:

https://github.com/apache/geode/pull/387
  
Built and ran unit tests.  I'll merge this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #389: GEODE-1434: Add ASF headers

2017-02-07 Thread metatype
Github user metatype closed the pull request at:

https://github.com/apache/geode/pull/389


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (GEODE-1434) Update native client source headers

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857010#comment-15857010
 ] 

ASF GitHub Bot commented on GEODE-1434:
---

Github user metatype closed the pull request at:

https://github.com/apache/geode/pull/389


> Update native client source headers
> ---
>
> Key: GEODE-1434
> URL: https://issues.apache.org/jira/browse/GEODE-1434
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Anthony Baker
>Assignee: Anthony Baker
> Attachments: rat.out.gz
>
>
> The existing native client source code headers contain { pivotal | vmware | 
> gemstone } copyrights and should be replaced with ASF headers.  See 
> https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors.
> Files without a source header probably need the ASF header added.  Only in 
> exceptional circumstances should a file not have a source header.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling

2017-02-07 Thread Kirk Lund (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856984#comment-15856984
 ] 

Kirk Lund commented on GEODE-1930:
--

Overhauling RegionManagementDUnitTest is incomplete and still needs to be 
completed. 

I had originally overhauled LocatorManagementDUnitTest on the feature branch, 
but other changes to Locator and LocatorManagementDUnitTest develop caused 
conflicts bad enough to cause me to abandon my changes. So 
LocatorManagementDUnitTest still needs to be overhauled as well.

There is redundant code within these tests to await for the existence of 
certain Geode mbeans. This should also be refactored.

Leaving this ticket open for these additional changes to eventually be made.

> JMX DistributedTests are in need of overhauling
> ---
>
> Key: GEODE-1930
> URL: https://issues.apache.org/jira/browse/GEODE-1930
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> In particular the DistributedTests that extend ManagementTestBase are really 
> lacking. Most of these have system outs instead of assertions, broken 
> AsyncInvocations and a host of other problems.
> Before working on anything in JMX or GFSH, these tests should be fixed up so 
> that keeping them green actually means something.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (GEODE-173) DLockManagementDUnitTest.testDLockMBean fails intermittently with suspect string

2017-02-07 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-173.
-
   Resolution: Fixed
Fix Version/s: 1.2.0

> DLockManagementDUnitTest.testDLockMBean fails intermittently with suspect 
> string
> 
>
> Key: GEODE-173
> URL: https://issues.apache.org/jira/browse/GEODE-173
> Project: Geode
>  Issue Type: Bug
>  Components: jmx
>Reporter: Darrel Schneider
>Assignee: Kirk Lund
>Priority: Minor
>  Labels: Flaky, LockServiceMXBean
> Fix For: 1.2.0
>
>
> com.gemstone.gemfire.management.DLockManagementDUnitTest.testDLockMBean:
> java.lang.AssertionError: Suspicious strings were written to the log during 
> this run.
> Fix the strings or use DistributedTestCase.addExpectedException to ignore.
> ---
> Found suspect string in log4j at line 1708
> com.gemstone.gemfire.cache.EntryDestroyedException: 
> GemFire:service=LockService,name=testLockService,type=Member,member=cc6-co6(20353)-8501



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (GEODE-553) DLockManagementDUnitTest.testDLockAggregate failed

2017-02-07 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-553.
-
   Resolution: Fixed
Fix Version/s: 1.2.0

> DLockManagementDUnitTest.testDLockAggregate failed
> --
>
> Key: GEODE-553
> URL: https://issues.apache.org/jira/browse/GEODE-553
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Hitesh Khamesra
>Assignee: Kirk Lund
>  Labels: DistributedLockServiceMXBean, Flaky, jmx
> Fix For: 1.2.0
>
>
> dunit.RMIException: While invoking 
> com.gemstone.gemfire.management.DLockManagementDUnitTest$7.run in VM 0 
> running on Host cc6-co6.gemstone.com with 4 VMs
> at dunit.VM.invoke(VM.java:369)
> at dunit.VM.invoke(VM.java:312)
> at dunit.VM.invoke(VM.java:266)
> at 
> com.gemstone.gemfire.management.DLockManagementDUnitTest.checkNavigation(DLockManagementDUnitTest.java:420)
> at 
> com.gemstone.gemfire.management.DLockManagementDUnitTest.testDLockAggregate(DLockManagementDUnitTest.java:118)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
> at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
> at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: junit.framework.AssertionFailedError: Lock Service Navigation 
> Failed java.lang.Exception: cc6-co6(9398):23428 is an invalid member 
> name or Id
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.TestCase.fail(TestCase.java:227)
> at 
> com.gemstone.gemfire.management.DLockManagementDUnitTest$7.run(DLockManagementDUnitTest.java:415)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> 

[jira] [Assigned] (GEODE-553) DLockManagementDUnitTest.testDLockAggregate failed

2017-02-07 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-553:
---

Assignee: Kirk Lund

> DLockManagementDUnitTest.testDLockAggregate failed
> --
>
> Key: GEODE-553
> URL: https://issues.apache.org/jira/browse/GEODE-553
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Hitesh Khamesra
>Assignee: Kirk Lund
>  Labels: DistributedLockServiceMXBean, Flaky, jmx
> Fix For: 1.2.0
>
>
> dunit.RMIException: While invoking 
> com.gemstone.gemfire.management.DLockManagementDUnitTest$7.run in VM 0 
> running on Host cc6-co6.gemstone.com with 4 VMs
> at dunit.VM.invoke(VM.java:369)
> at dunit.VM.invoke(VM.java:312)
> at dunit.VM.invoke(VM.java:266)
> at 
> com.gemstone.gemfire.management.DLockManagementDUnitTest.checkNavigation(DLockManagementDUnitTest.java:420)
> at 
> com.gemstone.gemfire.management.DLockManagementDUnitTest.testDLockAggregate(DLockManagementDUnitTest.java:118)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
> at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
> at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: junit.framework.AssertionFailedError: Lock Service Navigation 
> Failed java.lang.Exception: cc6-co6(9398):23428 is an invalid member 
> name or Id
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.TestCase.fail(TestCase.java:227)
> at 
> com.gemstone.gemfire.management.DLockManagementDUnitTest$7.run(DLockManagementDUnitTest.java:415)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> 

[jira] [Updated] (GEODE-2448) Improve performance of redis command lookup

2017-02-07 Thread Addison (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-2448:
---
Summary: Improve performance of redis command lookup  (was: Improve byte to 
string and vise-verse conversion)

> Improve performance of redis command lookup
> ---
>
> Key: GEODE-2448
> URL: https://issues.apache.org/jira/browse/GEODE-2448
> Project: Geode
>  Issue Type: Sub-task
>  Components: redis
>Reporter: Addison
> Fix For: 1.2.0
>
>
> Consensus seems to be that we should convert to String when we take commands 
> in, to avoid extra work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (GEODE-2451) Improve storage of key/values

2017-02-07 Thread Addison (JIRA)
Addison created GEODE-2451:
--

 Summary: Improve storage of key/values
 Key: GEODE-2451
 URL: https://issues.apache.org/jira/browse/GEODE-2451
 Project: Geode
  Issue Type: Sub-task
Reporter: Addison
 Fix For: 1.2.0






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Contributor Permissions in Jira

2017-02-07 Thread Dan Smith
Hi Sarge,

What's your JIRA username?

-Dan

On Tue, Feb 7, 2017 at 2:46 PM, Michael William Dodge 
wrote:

> As I'm working on the native code, may I have contributor permission in
> Jira so that I may resolve things that I've fixed. Thanks.
>
> Sarge


[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856961#comment-15856961
 ] 

ASF subversion and git services commented on GEODE-1930:


Commit 72ad9f4344aa0eab478d0a5f216197ffa0538fc4 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=72ad9f4 ]

GEODE-1930: Convert from ManagementTestCase to ManagementTestRule


> JMX DistributedTests are in need of overhauling
> ---
>
> Key: GEODE-1930
> URL: https://issues.apache.org/jira/browse/GEODE-1930
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> In particular the DistributedTests that extend ManagementTestBase are really 
> lacking. Most of these have system outs instead of assertions, broken 
> AsyncInvocations and a host of other problems.
> Before working on anything in JMX or GFSH, these tests should be fixed up so 
> that keeping them green actually means something.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Contributor Permissions in Jira

2017-02-07 Thread Michael William Dodge
As I'm working on the native code, may I have contributor permission in Jira so 
that I may resolve things that I've fixed. Thanks.

Sarge

[jira] [Commented] (GEODE-2377) Fix run-unit-tests target

2017-02-07 Thread Michael Dodge (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856957#comment-15856957
 ] 

Michael Dodge commented on GEODE-2377:
--

If the original concern was lack of output from the unit tests, pass 
-DCTEST_UNITTEST_VERBOSITY=-V to cmake during the original generation of the 
make files.

> Fix run-unit-tests target
> -
>
> Key: GEODE-2377
> URL: https://issues.apache.org/jira/browse/GEODE-2377
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>Assignee: Michael Dodge
>
> The run-unit-tests target is not running the unit tests and you must do the 
> following to run the tests...
> $ cd build/cppcache/test/
> $ ./gfcppcache_unittests



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #465 was SUCCESSFUL (with 1672 tests)

2017-02-07 Thread Spring CI

---
Spring Data GemFire > Nightly-ApacheGeode > #465 was successful.
---
Scheduled
1674 tests in total.

https://build.spring.io/browse/SGF-NAG-465/





--
This message is automatically generated by Atlassian Bamboo

[jira] [Created] (GEODE-2450) Redis Adapter should align with Redis defaults

2017-02-07 Thread Addison (JIRA)
Addison created GEODE-2450:
--

 Summary: Redis Adapter should align with Redis defaults
 Key: GEODE-2450
 URL: https://issues.apache.org/jira/browse/GEODE-2450
 Project: Geode
  Issue Type: Sub-task
  Components: redis
Reporter: Addison


1. Persistent disk
... investigate other defaults



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (GEODE-2449) Move redis adapter to extension framework

2017-02-07 Thread Addison (JIRA)
Addison created GEODE-2449:
--

 Summary: Move redis adapter to extension framework
 Key: GEODE-2449
 URL: https://issues.apache.org/jira/browse/GEODE-2449
 Project: Geode
  Issue Type: Sub-task
  Components: redis
Reporter: Addison
 Fix For: 1.2.0






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (GEODE-2377) Fix run-unit-tests target

2017-02-07 Thread Ernest Burghardt (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-2377.
-
Resolution: Not A Problem

Working, non-issue.

> Fix run-unit-tests target
> -
>
> Key: GEODE-2377
> URL: https://issues.apache.org/jira/browse/GEODE-2377
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>Assignee: Michael Dodge
>
> The run-unit-tests target is not running the unit tests and you must do the 
> following to run the tests...
> $ cd build/cppcache/test/
> $ ./gfcppcache_unittests



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (GEODE-2448) Improve byte to string and vise-verse conversion

2017-02-07 Thread Addison (JIRA)
Addison created GEODE-2448:
--

 Summary: Improve byte to string and vise-verse conversion
 Key: GEODE-2448
 URL: https://issues.apache.org/jira/browse/GEODE-2448
 Project: Geode
  Issue Type: Sub-task
  Components: redis
Reporter: Addison
 Fix For: 1.2.0


Consensus seems to be that we should convert to String when we take commands 
in, to avoid extra work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (GEODE-2447) Breakout redisMetaRegion to improve performance

2017-02-07 Thread Addison (JIRA)
Addison created GEODE-2447:
--

 Summary: Breakout redisMetaRegion to improve performance
 Key: GEODE-2447
 URL: https://issues.apache.org/jira/browse/GEODE-2447
 Project: Geode
  Issue Type: Sub-task
  Components: redis
Reporter: Addison


Currently, we have a metadata region that stores each key inserted by Redis 
and its type. There is an additional region where all strings are stored, and 
one where hyperLogLogs are stored. Each list/set/hash creates a table with its 
name.

Consider resolving into a single table or at least namespacing



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (GEODE-2445) evaluate / remove "examples"

2017-02-07 Thread Ernest Burghardt (JIRA)
Ernest Burghardt created GEODE-2445:
---

 Summary: evaluate / remove "examples"
 Key: GEODE-2445
 URL: https://issues.apache.org/jira/browse/GEODE-2445
 Project: Geode
  Issue Type: Task
  Components: native client
Reporter: Ernest Burghardt


at top level of the native repo there are some "examples"
they need to be evaluated viz-a-viz the Quickstarts
and removed if appropriate, otherwise they should join the rest of the 
"SampleCode"  and in either case the .jar file found within needs to be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (GEODE-2444) Redis Adapter Performance Improvements

2017-02-07 Thread Addison (JIRA)
Addison created GEODE-2444:
--

 Summary: Redis Adapter Performance Improvements
 Key: GEODE-2444
 URL: https://issues.apache.org/jira/browse/GEODE-2444
 Project: Geode
  Issue Type: New Feature
  Components: redis
Reporter: Addison
 Fix For: 1.2.0


The goal of this effort is to further test and complete the Redis Adapter to 
make the code more readable and performant. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (GEODE-2443) Evaluate Cmake 3.8

2017-02-07 Thread Ernest Burghardt (JIRA)
Ernest Burghardt created GEODE-2443:
---

 Summary: Evaluate Cmake 3.8
 Key: GEODE-2443
 URL: https://issues.apache.org/jira/browse/GEODE-2443
 Project: Geode
  Issue Type: Task
  Components: native client
Reporter: Ernest Burghardt


Cmake has RC'd 3.8 with support for C# - this needs to be looked to see if it 
works well and to see what (if any) changes we need to make in order to migrate 
to 3.8

Currently we configurate csproj.in files, this presumably would go away
We would need to update CI images to have cmake 3.8




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2441) Remove PDXAutoSerializer

2017-02-07 Thread Michael Dodge (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856908#comment-15856908
 ] 

Michael Dodge commented on GEODE-2441:
--

Perhaps move the relevant code to a user-contributed portion of the repo?

> Remove PDXAutoSerializer 
> -
>
> Key: GEODE-2441
> URL: https://issues.apache.org/jira/browse/GEODE-2441
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> Remove PDXAutoSerializer utility that generates PDX serialization C++ source 
> that you can include in your project to (de)serialize your C++ classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (GEODE-2442) Address link breaking

2017-02-07 Thread Ernest Burghardt (JIRA)
Ernest Burghardt created GEODE-2442:
---

 Summary: Address link breaking
 Key: GEODE-2442
 URL: https://issues.apache.org/jira/browse/GEODE-2442
 Project: Geode
  Issue Type: Bug
  Components: native client
Reporter: Ernest Burghardt


9.1 breaking changes
Link Breaking
Dropping deprecated types and functions. Only breaks if still in customer code 
despite years of deprecation.

Quickstarts should be a good test of linkage issues.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (GEODE-2441) Remove PDXAutoSerializer

2017-02-07 Thread Ernest Burghardt (JIRA)
Ernest Burghardt created GEODE-2441:
---

 Summary: Remove PDXAutoSerializer 
 Key: GEODE-2441
 URL: https://issues.apache.org/jira/browse/GEODE-2441
 Project: Geode
  Issue Type: Bug
  Components: native client
Reporter: Ernest Burghardt


Remove PDXAutoSerializer utility that generates PDX serialization C++ source 
that you can include in your project to (de)serialize your C++ classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

2017-02-07 Thread Ernest Burghardt (JIRA)
Ernest Burghardt created GEODE-2440:
---

 Summary: Fix CacheableKey::hashcode to int32_t to match Server.
 Key: GEODE-2440
 URL: https://issues.apache.org/jira/browse/GEODE-2440
 Project: Geode
  Issue Type: Bug
  Components: native client
Reporter: Ernest Burghardt






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-07 Thread Ernest Burghardt (JIRA)
Ernest Burghardt created GEODE-2439:
---

 Summary: Replace all non-standard types in all public includes / 
API
 Key: GEODE-2439
 URL: https://issues.apache.org/jira/browse/GEODE-2439
 Project: Geode
  Issue Type: Bug
  Components: native client
Reporter: Ernest Burghardt


research other non-standard types in API, ACE_Time




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (GEODE-2434) geodeOldVersionClasspaths.txt is generated every time build is parsed

2017-02-07 Thread Dan Smith (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith updated GEODE-2434:
-
Fix Version/s: 1.1.0

> geodeOldVersionClasspaths.txt is generated every time build is parsed
> -
>
> Key: GEODE-2434
> URL: https://issues.apache.org/jira/browse/GEODE-2434
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Dan Smith
>Assignee: Dan Smith
> Fix For: 1.1.0, 1.2.0
>
>
> geode-old-versions/build.gradle regenerates geodeOldVersionClasspaths.txt 
> during the configuration phase of the task createGeodeClasspathsFile. This is 
> a performance issue with the build because every time someone types ./gradlew 
> it will regenerate this file while configuring the build.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2434) geodeOldVersionClasspaths.txt is generated every time build is parsed

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856875#comment-15856875
 ] 

ASF subversion and git services commented on GEODE-2434:


Commit 889d17041a26536dcc99b9f2bd0207c9c2695340 in geode's branch 
refs/heads/release/1.1.0 from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=889d170 ]

GEODE-2434: Generate old version classpaths in doLast

The geode-old-versions/build.gradle was generating the classpath
properties file during the build configuration phase, rather than the
execution phase.

Also converting the file to an actual properties file so that it will
handle special characters properly.


> geodeOldVersionClasspaths.txt is generated every time build is parsed
> -
>
> Key: GEODE-2434
> URL: https://issues.apache.org/jira/browse/GEODE-2434
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Dan Smith
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
> geode-old-versions/build.gradle regenerates geodeOldVersionClasspaths.txt 
> during the configuration phase of the task createGeodeClasspathsFile. This is 
> a performance issue with the build because every time someone types ./gradlew 
> it will regenerate this file while configuring the build.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] geode pull request #395: GEODE-2430: Fix failing tests

2017-02-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/395


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Nightly build broken

2017-02-07 Thread Hitesh Khamesra
Thanks Dan. Lets merge this fix into 1.1 release branch.
-Hitesh


  From: Dan Smith 
 To: dev@geode.apache.org 
 Sent: Tuesday, February 7, 2017 1:12 PM
 Subject: Re: Nightly build broken
   
Actually, now that I think about it GEODE-2434 was probably the cause of
these backwards compatibility test failures. The build was generating the
geodeOldVersionClasspaths file during the configuration phase. What that
means is if you run './gradlew clean precheckin', the file gets generated
*before* the clean, which will then delete it. Just doing this without the
fix for GEODE-2434 will also fail with that error:

./gradlew clean geode-core:distributedTest --tests
'*ClientServerMiscBCDUnitTest*'

We should merge the fix for GEODE-2434 to the release branch as well.

-Dan

On Tue, Feb 7, 2017 at 12:59 PM, Kirk Lund  wrote:

> The BC tests are failing with this RuntimeException (it ends up being an
> initializationError):
>
> java.lang.RuntimeException: No older versions of Geode were found to test
> against
> at
> org.apache.geode.internal.cache.tier.sockets.ClientServerMiscBCDUnitTest.
> data(ClientServerMiscBCDUnitTest.java:37)
>
>
> On Tue, Feb 7, 2017 at 12:55 PM, Udo Kohlmeyer 
> wrote:
>
> > Looking at some of the failures, it seems it is complaining about not
> > finding diskstores to delete.
> >
> >
> >
> > On 2/7/17 12:53, Kirk Lund wrote:
> >
> >> Last night's nightly build is pretty horrible. 121 dunit test failures.
> >> Cluster config accounts for 13 of them and we already have a fix for
> those
> >> 13 only.
> >>
> >> Anyone else want to look into the other failures? Looks like some of the
> >> other failures are diskstore related.
> >>
> >> https://builds.apache.org/job/Geode-nightly/ws/geode-core/bu
> >> ild/reports/distributedTest/index.html
> >>
> >> Failures:
> >>
> >> DistTXDebugDUnitTest. testTXDestroy_invalidate
> >> DistTXDebugDUnitTest. testTXPR
> >> DistTXDebugDUnitTest. testTXPR2
> >> DistTXDebugDUnitTest. testTXPRRR2_create
> >> DistTXDebugDUnitTest. testTXPRRR2_putall
> >> DistTXDebugDUnitTest. testTXPR_RR
> >> DistTXDebugDUnitTest. testTXPR_putall
> >> DistTXDebugDUnitTest. testTXPR_removeAll
> >> DistTXDebugDUnitTest. testTXRR2
> >> DistTXDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
> >> DistTXDebugDUnitTest. testTXRR_removeAll
> >> DistTXDebugDUnitTest. testTXRR_removeAll_dataNodeAsCoordinator
> >> DistTXOrderDUnitTest. testBug43353
> >> DistTXOrderDUnitTest. testFarSideIndexOnDestroy
> >> DistTXOrderDUnitTest. testFarSideIndexOnInvalidate
> >> DistTXOrderDUnitTest. testFarSideIndexOnPut
> >> DistTXPersistentDebugDUnitTest. testBasicDistributedTX
> >> DistTXPersistentDebugDUnitTest. testTXDestroy_invalidate
> >> DistTXPersistentDebugDUnitTest. testTXPR
> >> DistTXPersistentDebugDUnitTest. testTXPR2
> >> DistTXPersistentDebugDUnitTest. testTXPRRR2_create
> >> DistTXPersistentDebugDUnitTest. testTXPRRR2_putall
> >> DistTXPersistentDebugDUnitTest. testTXPR_RR
> >> DistTXPersistentDebugDUnitTest. testTXPR_putall
> >> DistTXPersistentDebugDUnitTest. testTXPR_removeAll
> >> DistTXPersistentDebugDUnitTest. testTXRR2
> >> DistTXPersistentDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
> >> DistTXPersistentDebugDUnitTest. testTXRR_removeAll
> >> DistTXPersistentDebugDUnitTest. testTXRR_removeAll_
> dataNodeAsCoordinator
> >> DistTXRestrictionsDUnitTest. testPersistentRestriction
> >> DistTXWithDeltaDUnitTest. testClientServerDelta
> >> DistTXWithDeltaDUnitTest. testExceptionThrown
> >> DistTXWithDeltaDUnitTest. testTxWithCloning
> >> DistributedTransactionDUnitTest. testBasicDistributedTX
> >> DistributedTransactionDUnitTest. testCommitAndRollback
> >> DistributedTransactionDUnitTest. testCommitConflicts_PR
> >> DistributedTransactionDUnitTest. testCommitConflicts_PR_after_l
> >> ocks_acquired
> >> DistributedTransactionDUnitTest. testCommitConflicts_RR
> >> DistributedTransactionDUnitTest. testCommitNoConflicts_PR
> >> DistributedTransactionDUnitTest. testCommitNoConflicts_RR
> >> DistributedTransactionDUnitTest. testCommitOnPartitionedAndRepl
> >> icatedRegions
> >> DistributedTransactionDUnitTest. testGetIsolated
> >> DistributedTransactionDUnitTest. testMultipleOpsOnSameKeyInTx
> >> DistributedTransactionDUnitTest. testNonColocatedPutByPartitioning
> >> DistributedTransactionDUnitTest. testPutAllWithTransactions
> >> DistributedTransactionDUnitTest. testRegionAndEntryVersionsPR
> >> DistributedTransactionDUnitTest. testRegionAndEntryVersionsRR
> >> DistributedTransactionDUnitTest. testRemoveAllWithTransactions
> >> DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_PR
> >> DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_RR
> >> DistributedTransactionDUnitTest. testTransactionalKeyBasedUpdates
> >> DistributedTransactionDUnitTest. testTransactionalPutOnPartitio
> nedRegion
> >> DistributedTransactionDUnitTest. testTransactionalPutOnReplicatedRegion
> >> DistributedTransactionDUnitTest. 

[jira] [Commented] (GEODE-2434) geodeOldVersionClasspaths.txt is generated every time build is parsed

2017-02-07 Thread Dan Smith (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856807#comment-15856807
 ] 

Dan Smith commented on GEODE-2434:
--

It turns out this was also causing failures if you run ./gradlew clean 
precheckin because the file is generated in the configuration phase and then 
deleted by clean in the execution phase.

> geodeOldVersionClasspaths.txt is generated every time build is parsed
> -
>
> Key: GEODE-2434
> URL: https://issues.apache.org/jira/browse/GEODE-2434
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Dan Smith
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
> geode-old-versions/build.gradle regenerates geodeOldVersionClasspaths.txt 
> during the configuration phase of the task createGeodeClasspathsFile. This is 
> a performance issue with the build because every time someone types ./gradlew 
> it will regenerate this file while configuring the build.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Nightly build broken

2017-02-07 Thread Dan Smith
Actually, now that I think about it GEODE-2434 was probably the cause of
these backwards compatibility test failures. The build was generating the
geodeOldVersionClasspaths file during the configuration phase. What that
means is if you run './gradlew clean precheckin', the file gets generated
*before* the clean, which will then delete it. Just doing this without the
fix for GEODE-2434 will also fail with that error:

./gradlew clean geode-core:distributedTest --tests
'*ClientServerMiscBCDUnitTest*'

We should merge the fix for GEODE-2434 to the release branch as well.

-Dan

On Tue, Feb 7, 2017 at 12:59 PM, Kirk Lund  wrote:

> The BC tests are failing with this RuntimeException (it ends up being an
> initializationError):
>
> java.lang.RuntimeException: No older versions of Geode were found to test
> against
> at
> org.apache.geode.internal.cache.tier.sockets.ClientServerMiscBCDUnitTest.
> data(ClientServerMiscBCDUnitTest.java:37)
>
>
> On Tue, Feb 7, 2017 at 12:55 PM, Udo Kohlmeyer 
> wrote:
>
> > Looking at some of the failures, it seems it is complaining about not
> > finding diskstores to delete.
> >
> >
> >
> > On 2/7/17 12:53, Kirk Lund wrote:
> >
> >> Last night's nightly build is pretty horrible. 121 dunit test failures.
> >> Cluster config accounts for 13 of them and we already have a fix for
> those
> >> 13 only.
> >>
> >> Anyone else want to look into the other failures? Looks like some of the
> >> other failures are diskstore related.
> >>
> >> https://builds.apache.org/job/Geode-nightly/ws/geode-core/bu
> >> ild/reports/distributedTest/index.html
> >>
> >> Failures:
> >>
> >> DistTXDebugDUnitTest. testTXDestroy_invalidate
> >> DistTXDebugDUnitTest. testTXPR
> >> DistTXDebugDUnitTest. testTXPR2
> >> DistTXDebugDUnitTest. testTXPRRR2_create
> >> DistTXDebugDUnitTest. testTXPRRR2_putall
> >> DistTXDebugDUnitTest. testTXPR_RR
> >> DistTXDebugDUnitTest. testTXPR_putall
> >> DistTXDebugDUnitTest. testTXPR_removeAll
> >> DistTXDebugDUnitTest. testTXRR2
> >> DistTXDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
> >> DistTXDebugDUnitTest. testTXRR_removeAll
> >> DistTXDebugDUnitTest. testTXRR_removeAll_dataNodeAsCoordinator
> >> DistTXOrderDUnitTest. testBug43353
> >> DistTXOrderDUnitTest. testFarSideIndexOnDestroy
> >> DistTXOrderDUnitTest. testFarSideIndexOnInvalidate
> >> DistTXOrderDUnitTest. testFarSideIndexOnPut
> >> DistTXPersistentDebugDUnitTest. testBasicDistributedTX
> >> DistTXPersistentDebugDUnitTest. testTXDestroy_invalidate
> >> DistTXPersistentDebugDUnitTest. testTXPR
> >> DistTXPersistentDebugDUnitTest. testTXPR2
> >> DistTXPersistentDebugDUnitTest. testTXPRRR2_create
> >> DistTXPersistentDebugDUnitTest. testTXPRRR2_putall
> >> DistTXPersistentDebugDUnitTest. testTXPR_RR
> >> DistTXPersistentDebugDUnitTest. testTXPR_putall
> >> DistTXPersistentDebugDUnitTest. testTXPR_removeAll
> >> DistTXPersistentDebugDUnitTest. testTXRR2
> >> DistTXPersistentDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
> >> DistTXPersistentDebugDUnitTest. testTXRR_removeAll
> >> DistTXPersistentDebugDUnitTest. testTXRR_removeAll_
> dataNodeAsCoordinator
> >> DistTXRestrictionsDUnitTest. testPersistentRestriction
> >> DistTXWithDeltaDUnitTest. testClientServerDelta
> >> DistTXWithDeltaDUnitTest. testExceptionThrown
> >> DistTXWithDeltaDUnitTest. testTxWithCloning
> >> DistributedTransactionDUnitTest. testBasicDistributedTX
> >> DistributedTransactionDUnitTest. testCommitAndRollback
> >> DistributedTransactionDUnitTest. testCommitConflicts_PR
> >> DistributedTransactionDUnitTest. testCommitConflicts_PR_after_l
> >> ocks_acquired
> >> DistributedTransactionDUnitTest. testCommitConflicts_RR
> >> DistributedTransactionDUnitTest. testCommitNoConflicts_PR
> >> DistributedTransactionDUnitTest. testCommitNoConflicts_RR
> >> DistributedTransactionDUnitTest. testCommitOnPartitionedAndRepl
> >> icatedRegions
> >> DistributedTransactionDUnitTest. testGetIsolated
> >> DistributedTransactionDUnitTest. testMultipleOpsOnSameKeyInTx
> >> DistributedTransactionDUnitTest. testNonColocatedPutByPartitioning
> >> DistributedTransactionDUnitTest. testPutAllWithTransactions
> >> DistributedTransactionDUnitTest. testRegionAndEntryVersionsPR
> >> DistributedTransactionDUnitTest. testRegionAndEntryVersionsRR
> >> DistributedTransactionDUnitTest. testRemoveAllWithTransactions
> >> DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_PR
> >> DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_RR
> >> DistributedTransactionDUnitTest. testTransactionalKeyBasedUpdates
> >> DistributedTransactionDUnitTest. testTransactionalPutOnPartitio
> nedRegion
> >> DistributedTransactionDUnitTest. testTransactionalPutOnReplicatedRegion
> >> DistributedTransactionDUnitTest. testTransactionalUpdates
> >> DistributedTransactionDUnitTest. testTxWithSingleDataStore
> >> PRDistTXDUnitTest. testColocatedPRRedundancyRecovery
> >> PRDistTXDUnitTest. testColocatedPRRedundancyRecovery2
> >> 

Re: Feb 2017 Board Report DRAFT FOR REVIEW (need your input on Tuesday 2/7 if possible)

2017-02-07 Thread Dave Barnes
Actually, I deleted him. Anyone else have "corrections"? G

On Tue, Feb 7, 2017 at 12:13 PM, Udo Kohlmeyer 
wrote:

> stop being so picky... be happy he mentioned you :P
>
>
>
> On 2/7/17 10:30, Jared Stewart wrote:
>
>> One more minor edit:
>>
>> "Jared Steward" => “Jared Stewart”
>>
>> On Feb 7, 2017, at 10:27 AM, Anilkumar Gingade 
>>> wrote:
>>>
>>> Looks good...
>>>
>>> -Anil.
>>>
>>>
>>> On Mon, Feb 6, 2017 at 5:38 PM, Dan Smith  wrote:
>>>
>>> Looks good! A couple of minor edits:

 "open dev list" => "dev list"
 "commmitters" => "committers"

 -Dan

 On Mon, Feb 6, 2017 at 5:19 PM, Dave Barnes  wrote:

 Please review and comment by COB Tuesday, 2/7/2017, as the report is due
>
 on

> Wednesday. Thanks!
>
> ## Description:
>
> - Apache Geode provides a database-like consistency model, reliable
>transaction processing and a shared-nothing architecture to maintain
>very low latency performance with high concurrency processing.
>
> ## Issues:
>
> - There are no issues requiring board attention at this time.
>
> ## Activity:
>
> - Geode was promoted to TLP status in the November 2016 board meeting.
> Since that time:
>-  A new TLP repo was created and populated
>-  Work on the first TLP-level release has been underway.
> - Release candidate 2 for Version 1.1.0 is nearly complete; voting will
> likely begin before the upcoming board meeting.
> The release addresses 252 JIRA tickets. For a complete list, please see
>
 the

> [Geode Release Notes](
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318420=12338352
> ).
> - A new code contribution is in progress for C++ and C# native clients
>
 and

> their accompanying documentation. After a lively discussion on the open
>
 dev

> list, it was decided to create a separate Git repo to house this code.
>
> ## Health report:
>
> - Mailing lists remain active and productive.
> - JIRA tickets show that issues continue to be identified and resolved.
> - We’re continuing to work on attracting new contributors and making it
> easier to participate in the community.
>
> ## PMC changes:
> - Currently 32 PMC members.
> - New PMC members:
> - Kevin Duling was added to the PMC on Wed Jan 18 2017
> - Ken Howe was added to the PMC on Wed Jan 18 2017
>
> ## Committer base changes:
>
> - Currently 77 committers. New commmitters:
> - Kevin Duling was added as a committer on Sat Jan 14 2017
> - Jared Steward was added as a committer on Mon Feb 6 2017
>
> ## Releases:
>
> - Last release was 1.0.0-incubating issued on October 25, 2016.
> - Version 1.1.0 is imminent. See "Activity," above.
>
> ## Mailing list activity:
>
> Following an initial ramp-up in subscriber ship corresponding to TLP
> acceptance, mailing lists have remained active and have maintained
> consistent usage levels.
>
> - dev@geode.apache.org:
> - 155 subscribers (down -4 in the last 3 months):
> - 4562 emails sent to list (1761 in previous quarter)
>
> - iss...@geode.apache.org:
> - 56 subscribers (up 1 in the last 3 months):
> - 1042 emails sent to list (3050 in previous quarter)
>
> - u...@geode.apache.org:
> - 206 subscribers (up 12 in the last 3 months):
> - 306 emails sent to list (149 in previous quarter)
>
> ## JIRA activity:
> - 344 JIRA tickets created in the last 3 months
> - 278 JIRA tickets closed/resolved in the last 3 months
>
>
>


Re: Nightly build broken

2017-02-07 Thread Kirk Lund
The BC tests are failing with this RuntimeException (it ends up being an
initializationError):

java.lang.RuntimeException: No older versions of Geode were found to test
against
at
org.apache.geode.internal.cache.tier.sockets.ClientServerMiscBCDUnitTest.data(ClientServerMiscBCDUnitTest.java:37)


On Tue, Feb 7, 2017 at 12:55 PM, Udo Kohlmeyer 
wrote:

> Looking at some of the failures, it seems it is complaining about not
> finding diskstores to delete.
>
>
>
> On 2/7/17 12:53, Kirk Lund wrote:
>
>> Last night's nightly build is pretty horrible. 121 dunit test failures.
>> Cluster config accounts for 13 of them and we already have a fix for those
>> 13 only.
>>
>> Anyone else want to look into the other failures? Looks like some of the
>> other failures are diskstore related.
>>
>> https://builds.apache.org/job/Geode-nightly/ws/geode-core/bu
>> ild/reports/distributedTest/index.html
>>
>> Failures:
>>
>> DistTXDebugDUnitTest. testTXDestroy_invalidate
>> DistTXDebugDUnitTest. testTXPR
>> DistTXDebugDUnitTest. testTXPR2
>> DistTXDebugDUnitTest. testTXPRRR2_create
>> DistTXDebugDUnitTest. testTXPRRR2_putall
>> DistTXDebugDUnitTest. testTXPR_RR
>> DistTXDebugDUnitTest. testTXPR_putall
>> DistTXDebugDUnitTest. testTXPR_removeAll
>> DistTXDebugDUnitTest. testTXRR2
>> DistTXDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
>> DistTXDebugDUnitTest. testTXRR_removeAll
>> DistTXDebugDUnitTest. testTXRR_removeAll_dataNodeAsCoordinator
>> DistTXOrderDUnitTest. testBug43353
>> DistTXOrderDUnitTest. testFarSideIndexOnDestroy
>> DistTXOrderDUnitTest. testFarSideIndexOnInvalidate
>> DistTXOrderDUnitTest. testFarSideIndexOnPut
>> DistTXPersistentDebugDUnitTest. testBasicDistributedTX
>> DistTXPersistentDebugDUnitTest. testTXDestroy_invalidate
>> DistTXPersistentDebugDUnitTest. testTXPR
>> DistTXPersistentDebugDUnitTest. testTXPR2
>> DistTXPersistentDebugDUnitTest. testTXPRRR2_create
>> DistTXPersistentDebugDUnitTest. testTXPRRR2_putall
>> DistTXPersistentDebugDUnitTest. testTXPR_RR
>> DistTXPersistentDebugDUnitTest. testTXPR_putall
>> DistTXPersistentDebugDUnitTest. testTXPR_removeAll
>> DistTXPersistentDebugDUnitTest. testTXRR2
>> DistTXPersistentDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
>> DistTXPersistentDebugDUnitTest. testTXRR_removeAll
>> DistTXPersistentDebugDUnitTest. testTXRR_removeAll_dataNodeAsCoordinator
>> DistTXRestrictionsDUnitTest. testPersistentRestriction
>> DistTXWithDeltaDUnitTest. testClientServerDelta
>> DistTXWithDeltaDUnitTest. testExceptionThrown
>> DistTXWithDeltaDUnitTest. testTxWithCloning
>> DistributedTransactionDUnitTest. testBasicDistributedTX
>> DistributedTransactionDUnitTest. testCommitAndRollback
>> DistributedTransactionDUnitTest. testCommitConflicts_PR
>> DistributedTransactionDUnitTest. testCommitConflicts_PR_after_l
>> ocks_acquired
>> DistributedTransactionDUnitTest. testCommitConflicts_RR
>> DistributedTransactionDUnitTest. testCommitNoConflicts_PR
>> DistributedTransactionDUnitTest. testCommitNoConflicts_RR
>> DistributedTransactionDUnitTest. testCommitOnPartitionedAndRepl
>> icatedRegions
>> DistributedTransactionDUnitTest. testGetIsolated
>> DistributedTransactionDUnitTest. testMultipleOpsOnSameKeyInTx
>> DistributedTransactionDUnitTest. testNonColocatedPutByPartitioning
>> DistributedTransactionDUnitTest. testPutAllWithTransactions
>> DistributedTransactionDUnitTest. testRegionAndEntryVersionsPR
>> DistributedTransactionDUnitTest. testRegionAndEntryVersionsRR
>> DistributedTransactionDUnitTest. testRemoveAllWithTransactions
>> DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_PR
>> DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_RR
>> DistributedTransactionDUnitTest. testTransactionalKeyBasedUpdates
>> DistributedTransactionDUnitTest. testTransactionalPutOnPartitionedRegion
>> DistributedTransactionDUnitTest. testTransactionalPutOnReplicatedRegion
>> DistributedTransactionDUnitTest. testTransactionalUpdates
>> DistributedTransactionDUnitTest. testTxWithSingleDataStore
>> PRDistTXDUnitTest. testColocatedPRRedundancyRecovery
>> PRDistTXDUnitTest. testColocatedPRRedundancyRecovery2
>> PRDistTXDUnitTest. testColocatedPRWithAccessorOnDifferentNode1
>> PRDistTXDUnitTest. testColocatedPRWithAccessorOnDifferentNode2
>> PRDistTXDUnitTest. testColocatedPRWithClose
>> PRDistTXDUnitTest. testColocatedPRWithDestroy
>> PRDistTXDUnitTest. testColocatedPRWithLocalDestroy
>> PRDistTXDUnitTest. testColocatedPRWithPROnDifferentNode1
>> PRDistTXDUnitTest. testColocatedPartitionedRegion
>> PRDistTXDUnitTest. testColocatedPartitionedRegion_NoFullPath
>> PRDistTXDUnitTest. testColocatedSubPartitionedRegion
>> PRDistTXDUnitTest. testColocatedSubPartitionedRegion_NoFullPath
>> PRDistTXDUnitTest. testColocationPartitionedRegion
>> PRDistTXDUnitTest. testColocationPartitionedRegio
>> nWithKeyPartitionResolver
>> PRDistTXDUnitTest.
>> testColocationPartitionedRegionWithNullColocationSpecifiedOnOneNode
>> PRDistTXDUnitTest. 

Re: Nightly build broken

2017-02-07 Thread Udo Kohlmeyer
Looking at some of the failures, it seems it is complaining about not 
finding diskstores to delete.



On 2/7/17 12:53, Kirk Lund wrote:

Last night's nightly build is pretty horrible. 121 dunit test failures.
Cluster config accounts for 13 of them and we already have a fix for those
13 only.

Anyone else want to look into the other failures? Looks like some of the
other failures are diskstore related.

https://builds.apache.org/job/Geode-nightly/ws/geode-core/build/reports/distributedTest/index.html

Failures:

DistTXDebugDUnitTest. testTXDestroy_invalidate
DistTXDebugDUnitTest. testTXPR
DistTXDebugDUnitTest. testTXPR2
DistTXDebugDUnitTest. testTXPRRR2_create
DistTXDebugDUnitTest. testTXPRRR2_putall
DistTXDebugDUnitTest. testTXPR_RR
DistTXDebugDUnitTest. testTXPR_putall
DistTXDebugDUnitTest. testTXPR_removeAll
DistTXDebugDUnitTest. testTXRR2
DistTXDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
DistTXDebugDUnitTest. testTXRR_removeAll
DistTXDebugDUnitTest. testTXRR_removeAll_dataNodeAsCoordinator
DistTXOrderDUnitTest. testBug43353
DistTXOrderDUnitTest. testFarSideIndexOnDestroy
DistTXOrderDUnitTest. testFarSideIndexOnInvalidate
DistTXOrderDUnitTest. testFarSideIndexOnPut
DistTXPersistentDebugDUnitTest. testBasicDistributedTX
DistTXPersistentDebugDUnitTest. testTXDestroy_invalidate
DistTXPersistentDebugDUnitTest. testTXPR
DistTXPersistentDebugDUnitTest. testTXPR2
DistTXPersistentDebugDUnitTest. testTXPRRR2_create
DistTXPersistentDebugDUnitTest. testTXPRRR2_putall
DistTXPersistentDebugDUnitTest. testTXPR_RR
DistTXPersistentDebugDUnitTest. testTXPR_putall
DistTXPersistentDebugDUnitTest. testTXPR_removeAll
DistTXPersistentDebugDUnitTest. testTXRR2
DistTXPersistentDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
DistTXPersistentDebugDUnitTest. testTXRR_removeAll
DistTXPersistentDebugDUnitTest. testTXRR_removeAll_dataNodeAsCoordinator
DistTXRestrictionsDUnitTest. testPersistentRestriction
DistTXWithDeltaDUnitTest. testClientServerDelta
DistTXWithDeltaDUnitTest. testExceptionThrown
DistTXWithDeltaDUnitTest. testTxWithCloning
DistributedTransactionDUnitTest. testBasicDistributedTX
DistributedTransactionDUnitTest. testCommitAndRollback
DistributedTransactionDUnitTest. testCommitConflicts_PR
DistributedTransactionDUnitTest. testCommitConflicts_PR_after_locks_acquired
DistributedTransactionDUnitTest. testCommitConflicts_RR
DistributedTransactionDUnitTest. testCommitNoConflicts_PR
DistributedTransactionDUnitTest. testCommitNoConflicts_RR
DistributedTransactionDUnitTest. testCommitOnPartitionedAndReplicatedRegions
DistributedTransactionDUnitTest. testGetIsolated
DistributedTransactionDUnitTest. testMultipleOpsOnSameKeyInTx
DistributedTransactionDUnitTest. testNonColocatedPutByPartitioning
DistributedTransactionDUnitTest. testPutAllWithTransactions
DistributedTransactionDUnitTest. testRegionAndEntryVersionsPR
DistributedTransactionDUnitTest. testRegionAndEntryVersionsRR
DistributedTransactionDUnitTest. testRemoveAllWithTransactions
DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_PR
DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_RR
DistributedTransactionDUnitTest. testTransactionalKeyBasedUpdates
DistributedTransactionDUnitTest. testTransactionalPutOnPartitionedRegion
DistributedTransactionDUnitTest. testTransactionalPutOnReplicatedRegion
DistributedTransactionDUnitTest. testTransactionalUpdates
DistributedTransactionDUnitTest. testTxWithSingleDataStore
PRDistTXDUnitTest. testColocatedPRRedundancyRecovery
PRDistTXDUnitTest. testColocatedPRRedundancyRecovery2
PRDistTXDUnitTest. testColocatedPRWithAccessorOnDifferentNode1
PRDistTXDUnitTest. testColocatedPRWithAccessorOnDifferentNode2
PRDistTXDUnitTest. testColocatedPRWithClose
PRDistTXDUnitTest. testColocatedPRWithDestroy
PRDistTXDUnitTest. testColocatedPRWithLocalDestroy
PRDistTXDUnitTest. testColocatedPRWithPROnDifferentNode1
PRDistTXDUnitTest. testColocatedPartitionedRegion
PRDistTXDUnitTest. testColocatedPartitionedRegion_NoFullPath
PRDistTXDUnitTest. testColocatedSubPartitionedRegion
PRDistTXDUnitTest. testColocatedSubPartitionedRegion_NoFullPath
PRDistTXDUnitTest. testColocationPartitionedRegion
PRDistTXDUnitTest. testColocationPartitionedRegionWithKeyPartitionResolver
PRDistTXDUnitTest.
testColocationPartitionedRegionWithNullColocationSpecifiedOnOneNode
PRDistTXDUnitTest. testColocationPartitionedRegionWithRedundancy
PRDistTXDUnitTest. testDestroyColocatedPartitionedRegion
PRDistTXDUnitTest. testPRTXInCacheListenerRedundancy0
PRDistTXDUnitTest. testPRTXInCacheListenerRedundancy1
PRDistTXDUnitTest. testPRTXInCacheListenerRedundancy2
PRDistTXDUnitTest. testPRTXPerformance
PRDistTXDUnitTest. testPartitionResolverPartitionedRegion
PRDistTXDUnitTest. testRedundancyRestriction
PRDistTXDUnitTest. testRepeatableRead
PRDistTXDUnitTest. testSimulaneousChildRegionCreation
PRDistTXWithVersionsDUnitTest. testColocatedPRRedundancyRecovery
PRDistTXWithVersionsDUnitTest. testColocatedPRRedundancyRecovery2
PRDistTXWithVersionsDUnitTest. 

Nightly build broken

2017-02-07 Thread Kirk Lund
Last night's nightly build is pretty horrible. 121 dunit test failures.
Cluster config accounts for 13 of them and we already have a fix for those
13 only.

Anyone else want to look into the other failures? Looks like some of the
other failures are diskstore related.

https://builds.apache.org/job/Geode-nightly/ws/geode-core/build/reports/distributedTest/index.html

Failures:

DistTXDebugDUnitTest. testTXDestroy_invalidate
DistTXDebugDUnitTest. testTXPR
DistTXDebugDUnitTest. testTXPR2
DistTXDebugDUnitTest. testTXPRRR2_create
DistTXDebugDUnitTest. testTXPRRR2_putall
DistTXDebugDUnitTest. testTXPR_RR
DistTXDebugDUnitTest. testTXPR_putall
DistTXDebugDUnitTest. testTXPR_removeAll
DistTXDebugDUnitTest. testTXRR2
DistTXDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
DistTXDebugDUnitTest. testTXRR_removeAll
DistTXDebugDUnitTest. testTXRR_removeAll_dataNodeAsCoordinator
DistTXOrderDUnitTest. testBug43353
DistTXOrderDUnitTest. testFarSideIndexOnDestroy
DistTXOrderDUnitTest. testFarSideIndexOnInvalidate
DistTXOrderDUnitTest. testFarSideIndexOnPut
DistTXPersistentDebugDUnitTest. testBasicDistributedTX
DistTXPersistentDebugDUnitTest. testTXDestroy_invalidate
DistTXPersistentDebugDUnitTest. testTXPR
DistTXPersistentDebugDUnitTest. testTXPR2
DistTXPersistentDebugDUnitTest. testTXPRRR2_create
DistTXPersistentDebugDUnitTest. testTXPRRR2_putall
DistTXPersistentDebugDUnitTest. testTXPR_RR
DistTXPersistentDebugDUnitTest. testTXPR_putall
DistTXPersistentDebugDUnitTest. testTXPR_removeAll
DistTXPersistentDebugDUnitTest. testTXRR2
DistTXPersistentDebugDUnitTest. testTXRR2_dataNodeAsCoordinator
DistTXPersistentDebugDUnitTest. testTXRR_removeAll
DistTXPersistentDebugDUnitTest. testTXRR_removeAll_dataNodeAsCoordinator
DistTXRestrictionsDUnitTest. testPersistentRestriction
DistTXWithDeltaDUnitTest. testClientServerDelta
DistTXWithDeltaDUnitTest. testExceptionThrown
DistTXWithDeltaDUnitTest. testTxWithCloning
DistributedTransactionDUnitTest. testBasicDistributedTX
DistributedTransactionDUnitTest. testCommitAndRollback
DistributedTransactionDUnitTest. testCommitConflicts_PR
DistributedTransactionDUnitTest. testCommitConflicts_PR_after_locks_acquired
DistributedTransactionDUnitTest. testCommitConflicts_RR
DistributedTransactionDUnitTest. testCommitNoConflicts_PR
DistributedTransactionDUnitTest. testCommitNoConflicts_RR
DistributedTransactionDUnitTest. testCommitOnPartitionedAndReplicatedRegions
DistributedTransactionDUnitTest. testGetIsolated
DistributedTransactionDUnitTest. testMultipleOpsOnSameKeyInTx
DistributedTransactionDUnitTest. testNonColocatedPutByPartitioning
DistributedTransactionDUnitTest. testPutAllWithTransactions
DistributedTransactionDUnitTest. testRegionAndEntryVersionsPR
DistributedTransactionDUnitTest. testRegionAndEntryVersionsRR
DistributedTransactionDUnitTest. testRemoveAllWithTransactions
DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_PR
DistributedTransactionDUnitTest. testTransactionalKeyBasedDestroys_RR
DistributedTransactionDUnitTest. testTransactionalKeyBasedUpdates
DistributedTransactionDUnitTest. testTransactionalPutOnPartitionedRegion
DistributedTransactionDUnitTest. testTransactionalPutOnReplicatedRegion
DistributedTransactionDUnitTest. testTransactionalUpdates
DistributedTransactionDUnitTest. testTxWithSingleDataStore
PRDistTXDUnitTest. testColocatedPRRedundancyRecovery
PRDistTXDUnitTest. testColocatedPRRedundancyRecovery2
PRDistTXDUnitTest. testColocatedPRWithAccessorOnDifferentNode1
PRDistTXDUnitTest. testColocatedPRWithAccessorOnDifferentNode2
PRDistTXDUnitTest. testColocatedPRWithClose
PRDistTXDUnitTest. testColocatedPRWithDestroy
PRDistTXDUnitTest. testColocatedPRWithLocalDestroy
PRDistTXDUnitTest. testColocatedPRWithPROnDifferentNode1
PRDistTXDUnitTest. testColocatedPartitionedRegion
PRDistTXDUnitTest. testColocatedPartitionedRegion_NoFullPath
PRDistTXDUnitTest. testColocatedSubPartitionedRegion
PRDistTXDUnitTest. testColocatedSubPartitionedRegion_NoFullPath
PRDistTXDUnitTest. testColocationPartitionedRegion
PRDistTXDUnitTest. testColocationPartitionedRegionWithKeyPartitionResolver
PRDistTXDUnitTest.
testColocationPartitionedRegionWithNullColocationSpecifiedOnOneNode
PRDistTXDUnitTest. testColocationPartitionedRegionWithRedundancy
PRDistTXDUnitTest. testDestroyColocatedPartitionedRegion
PRDistTXDUnitTest. testPRTXInCacheListenerRedundancy0
PRDistTXDUnitTest. testPRTXInCacheListenerRedundancy1
PRDistTXDUnitTest. testPRTXInCacheListenerRedundancy2
PRDistTXDUnitTest. testPRTXPerformance
PRDistTXDUnitTest. testPartitionResolverPartitionedRegion
PRDistTXDUnitTest. testRedundancyRestriction
PRDistTXDUnitTest. testRepeatableRead
PRDistTXDUnitTest. testSimulaneousChildRegionCreation
PRDistTXWithVersionsDUnitTest. testColocatedPRRedundancyRecovery
PRDistTXWithVersionsDUnitTest. testColocatedPRRedundancyRecovery2
PRDistTXWithVersionsDUnitTest. testColocatedPRWithAccessorOnDifferentNode1
PRDistTXWithVersionsDUnitTest. testColocatedPRWithAccessorOnDifferentNode2

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-07 Thread Dan Smith


> On Feb. 7, 2017, 1:45 a.m., Mark Bretl wrote:
> > geode-old-versions/build.gradle, line 63
> > 
> >
> > Clarifying question: Should this be associated with 'test' sources or 
> > is 'main' so the tests may use it?
> 
> Dan Smith wrote:
> I was thinking that at some point in the future we might want to get this 
> file from the classpath, rather than what the code is doing now where it's 
> poking around on the filesystem.
> 
> Things in main will be added to the classpath of another project when you 
> declare a dependency on this project, eg testComplile 
> project('geode-old-versions'). Things in test generally aren't, unless you 
> jump through some hoops.
> 
> Bruce Schuchardt wrote:
> If this would allow the VersionManager code to find the file on its 
> classpath I'd really like to make that change.  Jenkins seems to be causing 
> problems with the current "poking around" method of trying to find the file.

Yeah, we ought to be able to load this file just with something like this:

Properties props = new Properties();
try (InputStream in = 
VersionManager.class.getResource("/geodeOldVersionClasspaths.txt").openStream())
 {
  props.load(in);
}

I'm not sure why the release build failed though, it seems like the code that's 
on that branch should work.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56348/#review164448
---


On Feb. 7, 2017, 12:53 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56348/
> ---
> 
> (Updated Feb. 7, 2017, 12:53 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Mark Bretl.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The geode-old-versions/build.gradle was generating the classpath
> properties file during the build configuration phase, rather than the
> execution phase.
> 
> Also converting the file to an actual properties file so that it will
> handle special characters properly.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java
>  7bda9481275d3801e347ae6dfd66520e3f123a3a 
>   geode-old-versions/build.gradle a09b2d71c4ae9ab393b2d6e9cd44d94155e760f9 
> 
> Diff: https://reviews.apache.org/r/56348/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>



Re: Feb 2017 Board Report DRAFT FOR REVIEW (need your input on Tuesday 2/7 if possible)

2017-02-07 Thread Udo Kohlmeyer

stop being so picky... be happy he mentioned you :P


On 2/7/17 10:30, Jared Stewart wrote:

One more minor edit:

"Jared Steward" => “Jared Stewart”


On Feb 7, 2017, at 10:27 AM, Anilkumar Gingade  wrote:

Looks good...

-Anil.


On Mon, Feb 6, 2017 at 5:38 PM, Dan Smith  wrote:


Looks good! A couple of minor edits:

"open dev list" => "dev list"
"commmitters" => "committers"

-Dan

On Mon, Feb 6, 2017 at 5:19 PM, Dave Barnes  wrote:


Please review and comment by COB Tuesday, 2/7/2017, as the report is due

on

Wednesday. Thanks!

## Description:

- Apache Geode provides a database-like consistency model, reliable
   transaction processing and a shared-nothing architecture to maintain
   very low latency performance with high concurrency processing.

## Issues:

- There are no issues requiring board attention at this time.

## Activity:

- Geode was promoted to TLP status in the November 2016 board meeting.
Since that time:
   -  A new TLP repo was created and populated
   -  Work on the first TLP-level release has been underway.
- Release candidate 2 for Version 1.1.0 is nearly complete; voting will
likely begin before the upcoming board meeting.
The release addresses 252 JIRA tickets. For a complete list, please see

the

[Geode Release Notes](
https://issues.apache.org/jira/secure/ReleaseNote.jspa?
projectId=12318420=12338352
).
- A new code contribution is in progress for C++ and C# native clients

and

their accompanying documentation. After a lively discussion on the open

dev

list, it was decided to create a separate Git repo to house this code.

## Health report:

- Mailing lists remain active and productive.
- JIRA tickets show that issues continue to be identified and resolved.
- We’re continuing to work on attracting new contributors and making it
easier to participate in the community.

## PMC changes:
- Currently 32 PMC members.
- New PMC members:
- Kevin Duling was added to the PMC on Wed Jan 18 2017
- Ken Howe was added to the PMC on Wed Jan 18 2017

## Committer base changes:

- Currently 77 committers. New commmitters:
- Kevin Duling was added as a committer on Sat Jan 14 2017
- Jared Steward was added as a committer on Mon Feb 6 2017

## Releases:

- Last release was 1.0.0-incubating issued on October 25, 2016.
- Version 1.1.0 is imminent. See "Activity," above.

## Mailing list activity:

Following an initial ramp-up in subscriber ship corresponding to TLP
acceptance, mailing lists have remained active and have maintained
consistent usage levels.

- dev@geode.apache.org:
- 155 subscribers (down -4 in the last 3 months):
- 4562 emails sent to list (1761 in previous quarter)

- iss...@geode.apache.org:
- 56 subscribers (up 1 in the last 3 months):
- 1042 emails sent to list (3050 in previous quarter)

- u...@geode.apache.org:
- 206 subscribers (up 12 in the last 3 months):
- 306 emails sent to list (149 in previous quarter)

## JIRA activity:
- 344 JIRA tickets created in the last 3 months
- 278 JIRA tickets closed/resolved in the last 3 months





[jira] [Closed] (GEODE-1672) When amount of overflowed persisted data exceeds heap size startup may run out of memory

2017-02-07 Thread Anilkumar Gingade (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-1672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anilkumar Gingade closed GEODE-1672.


> When amount of overflowed persisted data exceeds heap size startup may run 
> out of memory
> 
>
> Key: GEODE-1672
> URL: https://issues.apache.org/jira/browse/GEODE-1672
> Project: Geode
>  Issue Type: Bug
>  Components: docs, persistence
>Reporter: Darrel Schneider
>Assignee: Anilkumar Gingade
> Fix For: 1.2.0
>
>
> Basically, when the amount of data overflowed approaches the heap size, ,such 
> that the total amount of data is very close to or actually surpasses your 
> total tenured heap, it is possible that you will not be able to restart.
> The algorithm during recovery of oplogs/buckets is such that we don't "evict" 
> in the normal sense as data fills the heap during early stages of recovery 
> prior to creating the regions. When the data is first created in the heap, 
> it's not yet official in the region.
> At any rate, if during this early phase of recovery, or during subsequent 
> phase where eviction is working as usual, it is possible that the total data 
> or an early imbalance of buckets prior to the opportunity to rebalance causes 
> us to surpass the critical threshold which will kill us before successful 
> startup.
> To reproduce, you could have 1 region with tons of data that evicts and 
> overflows with persistence. Call it R1. Then another region with persistence 
> that does not evict. Call it R2.
> List R1 fist in the cache.xml file. Start running the system and add data 
> over time until you have overflowed tons of data approaching the heap size in 
> the evicted region, and also have enough data in the R2 region.
> Once you fill these regions with enough data and have overflowed enough to 
> disk and persisted the other region, then shutdown, and then attempt to 
> restart. If you put enough data in, you will hit the critical threshold 
> before being able to complete startup.
> You can work around this issue by configuring geode to not recovery values by 
> setting this system property: -Dgemfire.disk.recoverValues=false
> Values will not be faulted into memory until a read operation is done on that 
> value's key.
> If you have regions that do not use overflow and some that do then another 
> work around is the create the regions that do not use overflow first. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2411) Remove references to Gemfire from include guards

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856663#comment-15856663
 ] 

ASF GitHub Bot commented on GEODE-2411:
---

Github user echobravopapa commented on the issue:

https://github.com/apache/geode/pull/387
  
+1 ready for merging.


> Remove references to Gemfire from include guards
> 
>
> Key: GEODE-2411
> URL: https://issues.apache.org/jira/browse/GEODE-2411
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> Many of the macro definitions used as include guards in the C++ header files 
> refer to Gemfire. These references should be replaced at least with 
> references to Geode but preferably using pragmas instead of defines.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-07 Thread Bruce Schuchardt


> On Feb. 7, 2017, 1:45 a.m., Mark Bretl wrote:
> > geode-old-versions/build.gradle, line 63
> > 
> >
> > Clarifying question: Should this be associated with 'test' sources or 
> > is 'main' so the tests may use it?
> 
> Dan Smith wrote:
> I was thinking that at some point in the future we might want to get this 
> file from the classpath, rather than what the code is doing now where it's 
> poking around on the filesystem.
> 
> Things in main will be added to the classpath of another project when you 
> declare a dependency on this project, eg testComplile 
> project('geode-old-versions'). Things in test generally aren't, unless you 
> jump through some hoops.

If this would allow the VersionManager code to find the file on its classpath 
I'd really like to make that change.  Jenkins seems to be causing problems with 
the current "poking around" method of trying to find the file.


- Bruce


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56348/#review164448
---


On Feb. 7, 2017, 12:53 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56348/
> ---
> 
> (Updated Feb. 7, 2017, 12:53 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Mark Bretl.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The geode-old-versions/build.gradle was generating the classpath
> properties file during the build configuration phase, rather than the
> execution phase.
> 
> Also converting the file to an actual properties file so that it will
> handle special characters properly.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java
>  7bda9481275d3801e347ae6dfd66520e3f123a3a 
>   geode-old-versions/build.gradle a09b2d71c4ae9ab393b2d6e9cd44d94155e760f9 
> 
> Diff: https://reviews.apache.org/r/56348/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>



[jira] [Commented] (GEODE-2433) Backwards compatibility tests are not actually running

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856585#comment-15856585
 ] 

ASF subversion and git services commented on GEODE-2433:


Commit c8d10ec6440a3030a5da8c3022fb16fa2809150d in geode's branch 
refs/heads/release/1.1.0 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c8d10ec ]

GEODE-2433  Backwards compatibility tests are not actually running

Show current working directory if unable to run backward compatibility
tests.  For some reason we aren't finding the classpaths file when running
under Jenkins.


> Backwards compatibility tests are not actually running
> --
>
> Key: GEODE-2433
> URL: https://issues.apache.org/jira/browse/GEODE-2433
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Dan Smith
>Assignee: Bruce Schuchardt
> Fix For: 1.1.0
>
>
> We have several backwards compatibility tests checked in -
> RollingUpgradeDUnitTest
> RollingUpgrade2DUnitTest
> ClientServerMiscBCDUnitTest
> These tests are all parametered by the list of old versions to run against.
> However, it looks like the code to get the list of old versions incorrectly 
> just logs a message and continues on if it can't find a file called 
> geodeOldVersionClasspaths.txt. That file does not exist and is not being 
> generated as far is I can tell. The entire project - geode-old-versions, is 
> completely empty.
> The net effect is these tests don't actually run, because the list of 
> parameters is an empty list.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2403) CI Failure: LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856569#comment-15856569
 ] 

ASF subversion and git services commented on GEODE-2403:


Commit 80f8c26e13c0db8251e9384d58cc1e6a13b83e1b in geode's branch 
refs/heads/feature/GEODE-2267 from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=80f8c26 ]

GEODE-2403: Increment query executed stats before lastResult

* The stat for number of queries executed is now incremented before the 
lastResult call.
* Before, this was called in the finally block. This resulted in the 
increment even if there was a exception.


> CI Failure: 
> LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats
> ---
>
> Key: GEODE-2403
> URL: https://issues.apache.org/jira/browse/GEODE-2403
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Dan Smith
> Fix For: 1.2.0
>
>
> Failed with b529568dcd15b664a108d2cee5c783cb6b6ef79f
> {noformat}
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > 
> listIndexWithStatsShouldReturnCorrectStats FAILED
> java.lang.AssertionError: expected:<[1]> but was:<[2]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats(LuceneIndexCommandsDUnitTest.java:151)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2430) Remove binary files from test resources

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856570#comment-15856570
 ] 

ASF subversion and git services commented on GEODE-2430:


Commit 584df7722617b5b80e5ca042098325492da57290 in geode's branch 
refs/heads/feature/GEODE-2267 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=584df77 ]

GEODE-2430: Fix failing tests


> Remove binary files from test resources
> ---
>
> Key: GEODE-2430
> URL: https://issues.apache.org/jira/browse/GEODE-2430
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> We have some tests which rely on the following binary files:
> {code}
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group1.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group2.jar
> {code}
> We need to convert our tests to generate these files dynamically instead so 
> that we don't have binary files checked into our repository.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2314) Assert failure in LuceneQueriesPeerPRRedundancyDUnitTest returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856568#comment-15856568
 ] 

ASF subversion and git services commented on GEODE-2314:


Commit 5efe89b90e05b3a92afc627adfa9ba7ada485395 in geode's branch 
refs/heads/feature/GEODE-2267 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5efe89b ]

GEODE-2314: EOF file segment exceptions due to empty file

 * We will occasionally see EOF exceptions due to file segments being empty
 * This diff also reinstates the query retry
 * Added a few null checks
 * Added additional logging for exceptional cases


> Assert failure in LuceneQueriesPeerPRRedundancyDUnitTest 
> returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate 
> 
>
> Key: GEODE-2314
> URL: https://issues.apache.org/jira/browse/GEODE-2314
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: nabarun
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> Running the test until failure results in an assert failure
> {noformat}
> [vm_1][warn 2017/01/16 21:20:21.778 PST  GatewaySender_AsyncEventQueue_index#_region_2> tid=0xd30] An Exception 
> occurred. The dispatcher will continue.
> [vm_1]org.apache.geode.InternalGemFireError: Unable to create index repository
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.lambda$getRepository$0(AbstractPartitionedRepositoryManager.java:114)
> [vm_1]at 
> java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1853)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.getRepository(AbstractPartitionedRepositoryManager.java:103)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.getRepository(AbstractPartitionedRepositoryManager.java:68)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.LuceneEventListener.processEvents(LuceneEventListener.java:69)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:154)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:80)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.processQueue(AbstractGatewaySenderEventProcessor.java:597)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.run(AbstractGatewaySenderEventProcessor.java:1040)
> [vm_1]Caused by: java.io.EOFException: Read past end of file segments_1
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.directory.FileIndexInput.readByte(FileIndexInput.java:97)
> [vm_1]at 
> org.apache.lucene.store.BufferedChecksumIndexInput.readByte(BufferedChecksumIndexInput.java:41)
> [vm_1]at org.apache.lucene.store.DataInput.readInt(DataInput.java:101)
> [vm_1]at 
> org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:293)
> [vm_1]at 
> org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:284)
> [vm_1]at 
> org.apache.lucene.index.IndexWriter.(IndexWriter.java:910)
> …
> [vm_1]... 8 more
> {noformat}
> {noformat}
> java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertTrue(Assert.java:52)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.putEntriesAndValidateQueryResults(LuceneQueriesPRBase.java:148)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate(LuceneQueriesPRBase.java:68)
>   at sun.reflect.GeneratedMethodAccessor9.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at 

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856566#comment-15856566
 ] 

ASF subversion and git services commented on GEODE-2103:


Commit 1d5ae68ef07fa2c7f4298b91be9f02bea5fc8110 in geode's branch 
refs/heads/feature/GEODE-2267 from [~deepakddixit]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1d5ae68 ]

GEODE-2103: start locator command should include --http-service-port and 
--http-service-bind-address

* Adding --http-service-port and --http-service-bind-address parameters to 
start locator command
* Added Junit test to verify command line parameters
* Fixing HelpCommandsIntegrationTest
* this closes #326


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Deepak Dixit
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2434) geodeOldVersionClasspaths.txt is generated every time build is parsed

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856567#comment-15856567
 ] 

ASF subversion and git services commented on GEODE-2434:


Commit 77c1c6e1d9aa0afa4a9c86e82c56c782365888c4 in geode's branch 
refs/heads/feature/GEODE-2267 from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=77c1c6e ]

GEODE-2434: Generate old version classpaths in doLast

The geode-old-versions/build.gradle was generating the classpath
properties file during the build configuration phase, rather than the
execution phase.

Also converting the file to an actual properties file so that it will
handle special characters properly.


> geodeOldVersionClasspaths.txt is generated every time build is parsed
> -
>
> Key: GEODE-2434
> URL: https://issues.apache.org/jira/browse/GEODE-2434
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Dan Smith
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
> geode-old-versions/build.gradle regenerates geodeOldVersionClasspaths.txt 
> during the configuration phase of the task createGeodeClasspathsFile. This is 
> a performance issue with the build because every time someone types ./gradlew 
> it will regenerate this file while configuring the build.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2381) Make enums not get so mangled by Spotless

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856565#comment-15856565
 ] 

ASF subversion and git services commented on GEODE-2381:


Commit 2df3063f69b8e0a444896950003b344df4410826 in geode's branch 
refs/heads/feature/GEODE-2267 from [~gosullivan]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=2df3063 ]

[GEODE-2381] spotless: line break on enum constants.

* Change the style XML file to insert a line break after each constant
  of an enum.
* This commit is just the style file change; spotless will be applied
  next.
* Apply spotless to fix enums and nothing else in this commit.

There may be a better way to do this and allow simple enums to be all on
one line, but this looks better to me.

This closes #368


> Make enums not get so mangled by Spotless
> -
>
> Key: GEODE-2381
> URL: https://issues.apache.org/jira/browse/GEODE-2381
> Project: Geode
>  Issue Type: Bug
>Reporter: Galen O'Sullivan
>
> Perhaps the worst example is in {{CacheXMLVersion}}:
> {code}
> GEMFIRE_3_0(CacheXml.VERSION_3_0, CacheXml.PUBLIC_ID_3_0, 
> CacheXml.SYSTEM_ID_3_0, null,
> null), GEMFIRE_4_0(CacheXml.VERSION_4_0, CacheXml.PUBLIC_ID_4_0, 
> CacheXml.SYSTEM_ID_4_0, null,
> null), GEMFIRE_4_1(CacheXml.VERSION_4_1, CacheXml.PUBLIC_ID_4_1, 
> CacheXml.SYSTEM_ID_4_1,
> null, null), GEMFIRE_5_0(CacheXml.VERSION_5_0, 
> CacheXml.PUBLIC_ID_5_0,
> CacheXml.SYSTEM_ID_5_0, null, null), 
> GEMFIRE_5_1(CacheXml.VERSION_5_1,
> CacheXml.PUBLIC_ID_5_1, CacheXml.SYSTEM_ID_5_1, null, 
> null), GEMFIRE_5_5(
> CacheXml.VERSION_5_5, CacheXml.PUBLIC_ID_5_5, 
> CacheXml.SYSTEM_ID_5_5,
> null, null), GEMFIRE_5_7(CacheXml.VERSION_5_7, 
> CacheXml.PUBLIC_ID_5_7,
> CacheXml.SYSTEM_ID_5_7, null, null), 
> GEMFIRE_5_8(CacheXml.VERSION_5_8,
> CacheXml.PUBLIC_ID_5_8, 
> CacheXml.SYSTEM_ID_5_8, null,
> null), GEMFIRE_6_0(CacheXml.VERSION_6_0, 
> CacheXml.PUBLIC_ID_6_0,
> CacheXml.SYSTEM_ID_6_0, null, null), 
> GEMFIRE_6_1(
> CacheXml.VERSION_6_1, 
> CacheXml.PUBLIC_ID_6_1,
> CacheXml.SYSTEM_ID_6_1, null, null), 
> GEMFIRE_6_5(
> CacheXml.VERSION_6_5, 
> CacheXml.PUBLIC_ID_6_5,
> CacheXml.SYSTEM_ID_6_5, null, 
> null), GEMFIRE_6_6(
> CacheXml.VERSION_6_6, 
> CacheXml.PUBLIC_ID_6_6,
> CacheXml.SYSTEM_ID_6_6, null, 
> null), GEMFIRE_7_0(
> CacheXml.VERSION_7_0, 
> CacheXml.PUBLIC_ID_7_0,
> CacheXml.SYSTEM_ID_7_0, 
> null,
> null), 
> GEMFIRE_8_0(CacheXml.VERSION_8_0,
> 
> CacheXml.PUBLIC_ID_8_0,
> 
> CacheXml.SYSTEM_ID_8_0, null,
> null), 
> GEMFIRE_8_1(CacheXml.VERSION_8_1,
> null, null,
> 
> CacheXml.SCHEMA_8_1_LOCATION,
> 
> CacheXml.GEMFIRE_NAMESPACE),
> {code}
> I'd love to just format these one per line. This can be done by changing a 
> single line in the Spotless eclipse formatter xml file (I'll put up a PR in 
> just a minute).
> I'm not sure how attached we are to using {{eclipse-java-google-style.xml}} 
> in the same format as upstream (where did it come from exactly?). I also 
> noticed that Google has [their own 
> tool|https://github.com/google/google-java-format] for formatting text. 
> Probably what we have is fine for now, and this modification will make it 
> better.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2430) Remove binary files from test resources

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856564#comment-15856564
 ] 

ASF subversion and git services commented on GEODE-2430:


Commit e769796c5611f4fad1a21869ddea29853ed1958e in geode's branch 
refs/heads/feature/GEODE-2267 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e769796 ]

GEODE-2430: Remove jar and zip files from test resources

This closes #393


> Remove binary files from test resources
> ---
>
> Key: GEODE-2430
> URL: https://issues.apache.org/jira/browse/GEODE-2430
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> We have some tests which rely on the following binary files:
> {code}
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group1.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group2.jar
> {code}
> We need to convert our tests to generate these files dynamically instead so 
> that we don't have binary files checked into our repository.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2430) Remove binary files from test resources

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856563#comment-15856563
 ] 

ASF subversion and git services commented on GEODE-2430:


Commit 50aebcc859da9c2456ef142ff7ec4c1620c11900 in geode's branch 
refs/heads/feature/GEODE-2267 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=50aebcc ]

GEODE-2430: Refactor ZipUtils


> Remove binary files from test resources
> ---
>
> Key: GEODE-2430
> URL: https://issues.apache.org/jira/browse/GEODE-2430
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> We have some tests which rely on the following binary files:
> {code}
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group1.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group2.jar
> {code}
> We need to convert our tests to generate these files dynamically instead so 
> that we don't have binary files checked into our repository.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Fix version should be 1.2 for issues fixed on develop

2017-02-07 Thread Dan Smith
Just a reminder that since we've already cut the 1.1.0 release branch,
anything fixed on develop should be marked with a fix version of 1.2.0, not
1.1.0.

-Dan


[jira] [Updated] (GEODE-2403) CI Failure: LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats

2017-02-07 Thread Dan Smith (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith updated GEODE-2403:
-
Fix Version/s: (was: 1.1.0)
   1.2.0

> CI Failure: 
> LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats
> ---
>
> Key: GEODE-2403
> URL: https://issues.apache.org/jira/browse/GEODE-2403
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Dan Smith
> Fix For: 1.2.0
>
>
> Failed with b529568dcd15b664a108d2cee5c783cb6b6ef79f
> {noformat}
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > 
> listIndexWithStatsShouldReturnCorrectStats FAILED
> java.lang.AssertionError: expected:<[1]> but was:<[2]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats(LuceneIndexCommandsDUnitTest.java:151)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-1434) Update native client source headers

2017-02-07 Thread Anthony Baker (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856532#comment-15856532
 ] 

Anthony Baker commented on GEODE-1434:
--

Leaving this open until the 3 files listed above are addressed.

> Update native client source headers
> ---
>
> Key: GEODE-1434
> URL: https://issues.apache.org/jira/browse/GEODE-1434
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Anthony Baker
>Assignee: Anthony Baker
> Attachments: rat.out.gz
>
>
> The existing native client source code headers contain { pivotal | vmware | 
> gemstone } copyrights and should be replaced with ASF headers.  See 
> https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors.
> Files without a source header probably need the ASF header added.  Only in 
> exceptional circumstances should a file not have a source header.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Review Request 56396: Refactor test rules

2017-02-07 Thread Jared Stewart

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56396/#review164537
---


Ship it!




I think before() and after() in GfshShellConnectionRule probably ought to have 
@Override annotations, otherwise ship it!

- Jared Stewart


On Feb. 7, 2017, 5:28 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56396/
> ---
> 
> (Updated Feb. 7, 2017, 5:28 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk 
> Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * Refactor GfshShellConnectorRule so that it's easier to use it either as a 
> rule or classRule
> * Refactor LocatorServerStartupRule so that tests using it do not need to 
> extend from Junit4DUnitTest and can be used as a class rule.
> * add NetstatDUnitTest
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java
>  28d50da61669746145c143d33947da6b8564ca9d 
>   
> geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
>  9d678e1a8bd419e66e9dd79e8f7db5dbeeb0890b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java
>  3a3c74cd9d10b617a12c38c1fdd500ebe83a5707 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java
>  79f0128ecb87b7e1334f35cb4c0c703cd07af544 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDistributionDUnitTest.java
>  f362d4c679d391b50b9ce297d8e31ba9887024e1 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
>  f68015e5e4f70c91e3329a53134562b128745fd7 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
>  388fd9d40ccae21d58ea966e4c9c9fd71c46e873 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java
>  ac3d1dee3a76e2fa884f826291f88ccbd05d10fa 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
>  dbbe0dbc5dd04e06e4876ebcb15ece1cb018d56d 
>   
> geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
>  fe37f9e2becb46c448a97fa2ac4ed7a9548ff4f9 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
>  a7752aeb90da46071aa1ded17ef32c36f8b6208b 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerSecurityWithEmbeddedLocatorDUnitTest.java
>  66c5be6de9c33226f3ad4d93e9c16dcfbe674c1e 
>   
> geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java
>  ca209a73b247cd422b93864e7de841620140f996 
>   
> geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java
>  72654cb868f8a62212825eba72aa4fdf8bc7e39e 
>   
> geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java
>  24d0db5c123c221b9cff59ef7d91b3d6d2d9b3eb 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  49c141413909b1b31e9d148576832bbf788878eb 
>   geode-core/src/test/java/org/apache/geode/test/dunit/rules/Locator.java 
> 0350ffd06d09dfa742033baf0fb1c2afff1ee158 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  ac9221cab6ec9a56f269ac90f881049e0ef770de 
>   geode-core/src/test/java/org/apache/geode/test/dunit/rules/Member.java 
> 129fe681c918a15f0927846fb19c469a0ac683a7 
>   geode-core/src/test/java/org/apache/geode/test/dunit/rules/Server.java 
> bc4c5d614caa0d1555e84fc483af3fa74f9e52ef 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
>  0b0e936652444f0171e37fa52653f5a4e9a63c87 
> 
> Diff: https://reviews.apache.org/r/56396/diff/
> 
> 
> Testing
> ---
> 
> precheckin pending
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



[jira] [Resolved] (GEODE-2403) CI Failure: LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats

2017-02-07 Thread nabarun (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun resolved GEODE-2403.

   Resolution: Fixed
Fix Version/s: 1.1.0

> CI Failure: 
> LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats
> ---
>
> Key: GEODE-2403
> URL: https://issues.apache.org/jira/browse/GEODE-2403
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Dan Smith
> Fix For: 1.1.0
>
>
> Failed with b529568dcd15b664a108d2cee5c783cb6b6ef79f
> {noformat}
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > 
> listIndexWithStatsShouldReturnCorrectStats FAILED
> java.lang.AssertionError: expected:<[1]> but was:<[2]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats(LuceneIndexCommandsDUnitTest.java:151)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2403) CI Failure: LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856520#comment-15856520
 ] 

ASF subversion and git services commented on GEODE-2403:


Commit 80f8c26e13c0db8251e9384d58cc1e6a13b83e1b in geode's branch 
refs/heads/develop from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=80f8c26 ]

GEODE-2403: Increment query executed stats before lastResult

* The stat for number of queries executed is now incremented before the 
lastResult call.
* Before, this was called in the finally block. This resulted in the 
increment even if there was a exception.


> CI Failure: 
> LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats
> ---
>
> Key: GEODE-2403
> URL: https://issues.apache.org/jira/browse/GEODE-2403
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Dan Smith
>
> Failed with b529568dcd15b664a108d2cee5c783cb6b6ef79f
> {noformat}
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > 
> listIndexWithStatsShouldReturnCorrectStats FAILED
> java.lang.AssertionError: expected:<[1]> but was:<[2]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest.listIndexWithStatsShouldReturnCorrectStats(LuceneIndexCommandsDUnitTest.java:151)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2430) Remove binary files from test resources

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856517#comment-15856517
 ] 

ASF GitHub Bot commented on GEODE-2430:
---

Github user kjduling commented on the issue:

https://github.com/apache/geode/pull/395
  
+1


> Remove binary files from test resources
> ---
>
> Key: GEODE-2430
> URL: https://issues.apache.org/jira/browse/GEODE-2430
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> We have some tests which rely on the following binary files:
> {code}
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group1.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group2.jar
> {code}
> We need to convert our tests to generate these files dynamically instead so 
> that we don't have binary files checked into our repository.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] geode issue #395: GEODE-2430: Fix failing tests

2017-02-07 Thread kjduling
Github user kjduling commented on the issue:

https://github.com/apache/geode/pull/395
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Review Request 56399: GEODE-2403: Number of queries executed stat is incremented before making the lastResult call

2017-02-07 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56399/#review164536
---


Ship it!




Does the queryExecutionTotalHitsId also need to be treated this way?

- Dan Smith


On Feb. 7, 2017, 6:31 p.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56399/
> ---
> 
> (Updated Feb. 7, 2017, 6:31 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, Lynn Hughes-Godfrey, 
> Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Issue:
> ==
> * Initially, the endQuery call in the finally block was responsible for 
> incrementing the queries executed stat.
> * Even if there was an exception, the stat was incremented because of the 
> finally block.
> * In case of retries during bucket not found exception, the number of queries 
> executed keeps increasing.
> * This results in tests failures where it is expecting one query to be 
> executed but finds multiple entries.
> 
> 
> Solution:
> =
> * The queries executed stat is not incremented in the finally block.
> * It is incremented just before the lastResult calll.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexStats.java
>  a914799 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java
>  fd908de 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexStatsJUnitTest.java
>  f9e200a 
> 
> Diff: https://reviews.apache.org/r/56399/diff/
> 
> 
> Testing
> ---
> 
> geode-lucene:precheckin passed
> 
> 
> Thanks,
> 
> nabarun nag
> 
>



Discrepancies in dev mailing list archives?

2017-02-07 Thread Dave Barnes
There are two archives for the dev@geode.apache.org mailing list. Has
anyone else noticed that they differ? When I was searching for status
report material, there were some messages that turned up only in one of the
two archives.

Apache archive: http://mail-archives.apache.org/mod_mbox/geode-dev/

Apache archive, Pony Mail:
https://lists.apache.org/list.html?dev@geode.apache.org

I'm not sure who maintains these things, so for now this is just a heads-up
that if you're looking for something, you might want to try both archives.


Re: Feb 2017 Board Report DRAFT FOR REVIEW (need your input on Tuesday 2/7 if possible)

2017-02-07 Thread Anilkumar Gingade
Looks good...

-Anil.


On Mon, Feb 6, 2017 at 5:38 PM, Dan Smith  wrote:

> Looks good! A couple of minor edits:
>
> "open dev list" => "dev list"
> "commmitters" => "committers"
>
> -Dan
>
> On Mon, Feb 6, 2017 at 5:19 PM, Dave Barnes  wrote:
>
> > Please review and comment by COB Tuesday, 2/7/2017, as the report is due
> on
> > Wednesday. Thanks!
> >
> > ## Description:
> >
> >  - Apache Geode provides a database-like consistency model, reliable
> >transaction processing and a shared-nothing architecture to maintain
> >very low latency performance with high concurrency processing.
> >
> > ## Issues:
> >
> >  - There are no issues requiring board attention at this time.
> >
> > ## Activity:
> >
> >  - Geode was promoted to TLP status in the November 2016 board meeting.
> > Since that time:
> >-  A new TLP repo was created and populated
> >-  Work on the first TLP-level release has been underway.
> >  - Release candidate 2 for Version 1.1.0 is nearly complete; voting will
> > likely begin before the upcoming board meeting.
> > The release addresses 252 JIRA tickets. For a complete list, please see
> the
> > [Geode Release Notes](
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12318420=12338352
> > ).
> >  - A new code contribution is in progress for C++ and C# native clients
> and
> > their accompanying documentation. After a lively discussion on the open
> dev
> > list, it was decided to create a separate Git repo to house this code.
> >
> > ## Health report:
> >
> >  - Mailing lists remain active and productive.
> >  - JIRA tickets show that issues continue to be identified and resolved.
> >  - We’re continuing to work on attracting new contributors and making it
> > easier to participate in the community.
> >
> > ## PMC changes:
> >  - Currently 32 PMC members.
> >  - New PMC members:
> > - Kevin Duling was added to the PMC on Wed Jan 18 2017
> > - Ken Howe was added to the PMC on Wed Jan 18 2017
> >
> > ## Committer base changes:
> >
> > - Currently 77 committers. New commmitters:
> > - Kevin Duling was added as a committer on Sat Jan 14 2017
> > - Jared Steward was added as a committer on Mon Feb 6 2017
> >
> > ## Releases:
> >
> >  - Last release was 1.0.0-incubating issued on October 25, 2016.
> >  - Version 1.1.0 is imminent. See "Activity," above.
> >
> > ## Mailing list activity:
> >
> > Following an initial ramp-up in subscriber ship corresponding to TLP
> > acceptance, mailing lists have remained active and have maintained
> > consistent usage levels.
> >
> >  - dev@geode.apache.org:
> > - 155 subscribers (down -4 in the last 3 months):
> > - 4562 emails sent to list (1761 in previous quarter)
> >
> >  - iss...@geode.apache.org:
> > - 56 subscribers (up 1 in the last 3 months):
> > - 1042 emails sent to list (3050 in previous quarter)
> >
> >  - u...@geode.apache.org:
> > - 206 subscribers (up 12 in the last 3 months):
> > - 306 emails sent to list (149 in previous quarter)
> >
> > ## JIRA activity:
> >  - 344 JIRA tickets created in the last 3 months
> >  - 278 JIRA tickets closed/resolved in the last 3 months
> >
>


Re: Review Request 56398: use function to implement waitUntilFlushed

2017-02-07 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56398/#review164531
---


Ship it!




Awesome!

- Dan Smith


On Feb. 7, 2017, 6:10 p.m., xiaojian zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56398/
> ---
> 
> (Updated Feb. 7, 2017, 6:10 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: geode-2400
> https://issues.apache.org/jira/browse/geode-2400
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> 1) move the waitUntilFlushed from LuceneIndex into LuceneService.
> 2) use function
> 3) handle cacheClosedException
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/DSFIDFactory.java 
> bb29239 
>   
> geode-core/src/main/java/org/apache/geode/internal/DataSerializableFixedID.java
>  84eb8e9 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java
>  1f8704c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/WaitUntilParallelGatewaySenderFlushedCoordinator.java
>  a4c03a9 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest.java
>  c8b8ba1 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java 
> 802b21a 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java 
> 0ff5f0e 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
>  8d24a83 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
>  70061eb 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunctionContext.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/xml/LuceneIndexCreation.java
>  030 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
>  e6c4503 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesBase.java
>  a56fff7 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
>  d11ea91 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
>  c877f93 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java
>  5ec09f1 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexImplJUnitTest.java
>  aaa6dbd 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java
>  d194081 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneServiceImplJUnitTest.java
>  1815663 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsDUnitTest.java
>  2bb5b4b 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
>  5c47e13 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/IndexRepositorySpy.java
>  d363903 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
>  9f062bb 
> 
> Diff: https://reviews.apache.org/r/56398/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>



[jira] [Commented] (GEODE-2437) Integrate native client with travis-ci

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856462#comment-15856462
 ] 

ASF GitHub Bot commented on GEODE-2437:
---

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99889754
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
+  - sudo apt-get install -y cmake
+  - sudo apt-get install -y doxygen
+  - sudo apt-get install -y git
+  - sudo apt-get install -y openjdk-8-jdk
+  - sudo apt-get install -y wget
+  - sudo apt-get install -y zlib1g-dev
+
+install: mkdir build && cd build && cmake ../src && cmake --build . -- -j 8
--- End diff --

It is needed to build the javaobject(s)...


> Integrate native client with travis-ci
> --
>
> Key: GEODE-2437
> URL: https://issues.apache.org/jira/browse/GEODE-2437
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Anthony Baker
>
> We should integrate the native client branch with travis-ci so we can tell if 
> PR's  or other code changes are good.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99889754
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
+  - sudo apt-get install -y cmake
+  - sudo apt-get install -y doxygen
+  - sudo apt-get install -y git
+  - sudo apt-get install -y openjdk-8-jdk
+  - sudo apt-get install -y wget
+  - sudo apt-get install -y zlib1g-dev
+
+install: mkdir build && cd build && cmake ../src && cmake --build . -- -j 8
--- End diff --

It is needed to build the javaobject(s)...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (GEODE-2314) Assert failure in LuceneQueriesPeerPRRedundancyDUnitTest returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate

2017-02-07 Thread Jason Huynh (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856445#comment-15856445
 ] 

Jason Huynh commented on GEODE-2314:


Our rename method was writing an empty file and replacing it after the contents 
were copied over.  Instead we will copy the file contents and do a put if 
absent.

This is related to  GEODE-2367 in that it would only have been noticed in HA 
scenarios

> Assert failure in LuceneQueriesPeerPRRedundancyDUnitTest 
> returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate 
> 
>
> Key: GEODE-2314
> URL: https://issues.apache.org/jira/browse/GEODE-2314
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: nabarun
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> Running the test until failure results in an assert failure
> {noformat}
> [vm_1][warn 2017/01/16 21:20:21.778 PST  GatewaySender_AsyncEventQueue_index#_region_2> tid=0xd30] An Exception 
> occurred. The dispatcher will continue.
> [vm_1]org.apache.geode.InternalGemFireError: Unable to create index repository
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.lambda$getRepository$0(AbstractPartitionedRepositoryManager.java:114)
> [vm_1]at 
> java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1853)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.getRepository(AbstractPartitionedRepositoryManager.java:103)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.getRepository(AbstractPartitionedRepositoryManager.java:68)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.LuceneEventListener.processEvents(LuceneEventListener.java:69)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:154)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:80)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.processQueue(AbstractGatewaySenderEventProcessor.java:597)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.run(AbstractGatewaySenderEventProcessor.java:1040)
> [vm_1]Caused by: java.io.EOFException: Read past end of file segments_1
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.directory.FileIndexInput.readByte(FileIndexInput.java:97)
> [vm_1]at 
> org.apache.lucene.store.BufferedChecksumIndexInput.readByte(BufferedChecksumIndexInput.java:41)
> [vm_1]at org.apache.lucene.store.DataInput.readInt(DataInput.java:101)
> [vm_1]at 
> org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:293)
> [vm_1]at 
> org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:284)
> [vm_1]at 
> org.apache.lucene.index.IndexWriter.(IndexWriter.java:910)
> …
> [vm_1]... 8 more
> {noformat}
> {noformat}
> java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertTrue(Assert.java:52)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.putEntriesAndValidateQueryResults(LuceneQueriesPRBase.java:148)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate(LuceneQueriesPRBase.java:68)
>   at sun.reflect.GeneratedMethodAccessor9.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> 

[jira] [Assigned] (GEODE-2401) CI Failure: returnCorrectResultsWhenBucketIsMovedAndMovedBackOnIndexUpdate

2017-02-07 Thread Jason Huynh (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reassigned GEODE-2401:
--

Assignee: Jason Huynh

> CI Failure: returnCorrectResultsWhenBucketIsMovedAndMovedBackOnIndexUpdate
> --
>
> Key: GEODE-2401
> URL: https://issues.apache.org/jira/browse/GEODE-2401
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Dan Smith
>Assignee: Jason Huynh
>
> We're seeing this test fail in several subclasses of LuceneQueriesPRBase
> This is with 9cb9c1e997f0c38dfc99caf020aaec2f4c5d067f
> LuceneQueriesPeerFixedPRDUnitTest
> LuceneQueriesPeerPRRedundancyDUnitTest
> {noformat}
> java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertTrue(Assert.java:52)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.putEntriesAndValidateQueryResults(LuceneQueriesPRBase.java:148)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.returnCorrectResultsWhenBucketIsMovedAndMovedBackOnIndexUpdate(LuceneQueriesPRBase.java:81)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> 

[GitHub] geode issue #395: GEODE-2430: Fix failing tests

2017-02-07 Thread jaredjstewart
Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/395
  
Precheckin started


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Review Request 56398: use function to implement waitUntilFlushed

2017-02-07 Thread xiaojian zhou

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56398/
---

Review request for geode and Dan Smith.


Bugs: geode-2400
https://issues.apache.org/jira/browse/geode-2400


Repository: geode


Description
---

1) move the waitUntilFlushed from LuceneIndex into LuceneService.
2) use function
3) handle cacheClosedException


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/DSFIDFactory.java bb29239 
  
geode-core/src/main/java/org/apache/geode/internal/DataSerializableFixedID.java 
84eb8e9 
  
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java
 1f8704c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/WaitUntilParallelGatewaySenderFlushedCoordinator.java
 a4c03a9 
  
geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest.java
 c8b8ba1 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java 
802b21a 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java 
0ff5f0e 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
 8d24a83 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
 70061eb 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
 PRE-CREATION 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunctionContext.java
 PRE-CREATION 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/xml/LuceneIndexCreation.java
 030 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
 e6c4503 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesBase.java 
a56fff7 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
 d11ea91 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
 c877f93 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java
 5ec09f1 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexImplJUnitTest.java
 aaa6dbd 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java
 d194081 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneServiceImplJUnitTest.java
 1815663 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsDUnitTest.java
 2bb5b4b 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
 5c47e13 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/IndexRepositorySpy.java
 d363903 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
 9f062bb 

Diff: https://reviews.apache.org/r/56398/diff/


Testing
---


Thanks,

xiaojian zhou



[jira] [Commented] (GEODE-2430) Remove binary files from test resources

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856446#comment-15856446
 ] 

ASF GitHub Bot commented on GEODE-2430:
---

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/395
  
Precheckin started


> Remove binary files from test resources
> ---
>
> Key: GEODE-2430
> URL: https://issues.apache.org/jira/browse/GEODE-2430
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> We have some tests which rely on the following binary files:
> {code}
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group1.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group2.jar
> {code}
> We need to convert our tests to generate these files dynamically instead so 
> that we don't have binary files checked into our repository.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (GEODE-2314) Assert failure in LuceneQueriesPeerPRRedundancyDUnitTest returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate

2017-02-07 Thread Jason Huynh (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh resolved GEODE-2314.

Resolution: Fixed

> Assert failure in LuceneQueriesPeerPRRedundancyDUnitTest 
> returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate 
> 
>
> Key: GEODE-2314
> URL: https://issues.apache.org/jira/browse/GEODE-2314
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: nabarun
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> Running the test until failure results in an assert failure
> {noformat}
> [vm_1][warn 2017/01/16 21:20:21.778 PST  GatewaySender_AsyncEventQueue_index#_region_2> tid=0xd30] An Exception 
> occurred. The dispatcher will continue.
> [vm_1]org.apache.geode.InternalGemFireError: Unable to create index repository
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.lambda$getRepository$0(AbstractPartitionedRepositoryManager.java:114)
> [vm_1]at 
> java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1853)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.getRepository(AbstractPartitionedRepositoryManager.java:103)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.getRepository(AbstractPartitionedRepositoryManager.java:68)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.LuceneEventListener.processEvents(LuceneEventListener.java:69)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:154)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:80)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.processQueue(AbstractGatewaySenderEventProcessor.java:597)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.run(AbstractGatewaySenderEventProcessor.java:1040)
> [vm_1]Caused by: java.io.EOFException: Read past end of file segments_1
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.directory.FileIndexInput.readByte(FileIndexInput.java:97)
> [vm_1]at 
> org.apache.lucene.store.BufferedChecksumIndexInput.readByte(BufferedChecksumIndexInput.java:41)
> [vm_1]at org.apache.lucene.store.DataInput.readInt(DataInput.java:101)
> [vm_1]at 
> org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:293)
> [vm_1]at 
> org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:284)
> [vm_1]at 
> org.apache.lucene.index.IndexWriter.(IndexWriter.java:910)
> …
> [vm_1]... 8 more
> {noformat}
> {noformat}
> java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertTrue(Assert.java:52)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.putEntriesAndValidateQueryResults(LuceneQueriesPRBase.java:148)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate(LuceneQueriesPRBase.java:68)
>   at sun.reflect.GeneratedMethodAccessor9.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at 

[jira] [Updated] (GEODE-2314) Assert failure in LuceneQueriesPeerPRRedundancyDUnitTest returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate

2017-02-07 Thread Jason Huynh (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-2314:
---
Affects Version/s: 1.1.0
   1.0.0-incubating
Fix Version/s: 1.2.0

> Assert failure in LuceneQueriesPeerPRRedundancyDUnitTest 
> returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate 
> 
>
> Key: GEODE-2314
> URL: https://issues.apache.org/jira/browse/GEODE-2314
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: nabarun
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> Running the test until failure results in an assert failure
> {noformat}
> [vm_1][warn 2017/01/16 21:20:21.778 PST  GatewaySender_AsyncEventQueue_index#_region_2> tid=0xd30] An Exception 
> occurred. The dispatcher will continue.
> [vm_1]org.apache.geode.InternalGemFireError: Unable to create index repository
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.lambda$getRepository$0(AbstractPartitionedRepositoryManager.java:114)
> [vm_1]at 
> java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1853)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.getRepository(AbstractPartitionedRepositoryManager.java:103)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.getRepository(AbstractPartitionedRepositoryManager.java:68)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.LuceneEventListener.processEvents(LuceneEventListener.java:69)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:154)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:80)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.processQueue(AbstractGatewaySenderEventProcessor.java:597)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.run(AbstractGatewaySenderEventProcessor.java:1040)
> [vm_1]Caused by: java.io.EOFException: Read past end of file segments_1
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.directory.FileIndexInput.readByte(FileIndexInput.java:97)
> [vm_1]at 
> org.apache.lucene.store.BufferedChecksumIndexInput.readByte(BufferedChecksumIndexInput.java:41)
> [vm_1]at org.apache.lucene.store.DataInput.readInt(DataInput.java:101)
> [vm_1]at 
> org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:293)
> [vm_1]at 
> org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:284)
> [vm_1]at 
> org.apache.lucene.index.IndexWriter.(IndexWriter.java:910)
> …
> [vm_1]... 8 more
> {noformat}
> {noformat}
> java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertTrue(Assert.java:52)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.putEntriesAndValidateQueryResults(LuceneQueriesPRBase.java:148)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate(LuceneQueriesPRBase.java:68)
>   at sun.reflect.GeneratedMethodAccessor9.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at 

[jira] [Commented] (GEODE-2430) Remove binary files from test resources

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856435#comment-15856435
 ] 

ASF GitHub Bot commented on GEODE-2430:
---

GitHub user jaredjstewart opened a pull request:

https://github.com/apache/geode/pull/395

GEODE-2430: Fix failing tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaredjstewart/geode GEODE-2430

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #395






> Remove binary files from test resources
> ---
>
> Key: GEODE-2430
> URL: https://issues.apache.org/jira/browse/GEODE-2430
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> We have some tests which rely on the following binary files:
> {code}
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group1.jar
> + 
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group2.jar
> {code}
> We need to convert our tests to generate these files dynamically instead so 
> that we don't have binary files checked into our repository.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] geode pull request #395: GEODE-2430: Fix failing tests

2017-02-07 Thread jaredjstewart
GitHub user jaredjstewart opened a pull request:

https://github.com/apache/geode/pull/395

GEODE-2430: Fix failing tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaredjstewart/geode GEODE-2430

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #395






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #389: GEODE-1434: Add ASF headers

2017-02-07 Thread PivotalSarge
Github user PivotalSarge commented on the issue:

https://github.com/apache/geode/pull/389
  
I pulled this PR, built it on Windows, and ran the quick integration tests. 
This validates that the header addition has not broken the Visual Studio 
project files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (GEODE-2314) Assert failure in LuceneQueriesPeerPRRedundancyDUnitTest returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856416#comment-15856416
 ] 

ASF subversion and git services commented on GEODE-2314:


Commit 5efe89b90e05b3a92afc627adfa9ba7ada485395 in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5efe89b ]

GEODE-2314: EOF file segment exceptions due to empty file

 * We will occasionally see EOF exceptions due to file segments being empty
 * This diff also reinstates the query retry
 * Added a few null checks
 * Added additional logging for exceptional cases


> Assert failure in LuceneQueriesPeerPRRedundancyDUnitTest 
> returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate 
> 
>
> Key: GEODE-2314
> URL: https://issues.apache.org/jira/browse/GEODE-2314
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: Jason Huynh
>
> Running the test until failure results in an assert failure
> {noformat}
> [vm_1][warn 2017/01/16 21:20:21.778 PST  GatewaySender_AsyncEventQueue_index#_region_2> tid=0xd30] An Exception 
> occurred. The dispatcher will continue.
> [vm_1]org.apache.geode.InternalGemFireError: Unable to create index repository
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.lambda$getRepository$0(AbstractPartitionedRepositoryManager.java:114)
> [vm_1]at 
> java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1853)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.getRepository(AbstractPartitionedRepositoryManager.java:103)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.getRepository(AbstractPartitionedRepositoryManager.java:68)
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.LuceneEventListener.processEvents(LuceneEventListener.java:69)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:154)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:80)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.processQueue(AbstractGatewaySenderEventProcessor.java:597)
> [vm_1]at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.run(AbstractGatewaySenderEventProcessor.java:1040)
> [vm_1]Caused by: java.io.EOFException: Read past end of file segments_1
> [vm_1]at 
> org.apache.geode.cache.lucene.internal.directory.FileIndexInput.readByte(FileIndexInput.java:97)
> [vm_1]at 
> org.apache.lucene.store.BufferedChecksumIndexInput.readByte(BufferedChecksumIndexInput.java:41)
> [vm_1]at org.apache.lucene.store.DataInput.readInt(DataInput.java:101)
> [vm_1]at 
> org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:293)
> [vm_1]at 
> org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:284)
> [vm_1]at 
> org.apache.lucene.index.IndexWriter.(IndexWriter.java:910)
> …
> [vm_1]... 8 more
> {noformat}
> {noformat}
> java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertTrue(Assert.java:52)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.putEntriesAndValidateQueryResults(LuceneQueriesPRBase.java:148)
>   at 
> org.apache.geode.cache.lucene.LuceneQueriesPRBase.returnCorrectResultsWhenMoveBucketHappensOnIndexUpdate(LuceneQueriesPRBase.java:68)
>   at sun.reflect.GeneratedMethodAccessor9.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at 

[jira] [Commented] (GEODE-1434) Update native client source headers

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856411#comment-15856411
 ] 

ASF GitHub Bot commented on GEODE-1434:
---

Github user PivotalSarge commented on the issue:

https://github.com/apache/geode/pull/389
  
I pulled this PR, built it on Windows, and ran the quick integration tests. 
This validates that the header addition has not broken the Visual Studio 
project files.


> Update native client source headers
> ---
>
> Key: GEODE-1434
> URL: https://issues.apache.org/jira/browse/GEODE-1434
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Anthony Baker
>Assignee: Anthony Baker
> Attachments: rat.out.gz
>
>
> The existing native client source code headers contain { pivotal | vmware | 
> gemstone } copyrights and should be replaced with ASF headers.  See 
> https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors.
> Files without a source header probably need the ASF header added.  Only in 
> exceptional circumstances should a file not have a source header.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (GEODE-2437) Integrate native client with travis-ci

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856382#comment-15856382
 ] 

ASF GitHub Bot commented on GEODE-2437:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99882331
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
+  - sudo apt-get install -y cmake
--- End diff --

What CMake version does this install?  We need version 3.4 or higher.  If 
that's not the case, then we may need to `wget` and install manually.


> Integrate native client with travis-ci
> --
>
> Key: GEODE-2437
> URL: https://issues.apache.org/jira/browse/GEODE-2437
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Anthony Baker
>
> We should integrate the native client branch with travis-ci so we can tell if 
> PR's  or other code changes are good.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread dgkimura
Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99882331
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
+  - sudo apt-get install -y cmake
--- End diff --

What CMake version does this install?  We need version 3.4 or higher.  If 
that's not the case, then we may need to `wget` and install manually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (GEODE-2437) Integrate native client with travis-ci

2017-02-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856375#comment-15856375
 ] 

ASF GitHub Bot commented on GEODE-2437:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99881517
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
--- End diff --

We need GCC 4.8+ for full C++11 support.  Build #1992 looks like it has GCC 
4.6.  I think the easiest way to fix is to add `dist: trusty`.


> Integrate native client with travis-ci
> --
>
> Key: GEODE-2437
> URL: https://issues.apache.org/jira/browse/GEODE-2437
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Anthony Baker
>
> We should integrate the native client branch with travis-ci so we can tell if 
> PR's  or other code changes are good.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread dgkimura
Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99881517
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
--- End diff --

We need GCC 4.8+ for full C++11 support.  Build #1992 looks like it has GCC 
4.6.  I think the easiest way to fix is to add `dist: trusty`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Review Request 56396: Refactor test rules

2017-02-07 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56396/
---

Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk Lund.


Repository: geode


Description
---

* Refactor GfshShellConnectorRule so that it's easier to use it either as a 
rule or classRule
* Refactor LocatorServerStartupRule so that tests using it do not need to 
extend from Junit4DUnitTest and can be used as a class rule.
* add NetstatDUnitTest


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java
 28d50da61669746145c143d33947da6b8564ca9d 
  
geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
 9d678e1a8bd419e66e9dd79e8f7db5dbeeb0890b 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java
 3a3c74cd9d10b617a12c38c1fdd500ebe83a5707 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java
 79f0128ecb87b7e1334f35cb4c0c703cd07af544 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDistributionDUnitTest.java
 f362d4c679d391b50b9ce297d8e31ba9887024e1 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
 f68015e5e4f70c91e3329a53134562b128745fd7 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
 388fd9d40ccae21d58ea966e4c9c9fd71c46e873 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java
 ac3d1dee3a76e2fa884f826291f88ccbd05d10fa 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
 dbbe0dbc5dd04e06e4876ebcb15ece1cb018d56d 
  
geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
 fe37f9e2becb46c448a97fa2ac4ed7a9548ff4f9 
  
geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
 a7752aeb90da46071aa1ded17ef32c36f8b6208b 
  
geode-core/src/test/java/org/apache/geode/security/PeerSecurityWithEmbeddedLocatorDUnitTest.java
 66c5be6de9c33226f3ad4d93e9c16dcfbe674c1e 
  
geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java
 ca209a73b247cd422b93864e7de841620140f996 
  
geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java
 72654cb868f8a62212825eba72aa4fdf8bc7e39e 
  
geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java
 24d0db5c123c221b9cff59ef7d91b3d6d2d9b3eb 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 49c141413909b1b31e9d148576832bbf788878eb 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/Locator.java 
0350ffd06d09dfa742033baf0fb1c2afff1ee158 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 ac9221cab6ec9a56f269ac90f881049e0ef770de 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/Member.java 
129fe681c918a15f0927846fb19c469a0ac683a7 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/Server.java 
bc4c5d614caa0d1555e84fc483af3fa74f9e52ef 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
 0b0e936652444f0171e37fa52653f5a4e9a63c87 

Diff: https://reviews.apache.org/r/56396/diff/


Testing
---

precheckin pending


Thanks,

Jinmei Liao



Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-07 Thread Dan Smith


> On Feb. 7, 2017, 1:45 a.m., Mark Bretl wrote:
> > geode-old-versions/build.gradle, line 63
> > 
> >
> > Clarifying question: Should this be associated with 'test' sources or 
> > is 'main' so the tests may use it?

I was thinking that at some point in the future we might want to get this file 
from the classpath, rather than what the code is doing now where it's poking 
around on the filesystem.

Things in main will be added to the classpath of another project when you 
declare a dependency on this project, eg testComplile 
project('geode-old-versions'). Things in test generally aren't, unless you jump 
through some hoops.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56348/#review164448
---


On Feb. 7, 2017, 12:53 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56348/
> ---
> 
> (Updated Feb. 7, 2017, 12:53 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Mark Bretl.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The geode-old-versions/build.gradle was generating the classpath
> properties file during the build configuration phase, rather than the
> execution phase.
> 
> Also converting the file to an actual properties file so that it will
> handle special characters properly.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java
>  7bda9481275d3801e347ae6dfd66520e3f123a3a 
>   geode-old-versions/build.gradle a09b2d71c4ae9ab393b2d6e9cd44d94155e760f9 
> 
> Diff: https://reviews.apache.org/r/56348/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>



  1   2   >