[GitHub] geode-native pull request #28: Feature/geode 2440

[mmartell]

GitHub user mmartell opened a pull request:

https://github.com/apache/geode-native/pull/28

Feature/geode 2440

Convert hashcode from unsigned to signed and remove static_casts that are 
no longer necessary.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmartell/geode-native feature/GEODE-2440

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #28


commit db7ea70d191f4b71cde28f3b05126c844adfed42
Author: Mike Martell 
Date:   2017-02-22T23:00:54Z

GEODE-2440: Switch hashcode() return type.

- Conver from unit32_t to int32_t to match server.

commit 8b8eed2c284318242a04a70dc8bff28efda38967
Author: Mike Martell 
Date:   2017-02-23T05:09:22Z

Missed conversion of a few internal hashCode types.

commit f1e3fa7b0f27f393a30260f86607aa91e51782d1
Author: Mike Martell 
Date:   2017-02-23T07:28:31Z

GEODE-2440: Remove unneeded static_casts.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: off heap

[Dor Ben Dov]

Thanks Anthony.
Dor

-Original Message-
From: Anthony Baker [mailto:aba...@pivotal.io] 
Sent: יום ד 22 פברואר 2017 21:28
To: dev@geode.apache.org
Subject: Re: off heap

Hi Dor,

Here’s a few documentation links on off-heap usage:

https://geode.apache.org/docs/guide/managing/heap_use/off_heap_management.html
https://www.slideshare.net/PivotalOpenSourceHub/apache-geode-offheap-storage

Does that help?

Thanks,
Anthony


> On Feb 22, 2017, at 11:17 AM, Dor Ben Dov  wrote:
> 
> Hi,
> 
> Can one tell me how does the off heap flags solution is being done. I mean 
> what solution is being used for it ? 
> 
> 
> 
> Regards,
> Dor
> This message and the information contained herein is proprietary and 
> confidential and subject to the Amdocs policy statement,
> 
> you may review at http://www.amdocs.com/email_disclaimer.asp

This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at http://www.amdocs.com/email_disclaimer.asp

[jira] [Assigned] (GEODE-2531) Replace HostAsm::atomic* and AtomicInc with std::atomic

[Jacob S. Barrett (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett reassigned GEODE-2531:
---

Assignee: Jacob S. Barrett

> Replace HostAsm::atomic* and AtomicInc with std::atomic
> ---
>
> Key: GEODE-2531
> URL: https://issues.apache.org/jira/browse/GEODE-2531
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{HostAsm::atomic*}} and {{AtomicInc}} with 
> {{[std::atomic|http://en.cppreference.com/w/cpp/atomic/atomic]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (GEODE-2493) Replaces the locking and CAS operations provided in HostAsm with C++11 standards

[Jacob S. Barrett (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869186#comment-15869186
 ] 

Jacob S. Barrett edited comment on GEODE-2493 at 2/23/17 5:49 AM:
--

-Replace {{HostAsm::getCpuCount}} with 
{{[std::thread::hardware_concurrency|http://en.cppreference.com/w/cpp/thread/thread/hardware_concurrency]}}.-
All uses were eliminated when removing {{SpinLock}}.


was (Author: jbarrett):
Replace {{HostAsm::getCpuCount}} with 
{{[std::thread::hardware_concurrency|http://en.cppreference.com/w/cpp/thread/thread/hardware_concurrency]}}.

> Replaces the locking and CAS operations provided in HostAsm with C++11 
> standards
> 
>
> Key: GEODE-2493
> URL: https://issues.apache.org/jira/browse/GEODE-2493
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Several platform specific locking and CAS operations are implemented in 
> HostAsm and related files. These are not portable and require porting 
> efforts. They are also not well tested. Converting the C++11 standards allows 
> the compiler to choose the code or instructions that optimize the behavior 
> required. Most if not all of the functions these files provide can be 
> replaced with C++11 standard functions.
> Some Examples:
> On Solaris SPAC we have inline assembly.
> On Solaris x86 we use Solaris specific runtime functions.
> On Windows we use really old Win32 functions that have some non-standard 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2531) Replace HostAsm::atomic* and AtomicInc with std::atomic

[Jacob S. Barrett (JIRA)]

Jacob S. Barrett created GEODE-2531:
---

 Summary: Replace HostAsm::atomic* and AtomicInc with std::atomic
 Key: GEODE-2531
 URL: https://issues.apache.org/jira/browse/GEODE-2531
 Project: Geode
  Issue Type: Sub-task
Reporter: Jacob S. Barrett


Replace {{HostAsm::atomic*}} and {{AtomicInc}} with 
{{[std::atomic|http://en.cppreference.com/w/cpp/atomic/atomic]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[Jacob S. Barrett (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett reassigned GEODE-2494:
---

Assignee: Jacob S. Barrett

> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #480 has FAILED

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #480 failed (rerun 2 times).
---
This build was rerun by John Blum.
No failed tests found, a possible compilation error.

https://build.spring.io/browse/SGF-NAG-480/

-
Currently Responsible
-

No one is responsible for fixing this build.



--
Failing Jobs
--
  - Default Job (Default Stage): No tests found.




--
This message is automatically generated by Atlassian Bamboo

[jira] [Commented] (GEODE-2526) Enhance log statement in StatsArchiveReader

[Srikanth Manvi (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879774#comment-15879774
 ] 

Srikanth Manvi commented on GEODE-2526:
---

Created this review request https://reviews.apache.org/r/56964/

> Enhance log statement in StatsArchiveReader
> ---
>
> Key: GEODE-2526
> URL: https://issues.apache.org/jira/browse/GEODE-2526
> Project: Geode
>  Issue Type: New Feature
>  Components: statistics
>Reporter: Srikanth Manvi
>Assignee: Srikanth Manvi
>Priority: Trivial
>
> Rarely stats files are corrupted due to missing ResourceType info in the gfs 
> file. In those cases the gfs files cannot be opened in VSD tool as the tool 
> throws an error while loading.
> The log statement in the method 
> StatsArchiveReader.java(readResourceInstanceCreateToken())  prints out only 
> the missing ResourceTypeId which appears to be dynamically created. 
> If the log message can be enhanced to include the resourceName as well, it 
> will be valuable to know the name of ResourceType that is actually missing in 
> the stats file. 
> There is a [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility which takes in a corrupted stats files, name and id of the missing 
> ResourceType in the corrupted file and outputs a new .gfs file by filling in 
> the missing resource info. The new file can then be loaded and analyzed in 
> VSD.
>  
> For the [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility to be usable one needs to know the actual name of missing 
> resourceType, hence this New feature request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2530) Create DunitTests to tests the effect of dataStores going down while paginating

[nabarun (JIRA)]

nabarun created GEODE-2530:
--

 Summary: Create DunitTests to tests the effect of dataStores going 
down while paginating
 Key: GEODE-2530
 URL: https://issues.apache.org/jira/browse/GEODE-2530
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: nabarun


Analyze the effect of dataStores going offline while the pages are being 
extracted / Lucene results are being extracted.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

[Srikanth Manvi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56964/
---

Review request for geode and Kirk Lund.


Repository: geode


Description
---

Enhanced the log statement to include the ResourceType Name.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java
 9fba511 

Diff: https://reviews.apache.org/r/56964/diff/


Testing
---


Thanks,

Srikanth Manvi

[jira] [Commented] (GEODE-2523) Collapse RegionTestableTypes combinations into a single enum types

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879766#comment-15879766
 ] 

ASF subversion and git services commented on GEODE-2523:


Commit fa5963a3e6099136c3de70625b162ade3c1c5be0 in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fa5963a ]

GEODE-2523: Combined RegionTestableTypes into a "paired" enum type

*  Fixed accessor type attributes, now setting to valid 0 size
*  Readded fixed partition variant to existing test for gii


> Collapse RegionTestableTypes combinations into a single enum types
> --
>
> Key: GEODE-2523
> URL: https://issues.apache.org/jira/browse/GEODE-2523
> Project: Geode
>  Issue Type: Sub-task
>  Components: lucene
>Reporter: Jason Huynh
>
> Currently, we have pairs of RegionTestableTypes that are used in the 
> LuceneDUnit tests.  These pairs are used to determine the datastore and 
> accessor region types.  However the pairings are generally 1 to 1.  So we 
> should be able to collapse the types into a single enum and remove the 
> parameterized methods.  Instead we should then be able to add the enum name 
> into the parameters themselves.
> So instead of having the following for a test case
>  @Parameters(method = "getListOfClientServerTypes")
> We could then have
>   @Parameters({"PARTITION", "ETC..."})
> we can probably use PARTITION and know that the corresponding client type is 
> PARTITION_PROXY.  That or we can change the enum to be explicit about the 
> pairing, such as PARTITION_WITH_PARTITION_PROXY.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #480 has FAILED

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #480 failed (rerun once).
---
This build was rerun by John Blum.
No failed tests found, a possible compilation error.

https://build.spring.io/browse/SGF-NAG-480/

-
Currently Responsible
-

No one is responsible for fixing this build.



--
Failing Jobs
--
  - Default Job (Default Stage): No tests found.




--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 56958: Bring the RegionTestableType pairings into the enum itself

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56958/#review166463
---


Ship it!




Ship It!

- Dan Smith


On Feb. 23, 2017, 1:30 a.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56958/
> ---
> 
> (Updated Feb. 23, 2017, 1:30 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, 
> Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This will hopefully simplify the creation of new tests as well as allowing 
> tests to supply String parameters instead of creating a new method.
> 
> Fixed accessor type attributes... it was previously setting accessor sizes to 
> default value
> 
> Readded missing fixed pr variation of gii tests (that I accidently removed 
> with last commit)
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
> 31ffced 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java
>  71c111d 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationOnFixedPRDUnitTest.java
>  e623d7d 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesAccessorBase.java
>  00bb842 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesClientDUnitTest.java
>  0753adf 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesDUnitTest.java
>  f32bc84 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceDUnitTest.java
>  bf12e79 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceWithRedundancyDUnitTest.java
>  071bd7c 
> 
> Diff: https://reviews.apache.org/r/56958/diff/
> 
> 
> Testing
> ---
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Review Request 56958: Bring the RegionTestableType pairings into the enum itself

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56958/
---

Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, Dan 
Smith, and xiaojian zhou.


Repository: geode


Description
---

This will hopefully simplify the creation of new tests as well as allowing 
tests to supply String parameters instead of creating a new method.

Fixed accessor type attributes... it was previously setting accessor sizes to 
default value

Readded missing fixed pr variation of gii tests (that I accidently removed with 
last commit)


Diffs
-

  geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
31ffced 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java
 71c111d 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationOnFixedPRDUnitTest.java
 e623d7d 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesAccessorBase.java
 00bb842 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesClientDUnitTest.java
 0753adf 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesDUnitTest.java
 f32bc84 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceDUnitTest.java
 bf12e79 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceWithRedundancyDUnitTest.java
 071bd7c 

Diff: https://reviews.apache.org/r/56958/diff/


Testing
---

geode-lucene:precheckin


Thanks,

Jason Huynh

[jira] [Commented] (GEODE-2522) Refactor Lucene D Unit tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879639#comment-15879639
 ] 

ASF subversion and git services commented on GEODE-2522:


Commit 55a4c7aef2ad3d9f1f0bb4957a76489a3d73de84 in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=55a4c7a ]

GEODE-2522: Removed debugging log


> Refactor Lucene D Unit tests
> 
>
> Key: GEODE-2522
> URL: https://issues.apache.org/jira/browse/GEODE-2522
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> Currently our dunit tests for lucene are organized as a tree heirarchy based 
> on region types.  This makes it difficult to add a tests for a specific type 
> of region type as other test files can possibly extend the file we add the 
> test to.
> Instead we can use parameterized tests and flatten the heirarchy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2529) Rename LuceneFunction to LuceneQueryFunction

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879622#comment-15879622
 ] 

ASF subversion and git services commented on GEODE-2529:


Commit 5547c2a025a74c0abae58c0d4a876a4d887eb506 in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5547c2a ]

GEODE-2529: Rename LuceneFunction to LuceneQueryFunction

* Included new renamed file LuceneQueryFunction.java
* Change thrown exception type to InternalFunctionInvocationTargetException 
instead of FunctionException


> Rename LuceneFunction to LuceneQueryFunction
> 
>
> Key: GEODE-2529
> URL: https://issues.apache.org/jira/browse/GEODE-2529
> Project: Geode
>  Issue Type: Task
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> Just to give it a more descriptive name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879618#comment-15879618
 ] 

ASF subversion and git services commented on GEODE-2231:


Commit 0ed1575f687f052230ba63da55cc1caab381298c in geode-examples's branch 
refs/heads/feature/GEODE-2231 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;h=0ed1575 ]

GEODE-2231 Fix a typo in the partitioning example README


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879613#comment-15879613
 ] 

ASF subversion and git services commented on GEODE-2231:


Commit 34f63c68baf68cc52943d18fca506b78b59d14f3 in geode-examples's branch 
refs/heads/feature/GEODE-2231 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;h=34f63c6 ]

GEODE-2231  Tweak README for partitioning example


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2529) Rename LuceneFunction to LuceneQueryFunction

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879576#comment-15879576
 ] 

ASF subversion and git services commented on GEODE-2529:


Commit 2d72624cda30af5a34b48e2c1dcc2f6b69680909 in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=2d72624 ]

Revert "GEODE-2529: Rename LuceneFunction to LuceneQueryFunction"

This reverts commit a59a37a51deb89ccaf16728850687ead1657457a.


> Rename LuceneFunction to LuceneQueryFunction
> 
>
> Key: GEODE-2529
> URL: https://issues.apache.org/jira/browse/GEODE-2529
> Project: Geode
>  Issue Type: Task
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> Just to give it a more descriptive name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2529) Rename LuceneFunction to LuceneQueryFunction

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh resolved GEODE-2529.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Rename LuceneFunction to LuceneQueryFunction
> 
>
> Key: GEODE-2529
> URL: https://issues.apache.org/jira/browse/GEODE-2529
> Project: Geode
>  Issue Type: Task
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> Just to give it a more descriptive name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879550#comment-15879550
 ] 

ASF subversion and git services commented on GEODE-2231:


Commit 912a37234fdccb9a80de9335bab366b5cd3ec6b0 in geode-examples's branch 
refs/heads/feature/GEODE-2231 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;h=912a372 ]

GEODE-2231 Rework README, code, and tests to present
partitioning example in two parts


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2529) Rename LuceneFunction to LuceneQueryFunction

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879538#comment-15879538
 ] 

ASF subversion and git services commented on GEODE-2529:


Commit a59a37a51deb89ccaf16728850687ead1657457a in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a59a37a ]

GEODE-2529: Rename LuceneFunction to LuceneQueryFunction

* Also changed the thrown exception type from FunctionException to 
InternalFunctionInvocationTargetException


> Rename LuceneFunction to LuceneQueryFunction
> 
>
> Key: GEODE-2529
> URL: https://issues.apache.org/jira/browse/GEODE-2529
> Project: Geode
>  Issue Type: Task
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> Just to give it a more descriptive name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879537#comment-15879537
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

GitHub user dgkimura opened a pull request:

https://github.com/apache/geode-native/pull/27

GEODE-2439: Remove int type definitions

Purpose of this pull-request is to remove references to alleged 
non-portable `inttypes.h` header.  References are replaced with fixed width 
integer types introduced in C++11 and defined in `cstdint` header.
http://en.cppreference.com/w/cpp/types/integer

Testing - built and ran integration-tests on OSX and Windows

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dgkimura/geode-native feature/GEODE-2439

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #27


commit 6660b65c5dd0a9a73687d17f871ea8884d0f0885
Author: David Kimura 
Date:   2017-02-22T19:03:37Z

GEODE-2439: Remove int type definitions




> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #27: GEODE-2439: Remove int type definitions

[dgkimura]

GitHub user dgkimura opened a pull request:

https://github.com/apache/geode-native/pull/27

GEODE-2439: Remove int type definitions

Purpose of this pull-request is to remove references to alleged 
non-portable `inttypes.h` header.  References are replaced with fixed width 
integer types introduced in C++11 and defined in `cstdint` header.
http://en.cppreference.com/w/cpp/types/integer

Testing - built and ran integration-tests on OSX and Windows

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dgkimura/geode-native feature/GEODE-2439

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #27


commit 6660b65c5dd0a9a73687d17f871ea8884d0f0885
Author: David Kimura 
Date:   2017-02-22T19:03:37Z

GEODE-2439: Remove int type definitions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (GEODE-2529) Rename LuceneFunction to LuceneQueryFunction

[Jason Huynh (JIRA)]

Jason Huynh created GEODE-2529:
--

 Summary: Rename LuceneFunction to LuceneQueryFunction
 Key: GEODE-2529
 URL: https://issues.apache.org/jira/browse/GEODE-2529
 Project: Geode
  Issue Type: Task
  Components: lucene
Reporter: Jason Huynh


Just to give it a more descriptive name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2529) Rename LuceneFunction to LuceneQueryFunction

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reassigned GEODE-2529:
--

Assignee: Jason Huynh

> Rename LuceneFunction to LuceneQueryFunction
> 
>
> Key: GEODE-2529
> URL: https://issues.apache.org/jira/browse/GEODE-2529
> Project: Geode
>  Issue Type: Task
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> Just to give it a more descriptive name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: C++ Style

[Ernest Burghardt]

+1 for camelCase - not a fan of allowed (not as readable) or
under_scores(requires extra keying/shift)

-1 for variable decoration regardless of scope

+1 for const refs and I'm good with the pointers too, I think that tends to
work itself out with modern design patterns (in my experience)

*Preincrement and Predecrement
We have A LOT of var++ that ought to be ++var --- seems like an opportunity
for some sed-Fu if no other tool will handle this for us...

*Write Short Functions
Stretch goal for refactoring :-)

EB

On Tue, Feb 21, 2017 at 8:52 AM, Michael William Dodge 
wrote:

> * Variable Naming - I agree that lowercase-first camelCase is more
> readable and preferable for variable and data member names. Since class
> names are uppercase-first CamelCase, underscores should not be used. And
> alllowercase is unreadable.
>
> * Class Data Members - Any sort of Hungarian notation, including the
> leading "m_", is more trouble than it's worth, e.g., the compiler doesn't
> enforce m_foo actually being a data member. For those who have an aversion
> to this->foo, foo_ would be much better than m_foo. But I think neither a
> leading "m_" or trailing "_" is needed.
>
> * Constant Names - I always associated the leading "k" with Smalltalk
> since I first saw it in Objective-C but apparently it's originally from
> mathematics somehow. Just like with the rest of Hungarian notation, it
> doesn't mean anything to the compiler and I think it makes the code harder
> to read. It is unnecessary.
>
> * Reference vs. Pointer - I'll admit I don't see the logic to their
> argument. As far as I know, compilers pass the address for both references
> and pointers so there's no difference there. From a language standpoint,
> however, there is the very important difference that references may not be
> null. Thus, pointers (both const and non-const) should be used in cases
> where the value may be entirely absent (e.g., there is no foo) and
> references (both const and non-const) used in all other cases. There may be
> special cases (e.g., mocks for Google Test) where a pointer to an interface
> is preferable but as a general rule the precondition that a reference can
> not be null makes them preferable.
>
> Sarge
>
> > On 20 Feb, 2017, at 13:48, Jacob Barrett  wrote:
> >
> > A bit back we discussed and adopted the Google C++ Style Guide. As we dig
> > deeper into the C++ sources we find some striking differences in some of
> > the conventions that we may want to discuss and address before tackling
> > them.
> >
> > *Variable Naming*
> > Google style dictates no *camelCase*, use either *alllowercase* or
> > *variable_name.
> > *Our C++ code has a mix of all three. Personally I prefer cameCase as
> more
> > readable.
> >
> > *Class Data Members*
> > Google style says members must end with underscore, *my_member_*. While I
> > find this preferable to the common practice in our code of *m_* prefix,
> > like *m_myVariable,* I am not super fond of any decoration of member
> > variables.
> >
> > *Constant Names*
> > Google says prefix with *k* and gives and example with *kCamelCase*. I
> > think *cameCase* might be a typo but again I am not fond of any variable
> > decorations.
> >
> > *Reference vs. Pointer*
> > Google says use pointer if you intend to modify the value being passed
> and
> > use const references for values that are not going to be modified. It
> says
> > do not use references except for very limited use cases. We have
> references
> > and pointers spread inconsistently throughout the source. Worst, it is
> not
> > consistent in the public API. We should decide on a standard and make
> sure
> > our API adheres to it first.
> >
> > Others may pop up as we go but these are the obvious ones standing out.
> >
> > -Jake
>
>

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879479#comment-15879479
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 1defa8de9b3022341007cc61f6acbb88cba2b1e1 in geode's branch 
refs/heads/feature/GEODE-2142 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1defa8d ]

GEODE-2142: Removing JSON licence stuff from NOTICE files


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-52) Remove @author tags from Java source

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879476#comment-15879476
 ] 

ASF subversion and git services commented on GEODE-52:
--

Commit 377ccef230a6a91c216cedfb9bc578fe521816b5 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=377ccef ]

GEODE-52: remove old author todo comment


> Remove @author tags from Java source
> 
>
> Key: GEODE-52
> URL: https://issues.apache.org/jira/browse/GEODE-52
> Project: Geode
>  Issue Type: Bug
>Reporter: Jakob Homan
>Assignee: Sai Boorlagadda
> Fix For: 1.0.0-incubating.M2
>
>
> Apache generally frowns on @author tags (as they imply ownership of the code 
> by a single individual, see 
> https://blogs.oracle.com/ahe/entry/coding_conventions_and_attribution [best 
> asf link is not working, annoyingly] and 
> https://cwiki.apache.org/confluence/display/AVRO/How+To+Contribute as an 
> example)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56936: Change LuceneFunction exception thrown type and rename to LuceneQueryFunction

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56936/#review166441
---


Ship it!




Ship It!

- nabarun nag


On Feb. 22, 2017, 11:06 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56936/
> ---
> 
> (Updated Feb. 22, 2017, 11:06 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, 
> Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * Thought we should change the name of the LuceneFunction to describe that 
> the function is actually for querying.
> * Changed the exception thrown type to 
> InternalFunctionInvocationTargetException to piggy back on the function 
> execution retry mechanisms (so we can remove the while loop in our 
> LuceneQueryImpl)
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java
>  b41bb5f 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
>  f1b1861 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java
>  76c5893 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/package-info.java
>  f6c1018 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneQueryImplJUnitTest.java
>  4a31e96 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneServiceImplIntegrationTest.java
>  9e3a13c 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionContextJUnitTest.java
>  1a6ed59 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java
>  fe05248 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionContextJUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56936/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 56936: Change LuceneFunction exception thrown type and rename to LuceneQueryFunction

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56936/#review166440
---


Ship it!




Ship It!

- Dan Smith


On Feb. 22, 2017, 11:06 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56936/
> ---
> 
> (Updated Feb. 22, 2017, 11:06 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, 
> Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * Thought we should change the name of the LuceneFunction to describe that 
> the function is actually for querying.
> * Changed the exception thrown type to 
> InternalFunctionInvocationTargetException to piggy back on the function 
> execution retry mechanisms (so we can remove the while loop in our 
> LuceneQueryImpl)
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java
>  b41bb5f 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
>  f1b1861 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java
>  76c5893 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/package-info.java
>  f6c1018 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneQueryImplJUnitTest.java
>  4a31e96 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneServiceImplIntegrationTest.java
>  9e3a13c 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionContextJUnitTest.java
>  1a6ed59 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java
>  fe05248 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionContextJUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56936/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 56936: Change LuceneFunction exception thrown type and rename to LuceneQueryFunction

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56936/
---

(Updated Feb. 22, 2017, 11:06 p.m.)


Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, Dan 
Smith, and xiaojian zhou.


Repository: geode


Description
---

* Thought we should change the name of the LuceneFunction to describe that the 
function is actually for querying.
* Changed the exception thrown type to 
InternalFunctionInvocationTargetException to piggy back on the function 
execution retry mechanisms (so we can remove the while loop in our 
LuceneQueryImpl)


Diffs (updated)
-

  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java
 b41bb5f 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
 f1b1861 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java
 76c5893 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java
 PRE-CREATION 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/package-info.java
 f6c1018 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneQueryImplJUnitTest.java
 4a31e96 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneServiceImplIntegrationTest.java
 9e3a13c 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionContextJUnitTest.java
 1a6ed59 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java
 fe05248 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionContextJUnitTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56936/diff/


Testing
---


Thanks,

Jason Huynh

Review Request 56936: Change LuceneFunction exception thrown type and rename to LuceneQueryFunction

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56936/
---

Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, Dan 
Smith, and xiaojian zhou.


Repository: geode


Description
---

* Thought we should change the name of the LuceneFunction to describe that the 
function is actually for querying.
* Changed the exception thrown type to 
InternalFunctionInvocationTargetException to piggy back on the function 
execution retry mechanisms (so we can remove the while loop in our 
LuceneQueryImpl)


Diffs
-

  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java
 b41bb5f 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
 f1b1861 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java
 76c5893 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/package-info.java
 f6c1018 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneQueryImplJUnitTest.java
 4a31e96 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneServiceImplIntegrationTest.java
 9e3a13c 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionContextJUnitTest.java
 1a6ed59 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java
 fe05248 

Diff: https://reviews.apache.org/r/56936/diff/


Testing
---


Thanks,

Jason Huynh

[jira] [Commented] (GEODE-2527) geode-native docs: Fix broken links to Geode User Manual

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879414#comment-15879414
 ] 

ASF GitHub Bot commented on GEODE-2527:
---

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/26

GEODE-2527 geode-native docs: Fix broken links to Geode User Manual

Fix links to geode userman by modifying a redirect entry.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2527

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit 2f2d064a80e93e7661f2ca3e235f0d9eb23a389c
Author: Dave Barnes 
Date:   2017-02-22T22:50:04Z

GEODE-2527 geode-native docs: Fix broken links to Geode User Manual




> geode-native docs: Fix broken links to Geode User Manual
> 
>
> Key: GEODE-2527
> URL: https://issues.apache.org/jira/browse/GEODE-2527
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Geode Native User Guide contains links to the Geode User Manual 
> (designated "geodeman") that don't connect. 
> To find which files contain these references, you can grep the sources or you 
> can comment out the "geodeman" line in redirect.rb and try building the book. 
> I see 24 of these broken links.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #26: GEODE-2527 geode-native docs: Fix broken link...

[davebarnes97]

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/26

GEODE-2527 geode-native docs: Fix broken links to Geode User Manual

Fix links to geode userman by modifying a redirect entry.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2527

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit 2f2d064a80e93e7661f2ca3e235f0d9eb23a389c
Author: Dave Barnes 
Date:   2017-02-22T22:50:04Z

GEODE-2527 geode-native docs: Fix broken links to Geode User Manual




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEODE-2520) Add a lucene query test where a bucket is moved while a query is executing

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh resolved GEODE-2520.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Add a lucene query test where a bucket is moved while a query is executing
> --
>
> Key: GEODE-2520
> URL: https://issues.apache.org/jira/browse/GEODE-2520
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> The query should handle this scenario and return the correct results.
> As currently implemented, it should end up retrying the query on the new 
> primary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2526) Enhance log statement in StatsArchiveReader

[Srikanth Manvi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Srikanth Manvi updated GEODE-2526:
--
Priority: Trivial  (was: Major)

> Enhance log statement in StatsArchiveReader
> ---
>
> Key: GEODE-2526
> URL: https://issues.apache.org/jira/browse/GEODE-2526
> Project: Geode
>  Issue Type: New Feature
>  Components: statistics
>Reporter: Srikanth Manvi
>Assignee: Srikanth Manvi
>Priority: Trivial
>
> Rarely stats files are corrupted due to missing ResourceType info in the gfs 
> file. In those cases the gfs files cannot be opened in VSD tool as the tool 
> throws an error while loading.
> The log statement in the method 
> StatsArchiveReader.java(readResourceInstanceCreateToken())  prints out only 
> the missing ResourceTypeId which appears to be dynamically created. 
> If the log message can be enhanced to include the resourceName as well, it 
> will be valuable to know the name of ResourceType that is actually missing in 
> the stats file. 
> There is a [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility which takes in a corrupted stats files, name and id of the missing 
> ResourceType in the corrupted file and outputs a new .gfs file by filling in 
> the missing resource info. The new file can then be loaded and analyzed in 
> VSD.
>  
> For the [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility to be usable one needs to know the actual name of missing 
> resourceType, hence this New feature request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #480 has FAILED

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #480 failed.
---
Scheduled
No failed tests found, a possible compilation error.

https://build.spring.io/browse/SGF-NAG-480/

-
Currently Responsible
-

No one is responsible for fixing this build.



--
Failing Jobs
--
  - Default Job (Default Stage): No tests found.




--
This message is automatically generated by Atlassian Bamboo

[jira] [Created] (GEODE-2528) modify redis server threads to use thread-owned resources

[Bruce Schuchardt (JIRA)]

Bruce Schuchardt created GEODE-2528:
---

 Summary: modify redis server threads to use thread-owned resources
 Key: GEODE-2528
 URL: https://issues.apache.org/jira/browse/GEODE-2528
 Project: Geode
  Issue Type: Sub-task
  Components: redis
Reporter: Bruce Schuchardt


The Redis adapter's server threads are not configured for thread-owned 
resources so they are all contending for the same sockets when replicating or 
performing one-hop operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2527) geode-native docs: Fix broken links to Geode User Manual

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes reassigned GEODE-2527:
--

Assignee: Dave Barnes

> geode-native docs: Fix broken links to Geode User Manual
> 
>
> Key: GEODE-2527
> URL: https://issues.apache.org/jira/browse/GEODE-2527
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Geode Native User Guide contains links to the Geode User Manual 
> (designated "geodeman") that don't connect. 
> To find which files contain these references, you can grep the sources or you 
> can comment out the "geodeman" line in redirect.rb and try building the book. 
> I see 24 of these broken links.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2526) Enhance log statement in StatsArchiveReader

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879371#comment-15879371
 ] 

ASF GitHub Bot commented on GEODE-2526:
---

GitHub user smanvi-pivotal opened a pull request:

https://github.com/apache/geode/pull/406

GEODE-2526: Enhance log statement to include ResourceTypeName



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/smanvi-pivotal/geode feature/GEODE-2526

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/406.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #406


commit 3f6f430c0b8f71dfc78eb18e08667c6e9e35822b
Author: Srikanth Manvi 
Date:   2017-02-22T22:15:43Z

GEODE-2526: Enhance log statement to include ResourceTypeName




> Enhance log statement in StatsArchiveReader
> ---
>
> Key: GEODE-2526
> URL: https://issues.apache.org/jira/browse/GEODE-2526
> Project: Geode
>  Issue Type: New Feature
>  Components: statistics
>Reporter: Srikanth Manvi
>Assignee: Srikanth Manvi
>
> Rarely stats files are corrupted due to missing ResourceType info in the gfs 
> file. In those cases the gfs files cannot be opened in VSD tool as the tool 
> throws an error while loading.
> The log statement in the method 
> StatsArchiveReader.java(readResourceInstanceCreateToken())  prints out only 
> the missing ResourceTypeId which appears to be dynamically created. 
> If the log message can be enhanced to include the resourceName as well, it 
> will be valuable to know the name of ResourceType that is actually missing in 
> the stats file. 
> There is a [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility which takes in a corrupted stats files, name and id of the missing 
> ResourceType in the corrupted file and outputs a new .gfs file by filling in 
> the missing resource info. The new file can then be loaded and analyzed in 
> VSD.
>  
> For the [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility to be usable one needs to know the actual name of missing 
> resourceType, hence this New feature request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #406: GEODE-2526: Enhance log statement to include Resour...

[smanvi-pivotal]

GitHub user smanvi-pivotal opened a pull request:

https://github.com/apache/geode/pull/406

GEODE-2526: Enhance log statement to include ResourceTypeName



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/smanvi-pivotal/geode feature/GEODE-2526

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/406.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #406


commit 3f6f430c0b8f71dfc78eb18e08667c6e9e35822b
Author: Srikanth Manvi 
Date:   2017-02-22T22:15:43Z

GEODE-2526: Enhance log statement to include ResourceTypeName




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2441) Remove PDXAutoSerializer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879365#comment-15879365
 ] 

ASF GitHub Bot commented on GEODE-2441:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/21


> Remove PDXAutoSerializer 
> -
>
> Key: GEODE-2441
> URL: https://issues.apache.org/jira/browse/GEODE-2441
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> Remove PDXAutoSerializer utility that generates PDX serialization C++ source 
> that you can include in your project to (de)serialize your C++ classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #21: GEODE-2441: Remove pdx auto serializer from c...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2441) Remove PDXAutoSerializer

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879364#comment-15879364
 ] 

ASF subversion and git services commented on GEODE-2441:


Commit 97ded7036b08ce5d73b79c2786b01efdaa51d00f in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=97ded70 ]

GEODE-2441: Move pdx auto serializer into standalone contrib

This closes #21.


> Remove PDXAutoSerializer 
> -
>
> Key: GEODE-2441
> URL: https://issues.apache.org/jira/browse/GEODE-2441
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> Remove PDXAutoSerializer utility that generates PDX serialization C++ source 
> that you can include in your project to (de)serialize your C++ classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2527) geode-native docs: Fix broken links to Geode User Manual

[Dave Barnes (JIRA)]

Dave Barnes created GEODE-2527:
--

 Summary: geode-native docs: Fix broken links to Geode User Manual
 Key: GEODE-2527
 URL: https://issues.apache.org/jira/browse/GEODE-2527
 Project: Geode
  Issue Type: Bug
  Components: docs
Reporter: Dave Barnes


The Geode Native User Guide contains links to the Geode User Manual (designated 
"geodeman") that don't connect. 
To find which files contain these references, you can grep the sources or you 
can comment out the "geodeman" line in redirect.rb and try building the book. I 
see 24 of these broken links.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Reopened] (GEODE-2497) surprise members are never timed out during startup

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt reopened GEODE-2497:
-

the modifications made for this ticket are causing NPEs in UDP-only based tests

> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2489) Tombstone message with keys are sent to peer partitioned region nodes even though no clinets are registered

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879354#comment-15879354
 ] 

ASF subversion and git services commented on GEODE-2489:


Commit 257c21ece8ac54cf3ead2c41bfe8085b3219e3d5 in geode's branch 
refs/heads/develop from [~agingade]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=257c21e ]

GEODE-2489: Avoid sending tombstone GC messages to peer nodes if there is no 
client registration

When tombstones are removed, tombstone messages are sent to region replicas; 
and in case of Partitioned Region (PR) messages are also sent to peer region 
nodes for client events.

Currently tombstone messages meant for clients that have all the keys removed 
are getting sent to peer PR nodes even though no clients are registered on 
those peers.


> Tombstone message with keys are sent to peer partitioned region nodes even 
> though no clinets are registered
> ---
>
> Key: GEODE-2489
> URL: https://issues.apache.org/jira/browse/GEODE-2489
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>
> Tombstone:
> As part of consistency checking,  when an entry is destroyed, the member 
> temporarily retains the entry to detect possible conflicts with operations 
> that have occurred. The retained entry is referred to as a tombstone. 
> When tombstones are removed, tombstone messages are sent to region replicas; 
> and in case of Partitioned Region (PR) messages are also sent to peer region 
> nodes for client events.
> Currently tombstone messages meant for clients that have all the keys removed 
> are getting sent to peer PR nodes even though no clients are registered on 
> those peers.
> Based on the number tombstone keys processed (by default 10) this could 
> be large message sent to peer node which could impact the performance of the 
> system/cluster.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2519) geode-native docs: add ASF copyrights

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-2519.

Resolution: Fixed

This affected every geode-native doc file, so I committed directly without a 
pull request in order to minimize window in which conflicts might arise from 
the work of others.

> geode-native docs: add ASF copyrights
> -
>
> Key: GEODE-2519
> URL: https://issues.apache.org/jira/browse/GEODE-2519
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The recently contributed docs need ASF copyright headers.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: commons-beanutils in PR #403

[Anthony Baker]

commons-beanutils is a transitive dependency.  I noticed this by inspection :-)

Based on the PR comments, I am not planning to use the override resolution 
strategy.

Anthony

> On Feb 22, 2017, at 1:22 PM, Kirk Lund  wrote:
> 
> I'm comparing Anthony's PR with my changes for GEODE-2460, and I'm trying
> to understand why we need to add the override for commons-beanutils to
> gradle/dependency-resolution.gradle. Without this, GEODE-2460 passes
> precheckin and uiTest.
> 
> Is there some way to detect that commons-beanutils needs this further
> change?
> 
> Is there a gradle target that shows we end up using 2 different versions?
> 
> GEODE-2460: https://reviews.apache.org/r/56934/
> PR #403: https://github.com/apache/geode/pull/403
> 
> Thanks,
> Kirk

Re: Review Request 56934: GEODE-2460: update dependency versions

[Anthony Baker]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56934/#review166431
---


Ship it!




Ship It!

- Anthony Baker


On Feb. 22, 2017, 9:39 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56934/
> ---
> 
> (Updated Feb. 22, 2017, 9:39 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-2460
> https://issues.apache.org/jira/browse/GEODE-2460
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> -asm.version = 5.1 (Apache 2.0)
> +asm.version = 5.2 (Apache 2.0)
> 
> -fastutil.version = 7.0.13 (Apache 2.0)
> +fastutil.version = 7.1.0 (Apache 2.0)
> 
> -httpclient.version = 4.5.2 (Apache 2.0)
> +httpclient.version = 4.5.3 (Apache 2.0)
> 
> -netty-all.version = 4.1.7.Final (Apache 2.0)
> -open-json.version = 1.7 (Apache 2.0)
> +netty-all.version = 4.1.8.Final (Apache 2.0)
> +open-json.version = 1.8 (Apache 2.0)
> 
> -slf4j-api.version = 1.7.22 (MIT)
> +slf4j-api.version = 1.7.23 (MIT)
> 
> -spring-hateoas.version = 0.21.0.RELEASE (Apache 2.0)
> +spring-hateoas.version = 0.23.0.RELEASE (Apache 2.0)
> 
> -spring-ldap-core.version = 2.1.0.RELEASE (Apache 2.0)
> -spring-security.version = 4.1.3.RELEASE (Apache 2.0)
> -spring-tx.version = 4.3.2.RELEASE (Apache 2.0)
> -springframework.version = 4.3.2.RELEASE
> +spring-ldap-core.version = 2.3.1.RELEASE (Apache 2.0)
> +spring-security.version = 4.2.1.RELEASE (Apache 2.0)
> +spring-tx.version = 4.3.6.RELEASE (Apache 2.0)
> +springframework.version = 4.3.6.RELEASE (Apache 2.0)
> 
> -springfox.version=2.6.0 (Apache 2.0)
> +springfox.version=2.6.1 (Apache 2.0)
> 
> I tried to update selenium.version from 3.0.1 to 3.1.0 but it results in 
> uiTest failures so I backed that out and will file a separate Jira ticket for 
> updating Selenium.
> 
> 
> Diffs
> -
> 
>   geode-assembly/src/main/dist/NOTICE 
> 3ce86ba25bb7b52df5c43676a68cf36a37f7d93d 
>   geode-pulse/src/main/webapp/META-INF/NOTICE 
> 95c619c6b6907b9669dcf33648d93bf42f64b28b 
>   geode-web-api/src/main/webapp/META-INF/NOTICE 
> 004cd5fdd6e880e5449d131f837b00d6f3c65ab6 
>   geode-web/src/main/webapp/META-INF/NOTICE 
> a8caa6b6f4e29c63a6f322ee32c2322185e1dedf 
>   gradle/dependency-versions.properties 
> 12a76b4f7ae46f94e85123945d5ffbcbad6bcb77 
> 
> Diff: https://reviews.apache.org/r/56934/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed 100% green
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Commented] (GEODE-2519) geode-native docs: add ASF copyrights

[Dave Barnes (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879330#comment-15879330
 ] 

Dave Barnes commented on GEODE-2519:


Using a Perl script provided by Karen Miller to take care of *.erb files 
(nearly all the sources). Hand editing files in the book directory.

> geode-native docs: add ASF copyrights
> -
>
> Key: GEODE-2519
> URL: https://issues.apache.org/jira/browse/GEODE-2519
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The recently contributed docs need ASF copyright headers.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56934: GEODE-2460: update dependency versions

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56934/
---

(Updated Feb. 22, 2017, 9:39 p.m.)


Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
Duling, Ken Howe, and Mark Bretl.


Changes
---

add the changes to NOTICE files from Anthony's pull request (PR #403)


Bugs: GEODE-2460
https://issues.apache.org/jira/browse/GEODE-2460


Repository: geode


Description
---

-asm.version = 5.1 (Apache 2.0)
+asm.version = 5.2 (Apache 2.0)

-fastutil.version = 7.0.13 (Apache 2.0)
+fastutil.version = 7.1.0 (Apache 2.0)

-httpclient.version = 4.5.2 (Apache 2.0)
+httpclient.version = 4.5.3 (Apache 2.0)

-netty-all.version = 4.1.7.Final (Apache 2.0)
-open-json.version = 1.7 (Apache 2.0)
+netty-all.version = 4.1.8.Final (Apache 2.0)
+open-json.version = 1.8 (Apache 2.0)

-slf4j-api.version = 1.7.22 (MIT)
+slf4j-api.version = 1.7.23 (MIT)

-spring-hateoas.version = 0.21.0.RELEASE (Apache 2.0)
+spring-hateoas.version = 0.23.0.RELEASE (Apache 2.0)

-spring-ldap-core.version = 2.1.0.RELEASE (Apache 2.0)
-spring-security.version = 4.1.3.RELEASE (Apache 2.0)
-spring-tx.version = 4.3.2.RELEASE (Apache 2.0)
-springframework.version = 4.3.2.RELEASE
+spring-ldap-core.version = 2.3.1.RELEASE (Apache 2.0)
+spring-security.version = 4.2.1.RELEASE (Apache 2.0)
+spring-tx.version = 4.3.6.RELEASE (Apache 2.0)
+springframework.version = 4.3.6.RELEASE (Apache 2.0)

-springfox.version=2.6.0 (Apache 2.0)
+springfox.version=2.6.1 (Apache 2.0)

I tried to update selenium.version from 3.0.1 to 3.1.0 but it results in uiTest 
failures so I backed that out and will file a separate Jira ticket for updating 
Selenium.


Diffs (updated)
-

  geode-assembly/src/main/dist/NOTICE 3ce86ba25bb7b52df5c43676a68cf36a37f7d93d 
  geode-pulse/src/main/webapp/META-INF/NOTICE 
95c619c6b6907b9669dcf33648d93bf42f64b28b 
  geode-web-api/src/main/webapp/META-INF/NOTICE 
004cd5fdd6e880e5449d131f837b00d6f3c65ab6 
  geode-web/src/main/webapp/META-INF/NOTICE 
a8caa6b6f4e29c63a6f322ee32c2322185e1dedf 
  gradle/dependency-versions.properties 
12a76b4f7ae46f94e85123945d5ffbcbad6bcb77 

Diff: https://reviews.apache.org/r/56934/diff/


Testing
---

precheckin passed 100% green


Thanks,

Kirk Lund

[jira] [Commented] (GEODE-2520) Add a lucene query test where a bucket is moved while a query is executing

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879287#comment-15879287
 ] 

ASF subversion and git services commented on GEODE-2520:


Commit 0d2397b203060f02b95ece30bf4c7130685b71cd in geode's branch 
refs/heads/feature/GEODE-2460 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0d2397b ]

GEODE-2520: Add a lucene query test where a bucket is moved while a query is 
executing

*  Added LuceneIndexServiceSpy


> Add a lucene query test where a bucket is moved while a query is executing
> --
>
> Key: GEODE-2520
> URL: https://issues.apache.org/jira/browse/GEODE-2520
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> The query should handle this scenario and return the correct results.
> As currently implemented, it should end up retrying the query on the new 
> primary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2514) Need more tests for statistics archive rolling and removal

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879290#comment-15879290
 ] 

ASF subversion and git services commented on GEODE-2514:


Commit 76fa7cc7300359afa83c5df30d3af4043b82da27 in geode's branch 
refs/heads/feature/GEODE-2460 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=76fa7cc ]

GEODE-2514: add new tests for statistics archive rolling and removal

* add MainWithChildrenRollingFileHandlerIntegrationTest
* add StatArchiveHandlerIntegrationTest
* expand DiskSpaceLimitIntegrationTest


> Need more tests for statistics archive rolling and removal
> --
>
> Key: GEODE-2514
> URL: https://issues.apache.org/jira/browse/GEODE-2514
> Project: Geode
>  Issue Type: Wish
>  Components: statistics
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Fix For: 1.2.0
>
>
> We need more integration tests for StatArchiveHandler and 
> MainWithChildrenRollingFileHandler with file system behavior for rolling and 
> removal.
> Rolling is controlled by archive-file-size-limit. Removal is controlled by 
> archive-disk-space-limit.
> Tests should involve the mainId and childId (-01-01) and how they roll. Tests 
> should also involve the marker file used by 
> MainWithChildrenRollingFileHandler.
> Some of the methods that we would like to test in isolation will need to be 
> changed from private to protected (or package private).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879276#comment-15879276
 ] 

ASF GitHub Bot commented on GEODE-2440:
---

Github user mmartell commented on the issue:

https://github.com/apache/geode-native/pull/17
  
Close for now. Resubmit after implementing jbarrett's recommendations.


> Fix CacheableKey::hashcode to int32_t to match Server.
> --
>
> Key: GEODE-2440
> URL: https://issues.apache.org/jira/browse/GEODE-2440
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #17: GEODE-2440: Switch hashcode() return type.

[mmartell]

Github user mmartell closed the pull request at:

https://github.com/apache/geode-native/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #17: GEODE-2440: Switch hashcode() return type.

[mmartell]

Github user mmartell commented on the issue:

https://github.com/apache/geode-native/pull/17
  
Close for now. Resubmit after implementing jbarrett's recommendations.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

commons-beanutils in PR #403

[Kirk Lund]

I'm comparing Anthony's PR with my changes for GEODE-2460, and I'm trying
to understand why we need to add the override for commons-beanutils to
gradle/dependency-resolution.gradle. Without this, GEODE-2460 passes
precheckin and uiTest.

Is there some way to detect that commons-beanutils needs this further
change?

Is there a gradle target that shows we end up using 2 different versions?

GEODE-2460: https://reviews.apache.org/r/56934/
PR #403: https://github.com/apache/geode/pull/403

Thanks,
Kirk

[jira] [Commented] (GEODE-2506) Update spring dependencies

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879249#comment-15879249
 ] 

ASF GitHub Bot commented on GEODE-2506:
---

Github user kirklund commented on the issue:

https://github.com/apache/geode/pull/403
  
I think I should pull this in before applying 
https://reviews.apache.org/r/56934/. My changes for GEODE-2460 are missing the 
webapp NOTICE changes and the change to gradle/dependency-resolution.gradle.


> Update spring dependencies
> --
>
> Key: GEODE-2506
> URL: https://issues.apache.org/jira/browse/GEODE-2506
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Anthony Baker
>
> Update Spring dependencies from 4.3.2 to 4.3.6 to pick up latest maintenance 
> and security fixes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #403: GEODE-2506 Update Spring from 4.3.2 to 4.3.6

[kirklund]

Github user kirklund commented on the issue:

https://github.com/apache/geode/pull/403
  
I think I should pull this in before applying 
https://reviews.apache.org/r/56934/. My changes for GEODE-2460 are missing the 
webapp NOTICE changes and the change to gradle/dependency-resolution.gradle.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEODE-2514) Need more tests for statistics archive rolling and removal

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-2514.
--
   Resolution: Fixed
Fix Version/s: 1.2.0

> Need more tests for statistics archive rolling and removal
> --
>
> Key: GEODE-2514
> URL: https://issues.apache.org/jira/browse/GEODE-2514
> Project: Geode
>  Issue Type: Wish
>  Components: statistics
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Fix For: 1.2.0
>
>
> We need more integration tests for StatArchiveHandler and 
> MainWithChildrenRollingFileHandler with file system behavior for rolling and 
> removal.
> Rolling is controlled by archive-file-size-limit. Removal is controlled by 
> archive-disk-space-limit.
> Tests should involve the mainId and childId (-01-01) and how they roll. Tests 
> should also involve the marker file used by 
> MainWithChildrenRollingFileHandler.
> Some of the methods that we would like to test in isolation will need to be 
> changed from private to protected (or package private).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2526) Enhance log statement in StatsArchiveReader

[Srikanth Manvi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Srikanth Manvi reassigned GEODE-2526:
-

Assignee: Srikanth Manvi

> Enhance log statement in StatsArchiveReader
> ---
>
> Key: GEODE-2526
> URL: https://issues.apache.org/jira/browse/GEODE-2526
> Project: Geode
>  Issue Type: New Feature
>  Components: statistics
>Reporter: Srikanth Manvi
>Assignee: Srikanth Manvi
>
> Rarely stats files are corrupted due to missing ResourceType info in the gfs 
> file. In those cases the gfs files cannot be opened in VSD tool as the tool 
> throws an error while loading.
> The log statement in the method 
> StatsArchiveReader.java(readResourceInstanceCreateToken())  prints out only 
> the missing ResourceTypeId which appears to be dynamically created. 
> If the log message can be enhanced to include the resourceName as well, it 
> will be valuable to know the name of ResourceType that is actually missing in 
> the stats file. 
> There is a [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility which takes in a corrupted stats files, name and id of the missing 
> ResourceType in the corrupted file and outputs a new .gfs file by filling in 
> the missing resource info. The new file can then be loaded and analyzed in 
> VSD.
>  
> For the [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility to be usable one needs to know the actual name of missing 
> resourceType, hence this New feature request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56934: GEODE-2460: update dependency versions

[Kirk Lund]

> On Feb. 22, 2017, 8:11 p.m., Anthony Baker wrote:
> > I'll close my PR in favor of these changes.  However, there are some NOTICE 
> > file updates needed (e.g. see 
> > https://github.com/apache/geode/pull/403/files).

I already approved your PR. We could merge your PR in first?


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56934/#review166406
---


On Feb. 22, 2017, 9:05 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56934/
> ---
> 
> (Updated Feb. 22, 2017, 9:05 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-2460
> https://issues.apache.org/jira/browse/GEODE-2460
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> -asm.version = 5.1 (Apache 2.0)
> +asm.version = 5.2 (Apache 2.0)
> 
> -fastutil.version = 7.0.13 (Apache 2.0)
> +fastutil.version = 7.1.0 (Apache 2.0)
> 
> -httpclient.version = 4.5.2 (Apache 2.0)
> +httpclient.version = 4.5.3 (Apache 2.0)
> 
> -netty-all.version = 4.1.7.Final (Apache 2.0)
> -open-json.version = 1.7 (Apache 2.0)
> +netty-all.version = 4.1.8.Final (Apache 2.0)
> +open-json.version = 1.8 (Apache 2.0)
> 
> -slf4j-api.version = 1.7.22 (MIT)
> +slf4j-api.version = 1.7.23 (MIT)
> 
> -spring-hateoas.version = 0.21.0.RELEASE (Apache 2.0)
> +spring-hateoas.version = 0.23.0.RELEASE (Apache 2.0)
> 
> -spring-ldap-core.version = 2.1.0.RELEASE (Apache 2.0)
> -spring-security.version = 4.1.3.RELEASE (Apache 2.0)
> -spring-tx.version = 4.3.2.RELEASE (Apache 2.0)
> -springframework.version = 4.3.2.RELEASE
> +spring-ldap-core.version = 2.3.1.RELEASE (Apache 2.0)
> +spring-security.version = 4.2.1.RELEASE (Apache 2.0)
> +spring-tx.version = 4.3.6.RELEASE (Apache 2.0)
> +springframework.version = 4.3.6.RELEASE (Apache 2.0)
> 
> -springfox.version=2.6.0 (Apache 2.0)
> +springfox.version=2.6.1 (Apache 2.0)
> 
> I tried to update selenium.version from 3.0.1 to 3.1.0 but it results in 
> uiTest failures so I backed that out and will file a separate Jira ticket for 
> updating Selenium.
> 
> 
> Diffs
> -
> 
>   gradle/dependency-versions.properties 12a76b4 
> 
> Diff: https://reviews.apache.org/r/56934/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed 100% green
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Updated] (GEODE-2525) Replace random number implementation with C++11 standards

[Jacob S. Barrett (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett updated GEODE-2525:

Component/s: native client

> Replace random number implementation with C++11 standards
> -
>
> Key: GEODE-2525
> URL: https://issues.apache.org/jira/browse/GEODE-2525
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Remove Mersenne Twister implementation from source. Use C++11 random where 
> appropriate. Refactor random usage to be thread safe as applicable. GsRansom 
> uses spin lock to protect. Consider thread local random.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2525) Replace random number implementation with C++11 standards

[Jacob S. Barrett (JIRA)]

Jacob S. Barrett created GEODE-2525:
---

 Summary: Replace random number implementation with C++11 standards
 Key: GEODE-2525
 URL: https://issues.apache.org/jira/browse/GEODE-2525
 Project: Geode
  Issue Type: Bug
Reporter: Jacob S. Barrett


Remove Mersenne Twister implementation from source. Use C++11 random where 
appropriate. Refactor random usage to be thread safe as applicable. GsRansom 
uses spin lock to protect. Consider thread local random.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2512) Geode Native docs: book fails to build

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-2512.

Resolution: Fixed

> Geode Native docs: book fails to build
> --
>
> Key: GEODE-2512
> URL: https://issues.apache.org/jira/browse/GEODE-2512
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The geode native book fails to build. Need to update and correct the config 
> files in ../geode-native/docs/geode-native-book, and (once book generation is 
> restored) the README.md file needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2512) Geode Native docs: book fails to build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879204#comment-15879204
 ] 

ASF GitHub Bot commented on GEODE-2512:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/20


> Geode Native docs: book fails to build
> --
>
> Key: GEODE-2512
> URL: https://issues.apache.org/jira/browse/GEODE-2512
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The geode native book fails to build. Need to update and correct the config 
> files in ../geode-native/docs/geode-native-book, and (once book generation is 
> restored) the README.md file needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #20: GEODE-2512 Geode Native docs: book fails to b...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2512) Geode Native docs: book fails to build

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879201#comment-15879201
 ] 

ASF subversion and git services commented on GEODE-2512:


Commit 63e89434dc27b2d23fa7b33037d9abebb8ec912c in geode-native's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=63e8943 ]

GEODE-2512 Geode Native docs: book fails to build
This closes #20.


> Geode Native docs: book fails to build
> --
>
> Key: GEODE-2512
> URL: https://issues.apache.org/jira/browse/GEODE-2512
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The geode native book fails to build. Need to update and correct the config 
> files in ../geode-native/docs/geode-native-book, and (once book generation is 
> restored) the README.md file needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2514) Need more tests for statistics archive rolling and removal

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879200#comment-15879200
 ] 

ASF subversion and git services commented on GEODE-2514:


Commit 76fa7cc7300359afa83c5df30d3af4043b82da27 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=76fa7cc ]

GEODE-2514: add new tests for statistics archive rolling and removal

* add MainWithChildrenRollingFileHandlerIntegrationTest
* add StatArchiveHandlerIntegrationTest
* expand DiskSpaceLimitIntegrationTest


> Need more tests for statistics archive rolling and removal
> --
>
> Key: GEODE-2514
> URL: https://issues.apache.org/jira/browse/GEODE-2514
> Project: Geode
>  Issue Type: Wish
>  Components: statistics
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> We need more integration tests for StatArchiveHandler and 
> MainWithChildrenRollingFileHandler with file system behavior for rolling and 
> removal.
> Rolling is controlled by archive-file-size-limit. Removal is controlled by 
> archive-disk-space-limit.
> Tests should involve the mainId and childId (-01-01) and how they roll. Tests 
> should also involve the marker file used by 
> MainWithChildrenRollingFileHandler.
> Some of the methods that we would like to test in isolation will need to be 
> changed from private to protected (or package private).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2339) Update gfcpp src

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-2339.
-
Resolution: Fixed

> Update gfcpp src
> 
>
> Key: GEODE-2339
> URL: https://issues.apache.org/jira/browse/GEODE-2339
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> Parent task



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2346) Update GemfireStatisticsFactory

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-2346.
-
Resolution: Fixed

> Update  GemfireStatisticsFactory
> 
>
> Key: GEODE-2346
> URL: https://issues.apache.org/jira/browse/GEODE-2346
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Ernest Burghardt
>
> Gem fire => Geode transformation
> the following files are called Gemfire* let's make them Geode*
> src//cppcache/src/statistics/GemfireStatisticsFactory.cpp
> src//cppcache/src/statistics/GemfireStatisticsFactory.hpp
> Also, update inclusions usage and named components as appropriate.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2357) Update cli quickstarts

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-2357.
-
Resolution: Fixed

> Update cli quickstarts
> --
>
> Key: GEODE-2357
> URL: https://issues.apache.org/jira/browse/GEODE-2357
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Michael Martell
>
> Transform Gemfire => Geode as appropriate



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2524) Refactor LuceneIntegration Tests

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-2524:
---
Description: 
After refactoring the dunit tests, we should probably have the same structure 
for the integration tests.  This means changing them to use parameters and 
removing as many tests inheritance as possible.

Relates to GEODE-2522

  was:After refactoring the dunit tests, we should probably have the same 
structure for the integration tests.  This means changing them to use 
parameters and removing as many tests inheritance as possible.


> Refactor LuceneIntegration Tests
> 
>
> Key: GEODE-2524
> URL: https://issues.apache.org/jira/browse/GEODE-2524
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Jason Huynh
>
> After refactoring the dunit tests, we should probably have the same structure 
> for the integration tests.  This means changing them to use parameters and 
> removing as many tests inheritance as possible.
> Relates to GEODE-2522



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2524) Refactor LuceneIntegration Tests

[Jason Huynh (JIRA)]

Jason Huynh created GEODE-2524:
--

 Summary: Refactor LuceneIntegration Tests
 Key: GEODE-2524
 URL: https://issues.apache.org/jira/browse/GEODE-2524
 Project: Geode
  Issue Type: Improvement
  Components: lucene
Reporter: Jason Huynh


After refactoring the dunit tests, we should probably have the same structure 
for the integration tests.  This means changing them to use parameters and 
removing as many tests inheritance as possible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2522) Refactor Lucene D Unit tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879137#comment-15879137
 ] 

ASF subversion and git services commented on GEODE-2522:


Commit a63b8302a07475c1726c891152daa9f8947091a6 in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a63b830 ]

GEODE-2522: Flattened heirarchy of Lucene DUnit tests


> Refactor Lucene D Unit tests
> 
>
> Key: GEODE-2522
> URL: https://issues.apache.org/jira/browse/GEODE-2522
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Jason Huynh
>
> Currently our dunit tests for lucene are organized as a tree heirarchy based 
> on region types.  This makes it difficult to add a tests for a specific type 
> of region type as other test files can possibly extend the file we add the 
> test to.
> Instead we can use parameterized tests and flatten the heirarchy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2522) Refactor Lucene D Unit tests

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reassigned GEODE-2522:
--

Assignee: Jason Huynh

> Refactor Lucene D Unit tests
> 
>
> Key: GEODE-2522
> URL: https://issues.apache.org/jira/browse/GEODE-2522
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> Currently our dunit tests for lucene are organized as a tree heirarchy based 
> on region types.  This makes it difficult to add a tests for a specific type 
> of region type as other test files can possibly extend the file we add the 
> test to.
> Instead we can use parameterized tests and flatten the heirarchy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56934: GEODE-2460: update dependency versions

[Anthony Baker]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56934/#review166406
---



I'll close my PR in favor of these changes.  However, there are some NOTICE 
file updates needed (e.g. see https://github.com/apache/geode/pull/403/files).

- Anthony Baker


On Feb. 22, 2017, 5:09 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56934/
> ---
> 
> (Updated Feb. 22, 2017, 5:09 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-2460
> https://issues.apache.org/jira/browse/GEODE-2460
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> -asm.version = 5.1
> +asm.version = 5.2
> 
> -fastutil.version = 7.0.13
> +fastutil.version = 7.1.0
> 
> -httpclient.version = 4.5.2
> +httpclient.version = 4.5.3
> 
> -netty-all.version = 4.1.7.Final
> -open-json.version = 1.7
> +netty-all.version = 4.1.8.Final
> +open-json.version = 1.8
> 
> -slf4j-api.version = 1.7.22
> +slf4j-api.version = 1.7.23
> 
> -spring-hateoas.version = 0.21.0.RELEASE
> +spring-hateoas.version = 0.23.0.RELEASE
> 
> -spring-ldap-core.version = 2.1.0.RELEASE
> -spring-security.version = 4.1.3.RELEASE
> -spring-tx.version = 4.3.2.RELEASE
> -springframework.version = 4.3.2.RELEASE
> +spring-ldap-core.version = 2.3.1.RELEASE
> +spring-security.version = 4.2.1.RELEASE
> +spring-tx.version = 4.3.6.RELEASE
> +springframework.version = 4.3.6.RELEASE
> 
> -springfox.version=2.6.0
> +springfox.version=2.6.1
> 
> I tried to update selenium.version from 3.0.1 to 3.1.0 but it results in 
> uiTest failures so I backed that out and will file a separate Jira ticket for 
> updating Selenium.
> 
> 
> Diffs
> -
> 
>   gradle/dependency-versions.properties 12a76b4 
> 
> Diff: https://reviews.apache.org/r/56934/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed 100% green
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: [jira] [Created] (GEODE-2435) Redis adapter MULTI behavior is different from Redis

[Swapnil Bawaskar]

Indeed, all you need to do is set -Dgemfire.ALLOW_PERSISTENT_TRANSACTIONS
to true

On Tue, Feb 21, 2017 at 5:22 PM Michael Stolz  wrote:

> This looks like the persistence with transactions issue that Gemfire has.
> There is a system property to allow it to work
>
> --
> Mike Stolz
> Principal Engineer - Gemfire Product Manager
> Mobile: 631-835-4771 <(631)%20835-4771>
>
> On Feb 6, 2017 4:41 PM, "Galen O'Sullivan (JIRA)"  wrote:
>
> > Galen O'Sullivan created GEODE-2435:
> > ---
> >
> >  Summary: Redis adapter MULTI behavior is different from
> Redis
> >  Key: GEODE-2435
> >  URL: https://issues.apache.org/jira/browse/GEODE-2435
> >  Project: Geode
> >   Issue Type: Bug
> > Reporter: Galen O'Sullivan
> >
> >
> > {{WATCH}} isn't implemented properly, but this is about returning an
> error
> > instead of nil when we have a {{MULTI}} fail:
> > {code}
> > $ redis-cli -p 11212
> > 127.0.0.1:11212> set a b
> > OK
> > 127.0.0.1:11212> watch a
> > (error) ERR Keys cannot be watched or unwatched because GemFire watches
> > all keys by default for transactions
> > 127.0.0.1:11212> lpush la boo
> > (integer) 1
> > (2.09s)
> > 127.0.0.1:11212> multi
> > OK
> > 127.0.0.1:11212> lpush la z
> > QUEUED
> > 127.0.0.1:11212> lpush la x
> > QUEUED
> > {code}
> > At this point, we {{lpush la foo}} in a different client, then:
> > {code}
> > 127.0.0.1:11212> exec
> > 1) (error) ERR The server had an internal error please try again
> > 2) (error) ERR The server had an internal error please try again
> > 127.0.0.1:11212>
> > {code}
> >
> > whereas a Redis instance will simply return nil instead of an error.
> >
> > Looking in the logs, I see this:
> > {code}
> > [error 2017/02/06 13:21:39.493 PST server2
> 
> > tid=0x2a] GeodeRedisServer-Unexpected error handler for [id: 0x3ddf9f21,
> /
> > 127.0.0.1:58862 => /127.0.0.1:11212]
> > java.lang.UnsupportedOperationException: Operations on persist-backup
> > regions are not allowed because this thread has an active transaction
> > at org.apache.geode.internal.cache.TXRegionState.(
> > TXRegionState.java:60)
> > at org.apache.geode.internal.cache.TXBucketRegionState.<
> > init>(TXBucketRegionState.java:29)
> > at org.apache.geode.internal.cache.TXState.writeRegion(
> > TXState.java:252)
> > at org.apache.geode.internal.cache.TXState.txWriteRegion(
> > TXState.java:1110)
> > at org.apache.geode.internal.cache.TXState.txReadEntry(
> > TXState.java:1365)
> > at org.apache.geode.internal.cache.TXState.txReadEntry(
> > TXState.java:1344)
> > at org.apache.geode.internal.cache.TXState.
> > getDeserializedValue(TXState.java:1414)
> > at org.apache.geode.internal.cache.TXStateProxyImpl.
> > getDeserializedValue(TXStateProxyImpl.java:352)
> > at org.apache.geode.internal.cache.LocalRegion.get(
> > LocalRegion.java:1394)
> > at org.apache.geode.internal.cache.PartitionedRegionDataStore.
> > getLocally(PartitionedRegionDataStore.java:2047)
> > at org.apache.geode.internal.cache.PartitionedRegion.
> > getFromBucket(PartitionedRegion.java:4022)
> > at org.apache.geode.internal.cache.PartitionedRegion.
> > findObjectInSystem(PartitionedRegion.java:3399)
> > at org.apache.geode.internal.cache.TXState.findObject(
> > TXState.java:1540)
> > at org.apache.geode.internal.cache.TXStateProxyImpl.
> > findObject(TXStateProxyImpl.java:614)
> > at org.apache.geode.internal.cache.PartitionedRegion.get(
> > PartitionedRegion.java:3160)
> > at org.apache.geode.internal.cache.LocalRegion.get(
> > LocalRegion.java:1330)
> > at org.apache.geode.internal.cache.AbstractRegion.get(
> > AbstractRegion.java:282)
> > at org.apache.geode.redis.internal.executor.list.
> > ListExecutor.pushElements(ListExecutor.java:70)
> > at org.apache.geode.redis.internal.executor.list.
> > PushExecutor.executeCommand(PushExecutor.java:47)
> > at org.apache.geode.redis.internal.ExecutionHandlerContext.
> > executeWithTransaction(ExecutionHandlerContext.java:244)
> > at org.apache.geode.redis.internal.ExecutionHandlerContext.
> > executeCommand(ExecutionHandlerContext.java:191)
> > at org.apache.geode.redis.internal.ExecutionHandlerContext.
> > channelRead(ExecutionHandlerContext.java:137)
> > at io.netty.channel.DefaultChannelHandlerContext.
> > invokeChannelRead(DefaultChannelHandlerContext.java:368)
> > at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(
> > DefaultChannelHandlerContext.java:353)
> > at io.netty.handler.codec.ByteToMessageDecoder.channelRead(
> > ByteToMessageDecoder.java:173)
> > at io.netty.channel.DefaultChannelHandlerContext.
> > invokeChannelRead(DefaultChannelHandlerContext.java:368)
> > at 

Re: off heap

[Anthony Baker]

Hi Dor,

Here’s a few documentation links on off-heap usage:

https://geode.apache.org/docs/guide/managing/heap_use/off_heap_management.html
https://www.slideshare.net/PivotalOpenSourceHub/apache-geode-offheap-storage

Does that help?

Thanks,
Anthony


> On Feb 22, 2017, at 11:17 AM, Dor Ben Dov  wrote:
> 
> Hi,
> 
> Can one tell me how does the off heap flags solution is being done. I mean 
> what solution is being used for it ? 
> 
> 
> 
> Regards,
> Dor
> This message and the information contained herein is proprietary and 
> confidential and subject to the Amdocs policy statement,
> 
> you may review at http://www.amdocs.com/email_disclaimer.asp

off heap

[Dor Ben Dov]

Hi,

Can one tell me how does the off heap flags solution is being done. I mean what 
solution is being used for it ? 



Regards,
Dor
This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at http://www.amdocs.com/email_disclaimer.asp

Re: Review Request 56933: Attempt to refactor the Lucene DUnit tests

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56933/#review166391
---




geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
(line 70)


If ACCESSOR_PARTITION and PARTITION_PROXY have the same effect we can 
remove one of them as they both zero local max memory.


- nabarun nag


On Feb. 22, 2017, 5:09 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56933/
> ---
> 
> (Updated Feb. 22, 2017, 5:09 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, 
> Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> LuceneDUnitTest and LuceneQueriesAccessorBase are base type classes similar 
> to the old LuceneDUnitTest and LuceneQueriesBase. 
> 
> Made the tests parameterized with a RegionTestableType enum.  This enum 
> "knows" how to create a region provided a cache and a name.
> 
> Renamed the tests by functionality
> 
> Some of the refactoring is a bit clunky as some of our tests were expecting a 
> different behavior with initDataStore based on the region type.  If it were 
> not for that, 2 more classes could have been removed.
> 
> If this is ok, then we'd probably want to change the Integration tests to 
> look similar.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
> 9318b0e 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java
>  6a02a25 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationOnFixedPRDUnitTest.java
>  7de12e3 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesAccessorBase.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesBase.java
>  1b1167c 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesClientDUnitTest.java
>  36ede16 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
>  9c2f6ed 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerFixedPRDUnitTest.java
>  2622063 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRDUnitTest.java
>  f65777f 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java
>  86ce713 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java
>  4e809ce 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
>  1b4303a 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceWithRedundancyDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
>  5a6f774 
> 
> Diff: https://reviews.apache.org/r/56933/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 56933: Attempt to refactor the Lucene DUnit tests

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56933/#review166392
---


Ship it!




Ship It!

- nabarun nag


On Feb. 22, 2017, 5:09 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56933/
> ---
> 
> (Updated Feb. 22, 2017, 5:09 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, 
> Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> LuceneDUnitTest and LuceneQueriesAccessorBase are base type classes similar 
> to the old LuceneDUnitTest and LuceneQueriesBase. 
> 
> Made the tests parameterized with a RegionTestableType enum.  This enum 
> "knows" how to create a region provided a cache and a name.
> 
> Renamed the tests by functionality
> 
> Some of the refactoring is a bit clunky as some of our tests were expecting a 
> different behavior with initDataStore based on the region type.  If it were 
> not for that, 2 more classes could have been removed.
> 
> If this is ok, then we'd probably want to change the Integration tests to 
> look similar.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
> 9318b0e 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java
>  6a02a25 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationOnFixedPRDUnitTest.java
>  7de12e3 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesAccessorBase.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesBase.java
>  1b1167c 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesClientDUnitTest.java
>  36ede16 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
>  9c2f6ed 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerFixedPRDUnitTest.java
>  2622063 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRDUnitTest.java
>  f65777f 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java
>  86ce713 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java
>  4e809ce 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
>  1b4303a 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/RebalanceWithRedundancyDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
>  5a6f774 
> 
> Diff: https://reviews.apache.org/r/56933/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[jira] [Commented] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878986#comment-15878986
 ] 

ASF GitHub Bot commented on GEODE-2440:
---

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/17
  
Please close this pull request and resubmit when you have cleaned up all 
the places that use hashcode.


> Fix CacheableKey::hashcode to int32_t to match Server.
> --
>
> Key: GEODE-2440
> URL: https://issues.apache.org/jira/browse/GEODE-2440
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #17: GEODE-2440: Switch hashcode() return type.

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/17
  
Please close this pull request and resubmit when you have cleaned up all 
the places that use hashcode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2516) Script to Run Quickstarts not exectable

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878979#comment-15878979
 ] 

ASF subversion and git services commented on GEODE-2516:


Commit 59cfa9f64d70c5285fdc854a56abcd03830d8ef7 in geode-native's branch 
refs/heads/develop from [~mmartell]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=59cfa9f ]

GEODE-2516: Fix quickstart install to retain permissions.

- By default cmake install unsets the execute bit. To retain it add 
USE_SOURCE_PERMISSIONS flag.

This closes #22.


> Script to Run Quickstarts not exectable
> ---
>
> Key: GEODE-2516
> URL: https://issues.apache.org/jira/browse/GEODE-2516
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>
> The runcpp.sh script for running the native client quickstarts is not 
> executable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2516) Script to Run Quickstarts not exectable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878980#comment-15878980
 ] 

ASF GitHub Bot commented on GEODE-2516:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/22


> Script to Run Quickstarts not exectable
> ---
>
> Key: GEODE-2516
> URL: https://issues.apache.org/jira/browse/GEODE-2516
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>
> The runcpp.sh script for running the native client quickstarts is not 
> executable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #22: GEODE-2516: Fix quickstart install to retain ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2478) Replace gf with geode

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878975#comment-15878975
 ] 

ASF subversion and git services commented on GEODE-2478:


Commit 46f71fde815fdfbfc6b7c16534eb91e275cbbcc0 in geode-native's branch 
refs/heads/develop from [~PivotalSarge]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=46f71fd ]

GEODE-2478: Replace gf with geode.

- Rename directories and files with gf into their name to
  instead use geode and update all references thereto.
- Ensure formatting style guide compliance.
- Elide duplicate GEODE_ from include guards.

This closes #23.


> Replace gf with geode
> -
>
> Key: GEODE-2478
> URL: https://issues.apache.org/jira/browse/GEODE-2478
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>
> The substring "gf" still occurs in some places in the native client codebase. 
> It ought to be replaced with "geode" or "geode-native", whichever makes more 
> sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2478) Replace gf with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878977#comment-15878977
 ] 

ASF GitHub Bot commented on GEODE-2478:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/23


> Replace gf with geode
> -
>
> Key: GEODE-2478
> URL: https://issues.apache.org/jira/browse/GEODE-2478
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>
> The substring "gf" still occurs in some places in the native client codebase. 
> It ought to be replaced with "geode" or "geode-native", whichever makes more 
> sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #23: GEODE-2478: Replace gf with geode.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (GEODE-2522) Refactor Lucene D Unit tests

[Jason Huynh (JIRA)]

Jason Huynh created GEODE-2522:
--

 Summary: Refactor Lucene D Unit tests
 Key: GEODE-2522
 URL: https://issues.apache.org/jira/browse/GEODE-2522
 Project: Geode
  Issue Type: Improvement
  Components: lucene
Reporter: Jason Huynh


Currently our dunit tests for lucene are organized as a tree heirarchy based on 
region types.  This makes it difficult to add a tests for a specific type of 
region type as other test files can possibly extend the file we add the test to.

Instead we can use parameterized tests and flatten the heirarchy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2478) Replace gf with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878969#comment-15878969
 ] 

ASF GitHub Bot commented on GEODE-2478:
---

Github user PivotalSarge commented on the issue:

https://github.com/apache/geode-native/pull/23
  
Good idea. I think you're right about redundancies. I'll look into that.

Sarge

> On 22 Feb, 2017, at 10:48, Jacob Barrett  wrote:
> 
> @pivotal-jbarrett approved this pull request.
> 
> I would suggest opening a ticket with any cleanup ideas you may have seen 
when going through all these headers. Seems like geode_defs and geode_base and 
and whatever generically named includes we have might be fairly redundant and 
ripe for cleanup or reorganization.
> 
> Otherwise this looks good.
> 
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
> 




> Replace gf with geode
> -
>
> Key: GEODE-2478
> URL: https://issues.apache.org/jira/browse/GEODE-2478
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>
> The substring "gf" still occurs in some places in the native client codebase. 
> It ought to be replaced with "geode" or "geode-native", whichever makes more 
> sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #23: GEODE-2478: Replace gf with geode.

[PivotalSarge]

Github user PivotalSarge commented on the issue:

https://github.com/apache/geode-native/pull/23
  
Good idea. I think you're right about redundancies. I'll look into that.

Sarge

> On 22 Feb, 2017, at 10:48, Jacob Barrett  wrote:
> 
> @pivotal-jbarrett approved this pull request.
> 
> I would suggest opening a ticket with any cleanup ideas you may have seen 
when going through all these headers. Seems like geode_defs and geode_base and 
and whatever generically named includes we have might be fairly redundant and 
ripe for cleanup or reorganization.
> 
> Otherwise this looks good.
> 
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
> 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...

[echobravopapa]

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102539038
  
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
   for (int i = 0; i < PATH_MAX && path[i] != 0; i++) {
 path[i] = ::tolower(path[i]);
   }
-  dllNamePtr = strstr(path, "apache-geode.dll");
+  std::string cppName = PRODUCT_LIB_NAME;
+  cppName += ".dll";
+  std::string dotNetName = PRODUCT_DLL_NAME;
+  dotNetName += ".dll";
+  dllNamePtr = strstr(path, cppName.c_str());
--- End diff --

fair nit 👍 will change it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2508) Generize lib naming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878945#comment-15878945
 ] 

ASF GitHub Bot commented on GEODE-2508:
---

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102539038
  
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
   for (int i = 0; i < PATH_MAX && path[i] != 0; i++) {
 path[i] = ::tolower(path[i]);
   }
-  dllNamePtr = strstr(path, "apache-geode.dll");
+  std::string cppName = PRODUCT_LIB_NAME;
+  cppName += ".dll";
+  std::string dotNetName = PRODUCT_DLL_NAME;
+  dotNetName += ".dll";
+  dllNamePtr = strstr(path, cppName.c_str());
--- End diff --

fair nit  will change it


> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2508) Generize lib naming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878943#comment-15878943
 ] 

ASF GitHub Bot commented on GEODE-2508:
---

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102538789
  
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
 $
 )
 add_dependencies(client-libraries apache-geode)
-set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}")
+set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}" OUTPUT_NAME ${PRODUCT_LIB_NAME} )
--- End diff --

will adjust that.  cmake did not like duplicate calls to 
set_target_properites


> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...

[echobravopapa]

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/24#discussion_r102538789
  
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
 $
 )
 add_dependencies(client-libraries apache-geode)
-set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}")
+set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER 
"${PUBLIC_HEADERS}" OUTPUT_NAME ${PRODUCT_LIB_NAME} )
--- End diff --

will adjust that.  cmake did not like duplicate calls to 
set_target_properites


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2521) geode native docs: Document installation from source

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2521:
---
Description: Update installation instructions to include building from 
source. Binary distributions will also (presumably) be available on the 
website's Releases page. (See the installation section of the Geode user manual 
for a model to follow.)  (was: Update installation instructions to include 
building from source. Binary distributions will also (presumably) be available 
on the website's Releases page.)

> geode native docs: Document installation from source
> 
>
> Key: GEODE-2521
> URL: https://issues.apache.org/jira/browse/GEODE-2521
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> Update installation instructions to include building from source. Binary 
> distributions will also (presumably) be available on the website's Releases 
> page. (See the installation section of the Geode user manual for a model to 
> follow.)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)