Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57573/#review169096
---


Ship it!




Ship It!

- Jinmei Liao


On March 15, 2017, 8:02 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57573/
> ---
> 
> (Updated March 15, 2017, 8:02 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2648
> https://issues.apache.org/jira/browse/GEODE-2648
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2648: always move deleted files to dirOfDeletedFiles
> 
> Fix flaky test by always moving deleted files to dirOfDeletedFiles to avoid 
> race condition in which file is deleted before its presence can be detected.
> 
> Update:
> ```java
> // Arrays.asList returns unmodifiable list
> List unmodifiable = Arrays.asList("Larry", "Moe", "Curly");
> unmodifiable.remove("Curly"); <-- throws UnsupportedOperationException
> ```
> I created a new modifiable version of asList and added it to the Geode 
> ArrayUtils class and used this new utility in DiskSpaceLimitIntegrationTest 
> as part of the recommendation in Ken's review.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/util/ArrayUtils.java 
> 3459e16c8f9b4c7d0ebb070bba2e0b2e55a69381 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java
>  5d94fa0ba32aabc0f0bfc396d99d0b5ef9572360 
>   
> geode-core/src/test/java/org/apache/geode/internal/util/ArrayUtilsJUnitTest.java
>  3ec8b12b5ad7bc86556d1259be0b3e2e9a240845 
>   geode-core/src/test/java/org/apache/geode/internal/util/ArrayUtilsTest.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57573/diff/2/
> 
> 
> Testing
> ---
> 
> DiskSpaceLimitIntegrationTest
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57573/#review169085
---


Ship it!




Ship It!

- Kevin Duling


On March 15, 2017, 1:02 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57573/
> ---
> 
> (Updated March 15, 2017, 1:02 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2648
> https://issues.apache.org/jira/browse/GEODE-2648
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2648: always move deleted files to dirOfDeletedFiles
> 
> Fix flaky test by always moving deleted files to dirOfDeletedFiles to avoid 
> race condition in which file is deleted before its presence can be detected.
> 
> Update:
> ```java
> // Arrays.asList returns unmodifiable list
> List unmodifiable = Arrays.asList("Larry", "Moe", "Curly");
> unmodifiable.remove("Curly"); <-- throws UnsupportedOperationException
> ```
> I created a new modifiable version of asList and added it to the Geode 
> ArrayUtils class and used this new utility in DiskSpaceLimitIntegrationTest 
> as part of the recommendation in Ken's review.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/util/ArrayUtils.java 
> 3459e16c8f9b4c7d0ebb070bba2e0b2e55a69381 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java
>  5d94fa0ba32aabc0f0bfc396d99d0b5ef9572360 
>   
> geode-core/src/test/java/org/apache/geode/internal/util/ArrayUtilsJUnitTest.java
>  3ec8b12b5ad7bc86556d1259be0b3e2e9a240845 
>   geode-core/src/test/java/org/apache/geode/internal/util/ArrayUtilsTest.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57573/diff/2/
> 
> 
> Testing
> ---
> 
> DiskSpaceLimitIntegrationTest
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: region put followed by region getEntry returns null

[Darrel Schneider]

The problem with this test is that is does register interest. The first
client that calls the put method does 2 puts, then a clear, then 2 puts,
then a clear. All of those ops get sent async to the other client. So when
you call the same put method on the second client it can be receiving the
events from the first client. When you see the "null" right after client 2
did a put it is because you processed one of the clears from client1.

>From looking at this test it is unclear to me why is does puts and clears.
For the health stats it is trying to verify I would not think any of these
ops are needed. Or you could add some type of listener on client2 and wait
for it to see 2 clears before you have it execute the put task.

Hope this helps

On Wed, Mar 15, 2017 at 9:20 AM, Kirk Lund  wrote:

> I'm looking into a CI test failure
> (ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled). I
> don't see anything wrong with the test so far.
>
> It looks to me like region.getEntry(KEY1) must have either returned a null
> RegionEntry or RegionEntry.getValue returned a null immediately after the
> same thread that just called region.put(KEY1, VALUE1). I'm looking for
> confirmation that this is incorrect behavior or more info about how and why
> this would be correct:
>
>   private static final String KEY1 = "KEY1";
>   private static final String VALUE1 = "VALUE1";
>
> 365: Cache cache = (Cache) clientCache;
> 366: Region region = cache.getRegion(Region.SEPARATOR +
> REGION_NAME);
> 367:
> 368: *region.put(KEY1, VALUE1);*
> 369: *assertThat(region.getEntry(KEY1).getValue()).isEqualTo(VALUE1); <--
> throws NPE*
>
> The following is the setup code that configured and created clientCache:
>
> Properties props = new Properties();
> props.setProperty(STATISTIC_SAMPLING_ENABLED, "true");
>
> ClientCacheFactory cacheFactory = new ClientCacheFactory(props);
> if (subscriptionEnabled) {
>   cacheFactory.setPoolSubscriptionEnabled(true);
>   cacheFactory.setPoolSubscriptionAckInterval(50);
>   cacheFactory.setPoolSubscriptionRedundancy(0);
> }
>
> cacheFactory.set(DURABLE_CLIENT_ID, "DurableClientId_" + clientNum);
> cacheFactory.set(DURABLE_CLIENT_TIMEOUT, "" + 3);
>
> cacheFactory.addPoolServer(hostName, port);
> clientCache = cacheFactory.create();
>
> ClientRegionFactory regionFactory =
>
> clientCache.createClientRegionFactory(ClientRegionShortcut.CACHING_PROXY);
> regionFactory.setConcurrencyChecksEnabled(false);
>
> regionFactory.addCacheListener(new CacheListenerAdapter String>() {
>   @Override
>   public void afterInvalidate(final EntryEvent event) {
> numOfInvalidates++;
>   }
>
>   @Override
>   public void afterCreate(final EntryEvent event) {
> if ("last_key".equals(event.getKey())) {
>   lastKeyReceived = true;
> }
> numOfCreates++;
>   }
>
>   @Override
>   public void afterUpdate(final EntryEvent event) {
> numOfUpdates++;
>   }
> });
>
> Region region = regionFactory.create(REGION_NAME);
> if (subscriptionEnabled) {
>   region.registerInterest("ALL_KEYS", true);
>   clientCache.readyForEvents();
> }
>   }
>
> The following is the stack trace showing the NPE:
>
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.management.ClientHealthStatsDUnitTest$$
> Lambda$193/1653332728.run
> in VM 3 running on Host asf902.gq1.ygridcore.net with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
> at
> org.apache.geode.management.ClientHealthStatsDUnitTest.
> testClientHealthStats_SubscriptionEnabled(ClientHealthStatsDUnitTest.
> java:128)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(
> FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(
> ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(
> FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.
> evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.
> evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(
> RunAfters.java:27)
> at
> org.apache.geode.management.ManagementTestRule$2.evaluate(
> ManagementTestRule.java:86)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> 

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927107#comment-15927107
 ] 

ASF subversion and git services commented on GEODE-2513:


Commit 0138dbd5a753c7671c82773fcee76f847a6edebb in geode-native's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=0138dbd ]

GEODE-2513 Unbrand Programming Examples section

- also removed ancient examples, and replaced them with pointers
to the QuickStart examples


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #57: GEODE-2513 Unbrand Programming Examples secti...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/57


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927104#comment-15927104
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-native/pull/58

GEODE-2513 Unbrand Transactions section of doc

- Also updated an instance of an old package namespace

@davebarnes97 @joeymcallister @dgkimura @mmartell @echobravopapa 
@PivotalSarge Please review this PR that updates the Transactions section of 
the documentation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-native 
feature/GEODE-2513-9

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #58


commit 89245fb378808d594debdd721d8ef199b3017f1d
Author: Karen Miller 
Date:   2017-03-15T22:27:47Z

GEODE-2513 Unbrand Transactions section of doc

- Also updated an instance of an old package namespace




> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #58: GEODE-2513 Unbrand Transactions section of do...

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-native/pull/58

GEODE-2513 Unbrand Transactions section of doc

- Also updated an instance of an old package namespace

@davebarnes97 @joeymcallister @dgkimura @mmartell @echobravopapa 
@PivotalSarge Please review this PR that updates the Transactions section of 
the documentation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-native 
feature/GEODE-2513-9

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #58


commit 89245fb378808d594debdd721d8ef199b3017f1d
Author: Karen Miller 
Date:   2017-03-15T22:27:47Z

GEODE-2513 Unbrand Transactions section of doc

- Also updated an instance of an old package namespace




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2645) Refactor CacheLogRollDUnitTest to be an IntegrationTest

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927061#comment-15927061
 ] 

ASF subversion and git services commented on GEODE-2645:


Commit ca7a456a3470d0aa495ba8872dff5445cd3eedb7 in geode's branch 
refs/heads/feature/GEODE-2645 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ca7a456 ]

GEODE-2645: rewrite test to fix flakiness and improve readability


> Refactor CacheLogRollDUnitTest to be an IntegrationTest
> ---
>
> Key: GEODE-2645
> URL: https://issues.apache.org/jira/browse/GEODE-2645
> Project: Geode
>  Issue Type: Wish
>  Components: logging, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> CacheLogRollDUnitTest appears to only use one JVM so it should be ported from 
> using DUnit to being a more simple IntegrationTest.
> It also has 4 flaky test bugs:
> * GEODE-674
> * GEODE-675
> * GEODE-676
> * GEODE-677
> If possible, test cleanup should also try to resolve the flakiness in these 
> tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57660: GEODE-2536: Do not change keyId for persistent region DiskId

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57660/#review169063
---


Ship it!




Ship It!

- Darrel Schneider


On March 15, 2017, 2:10 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57660/
> ---
> 
> (Updated March 15, 2017, 2:10 p.m.)
> 
> 
> Review request for geode, anilkumar gingade and Darrel Schneider.
> 
> 
> Bugs: GEODE-2536
> https://issues.apache.org/jira/browse/GEODE-2536
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> markForWriting and unmarkForWriting should not used for persistent region.
> needsToBeWritten always return false now for persistent region, as the 
> diskEntry either is being written to disk (sync) or sheduled to be written to 
> disk (async)
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskEntry.java 
> bde6a32 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskId.java 
> e802ac9 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> cce8100 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/DiskIdJUnitTest.java 
> 195c6a2 
> 
> 
> Diff: https://reviews.apache.org/r/57660/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

[jira] [Reopened] (GEODE-2398) Sporadic Oplog corruption due to channel.write failure

[Anilkumar Gingade (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anilkumar Gingade reopened GEODE-2398:
--

We need to make similar change (as done by ken in Oplog)  in OverflowOplog".

> Sporadic Oplog corruption due to channel.write failure
> --
>
> Key: GEODE-2398
> URL: https://issues.apache.org/jira/browse/GEODE-2398
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
> Fix For: 1.2.0
>
>
> There have been some occurrences of Oplog corruption during testing that have 
> been traced to failures in writing oplog entries to the .crf file. When it 
> fails, Oplog.flush attempts to write a ByteBuffer to the file channel. The 
> call to channel.write(bb) method returns 0 bytes written, but the source 
> ByteBuffer position is moved to the ByteBuffer limit.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2398) Sporadic Oplog corruption due to channel.write failure

[Anilkumar Gingade (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anilkumar Gingade reassigned GEODE-2398:


Assignee: Anilkumar Gingade  (was: Kenneth Howe)

> Sporadic Oplog corruption due to channel.write failure
> --
>
> Key: GEODE-2398
> URL: https://issues.apache.org/jira/browse/GEODE-2398
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Kenneth Howe
>Assignee: Anilkumar Gingade
> Fix For: 1.2.0
>
>
> There have been some occurrences of Oplog corruption during testing that have 
> been traced to failures in writing oplog entries to the .crf file. When it 
> fails, Oplog.flush attempts to write a ByteBuffer to the file channel. The 
> call to channel.write(bb) method returns 0 bytes written, but the source 
> ByteBuffer position is moved to the ByteBuffer limit.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57660: GEODE-2536: Do not change keyId for persistent region DiskId

[Eric Shu]

> On March 15, 2017, 8:53 p.m., anilkumar gingade wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/DiskEntry.java
> > Line 1691 (original), 1691 (patched)
> > 
> >
> > We should remove this comment as it doesn't make sense for Geode...

This will be addressed when fixing GEODE-2535.


> On March 15, 2017, 8:53 p.m., anilkumar gingade wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
> > Line 706 (original), 706 (patched)
> > 
> >
> > How about using, "isKeyIdNegative"...

This will not be applied once the GEODE-2535 is fixed. KeyId will be final for 
persistent region. No need to change for this checkin.


- Eric


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57660/#review169056
---


On March 15, 2017, 8:14 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57660/
> ---
> 
> (Updated March 15, 2017, 8:14 p.m.)
> 
> 
> Review request for geode, anilkumar gingade and Darrel Schneider.
> 
> 
> Bugs: GEODE-2536
> https://issues.apache.org/jira/browse/GEODE-2536
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> markForWriting and unmarkForWriting should not used for persistent region.
> needsToBeWritten always return false now for persistent region, as the 
> diskEntry either is being written to disk (sync) or sheduled to be written to 
> disk (async)
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskEntry.java 
> bde6a32 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskId.java 
> e802ac9 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> cce8100 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/DiskIdJUnitTest.java 
> 195c6a2 
> 
> 
> Diff: https://reviews.apache.org/r/57660/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 57660: GEODE-2536: Do not change keyId for persistent region DiskId

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57660/#review169056
---




geode-core/src/main/java/org/apache/geode/internal/cache/DiskEntry.java
Line 1691 (original), 1691 (patched)


We should remove this comment as it doesn't make sense for Geode...



geode-core/src/main/java/org/apache/geode/internal/cache/DiskId.java
Line 561 (original), 561 (patched)


is it appropriate to say, not needed for persistent region...Or remove the 
comment as exception indicates that.



geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
Line 706 (original), 706 (patched)


How about using, "isKeyIdNegative"...


- anilkumar gingade


On March 15, 2017, 8:14 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57660/
> ---
> 
> (Updated March 15, 2017, 8:14 p.m.)
> 
> 
> Review request for geode, anilkumar gingade and Darrel Schneider.
> 
> 
> Bugs: GEODE-2536
> https://issues.apache.org/jira/browse/GEODE-2536
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> markForWriting and unmarkForWriting should not used for persistent region.
> needsToBeWritten always return false now for persistent region, as the 
> diskEntry either is being written to disk (sync) or sheduled to be written to 
> disk (async)
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskEntry.java 
> bde6a32 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskId.java 
> e802ac9 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> cce8100 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/DiskIdJUnitTest.java 
> 195c6a2 
> 
> 
> Diff: https://reviews.apache.org/r/57660/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926972#comment-15926972
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/57#discussion_r106279511
  
--- Diff: 
docs/geode-native-book/master_middleman/source/subnavs/geode-nc-nav.erb ---
@@ -883,7 +883,7 @@ limitations under the License.
 Programming
 Examples
 
 
-Declaring
 a Native Client Region
+Declaring
 a Client Region
--- End diff --

That was an odd way to put it, in the original wording... I think "native" 
snuck in there, but was not correct.


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #57: GEODE-2513 Unbrand Programming Examples secti...

[echobravopapa]

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/57#discussion_r106279511
  
--- Diff: 
docs/geode-native-book/master_middleman/source/subnavs/geode-nc-nav.erb ---
@@ -883,7 +883,7 @@ limitations under the License.
 Programming
 Examples
 
 
-Declaring
 a Native Client Region
+Declaring
 a Client Region
--- End diff --

That was an odd way to put it, in the original wording... I think "native" 
snuck in there, but was not correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926949#comment-15926949
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-native/pull/57

GEODE-2513 Unbrand Programming Examples section

- also removed ancient examples, and replaced them with pointers
to the QuickStart examples

@davebarnes97 @joeymcallister @mmartell @dgkimura @echobravopapa 
@PivotalSarge Please review these minor changes to the documentation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-native 
feature/GEODE-2513-8

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit 0138dbd5a753c7671c82773fcee76f847a6edebb
Author: Karen Miller 
Date:   2017-03-15T20:34:41Z

GEODE-2513 Unbrand Programming Examples section

- also removed ancient examples, and replaced them with pointers
to the QuickStart examples




> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #57: GEODE-2513 Unbrand Programming Examples secti...

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-native/pull/57

GEODE-2513 Unbrand Programming Examples section

- also removed ancient examples, and replaced them with pointers
to the QuickStart examples

@davebarnes97 @joeymcallister @mmartell @dgkimura @echobravopapa 
@PivotalSarge Please review these minor changes to the documentation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-native 
feature/GEODE-2513-8

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit 0138dbd5a753c7671c82773fcee76f847a6edebb
Author: Karen Miller 
Date:   2017-03-15T20:34:41Z

GEODE-2513 Unbrand Programming Examples section

- also removed ancient examples, and replaced them with pointers
to the QuickStart examples




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (GEODE-2673) PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI fails intermittently with ForcedDisconnectException

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-2673:


 Summary: 
PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI 
fails intermittently with ForcedDisconnectException
 Key: GEODE-2673
 URL: https://issues.apache.org/jira/browse/GEODE-2673
 Project: Geode
  Issue Type: Bug
  Components: membership, regions, tests
Reporter: Kirk Lund


Test passes when run by itself:
{noformat}
./gradlew -DdistributedTest.single=PartitionedRegionMultipleDUnitTest 
geode-core:distributedTest
{noformat}
But fails intermittently in precheckin:
{noformat}
org.apache.geode.internal.cache.PartitionedRegionMultipleDUnitTest > 
testPartitionedRegionDestroyAndContainsAPI FAILED
java.lang.AssertionError: exception during 0
at org.apache.geode.test.dunit.Assert.fail(Assert.java:60)
at 
org.apache.geode.internal.cache.PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI(PartitionedRegionMultipleDUnitTest.java:231)

Caused by:
java.lang.AssertionError: Validation failed for key = 
0testPartitionedRegionDestroyAndContainsAPI3Value got = null

java.lang.AssertionError: Suspicious strings were written to the log during 
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 1807

[fatal 2017/03/13 23:48:06.633 UTC  
tid=0xc5] Membership service failure: this member is no longer in the view but 
is initiating connections
org.apache.geode.ForcedDisconnectException: this member is no longer in the 
view but is initiating connections
at 
org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.forceDisconnect(GMSMembershipManager.java:2517)
at 
org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:998)
at 
org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processRemoveRequest(GMSJoinLeave.java:635)
at 
org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1702)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1286)
at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
at org.jgroups.JChannel.up(JChannel.java:741)
at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1070)
at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:785)
at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:426)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:74)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:72)
at org.jgroups.protocols.TP.passMessageUp(TP.java:1601)
at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1817)
at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1729)
at org.jgroups.protocols.TP.receive(TP.java:1654)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:160)
at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
at java.lang.Thread.run(Thread.java:745)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2673) PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI fails intermittently with ForcedDisconnectException

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2673:
-
Labels: Flaky  (was: )

> PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI 
> fails intermittently with ForcedDisconnectException
> -
>
> Key: GEODE-2673
> URL: https://issues.apache.org/jira/browse/GEODE-2673
> Project: Geode
>  Issue Type: Bug
>  Components: membership, regions, tests
>Reporter: Kirk Lund
>  Labels: Flaky
>
> Test passes when run by itself:
> {noformat}
> ./gradlew -DdistributedTest.single=PartitionedRegionMultipleDUnitTest 
> geode-core:distributedTest
> {noformat}
> But fails intermittently in precheckin:
> {noformat}
> org.apache.geode.internal.cache.PartitionedRegionMultipleDUnitTest > 
> testPartitionedRegionDestroyAndContainsAPI FAILED
> java.lang.AssertionError: exception during 0
> at org.apache.geode.test.dunit.Assert.fail(Assert.java:60)
> at 
> org.apache.geode.internal.cache.PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI(PartitionedRegionMultipleDUnitTest.java:231)
> Caused by:
> java.lang.AssertionError: Validation failed for key = 
> 0testPartitionedRegionDestroyAndContainsAPI3Value got = null
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1807
> [fatal 2017/03/13 23:48:06.633 UTC  
> tid=0xc5] Membership service failure: this member is no longer in the view 
> but is initiating connections
> org.apache.geode.ForcedDisconnectException: this member is no longer in 
> the view but is initiating connections
>   at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.forceDisconnect(GMSMembershipManager.java:2517)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:998)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processRemoveRequest(GMSJoinLeave.java:635)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1702)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1286)
>   at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
>   at org.jgroups.JChannel.up(JChannel.java:741)
>   at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
>   at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
>   at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
>   at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1070)
>   at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:785)
>   at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:426)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:74)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:72)
>   at org.jgroups.protocols.TP.passMessageUp(TP.java:1601)
>   at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1817)
>   at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
>   at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1729)
>   at org.jgroups.protocols.TP.receive(TP.java:1654)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:160)
>   at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57573/#review169054
---


Ship it!




Ship It!

- Ken Howe


On March 15, 2017, 8:02 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57573/
> ---
> 
> (Updated March 15, 2017, 8:02 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2648
> https://issues.apache.org/jira/browse/GEODE-2648
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2648: always move deleted files to dirOfDeletedFiles
> 
> Fix flaky test by always moving deleted files to dirOfDeletedFiles to avoid 
> race condition in which file is deleted before its presence can be detected.
> 
> Update:
> ```java
> // Arrays.asList returns unmodifiable list
> List unmodifiable = Arrays.asList("Larry", "Moe", "Curly");
> unmodifiable.remove("Curly"); <-- throws UnsupportedOperationException
> ```
> I created a new modifiable version of asList and added it to the Geode 
> ArrayUtils class and used this new utility in DiskSpaceLimitIntegrationTest 
> as part of the recommendation in Ken's review.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/util/ArrayUtils.java 
> 3459e16c8f9b4c7d0ebb070bba2e0b2e55a69381 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java
>  5d94fa0ba32aabc0f0bfc396d99d0b5ef9572360 
>   
> geode-core/src/test/java/org/apache/geode/internal/util/ArrayUtilsJUnitTest.java
>  3ec8b12b5ad7bc86556d1259be0b3e2e9a240845 
>   geode-core/src/test/java/org/apache/geode/internal/util/ArrayUtilsTest.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57573/diff/2/
> 
> 
> Testing
> ---
> 
> DiskSpaceLimitIntegrationTest
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Commented] (GEODE-2379) Document new behavior of export logs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926916#comment-15926916
 ] 

ASF subversion and git services commented on GEODE-2379:


Commit f329f4a54c2bdfa254f2a9a9be1f535a9899cd85 in geode's branch 
refs/heads/feature/GEODE-2645 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f329f4a ]

GEODE-2379 Document new behavior of export logs
This closes #425


> Document new behavior of export logs
> 
>
> Key: GEODE-2379
> URL: https://issues.apache.org/jira/browse/GEODE-2379
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs
>Reporter: Joey McAllister
>Assignee: Dave Barnes
>
> the new command help: 
> NAME
> export logs
> IS AVAILABLE
> false
> SYNOPSIS
> Export the log files for a member or members.
> SYNTAX
> export logs [--dir=value] [--group=value(,value)*] 
> [--member=value(,value)*] [--log-level=value] [--only-log-level=value] 
> [--merge-log=value] [--start-time=value] [--end-time=value] 
> [--logs-only(=value)?] [--stats-only(=value)?]
> PARAMETERS
> dir
> Local directory to which log files will be written. This is only used 
> when you are exporting logs using http connection. If not specified, user.dir 
> will be used.
> Required: false
> group
> Group of members whose log files will be exported.
> Required: false
> member
> Name/Id of the member whose log files will be exported.
> Required: false
> log-level
> Minimum level of log entries to export. Valid values are: fatal, 
> error, warn, info, debug, trace and all.  The default is "INFO".
> Required: false
> Default (if the parameter is not specified): INFO
> only-log-level
> Whether to only include those entries that exactly match the 
> --log-level specified.
> Required: false
> Default (if the parameter is not specified): false
> merge-log
> Whether to merge logs after exporting to the target directory.  -- 
> deprecated
> Required: false
> Default (if the parameter is not specified): false
> start-time
> Log entries that occurred after this time will be exported. The 
> default is no limit. Format: /MM/dd/HH/mm/ss/SSS/z OR /MM/dd
> Required: false
> end-time
> Log entries that occurred before this time will be exported. The 
> default is no limit. Format: /MM/dd/HH/mm/ss/SSS/z OR /MM/dd
> Required: false
> logs-only
> Whether to only export logs
> Required: false
> Default (if the parameter is specified without value): true
> Default (if the parameter is not specified): false
> stats-only
> Whether to only export statistics
> Required: false
> Default (if the parameter is specified without value): true
> Default (if the parameter is not specified): false
> changes are:  --dir is not required anymore. added logs-only and stats-only 
> options. --merge-log is deprecated, group and member can be comma separated 
> strings.
> Also note down in the docs: when this command is executed over jmx, the 
> exported logs will be saved as exportedlogs_xxx.zip in the connected 
> locator's working directory. If executed over http, the zip will be saved in 
> specified dir in the user's client machine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2641) export logs help strings has [--group=value(nullvalue)*] [--member=value(nullvalue)*]

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926914#comment-15926914
 ] 

ASF subversion and git services commented on GEODE-2641:


Commit f9fa3e35bb60cb67d1d709d1ee080f61d6e60a1d in geode's branch 
refs/heads/feature/GEODE-2645 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f9fa3e3 ]

GEODE-2641: minor help string changes


> export logs help strings has [--group=value(nullvalue)*] 
> [--member=value(nullvalue)*] 
> --
>
> Key: GEODE-2641
> URL: https://issues.apache.org/jira/browse/GEODE-2641
> Project: Geode
>  Issue Type: Bug
>Reporter: Jinmei Liao
>
> export logs help strings has [--group=value(nullvalue)*] 
> [--member=value(nullvalue)*] 
> Also, merge-log option is deprecated, need to say that in the help



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2522) Refactor Lucene D Unit tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926913#comment-15926913
 ] 

ASF subversion and git services commented on GEODE-2522:


Commit 057f60be137992085f2044354a6387c9fe752059 in geode's branch 
refs/heads/feature/GEODE-2645 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=057f60b ]

GEODE-2522: Added missing teardown method in test


> Refactor Lucene D Unit tests
> 
>
> Key: GEODE-2522
> URL: https://issues.apache.org/jira/browse/GEODE-2522
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> Currently our dunit tests for lucene are organized as a tree heirarchy based 
> on region types.  This makes it difficult to add a tests for a specific type 
> of region type as other test files can possibly extend the file we add the 
> test to.
> Instead we can use parameterized tests and flatten the heirarchy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2303) Review openssl linking

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926910#comment-15926910
 ] 

ASF subversion and git services commented on GEODE-2303:


Commit 3c212fb11c8220f19750a154d4e31e38713b52f5 in geode's branch 
refs/heads/feature/GEODE-2645 from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3c212fb ]

GEODE-2303 Add eccn text to README.md


> Review openssl linking
> --
>
> Key: GEODE-2303
> URL: https://issues.apache.org/jira/browse/GEODE-2303
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Anthony Baker
> Fix For: 1.2.0
>
>
> Since we link to the openssl library, we should assess whether an ECCN is 
> required.
> https://www.apache.org/licenses/exports/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2653) GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926908#comment-15926908
 ] 

ASF subversion and git services commented on GEODE-2653:


Commit f4701a1f97df18b394bbf3f3fcd8c23156d95510 in geode's branch 
refs/heads/feature/GEODE-2645 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f4701a1 ]

GEODE-2653: Add FlakyTest category to test with Thread.sleep


> GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError
> 
>
> Key: GEODE-2653
> URL: https://issues.apache.org/jira/browse/GEODE-2653
> Project: Geode
>  Issue Type: Bug
>  Components: membership, tests
>Reporter: Kirk Lund
>  Labels: Flaky
>
> Intermittent failure stack:
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest
>  > testRemoveMember FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testRemoveMember(GMSJoinLeaveJUnitTest.java:337)
> {noformat}
> This test looks like it's flaky due to the Thread sleep:
> {noformat}
>   @Test
>   public void testRemoveMember() throws Exception {
> initMocks();
> prepareAndInstallView(mockMembers[0], createMemberList(mockMembers[0], 
> gmsJoinLeaveMemberId));
> MethodExecuted removeMessageSent = new MethodExecuted();
> 
> when(messenger.send(any(RemoveMemberMessage.class))).thenAnswer(removeMessageSent);
> gmsJoinLeave.remove(mockMembers[0], "removing for test");
> Thread.sleep(ServiceConfig.MEMBER_REQUEST_COLLECTION_INTERVAL * 2);
> assertTrue(removeMessageSent.methodExecuted);
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2639) Create Dunit tests to validate region expiration behavior with Lucene indexes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926912#comment-15926912
 ] 

ASF subversion and git services commented on GEODE-2639:


Commit 89847ddb5eafa3f9e1d918d3d3b99a631ab99608 in geode's branch 
refs/heads/feature/GEODE-2645 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=89847dd ]

GEODE-2639: Added a wait for flush to avoid flakiness in test


> Create Dunit tests to validate region expiration behavior with Lucene indexes
> -
>
> Key: GEODE-2639
> URL: https://issues.apache.org/jira/browse/GEODE-2639
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
> Fix For: 1.2.0
>
>
> If region is configured for expiration with a destroy action,  the destroy 
> operation must remove entries from the Lucene index as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2643) Combine chunk and file region into a single region

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926911#comment-15926911
 ] 

ASF subversion and git services commented on GEODE-2643:


Commit d8a897305c1fe9954f2511a6af0c8a633ef152d0 in geode's branch 
refs/heads/feature/GEODE-2645 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d8a8973 ]

GEODE-2643: Combine chunk and file region into a single region

* removed file and chunk count from stat
* removed tests that were doing checks against chunk bucketRegions


> Combine chunk and file region into a single region
> --
>
> Key: GEODE-2643
> URL: https://issues.apache.org/jira/browse/GEODE-2643
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> When recovering the chunk and file region from a back up, it is possible that 
> we end up recovering buckets from different sources.  This possibly leads to 
> missing chunks or extra files, which causes a Corrupt Index Exception to be 
> thrown.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2645) Refactor CacheLogRollDUnitTest to be an IntegrationTest

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926917#comment-15926917
 ] 

ASF subversion and git services commented on GEODE-2645:


Commit b48f5a35450c1f9b0a2e16f9ac278efd9d9801a7 in geode's branch 
refs/heads/feature/GEODE-2645 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b48f5a3 ]

GEODE-2645: rewrite test to fix flakiness and improve readability


> Refactor CacheLogRollDUnitTest to be an IntegrationTest
> ---
>
> Key: GEODE-2645
> URL: https://issues.apache.org/jira/browse/GEODE-2645
> Project: Geode
>  Issue Type: Wish
>  Components: logging, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> CacheLogRollDUnitTest appears to only use one JVM so it should be ported from 
> using DUnit to being a more simple IntegrationTest.
> It also has 4 flaky test bugs:
> * GEODE-674
> * GEODE-675
> * GEODE-676
> * GEODE-677
> If possible, test cleanup should also try to resolve the flakiness in these 
> tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2672) LuceneManagementDUnitTest.testMBeanAndProxiesCreated fails intermittently with ConditionTimeoutException

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-2672:


 Summary: LuceneManagementDUnitTest.testMBeanAndProxiesCreated 
fails intermittently with ConditionTimeoutException
 Key: GEODE-2672
 URL: https://issues.apache.org/jira/browse/GEODE-2672
 Project: Geode
  Issue Type: Bug
  Components: lucene, tests
Reporter: Kirk Lund


This test seems to pass when I run it on its own:
{noformat}
./gradlew -DdistributedTest.single=LuceneManagementDUnitTest 
geode-lucene:distributedTest
{noformat}
But it fails intermittently in precheckin:
{noformat}
org.apache.geode.cache.lucene.internal.management.LuceneManagementDUnitTest > 
testMBeanAndProxiesCreated FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.cache.lucene.internal.management.LuceneManagementDUnitTest$$Lambda$22/815946332.run
 in VM 0 running on Host d020cb82c1fd with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
at 
org.apache.geode.cache.lucene.internal.management.LuceneManagementDUnitTest.testMBeanAndProxiesCreated(LuceneManagementDUnitTest.java:58)

Caused by:
org.awaitility.core.ConditionTimeoutException: Condition defined as a 
lambda expression in 
org.apache.geode.cache.lucene.internal.management.LuceneManagementDUnitTest 
that uses org.apache.geode.management.internal.SystemManagementService, 
org.apache.geode.management.internal.SystemManagementServicejavax.management.ObjectName
 null within 5 seconds.
at 
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:104)
at 
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:117)
at 
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:32)
at 
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:809)
at 
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:648)
at 
org.apache.geode.cache.lucene.internal.management.LuceneManagementDUnitTest.getMBeanProxy(LuceneManagementDUnitTest.java:172)
at 
org.apache.geode.cache.lucene.internal.management.LuceneManagementDUnitTest.verifyMBeanProxies(LuceneManagementDUnitTest.java:164)
at 
org.apache.geode.cache.lucene.internal.management.LuceneManagementDUnitTest.lambda$testMBeanAndProxiesCreated$bb17a952$2(LuceneManagementDUnitTest.java:58)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

[Kirk Lund]

> On March 14, 2017, 10:13 p.m., Ken Howe wrote:
> > geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java
> > Lines 395-396 (original), 399-401 (patched)
> > 
> >
> > Is there any possibility that the dirOfDeletedFiles will not exist in 
> > "dir"? It seems more robust to me to explicity remove the deleted files dir 
> > from the dir.listFiles() rather than arbitarily returning length - 1. 
> > Something like
> > 
> > List listOfFiles = Arrays.asList(dir.listFiles());
> > listOfFiles.remove(dirOfDeletedFiles.getName());
> > return listOfFiles.size();

New changes use this approach. Thanks!


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57573/#review168945
---


On March 15, 2017, 8:02 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57573/
> ---
> 
> (Updated March 15, 2017, 8:02 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2648
> https://issues.apache.org/jira/browse/GEODE-2648
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2648: always move deleted files to dirOfDeletedFiles
> 
> Fix flaky test by always moving deleted files to dirOfDeletedFiles to avoid 
> race condition in which file is deleted before its presence can be detected.
> 
> Update:
> ```java
> // Arrays.asList returns unmodifiable list
> List unmodifiable = Arrays.asList("Larry", "Moe", "Curly");
> unmodifiable.remove("Curly"); <-- throws UnsupportedOperationException
> ```
> I created a new modifiable version of asList and added it to the Geode 
> ArrayUtils class and used this new utility in DiskSpaceLimitIntegrationTest 
> as part of the recommendation in Ken's review.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/util/ArrayUtils.java 
> 3459e16c8f9b4c7d0ebb070bba2e0b2e55a69381 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java
>  5d94fa0ba32aabc0f0bfc396d99d0b5ef9572360 
>   
> geode-core/src/test/java/org/apache/geode/internal/util/ArrayUtilsJUnitTest.java
>  3ec8b12b5ad7bc86556d1259be0b3e2e9a240845 
>   geode-core/src/test/java/org/apache/geode/internal/util/ArrayUtilsTest.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57573/diff/2/
> 
> 
> Testing
> ---
> 
> DiskSpaceLimitIntegrationTest
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Commented] (GEODE-2657) Execute Region Function sends incorrect message format

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926777#comment-15926777
 ] 

ASF subversion and git services commented on GEODE-2657:


Commit 39a0d7137a39434d56063b7254e2ae127bfe3b64 in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=39a0d71 ]

GEODE-2657: Execute Region Function sends incorrect message format


> Execute Region Function sends incorrect message format
> --
>
> Key: GEODE-2657
> URL: https://issues.apache.org/jira/browse/GEODE-2657
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: David Kimura
>
> `TcrMessageExecuteRegionFunction` is missing a call to set `m_hasResults`. 
> This causes the message response to be parsed synchronously and not 
> asynchronously chunked. The synchronous parser does not support this message 
> type and it barfs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2657) Execute Region Function sends incorrect message format

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926773#comment-15926773
 ] 

ASF GitHub Bot commented on GEODE-2657:
---

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/54
  
@dgkimura I will pull this and work on some of the tests.


> Execute Region Function sends incorrect message format
> --
>
> Key: GEODE-2657
> URL: https://issues.apache.org/jira/browse/GEODE-2657
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: David Kimura
>
> `TcrMessageExecuteRegionFunction` is missing a call to set `m_hasResults`. 
> This causes the message response to be parsed synchronously and not 
> asynchronously chunked. The synchronous parser does not support this message 
> type and it barfs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/54
  
@dgkimura I will pull this and work on some of the tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Geode log levels vs. log4j log levels

[Swapnil Bawaskar]

+1 to making the change and updating the docs to reflect only the new log
levels.

On Wed, Mar 15, 2017 at 10:45 AM Jinmei Liao  wrote:

> Hi, all,
>
> Geode, before using log4j for logging has implemented its own LogWriters
> and logLevels. Geode log levels has values like "finest, finer, fine,
> config, info, warning, error, severe".  We've moved away from using these
> log writers to favor using log4j logging. So, mostly, geode logs have log4j
> log statements with levels like "fatal, error, warn, info, debug".
>
> But by examining our existing commands that has log-level options,
> specifically "start server", "start locator", "alter runtime", "change
> log-level", these commands are still accepting log-levels with geode log
> levels, and under the cover, it has a mapping to the log4j levels. Since we
> are moving away from geode's own logging, I would like to propose changing
> these commands to use log4j log levels explicitly.
>
> To avoid breaking existing commands, we can provide a mapping to the log4j
> levels after user provides an "old" log level, but at least I would like to
> have the auto complete start showing the log4j levels instead of the geode
> log levels and move towards getting rid of these old levels completely.
>
> --
> Cheers
>
> Jinmei
>

[jira] [Resolved] (GEODE-2669) Add gfsh command to destroy lucene index

[Diane Hardman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Diane Hardman resolved GEODE-2669.
--
   Resolution: Fixed
Fix Version/s: 1.2.0

This command has been implemented on develop (Geode v1.2.0).

> Add gfsh command to destroy lucene index
> 
>
> Key: GEODE-2669
> URL: https://issues.apache.org/jira/browse/GEODE-2669
> Project: Geode
>  Issue Type: Sub-task
>  Components: lucene
>Reporter: Swapnil Bawaskar
>Assignee: Diane Hardman
> Fix For: 1.2.0
>
>
> Currently, there is a {{create lucene index}} gfsh command, however, there is 
> no corresponding {{destroy lucence index}} command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57658: GEODE-2670: fixing pulse authentication/authorization issues

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57658/#review169041
---


Ship it!




Ship It!

- Kevin Duling


On March 15, 2017, 11:43 a.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57658/
> ---
> 
> (Updated March 15, 2017, 11:43 a.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2670: fixing pulse authentication/authorization issues
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  PRE-CREATION 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
>  432834a314f26e308c1430362355bf250dfb2264 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java
>  5c30501a2c07e55873b090d7c7d14efcfc48139b 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Repository.java
>  61e967b7e81511dc2f47b6a641e938c4b31502db 
>   geode-pulse/src/main/webapp/DataBrowser.html  
>   geode-pulse/src/main/webapp/Login.html  
>   geode-pulse/src/main/webapp/MemberDetails.html  
>   geode-pulse/src/main/webapp/QueryStatistics.html  
>   geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 
> cac6caffe500ff3b93d12b4556bde475a45401ad 
>   geode-pulse/src/main/webapp/index.html 
> 74b895430bac774da81332b72017c619c369787d 
>   geode-pulse/src/main/webapp/scripts/lib/common.js 
> 0c58922eb82eb760d668c3054a52fa9d654fd598 
>   geode-pulse/src/main/webapp/scripts/pulsescript/MemberDetails.js 
> 650f30d2b26e51b24b64c43f974138bf20d30702 
>   geode-pulse/src/main/webapp/scripts/pulsescript/PulseCallbacks.js 
> e19ddf4779be8d5567380f19d87dcae5e7840344 
>   geode-pulse/src/main/webapp/scripts/pulsescript/clusterDetail.js 
> 3fe49eb57c79e637c8ba4d7e8e972bd078b04212 
>   geode-pulse/src/main/webapp/scripts/pulsescript/clusterRGraphMembers.js 
> 94b0538ede779a15269b7bf0e29803704ac1cb7e 
>   geode-pulse/src/main/webapp/scripts/pulsescript/common.js 
> 550af7c9ab498413cfae9d988afb92f4e7886695 
>   geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowser.js 
> 5bbcd7534864f6cb4d6344adfb2179d049a1f13f 
>   geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowserQuery.js 
> 534f5c87baa63de5fcbff9f50593b037ea67cc46 
>   
> geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowserQueryHistory.js
>  77f939e82f9557c513e41de5fcae255bf957f44b 
>   geode-pulse/src/main/webapp/scripts/pulsescript/regionView.js 
> 5ce63007b3be2467c47bd7a936d9eaa1a3b63312 
>   
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/WebDriverRule.java
>  ca4646bc41921f3fccee833618bca58ae14df91a 
>   
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/ui/PulseAnonymousUserTest.java
>  b37551b565da3eca97dfe92d75b9ebaf1fd2f1f8 
> 
> 
> Diff: https://reviews.apache.org/r/57658/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[jira] [Assigned] (GEODE-2669) Add gfsh command to destroy lucene index

[Diane Hardman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Diane Hardman reassigned GEODE-2669:


Assignee: Diane Hardman

> Add gfsh command to destroy lucene index
> 
>
> Key: GEODE-2669
> URL: https://issues.apache.org/jira/browse/GEODE-2669
> Project: Geode
>  Issue Type: Sub-task
>  Components: lucene
>Reporter: Swapnil Bawaskar
>Assignee: Diane Hardman
>
> Currently, there is a {{create lucene index}} gfsh command, however, there is 
> no corresponding {{destroy lucence index}} command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 57658: GEODE-2670: fixing pulse authentication/authorization issues

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57658/
---

Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-2670: fixing pulse authentication/authorization issues


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
 PRE-CREATION 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
 432834a314f26e308c1430362355bf250dfb2264 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java
 5c30501a2c07e55873b090d7c7d14efcfc48139b 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Repository.java
 61e967b7e81511dc2f47b6a641e938c4b31502db 
  geode-pulse/src/main/webapp/DataBrowser.html  
  geode-pulse/src/main/webapp/Login.html  
  geode-pulse/src/main/webapp/MemberDetails.html  
  geode-pulse/src/main/webapp/QueryStatistics.html  
  geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 
cac6caffe500ff3b93d12b4556bde475a45401ad 
  geode-pulse/src/main/webapp/index.html 
74b895430bac774da81332b72017c619c369787d 
  geode-pulse/src/main/webapp/scripts/lib/common.js 
0c58922eb82eb760d668c3054a52fa9d654fd598 
  geode-pulse/src/main/webapp/scripts/pulsescript/MemberDetails.js 
650f30d2b26e51b24b64c43f974138bf20d30702 
  geode-pulse/src/main/webapp/scripts/pulsescript/PulseCallbacks.js 
e19ddf4779be8d5567380f19d87dcae5e7840344 
  geode-pulse/src/main/webapp/scripts/pulsescript/clusterDetail.js 
3fe49eb57c79e637c8ba4d7e8e972bd078b04212 
  geode-pulse/src/main/webapp/scripts/pulsescript/clusterRGraphMembers.js 
94b0538ede779a15269b7bf0e29803704ac1cb7e 
  geode-pulse/src/main/webapp/scripts/pulsescript/common.js 
550af7c9ab498413cfae9d988afb92f4e7886695 
  geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowser.js 
5bbcd7534864f6cb4d6344adfb2179d049a1f13f 
  geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowserQuery.js 
534f5c87baa63de5fcbff9f50593b037ea67cc46 
  
geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowserQueryHistory.js
 77f939e82f9557c513e41de5fcae255bf957f44b 
  geode-pulse/src/main/webapp/scripts/pulsescript/regionView.js 
5ce63007b3be2467c47bd7a936d9eaa1a3b63312 
  
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/WebDriverRule.java
 ca4646bc41921f3fccee833618bca58ae14df91a 
  
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/ui/PulseAnonymousUserTest.java
 b37551b565da3eca97dfe92d75b9ebaf1fd2f1f8 


Diff: https://reviews.apache.org/r/57658/diff/1/


Testing
---

precheckin running


Thanks,

Jinmei Liao

[jira] [Assigned] (GEODE-2670) pulse with integrated security has authentication and authorization issues

[Jinmei Liao (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao reassigned GEODE-2670:
--

Assignee: Jinmei Liao

> pulse with integrated security has authentication and authorization issues
> --
>
> Key: GEODE-2670
> URL: https://issues.apache.org/jira/browse/GEODE-2670
> Project: Geode
>  Issue Type: Bug
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>
> Steps to reproduce:
> 1) in gfsh, start up a locator with a security manager
> 2) in the browser, try to connect to pulse: http://localhost:7070/pulse
> 3) when presented a login page, try a invalid username/password.
> 4) when getting "incorrect password" hint, use the same username, try using 
> the correct password for that user. It would still say "incorrect password".
> Also, repeat above step 1 and 2, 
> 3), use a correct username and password that only have cluster:read previlage.
> 4) try to access the dataBrowser.html, expect to get denied access, but is 
> still able to access. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2671) when a locator is started with a jmx-manager-port that is not 1099, the embedded pulse server still tries to connect to jmx using 1099

[Jinmei Liao (JIRA)]

Jinmei Liao created GEODE-2671:
--

 Summary: when a locator is started with a jmx-manager-port that is 
not 1099, the embedded pulse server still tries to connect to jmx using 1099
 Key: GEODE-2671
 URL: https://issues.apache.org/jira/browse/GEODE-2671
 Project: Geode
  Issue Type: Bug
  Components: pulse
Reporter: Jinmei Liao


embedded pulse does not use the jmx-manager-port used by the locator to connect.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2670) pulse with integrated security has authentication and authorization issues

[Jinmei Liao (JIRA)]

Jinmei Liao created GEODE-2670:
--

 Summary: pulse with integrated security has authentication and 
authorization issues
 Key: GEODE-2670
 URL: https://issues.apache.org/jira/browse/GEODE-2670
 Project: Geode
  Issue Type: Bug
Reporter: Jinmei Liao


Steps to reproduce:
1) in gfsh, start up a locator with a security manager
2) in the browser, try to connect to pulse: http://localhost:7070/pulse
3) when presented a login page, try a invalid username/password.
4) when getting "incorrect password" hint, use the same username, try using the 
correct password for that user. It would still say "incorrect password".

Also, repeat above step 1 and 2, 
3), use a correct username and password that only have cluster:read previlage.
4) try to access the dataBrowser.html, expect to get denied access, but is 
still able to access. 




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2602) Resolve C++11 and minimum support compilers discrepancies

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926712#comment-15926712
 ] 

ASF subversion and git services commented on GEODE-2602:


Commit d782efa7dbf84f691738087e7c5ff41a297c9e67 in geode-native's branch 
refs/heads/feature/GEODE-2602 from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=d782efa ]

GEODE-2602: Fixes C++11 issues with Solaris Studio 12.5.


> Resolve C++11 and minimum support compilers discrepancies
> -
>
> Key: GEODE-2602
> URL: https://issues.apache.org/jira/browse/GEODE-2602
> Project: Geode
>  Issue Type: Wish
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Referencing BUILDING.md our target language is C++11 and we state:
> {noformat}
> ### Required Tools
> * C++11 compiler *(see platform specific requirements)*
> {noformat}
> The problem is that our platform specific requirements do not meet the 
> minimum standards for C++11 compilers. 
> *Linux - GCC 4.8.1+*
> https://gcc.gnu.org/projects/cxx-status.html#cxx11
> Our Travis CI compiles on Linux using GCC 4.9.1.
> _Current listed minimum, 4.6,  does not support many of the C++11 features 
> currently in our source._
> *MacOS X - clang 3.3+*
> https://clang.llvm.org/cxx_status.html
> *Solaris - Solaris Studio 12.5+*
> https://docs.oracle.com/cd/E60778_01/html/E60746/bkabe.html#OSSCPgnyio
> _Currently listed minimum, 12.4, [does not 
> support|https://docs.oracle.com/cd/E37069_01/html/E37071/gncix.html#scrolltoc]
>  many concurrent features like std::atomic necessary to remove platform 
> specific concurrency code._
> *Windows - Visual Studio 2015*
> https://msdn.microsoft.com/en-us/library/hh567368(v=vs.140).aspx
> _Currently listed minimum, 2013, does not support many of the C++11 features, 
> like std::atomic_flag, necessary to remove platform specific concurrency 
> code._



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926710#comment-15926710
 ] 

ASF subversion and git services commented on GEODE-2494:


Commit 6f2952e76aecaa6e1c317bac9983fb74b9e64352 in geode-native's branch 
refs/heads/feature/GEODE-2602 from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=6f2952e ]

Revert "GEODE-2494: Replace global statics with class scoped statics."

- Solaris Studio 12.5 has unknown issue with constexpr.

This reverts commit 3dd36d608a27696bba28f7b1dde6d8453f6217e2.


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2648) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fails with TimeoutException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926703#comment-15926703
 ] 

ASF subversion and git services commented on GEODE-2648:


Commit e5532e51f1a5d20011b6c8d7dd135d15d393232f in geode's branch 
refs/heads/feature/GEODE-2648 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e5532e5 ]

GEODE-2648: always move deleted files to dirOfDeletedFiles


> DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fails with 
> TimeoutException
> ---
>
> Key: GEODE-2648
> URL: https://issues.apache.org/jira/browse/GEODE-2648
> Project: Geode
>  Issue Type: Bug
>  Components: statistics, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>  Labels: Flaky
>
> {noformat}
> java.util.concurrent.TimeoutException: File 
> /tmp/junit460899251228048267/aboveZeroDeletesPreviousFiles-02-01.gfs does not 
> exist after 5559 samples within 1 MINUTES
>   at 
> org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.sampleUntilFileExists(DiskSpaceLimitIntegrationTest.java:285)
>   at 
> org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles(DiskSpaceLimitIntegrationTest.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> 

[jira] [Commented] (GEODE-2599) `start locator` prints `null` in startup dots.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926694#comment-15926694
 ] 

ASF subversion and git services commented on GEODE-2599:


Commit 6b4e4f2c532c478d8a7a48bc5ac3a3152fc2e208 in geode's branch 
refs/heads/feature/GEODE-2648 from [~khowe]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6b4e4f2 ]

GEODE-2599: fix for "null" in string of dots

Check for string "null" in server/locator status message

Refactor server and locator launcer wait loops by using Process.isAlive
instead of Process.exitValue


> `start locator` prints `null` in startup dots.
> --
>
> Key: GEODE-2599
> URL: https://issues.apache.org/jira/browse/GEODE-2599
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.2.0
>Reporter: Patrick Rhomberg
>Assignee: Kenneth Howe
>Priority: Minor
>  Labels: gfsh
> Fix For: 1.2.0
>
>
> {noformat}
> gfsh>start locator --name=loc1
> Starting a Geode Locator in /Users/prhomberg/workspace/gemfire/open/loc1...
> ..
> null
> .
> Locator in /Users/prhomberg/workspace/gemfire/open/loc1 on 
> 10.118.33.239[10334] as loc1 is currently online.
> Process ID: 41909
> Uptime: 2 seconds
> Geode Version: 0.0.0
> Java Version: 1.8.0_121
> Log File: /Users/prhomberg/workspace/gemfire/open/loc1/loc1.log
> JVM Arguments: -Dgemfire.enable-cluster-configuration=true 
> -Dgemfire.load-cluster-configuration-from-dir=false 
> -Dgemfire.launcher.registerSignalHandlers=true -Djava.awt.headless=true 
> -Dsun.rmi.dgc.server.gcInterval=9223372036854775806
> Class-Path: 
> /Users/prhomberg/workspace/gemfire/open/geode-assembly/build/install/apache-geode/lib/geode-core-0.0.0.jar:/Users/prhomberg/workspace/gemfire/open/geode-assembly/build/install/apache-geode/lib/geode-dependencies.jar
> Successfully connected to: JMX Manager [host=10.118.33.239, port=1099]
> Cluster configuration service is up and running.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2522) Refactor Lucene D Unit tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926692#comment-15926692
 ] 

ASF subversion and git services commented on GEODE-2522:


Commit 057f60be137992085f2044354a6387c9fe752059 in geode's branch 
refs/heads/feature/GEODE-2648 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=057f60b ]

GEODE-2522: Added missing teardown method in test


> Refactor Lucene D Unit tests
> 
>
> Key: GEODE-2522
> URL: https://issues.apache.org/jira/browse/GEODE-2522
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> Currently our dunit tests for lucene are organized as a tree heirarchy based 
> on region types.  This makes it difficult to add a tests for a specific type 
> of region type as other test files can possibly extend the file we add the 
> test to.
> Instead we can use parameterized tests and flatten the heirarchy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2379) Document new behavior of export logs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926695#comment-15926695
 ] 

ASF subversion and git services commented on GEODE-2379:


Commit f329f4a54c2bdfa254f2a9a9be1f535a9899cd85 in geode's branch 
refs/heads/feature/GEODE-2648 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f329f4a ]

GEODE-2379 Document new behavior of export logs
This closes #425


> Document new behavior of export logs
> 
>
> Key: GEODE-2379
> URL: https://issues.apache.org/jira/browse/GEODE-2379
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs
>Reporter: Joey McAllister
>Assignee: Dave Barnes
>
> the new command help: 
> NAME
> export logs
> IS AVAILABLE
> false
> SYNOPSIS
> Export the log files for a member or members.
> SYNTAX
> export logs [--dir=value] [--group=value(,value)*] 
> [--member=value(,value)*] [--log-level=value] [--only-log-level=value] 
> [--merge-log=value] [--start-time=value] [--end-time=value] 
> [--logs-only(=value)?] [--stats-only(=value)?]
> PARAMETERS
> dir
> Local directory to which log files will be written. This is only used 
> when you are exporting logs using http connection. If not specified, user.dir 
> will be used.
> Required: false
> group
> Group of members whose log files will be exported.
> Required: false
> member
> Name/Id of the member whose log files will be exported.
> Required: false
> log-level
> Minimum level of log entries to export. Valid values are: fatal, 
> error, warn, info, debug, trace and all.  The default is "INFO".
> Required: false
> Default (if the parameter is not specified): INFO
> only-log-level
> Whether to only include those entries that exactly match the 
> --log-level specified.
> Required: false
> Default (if the parameter is not specified): false
> merge-log
> Whether to merge logs after exporting to the target directory.  -- 
> deprecated
> Required: false
> Default (if the parameter is not specified): false
> start-time
> Log entries that occurred after this time will be exported. The 
> default is no limit. Format: /MM/dd/HH/mm/ss/SSS/z OR /MM/dd
> Required: false
> end-time
> Log entries that occurred before this time will be exported. The 
> default is no limit. Format: /MM/dd/HH/mm/ss/SSS/z OR /MM/dd
> Required: false
> logs-only
> Whether to only export logs
> Required: false
> Default (if the parameter is specified without value): true
> Default (if the parameter is not specified): false
> stats-only
> Whether to only export statistics
> Required: false
> Default (if the parameter is specified without value): true
> Default (if the parameter is not specified): false
> changes are:  --dir is not required anymore. added logs-only and stats-only 
> options. --merge-log is deprecated, group and member can be comma separated 
> strings.
> Also note down in the docs: when this command is executed over jmx, the 
> exported logs will be saved as exportedlogs_xxx.zip in the connected 
> locator's working directory. If executed over http, the zip will be saved in 
> specified dir in the user's client machine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2648) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fails with TimeoutException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926696#comment-15926696
 ] 

ASF subversion and git services commented on GEODE-2648:


Commit 9d75370b59125fe0d28b648798070f7e204c508c in geode's branch 
refs/heads/feature/GEODE-2648 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9d75370 ]

GEODE-2648: always move deleted files to dirOfDeletedFiles


> DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fails with 
> TimeoutException
> ---
>
> Key: GEODE-2648
> URL: https://issues.apache.org/jira/browse/GEODE-2648
> Project: Geode
>  Issue Type: Bug
>  Components: statistics, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>  Labels: Flaky
>
> {noformat}
> java.util.concurrent.TimeoutException: File 
> /tmp/junit460899251228048267/aboveZeroDeletesPreviousFiles-02-01.gfs does not 
> exist after 5559 samples within 1 MINUTES
>   at 
> org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.sampleUntilFileExists(DiskSpaceLimitIntegrationTest.java:285)
>   at 
> org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles(DiskSpaceLimitIntegrationTest.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> 

[jira] [Commented] (GEODE-2643) Combine chunk and file region into a single region

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926690#comment-15926690
 ] 

ASF subversion and git services commented on GEODE-2643:


Commit d8a897305c1fe9954f2511a6af0c8a633ef152d0 in geode's branch 
refs/heads/feature/GEODE-2648 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d8a8973 ]

GEODE-2643: Combine chunk and file region into a single region

* removed file and chunk count from stat
* removed tests that were doing checks against chunk bucketRegions


> Combine chunk and file region into a single region
> --
>
> Key: GEODE-2643
> URL: https://issues.apache.org/jira/browse/GEODE-2643
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> When recovering the chunk and file region from a back up, it is possible that 
> we end up recovering buckets from different sources.  This possibly leads to 
> missing chunks or extra files, which causes a Corrupt Index Exception to be 
> thrown.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2267) Add gfsh command to export stat files

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926688#comment-15926688
 ] 

ASF subversion and git services commented on GEODE-2267:


Commit 55a2a3ce0b3c30f7386096d0ff3a8c4eae0c08b3 in geode's branch 
refs/heads/feature/GEODE-2648 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=55a2a3c ]

GEODE-2267: enhance error output for gfsh.

* correctly output error message if gfsh execution has an error
* export logs should output correct log message over http connection as well


> Add gfsh command to export stat files
> -
>
> Key: GEODE-2267
> URL: https://issues.apache.org/jira/browse/GEODE-2267
> Project: Geode
>  Issue Type: New Feature
>  Components: configuration, gfsh
>Reporter: Diane Hardman
>Assignee: Kirk Lund
>  Labels: ExportClusterArtifacts, export, gfsh, logging, statistics
>
> We would like a single gfsh command to collect and export all logfiles and 
> stat files into a single package that will be returned to the gfsh client 
> machine. This package (zipfile) can then be saved and attached to emails and 
> Jira tickets to help evaluate the Geode cluster status.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2303) Review openssl linking

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926689#comment-15926689
 ] 

ASF subversion and git services commented on GEODE-2303:


Commit 3c212fb11c8220f19750a154d4e31e38713b52f5 in geode's branch 
refs/heads/feature/GEODE-2648 from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3c212fb ]

GEODE-2303 Add eccn text to README.md


> Review openssl linking
> --
>
> Key: GEODE-2303
> URL: https://issues.apache.org/jira/browse/GEODE-2303
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Anthony Baker
> Fix For: 1.2.0
>
>
> Since we link to the openssl library, we should assess whether an ECCN is 
> required.
> https://www.apache.org/licenses/exports/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2641) export logs help strings has [--group=value(nullvalue)*] [--member=value(nullvalue)*]

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926693#comment-15926693
 ] 

ASF subversion and git services commented on GEODE-2641:


Commit f9fa3e35bb60cb67d1d709d1ee080f61d6e60a1d in geode's branch 
refs/heads/feature/GEODE-2648 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f9fa3e3 ]

GEODE-2641: minor help string changes


> export logs help strings has [--group=value(nullvalue)*] 
> [--member=value(nullvalue)*] 
> --
>
> Key: GEODE-2641
> URL: https://issues.apache.org/jira/browse/GEODE-2641
> Project: Geode
>  Issue Type: Bug
>Reporter: Jinmei Liao
>
> export logs help strings has [--group=value(nullvalue)*] 
> [--member=value(nullvalue)*] 
> Also, merge-log option is deprecated, need to say that in the help



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2639) Create Dunit tests to validate region expiration behavior with Lucene indexes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926691#comment-15926691
 ] 

ASF subversion and git services commented on GEODE-2639:


Commit 89847ddb5eafa3f9e1d918d3d3b99a631ab99608 in geode's branch 
refs/heads/feature/GEODE-2648 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=89847dd ]

GEODE-2639: Added a wait for flush to avoid flakiness in test


> Create Dunit tests to validate region expiration behavior with Lucene indexes
> -
>
> Key: GEODE-2639
> URL: https://issues.apache.org/jira/browse/GEODE-2639
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
> Fix For: 1.2.0
>
>
> If region is configured for expiration with a destroy action,  the destroy 
> operation must remove entries from the Lucene index as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926647#comment-15926647
 ] 

ASF subversion and git services commented on GEODE-2552:


Commit bb5d430586b83b89097d62bb9839ff4dd360716f in geode-native's branch 
refs/heads/feature/GEODE-2602 from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=bb5d430 ]

GEODE-2552: Replace NanoSleep with std::this_thread::sleepFor.

- Replaced custom time/duration with std::crono.


> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2602) Resolve C++11 and minimum support compilers discrepancies

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926651#comment-15926651
 ] 

ASF subversion and git services commented on GEODE-2602:


Commit 57e915b289e59d7fd5c3c97e4ade189cd798df73 in geode-native's branch 
refs/heads/feature/GEODE-2602 from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=57e915b ]

GEODE-2602: Fixes C++11 issues with C++/CLI.


> Resolve C++11 and minimum support compilers discrepancies
> -
>
> Key: GEODE-2602
> URL: https://issues.apache.org/jira/browse/GEODE-2602
> Project: Geode
>  Issue Type: Wish
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Referencing BUILDING.md our target language is C++11 and we state:
> {noformat}
> ### Required Tools
> * C++11 compiler *(see platform specific requirements)*
> {noformat}
> The problem is that our platform specific requirements do not meet the 
> minimum standards for C++11 compilers. 
> *Linux - GCC 4.8.1+*
> https://gcc.gnu.org/projects/cxx-status.html#cxx11
> Our Travis CI compiles on Linux using GCC 4.9.1.
> _Current listed minimum, 4.6,  does not support many of the C++11 features 
> currently in our source._
> *MacOS X - clang 3.3+*
> https://clang.llvm.org/cxx_status.html
> *Solaris - Solaris Studio 12.5+*
> https://docs.oracle.com/cd/E60778_01/html/E60746/bkabe.html#OSSCPgnyio
> _Currently listed minimum, 12.4, [does not 
> support|https://docs.oracle.com/cd/E37069_01/html/E37071/gncix.html#scrolltoc]
>  many concurrent features like std::atomic necessary to remove platform 
> specific concurrency code._
> *Windows - Visual Studio 2015*
> https://msdn.microsoft.com/en-us/library/hh567368(v=vs.140).aspx
> _Currently listed minimum, 2013, does not support many of the C++11 features, 
> like std::atomic_flag, necessary to remove platform specific concurrency 
> code._



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926644#comment-15926644
 ] 

ASF subversion and git services commented on GEODE-2494:


Commit 09837a09c003c2b1dd5805016dca56596d545a67 in geode-native's branch 
refs/heads/feature/GEODE-2602 from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=09837a0 ]

GEODE-2494: Remove dead code.


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926648#comment-15926648
 ] 

ASF subversion and git services commented on GEODE-2552:


Commit c0d0c2a2035d7b8241311fb018ff1f156352dc65 in geode-native's branch 
refs/heads/feature/GEODE-2602 from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=c0d0c2a ]

GEODE-2552: Replaced NanoTimer with std::chrono.


> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926650#comment-15926650
 ] 

ASF subversion and git services commented on GEODE-2552:


Commit e0145aced70d9659b286df4762a00940dccefa4d in geode-native's branch 
refs/heads/feature/GEODE-2602 from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=e0145ac ]

GEODE-2552: Removed NanoTimer

- Replaced millisleep with std::this_thread::sleep_for.


> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926645#comment-15926645
 ] 

ASF subversion and git services commented on GEODE-2494:


Commit 19c6171c98835940d85b1cfbb7798604e2626125 in geode-native's branch 
refs/heads/feature/GEODE-2602 from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=19c6171 ]

GEODE-2494: Fixes missing include for strlen.


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Geode log levels vs. log4j log levels

[Jinmei Liao]

Hi, all,

Geode, before using log4j for logging has implemented its own LogWriters
and logLevels. Geode log levels has values like "finest, finer, fine,
config, info, warning, error, severe".  We've moved away from using these
log writers to favor using log4j logging. So, mostly, geode logs have log4j
log statements with levels like "fatal, error, warn, info, debug".

But by examining our existing commands that has log-level options,
specifically "start server", "start locator", "alter runtime", "change
log-level", these commands are still accepting log-levels with geode log
levels, and under the cover, it has a mapping to the log4j levels. Since we
are moving away from geode's own logging, I would like to propose changing
these commands to use log4j log levels explicitly.

To avoid breaking existing commands, we can provide a mapping to the log4j
levels after user provides an "old" log level, but at least I would like to
have the auto complete start showing the log4j levels instead of the geode
log levels and move towards getting rid of these old levels completely.

-- 
Cheers

Jinmei

[jira] [Commented] (GEODE-2660) Mark Redis Adapter as Experimental

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926628#comment-15926628
 ] 

ASF GitHub Bot commented on GEODE-2660:
---

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/426

GEODE-2660 Add @Experimental to the Redis adapter.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/incubator-geode 
feature/GEODE-2660

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/426.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #426


commit 23dc29d909ab5127b8e717555bbc564bbbe1e88e
Author: Galen OSullivan 
Date:   2017-03-15T17:41:42Z

GEODE-2660 Add @Experimental to the Redis adapter.




> Mark Redis Adapter as Experimental
> --
>
> Key: GEODE-2660
> URL: https://issues.apache.org/jira/browse/GEODE-2660
> Project: Geode
>  Issue Type: Bug
>Reporter: Galen O'Sullivan
>
> I put this up for a vote recently. The Redis adapter is really not ready for 
> prime time at this point. We should mark it experimental so people don't 
> mistakenly think it's ready, and so that we can change it more readily on 
> develop.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #426: GEODE-2660 Add @Experimental to the Redis adapter.

[galen-pivotal]

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/426

GEODE-2660 Add @Experimental to the Redis adapter.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/incubator-geode 
feature/GEODE-2660

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/426.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #426


commit 23dc29d909ab5127b8e717555bbc564bbbe1e88e
Author: Galen OSullivan 
Date:   2017-03-15T17:41:42Z

GEODE-2660 Add @Experimental to the Redis adapter.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2379) Document new behavior of export logs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926621#comment-15926621
 ] 

ASF GitHub Bot commented on GEODE-2379:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/425


> Document new behavior of export logs
> 
>
> Key: GEODE-2379
> URL: https://issues.apache.org/jira/browse/GEODE-2379
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs
>Reporter: Joey McAllister
>Assignee: Dave Barnes
>
> the new command help: 
> NAME
> export logs
> IS AVAILABLE
> false
> SYNOPSIS
> Export the log files for a member or members.
> SYNTAX
> export logs [--dir=value] [--group=value(,value)*] 
> [--member=value(,value)*] [--log-level=value] [--only-log-level=value] 
> [--merge-log=value] [--start-time=value] [--end-time=value] 
> [--logs-only(=value)?] [--stats-only(=value)?]
> PARAMETERS
> dir
> Local directory to which log files will be written. This is only used 
> when you are exporting logs using http connection. If not specified, user.dir 
> will be used.
> Required: false
> group
> Group of members whose log files will be exported.
> Required: false
> member
> Name/Id of the member whose log files will be exported.
> Required: false
> log-level
> Minimum level of log entries to export. Valid values are: fatal, 
> error, warn, info, debug, trace and all.  The default is "INFO".
> Required: false
> Default (if the parameter is not specified): INFO
> only-log-level
> Whether to only include those entries that exactly match the 
> --log-level specified.
> Required: false
> Default (if the parameter is not specified): false
> merge-log
> Whether to merge logs after exporting to the target directory.  -- 
> deprecated
> Required: false
> Default (if the parameter is not specified): false
> start-time
> Log entries that occurred after this time will be exported. The 
> default is no limit. Format: /MM/dd/HH/mm/ss/SSS/z OR /MM/dd
> Required: false
> end-time
> Log entries that occurred before this time will be exported. The 
> default is no limit. Format: /MM/dd/HH/mm/ss/SSS/z OR /MM/dd
> Required: false
> logs-only
> Whether to only export logs
> Required: false
> Default (if the parameter is specified without value): true
> Default (if the parameter is not specified): false
> stats-only
> Whether to only export statistics
> Required: false
> Default (if the parameter is specified without value): true
> Default (if the parameter is not specified): false
> changes are:  --dir is not required anymore. added logs-only and stats-only 
> options. --merge-log is deprecated, group and member can be comma separated 
> strings.
> Also note down in the docs: when this command is executed over jmx, the 
> exported logs will be saved as exportedlogs_xxx.zip in the connected 
> locator's working directory. If executed over http, the zip will be saved in 
> specified dir in the user's client machine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #425: GEODE-2379 Document new behavior of export logs

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/425


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2379) Document new behavior of export logs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926620#comment-15926620
 ] 

ASF subversion and git services commented on GEODE-2379:


Commit f329f4a54c2bdfa254f2a9a9be1f535a9899cd85 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f329f4a ]

GEODE-2379 Document new behavior of export logs
This closes #425


> Document new behavior of export logs
> 
>
> Key: GEODE-2379
> URL: https://issues.apache.org/jira/browse/GEODE-2379
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs
>Reporter: Joey McAllister
>Assignee: Dave Barnes
>
> the new command help: 
> NAME
> export logs
> IS AVAILABLE
> false
> SYNOPSIS
> Export the log files for a member or members.
> SYNTAX
> export logs [--dir=value] [--group=value(,value)*] 
> [--member=value(,value)*] [--log-level=value] [--only-log-level=value] 
> [--merge-log=value] [--start-time=value] [--end-time=value] 
> [--logs-only(=value)?] [--stats-only(=value)?]
> PARAMETERS
> dir
> Local directory to which log files will be written. This is only used 
> when you are exporting logs using http connection. If not specified, user.dir 
> will be used.
> Required: false
> group
> Group of members whose log files will be exported.
> Required: false
> member
> Name/Id of the member whose log files will be exported.
> Required: false
> log-level
> Minimum level of log entries to export. Valid values are: fatal, 
> error, warn, info, debug, trace and all.  The default is "INFO".
> Required: false
> Default (if the parameter is not specified): INFO
> only-log-level
> Whether to only include those entries that exactly match the 
> --log-level specified.
> Required: false
> Default (if the parameter is not specified): false
> merge-log
> Whether to merge logs after exporting to the target directory.  -- 
> deprecated
> Required: false
> Default (if the parameter is not specified): false
> start-time
> Log entries that occurred after this time will be exported. The 
> default is no limit. Format: /MM/dd/HH/mm/ss/SSS/z OR /MM/dd
> Required: false
> end-time
> Log entries that occurred before this time will be exported. The 
> default is no limit. Format: /MM/dd/HH/mm/ss/SSS/z OR /MM/dd
> Required: false
> logs-only
> Whether to only export logs
> Required: false
> Default (if the parameter is specified without value): true
> Default (if the parameter is not specified): false
> stats-only
> Whether to only export statistics
> Required: false
> Default (if the parameter is specified without value): true
> Default (if the parameter is not specified): false
> changes are:  --dir is not required anymore. added logs-only and stats-only 
> options. --merge-log is deprecated, group and member can be comma separated 
> strings.
> Also note down in the docs: when this command is executed over jmx, the 
> exported logs will be saved as exportedlogs_xxx.zip in the connected 
> locator's working directory. If executed over http, the zip will be saved in 
> specified dir in the user's client machine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Geode Modularization Proposal

[Udo Kohlmeyer]

Hi there Guys,

The first high-level proposal on Geode modularization has been posted: 
https://cwiki.apache.org/confluence/display/GEODE/Proposal+for+Geode+Modularization.


Please look through this. It is neither a hard or long read BUT it is 
the precursor to the more detailed proposal.


What is asked of all dev's is that they take a critical look at the code 
they are working on and start identifying module boundaries. This 
identification and implementation process is the most important piece to 
the whole modularization process. Without the identification work, all 
efforts to have bootstrapping, DI, streaming, reactive, messaging 
frameworks is an exercise in futility.


If there is any doubt about the size of a module, err on the side of 
caution... Smaller is better. If a piece of functionality could 
plausibly be replaced with another implementation, it is a strong 
candidate for a module.


Over the next few days a more detailed implementation approach will be 
proposed. In conjunction to that proposal, a register of 
modules/potential modules will be started. This way we can easily 
identify modules, no matter how small.


--Udo

[jira] [Created] (GEODE-2669) Add gfsh command to destroy lucene index

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2669:
---

 Summary: Add gfsh command to destroy lucene index
 Key: GEODE-2669
 URL: https://issues.apache.org/jira/browse/GEODE-2669
 Project: Geode
  Issue Type: Sub-task
  Components: lucene
Reporter: Swapnil Bawaskar


Currently, there is a {{create lucene index}} gfsh command, however, there is 
no corresponding {{destroy lucence index}} command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2668) Add gfsh command to destroy gateway receiver

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2668:
---

 Summary: Add gfsh command to destroy gateway receiver
 Key: GEODE-2668
 URL: https://issues.apache.org/jira/browse/GEODE-2668
 Project: Geode
  Issue Type: Sub-task
  Components: gfsh
Reporter: Swapnil Bawaskar


Currently, there is a {{create gateway-receiver}} command, but no corresponding 
destroy command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2667) Need API to destroy gateway receiver

[Swapnil Bawaskar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Bawaskar updated GEODE-2667:

Description: A {{GatewayReceiver}} can be created from 
{{GatewayReceiverFactory}}, however, there is no API for destroying the 
{{GatewayReceiver}}.   (was: An {{AsyncEventQueue}} can be created from 
{{AsyncEventQueueFactory}}, however, there is no API for destroying the 
{{AsyncEventQueue}}. )

>  Need API to destroy gateway receiver
> -
>
> Key: GEODE-2667
> URL: https://issues.apache.org/jira/browse/GEODE-2667
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Swapnil Bawaskar
>
> A {{GatewayReceiver}} can be created from {{GatewayReceiverFactory}}, 
> however, there is no API for destroying the {{GatewayReceiver}}. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2667) Need API to destroy gateway receiver

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2667:
---

 Summary:  Need API to destroy gateway receiver
 Key: GEODE-2667
 URL: https://issues.apache.org/jira/browse/GEODE-2667
 Project: Geode
  Issue Type: Bug
  Components: wan
Reporter: Swapnil Bawaskar


An {{AsyncEventQueue}} can be created from {{AsyncEventQueueFactory}}, however, 
there is no API for destroying the {{AsyncEventQueue}}. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2666) Need API to destroy async event queue

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2666:
---

 Summary: Need API to destroy async event queue
 Key: GEODE-2666
 URL: https://issues.apache.org/jira/browse/GEODE-2666
 Project: Geode
  Issue Type: Bug
  Components: wan
Reporter: Swapnil Bawaskar


An {{AsyncEventQueue}} can be created from {{AsyncEventQueueFactory}}, however, 
there is no API for destroying the {{AsyncEventQueue}}. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2665) Add gfsh command to destroy async-event-queue

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2665:
---

 Summary: Add gfsh command to destroy async-event-queue
 Key: GEODE-2665
 URL: https://issues.apache.org/jira/browse/GEODE-2665
 Project: Geode
  Issue Type: Sub-task
  Components: gfsh
Reporter: Swapnil Bawaskar


Currently, there is only an {{create async-event-queue}} command in gfsh, we 
need the corresponding {{destroy async-event-queue}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: Geode-nightly #777

[Apache Jenkins Server]

See 


Changes:

[huynhja] GEODE-2643: Combine chunk and file region into a single region

[huynhja] GEODE-2639: Added a wait for flush to avoid flakiness in test

[huynhja] GEODE-2522: Added missing teardown method in test

[jiliao] GEODE-2641: minor help string changes

[khowe] GEODE-2599: fix for "null" in string of dots

--
[...truncated 99.00 KB...]
:geode-core:flakyTest

org.apache.geode.management.internal.cli.commands.ExportLogsDUnitTest > 
testExportWithStartAndEndDateTimeFiltering FAILED
java.lang.AssertionError: 
Expected size:<3> but was:<1> in:
<[/tmp/junit3538921893289850247/unzippedLogs/server-2]>
at 
org.apache.geode.management.internal.cli.commands.ExportLogsDUnitTest.verifyZipFileContents(ExportLogsDUnitTest.java:225)
at 
org.apache.geode.management.internal.cli.commands.ExportLogsDUnitTest.testExportWithStartAndEndDateTimeFiltering(ExportLogsDUnitTest.java:155)

302 tests completed, 1 failed, 6 skipped
:geode-core:flakyTest FAILED
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest

[jira] [Updated] (GEODE-2648) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fails with TimeoutException

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2648:
-
Labels: Flaky  (was: )

> DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fails with 
> TimeoutException
> ---
>
> Key: GEODE-2648
> URL: https://issues.apache.org/jira/browse/GEODE-2648
> Project: Geode
>  Issue Type: Bug
>  Components: statistics, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>  Labels: Flaky
>
> {noformat}
> java.util.concurrent.TimeoutException: File 
> /tmp/junit460899251228048267/aboveZeroDeletesPreviousFiles-02-01.gfs does not 
> exist after 5559 samples within 1 MINUTES
>   at 
> org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.sampleUntilFileExists(DiskSpaceLimitIntegrationTest.java:285)
>   at 
> org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles(DiskSpaceLimitIntegrationTest.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> 

[jira] [Commented] (GEODE-2647) ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fails with NullPointerException

[Kirk Lund (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926533#comment-15926533
 ] 

Kirk Lund commented on GEODE-2647:
--

This failure is intermittent, but I don't see evidence of it being flakiness in 
the test. 

It looks to me like region.getEntry(KEY1).getValue() should return non-null 
entry and value to the thread that immediately before that invoked 
region.put(KEY1, VALUE1).
{noformat}
Cache cache = (Cache) clientCache;
Region region = cache.getRegion(Region.SEPARATOR + 
REGION_NAME);

region.put(KEY1, VALUE1);
assertThat(region.getEntry(KEY1).getValue()).isEqualTo(VALUE1); <-- throws 
NPE!
{noformat}

> ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fails 
> with NullPointerException
> 
>
> Key: GEODE-2647
> URL: https://issues.apache.org/jira/browse/GEODE-2647
> Project: Geode
>  Issue Type: Bug
>  Components: jmx, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.management.ClientHealthStatsDUnitTest$$Lambda$193/1653332728.run
>  in VM 3 running on Host asf902.gq1.ygridcore.net with 4 VMs
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
>   at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled(ClientHealthStatsDUnitTest.java:128)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at 
> org.apache.geode.management.ManagementTestRule$2.evaluate(ManagementTestRule.java:86)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor16.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor15.invoke(Unknown Source)
>   at 
> 

[jira] [Updated] (GEODE-2646) PulseDataExportTest.dataBrowserExportWorksAsExpected fails with BindException

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2646:
-
Labels: Flaky  (was: )

> PulseDataExportTest.dataBrowserExportWorksAsExpected fails with BindException
> -
>
> Key: GEODE-2646
> URL: https://issues.apache.org/jira/browse/GEODE-2646
> Project: Geode
>  Issue Type: Bug
>  Components: pulse, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>  Labels: Flaky
>
> {noformat}
> :geode-assembly:flakyTest
> org.apache.geode.tools.pulse.PulseDataExportTest > 
> dataBrowserExportWorksAsExpected FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1371
> [error 2017/03/08 04:58:14.240 UTC  tid=0x31] 
> Jmx manager could not be started because java.rmi.server.ExportException: 
> Port already in use: 1099; nested exception is:
> java.net.BindException: Failed to create server socket on  null[1,099]
> org.apache.geode.management.ManagementException: 
> java.rmi.server.ExportException: Port already in use: 1099; nested exception 
> is:
> java.net.BindException: Failed to create server socket on  null[1,099]
> at 
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:149)
> at 
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:469)
> at 
> org.apache.geode.management.internal.JmxManagerLocator.findJmxManager(JmxManagerLocator.java:105)
> at 
> org.apache.geode.management.internal.JmxManagerLocator.processRequest(JmxManagerLocator.java:55)
> at 
> org.apache.geode.distributed.internal.InternalLocator$PrimaryHandler.processRequest(InternalLocator.java:1318)
> at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:392)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.rmi.server.ExportException: Port already in use: 1099; 
> nested exception is:
> java.net.BindException: Failed to create server socket on  null[1,099]
> at sun.rmi.transport.tcp.TCPTransport.listen(TCPTransport.java:341)
> at 
> sun.rmi.transport.tcp.TCPTransport.exportObject(TCPTransport.java:249)
> at 
> sun.rmi.transport.tcp.TCPEndpoint.exportObject(TCPEndpoint.java:411)
> at sun.rmi.transport.LiveRef.exportObject(LiveRef.java:147)
> at 
> sun.rmi.server.UnicastServerRef.exportObject(UnicastServerRef.java:234)
> at sun.rmi.registry.RegistryImpl.setup(RegistryImpl.java:195)
> at sun.rmi.registry.RegistryImpl.(RegistryImpl.java:155)
> at 
> java.rmi.registry.LocateRegistry.createRegistry(LocateRegistry.java:239)
> at 
> org.apache.geode.management.internal.ManagementAgent.configureAndStart(ManagementAgent.java:398)
> at 
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:147)
> ... 8 more
> Caused by: java.net.BindException: Failed to create server socket on  
> null[1,099]
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:782)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:739)
> at 
> org.apache.geode.management.internal.ManagementAgent$GemFireRMIServerSocketFactory.createServerSocket(ManagementAgent.java:556)
> at 
> sun.rmi.transport.tcp.TCPEndpoint.newServerSocket(TCPEndpoint.java:666)
> at sun.rmi.transport.tcp.TCPTransport.listen(TCPTransport.java:330)
> ... 17 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at 
> java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:778)
> ... 21 more
> 2 tests completed, 1 failed
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2576) delete the old exported zip on the locator

[Swapnil Bawaskar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Bawaskar resolved GEODE-2576.
-
Resolution: Won't Do

> delete the old exported zip on the locator
> --
>
> Key: GEODE-2576
> URL: https://issues.apache.org/jira/browse/GEODE-2576
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, gfsh
>Reporter: Jinmei Liao
>
> Currently when user is exporting logs over jmx connection, a zip file will be 
> created in the locator's working dir with a unique file name. If user does 
> exports for multiple times, all these zips will be created and we have no 
> mechanism to clean them up unless user go in there to delete them.
> May need to decide whether this is a problem or not. If it is, we need to 
> implement a way to delete these stale zip files periodically.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (GEODE-2576) delete the old exported zip on the locator

[Swapnil Bawaskar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Bawaskar closed GEODE-2576.
---

> delete the old exported zip on the locator
> --
>
> Key: GEODE-2576
> URL: https://issues.apache.org/jira/browse/GEODE-2576
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, gfsh
>Reporter: Jinmei Liao
>
> Currently when user is exporting logs over jmx connection, a zip file will be 
> created in the locator's working dir with a unique file name. If user does 
> exports for multiple times, all these zips will be created and we have no 
> mechanism to clean them up unless user go in there to delete them.
> May need to decide whether this is a problem or not. If it is, we need to 
> implement a way to delete these stale zip files periodically.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (GEODE-2576) delete the old exported zip on the locator

[Swapnil Bawaskar (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925709#comment-15925709
 ] 

Swapnil Bawaskar edited comment on GEODE-2576 at 3/15/17 4:40 PM:
--

Rather than trying to figure out a mechanism for cleaning old zip files, we 
should try to do the right thing by streaming the zip file back to the gfsh 
client rather than leave it on the locator, even when connected over jmx. see 
GEODE-2663.


was (Author: swapnil.bawaskar):
Rather than trying to figure out a mechanism for cleaning old zip files, we 
should try to do the right thing by streaming the zip file back to the gfsh 
client rather than leave it on the locator, even when connected over jmx.

> delete the old exported zip on the locator
> --
>
> Key: GEODE-2576
> URL: https://issues.apache.org/jira/browse/GEODE-2576
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, gfsh
>Reporter: Jinmei Liao
>
> Currently when user is exporting logs over jmx connection, a zip file will be 
> created in the locator's working dir with a unique file name. If user does 
> exports for multiple times, all these zips will be created and we have no 
> mechanism to clean them up unless user go in there to delete them.
> May need to decide whether this is a problem or not. If it is, we need to 
> implement a way to delete these stale zip files periodically.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926521#comment-15926521
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/56


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #56: GEODE-2513 Unbrand docs section Interoperabil...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/56


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926519#comment-15926519
 ] 

ASF subversion and git services commented on GEODE-2513:


Commit 4a6d11d54a0c5d415876f4c6dde6934d26a6ef52 in geode-native's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=4a6d11d ]

GEODE-2513 Unbrand docs section Interoperability

- section title is Interoperability of Language Classes and Types
- corrected namespaces (packages)
- removed duplicate table captions


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926516#comment-15926516
 ] 

ASF subversion and git services commented on GEODE-2513:


Commit 1300b48d7ab20e93dd83d6813b790efeee3f1d89 in geode-native's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=1300b48 ]

GEODE-2513 Unbrand docs section Installing the SQLite
Persistence Manager


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926517#comment-15926517
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/55


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #55: GEODE-2513 Unbrand docs section Installing th...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/55


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

region put followed by region getEntry returns null

[Kirk Lund]

I'm looking into a CI test failure
(ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled). I
don't see anything wrong with the test so far.

It looks to me like region.getEntry(KEY1) must have either returned a null
RegionEntry or RegionEntry.getValue returned a null immediately after the
same thread that just called region.put(KEY1, VALUE1). I'm looking for
confirmation that this is incorrect behavior or more info about how and why
this would be correct:

  private static final String KEY1 = "KEY1";
  private static final String VALUE1 = "VALUE1";

365: Cache cache = (Cache) clientCache;
366: Region region = cache.getRegion(Region.SEPARATOR +
REGION_NAME);
367:
368: *region.put(KEY1, VALUE1);*
369: *assertThat(region.getEntry(KEY1).getValue()).isEqualTo(VALUE1); <--
throws NPE*

The following is the setup code that configured and created clientCache:

Properties props = new Properties();
props.setProperty(STATISTIC_SAMPLING_ENABLED, "true");

ClientCacheFactory cacheFactory = new ClientCacheFactory(props);
if (subscriptionEnabled) {
  cacheFactory.setPoolSubscriptionEnabled(true);
  cacheFactory.setPoolSubscriptionAckInterval(50);
  cacheFactory.setPoolSubscriptionRedundancy(0);
}

cacheFactory.set(DURABLE_CLIENT_ID, "DurableClientId_" + clientNum);
cacheFactory.set(DURABLE_CLIENT_TIMEOUT, "" + 3);

cacheFactory.addPoolServer(hostName, port);
clientCache = cacheFactory.create();

ClientRegionFactory regionFactory =

clientCache.createClientRegionFactory(ClientRegionShortcut.CACHING_PROXY);
regionFactory.setConcurrencyChecksEnabled(false);

regionFactory.addCacheListener(new CacheListenerAdapter() {
  @Override
  public void afterInvalidate(final EntryEvent event) {
numOfInvalidates++;
  }

  @Override
  public void afterCreate(final EntryEvent event) {
if ("last_key".equals(event.getKey())) {
  lastKeyReceived = true;
}
numOfCreates++;
  }

  @Override
  public void afterUpdate(final EntryEvent event) {
numOfUpdates++;
  }
});

Region region = regionFactory.create(REGION_NAME);
if (subscriptionEnabled) {
  region.registerInterest("ALL_KEYS", true);
  clientCache.readyForEvents();
}
  }

The following is the stack trace showing the NPE:

org.apache.geode.test.dunit.RMIException: While invoking
org.apache.geode.management.ClientHealthStatsDUnitTest$$Lambda$193/1653332728.run
in VM 3 running on Host asf902.gq1.ygridcore.net with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
at
org.apache.geode.management.ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled(ClientHealthStatsDUnitTest.java:128)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at
org.apache.geode.management.ManagementTestRule$2.evaluate(ManagementTestRule.java:86)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
at
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at 

[jira] [Updated] (GEODE-2664) all gfsh commands that contains log-level needs to be updated to use log4j levels

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2664:
---
Component/s: docs

> all gfsh commands that contains log-level needs to be updated to use log4j 
> levels
> -
>
> Key: GEODE-2664
> URL: https://issues.apache.org/jira/browse/GEODE-2664
> Project: Geode
>  Issue Type: Bug
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>
> The commands' auto completion are still giving user options with gemfire log 
> levels, but our logs are mostly using log4j now. We need to have these 
> commands accept log4j levels now. Here are the problems:
> 1. "Export logs" command already accept log4j level, but the auto-complete 
> still hints users with gemfire levels, this is a must fix.
> 2. The auto complete is also used by "start locator", "start server", "alter 
> config", "change log-level" commands, needs to update these commands to 
> accept log4j level as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2576) delete the old exported zip on the locator

[Swapnil Bawaskar (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925709#comment-15925709
 ] 

Swapnil Bawaskar commented on GEODE-2576:
-

Rather than trying to figure out a mechanism for cleaning old zip files, we 
should try to do the right thing by streaming the zip file back to the gfsh 
client rather than leave it on the locator, even when connected over jmx.

> delete the old exported zip on the locator
> --
>
> Key: GEODE-2576
> URL: https://issues.apache.org/jira/browse/GEODE-2576
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, gfsh
>Reporter: Jinmei Liao
>
> Currently when user is exporting logs over jmx connection, a zip file will be 
> created in the locator's working dir with a unique file name. If user does 
> exports for multiple times, all these zips will be created and we have no 
> mechanism to clean them up unless user go in there to delete them.
> May need to decide whether this is a problem or not. If it is, we need to 
> implement a way to delete these stale zip files periodically.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)