[CVE-2017-5649] Apache Geode information disclosure vulnerability

[Anthony Baker]

CVE-2017-5649: Apache Geode information disclosure vulnerability

Severity:  Medium
Base score:  5.5 (CVSS:3.0/AV:N/AC:L/PR:H/UI:N/S:U/C:H/I:N/A:L)

Vendor:
The Apache Software Foundation

Versions Affected:
Geode 1.1.0

Description:
When a cluster has enabled security by setting the security-manager
property, a user should have DATA:READ permission to view data stored
in the cluster.  However, if an authenticated user has CLUSTER:READ
but not DATA:READ permission they can access the data
browser page in Pulse.  From there the user could execute an OQL query
that exposes data stored in the cluster.

Mitigation:
1.1.0 users should upgrade to 1.1.1

Credit:
This issue was discovered by Jinmei Liao.

References:
https://www.apache.org/security/

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955340#comment-15955340
 ] 

ASF subversion and git services commented on GEODE-2513:


Commit 1dbe9e61185dc8ef62ec4ae744de3636a1d311ab in geode-native's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=1dbe9e6 ]

GEODE-2513: Rename and reorganize client doc sources
This closes #85


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #85: GEODE-2513: Rename and reorganize client doc ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/85


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955341#comment-15955341
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/85


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2466) Document that examples were combined with quickstarts

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes reassigned GEODE-2466:
--

Assignee: Dave Barnes

> Document that examples were combined with quickstarts
> -
>
> Key: GEODE-2466
> URL: https://issues.apache.org/jira/browse/GEODE-2466
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> See GEODE-2462 Unify Quckstarts and examples



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2466) Document that examples were combined with quickstarts

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2466:
---
Fix Version/s: 1.2.0

> Document that examples were combined with quickstarts
> -
>
> Key: GEODE-2466
> URL: https://issues.apache.org/jira/browse/GEODE-2466
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
> Fix For: 1.2.0
>
>
> See GEODE-2462 Unify Quckstarts and examples



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2466) Document that examples were combined with quickstarts

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-2466.

Resolution: Fixed

Updated client documentation to reflect these changes.

> Document that examples were combined with quickstarts
> -
>
> Key: GEODE-2466
> URL: https://issues.apache.org/jira/browse/GEODE-2466
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> See GEODE-2462 Unify Quckstarts and examples



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes reassigned GEODE-2513:
--

Assignee: Dave Barnes

> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-2513.

   Resolution: Fixed
Fix Version/s: 1.2.0

Wholesale client doc conversion from proprietary to open source is complete. 
Address subsequent doc issues with new tickets.

> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
> Fix For: 1.2.0
>
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: Geode-nightly #797

[Apache Jenkins Server]

See 

--
[...truncated 104.44 KB...]
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJava
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.4.1/lucene-test-framework-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.4.1/lucene-codecs-6.4.1.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.4.0/randomizedtesting-runner-2.4.0.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-parent/2.4.0/randomizedtesting-parent-2.4.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.4.1/lucene-test-framework-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.4.1/lucene-codecs-6.4.1.jar
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.4.0/randomizedtesting-runner-2.4.0.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJava
Download 
https://repo1.maven.org/maven2/com/codeborne/phantomjsdriver/1.3.0/phantomjsdriver-1.3.0.pom
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-api/3.0.1/selenium-api-3.0.1.pom
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-remote-driver/3.0.1/selenium-remote-driver-3.0.1.pom
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-support/3.0.1/selenium-support-3.0.1.pom
Download https://repo1.maven.org/maven2/com/tdunning/json/1.8/json-1.8.pom
Download 
https://repo1.maven.org/maven2/com/codeborne/phantomjsdriver/1.3.0/phantomjsdriver-1.3.0.jar
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-api/3.0.1/selenium-api-3.0.1.jar
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-remote-driver/3.0.1/selenium-remote-driver-3.0.1.jar
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-support/3.0.1/selenium-support-3.0.1.jar
Download https://repo1.maven.org/maven2/com/tdunning/json/1.8/json-1.8.jar
Note: 

[jira] [Commented] (GEODE-2145) A valid query in GFSH appears not to work from Java

[Avinash Dongre (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955527#comment-15955527
 ] 

Avinash Dongre commented on GEODE-2145:
---

I tried to reproduce this issue with following test, But I could not reproduce .

{code}
public class BugGeode2145DUnitTest extends LocatorTestBase {
  public BugGeode2145DUnitTest() {
super();
  }

  @Override
  public final void postSetUp() throws Exception {
disconnectAllFromDS();
  }

  @Override
  protected final void postTearDownLocatorTestBase() throws Exception {
disconnectAllFromDS();
  }

  @Test
  public void testOqlWithEntrySet() {
Host host = Host.getHost(0);
VM locator = host.getVM(0);
VM server1 = host.getVM(1);
VM client = host.getVM(3);

final int locatorPort = 
AvailablePort.getRandomAvailablePort(AvailablePort.SOCKET);
final String locatorHost = NetworkUtils.getServerHostName(host);
locator.invoke("Start Locator", () -> startLocator(locatorHost, 
locatorPort, ""));

String locString = getLocatorString(host, locatorPort);
server1.invoke("Start BridgeServer",
() -> startBridgeServer(locString));

client.invoke("create region and insert, query with entrySet", () -> {
  ClientCacheFactory ccf = new ClientCacheFactory();
  ccf.addPoolLocator(locatorHost, locatorPort);
  ClientCache cache = ccf.create();

  Region region = 
cache.createClientRegionFactory(ClientRegionShortcut.CACHING_PROXY).create(REGION_NAME);

  for (int i = 0; i < 10; i++) {
region.put(i, i * 100);
  }
  SelectResults results = (SelectResults) cache.getQueryService()
  .newQuery("select * from /" + REGION_NAME + ".entrySet").execute();
  assertEquals(10, results.asList().size());

  ClientCacheFactory.getAnyInstance().close();
});
server1.invoke("Stopping BridgeServer", () -> stopBridgeServer());
  }

  private void startBridgeServer(final String locString) throws IOException {
Properties props = new Properties();
props.setProperty(MCAST_PORT, "0");
props.setProperty(LOCATORS, locString);
DistributedSystem ds = getSystem(props);
Cache cache = CacheFactory.create(ds);
CacheServer server = cache.addCacheServer();
server.setPort(0);
server.start();
cache.createRegionFactory(RegionShortcut.PARTITION).create(REGION_NAME);
  }

  private void stopBridgeServer() {
CacheFactory.getAnyInstance().close();
  }
}
{code}



> A valid query in GFSH appears not to work from Java
> ---
>
> Key: GEODE-2145
> URL: https://issues.apache.org/jira/browse/GEODE-2145
> Project: Geode
>  Issue Type: Bug
>Reporter: Jared Stewart
>
> The following query works from gfsh:
> {code}
> gfsh> query --query="select * from /RegionA.entrySet"
> {code}
> but appears not work from a Java client:
> {code}
> Object result = queryService.newQuery("select * from 
> /RegionA.entrySet").execute();
> {code}
> resulting in this error:
> {code}
> Exception in thread "main" 
> org.apache.geode.cache.client.ServerOperationException: remote server on 
> pdx2-office-dhcp4(48651:loner):60244:8a112bad: 
> org.apache.geode.SerializationException: failed serializing object
>   at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.handleException(OpExecutorImpl.java:675)
>   at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.handleException(OpExecutorImpl.java:772)
>   at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.handleException(OpExecutorImpl.java:603)
>   at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.execute(OpExecutorImpl.java:165)
>   at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.execute(OpExecutorImpl.java:110)
>   at 
> org.apache.geode.cache.client.internal.PoolImpl.execute(PoolImpl.java:697)
>   at 
> org.apache.geode.cache.client.internal.QueryOp.execute(QueryOp.java:59)
>   at 
> org.apache.geode.cache.client.internal.ServerProxy.query(ServerProxy.java:65)
>   at 
> org.apache.geode.cache.query.internal.DefaultQuery.executeOnServer(DefaultQuery.java:440)
>   at 
> org.apache.geode.cache.query.internal.DefaultQuery.execute(DefaultQuery.java:316)
>   at 
> org.apache.geode.cache.query.internal.DefaultQuery.execute(DefaultQuery.java:298)
>   at com.jaredjstewart.ReadOnlyClient.main(ReadOnlyClient.java:58)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)
> Caused by: org.apache.geode.SerializationExcept

[GitHub] geode-native pull request #83: GEODE-2691: Fix function execution attributes...

[echobravopapa]

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/83#discussion_r109743229
  
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char* 
fn, uint32_t timeout,
   bool serverIsHA = false;
   bool serverOptimizeForWrite = false;
 
-  if (verifyFuncArgs) {
-std::vector* attr = getFunctionAttributes(fn);
-{
+  std::vector* attr = getFunctionAttributes(fn);
+  {
--- End diff --

looks like it is an artifact from the previous if statement and can be 
removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2691) Function execution failure with property disable-chunk-handler-thread enabled.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955574#comment-15955574
 ] 

ASF GitHub Bot commented on GEODE-2691:
---

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/83#discussion_r109743229
  
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char* 
fn, uint32_t timeout,
   bool serverIsHA = false;
   bool serverOptimizeForWrite = false;
 
-  if (verifyFuncArgs) {
-std::vector* attr = getFunctionAttributes(fn);
-{
+  std::vector* attr = getFunctionAttributes(fn);
+  {
--- End diff --

looks like it is an artifact from the previous if statement and can be 
removed


> Function execution failure with property disable-chunk-handler-thread enabled.
> --
>
> Key: GEODE-2691
> URL: https://issues.apache.org/jira/browse/GEODE-2691
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>Priority: Critical
>
> If property {{disable-chunk-handler-thread}} enabled the function execution 
> fails with
> {{Unknown message type 61 in response, possible serialization mismatch}} 
> message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

GEODE-2749: ignore bin/ and out/ which are commonly created by IDEs

[Kirk Lund]

Can someone please review my review request:

https://reviews.apache.org/r/58158/

Thanks,
Kirk

[GitHub] geode-native pull request #83: GEODE-2691: Fix function execution attributes...

[echobravopapa]

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/83#discussion_r109743478
  
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char* 
fn, uint32_t timeout,
   bool serverIsHA = false;
   bool serverOptimizeForWrite = false;
 
-  if (verifyFuncArgs) {
-std::vector* attr = getFunctionAttributes(fn);
-{
+  std::vector* attr = getFunctionAttributes(fn);
+  {
--- End diff --

I take that back... @dgkimura what is with the curly braced block?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2691) Function execution failure with property disable-chunk-handler-thread enabled.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955576#comment-15955576
 ] 

ASF GitHub Bot commented on GEODE-2691:
---

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/83#discussion_r109743478
  
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char* 
fn, uint32_t timeout,
   bool serverIsHA = false;
   bool serverOptimizeForWrite = false;
 
-  if (verifyFuncArgs) {
-std::vector* attr = getFunctionAttributes(fn);
-{
+  std::vector* attr = getFunctionAttributes(fn);
+  {
--- End diff --

I take that back... @dgkimura what is with the curly braced block?


> Function execution failure with property disable-chunk-handler-thread enabled.
> --
>
> Key: GEODE-2691
> URL: https://issues.apache.org/jira/browse/GEODE-2691
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>Priority: Critical
>
> If property {{disable-chunk-handler-thread}} enabled the function execution 
> fails with
> {{Unknown message type 61 in response, possible serialization mismatch}} 
> message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #83: GEODE-2691: Fix function execution attributes...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/83#discussion_r109744732
  
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char* 
fn, uint32_t timeout,
   bool serverIsHA = false;
   bool serverOptimizeForWrite = false;
 
-  if (verifyFuncArgs) {
-std::vector* attr = getFunctionAttributes(fn);
-{
+  std::vector* attr = getFunctionAttributes(fn);
+  {
--- End diff --

The curly-brace block was not introduced as part of this change, so your 
guess is as good as mine. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2691) Function execution failure with property disable-chunk-handler-thread enabled.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955589#comment-15955589
 ] 

ASF GitHub Bot commented on GEODE-2691:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/83#discussion_r109744732
  
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char* 
fn, uint32_t timeout,
   bool serverIsHA = false;
   bool serverOptimizeForWrite = false;
 
-  if (verifyFuncArgs) {
-std::vector* attr = getFunctionAttributes(fn);
-{
+  std::vector* attr = getFunctionAttributes(fn);
+  {
--- End diff --

The curly-brace block was not introduced as part of this change, so your 
guess is as good as mine. :)


> Function execution failure with property disable-chunk-handler-thread enabled.
> --
>
> Key: GEODE-2691
> URL: https://issues.apache.org/jira/browse/GEODE-2691
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>Priority: Critical
>
> If property {{disable-chunk-handler-thread}} enabled the function execution 
> fails with
> {{Unknown message type 61 in response, possible serialization mismatch}} 
> message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #74: GEODE-2713: Wrap result collector lock in shared_ptr...

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/74
  
@PivotalSarge need to clean up this PR, should not have all of the docs 
commits included, TIA


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955594#comment-15955594
 ] 

ASF GitHub Bot commented on GEODE-2713:
---

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/74
  
@PivotalSarge need to clean up this PR, should not have all of the docs 
commits included, TIA


> Function execution can lead to passing the address of a stack variable
> --
>
> Key: GEODE-2713
> URL: https://issues.apache.org/jira/browse/GEODE-2713
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>
> In ThinClientRegion::executeFunctionSH(), the address of a stack variable 
> (the result collector lock) is passed to the workers. If an exception occurs 
> with any of the workers, the function will return, causing the stack variable 
> to be destructed. Since the workers have the raw address, it is now a 
> dangling pointer situation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #86: Feature/geode 2513 security props

[davebarnes97]

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/86

Feature/geode 2513 security props



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-security-props

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #86


commit 03b21c213232831845525dc1445cd7f3dde1418c
Author: Dave Barnes 
Date:   2017-02-25T00:06:37Z

GEMNC-268 Update security docs. New OpenSSL build procedure, new properties

commit 395285195ec89afee47e807441993f535ffdf98e
Author: Dave Barnes 
Date:   2017-04-04T18:20:25Z

GEMNC-268: genericize property file names, update ssl-enabled to 
ssl-enabled-components




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 58158: GEODE-2749: ignore bin/ and out/ which are commonly created by IDEs

[Mark Bretl]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58158/#review171015
---


Ship it!




Ship It!

- Mark Bretl


On April 3, 2017, 12:57 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58158/
> ---
> 
> (Updated April 3, 2017, 12:57 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick 
> Rhomberg.
> 
> 
> Bugs: GEODE-2749
> https://issues.apache.org/jira/browse/GEODE-2749
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I installed new versions of Eclipse and IntelliJ and created geode projects 
> in both using the defaults for IDE output of compiled classes. They created 
> bin/ and out/ which were then failing rat and also showing up as untracked 
> files by git.
> 
> I added both to .gitignore and the ignore list in gradle/rat.gradle and 
> tested with git status and ./gradlew rat.
> 
> 
> Diffs
> -
> 
>   .gitignore 38c813196f5 
>   gradle/rat.gradle c97a9e9dc78 
> 
> 
> Diff: https://reviews.apache.org/r/58158/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 58158: GEODE-2749: ignore bin/ and out/ which are commonly created by IDEs

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58158/#review171016
---


Ship it!




Ship It!

- Udo Kohlmeyer


On April 3, 2017, 7:57 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58158/
> ---
> 
> (Updated April 3, 2017, 7:57 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick 
> Rhomberg.
> 
> 
> Bugs: GEODE-2749
> https://issues.apache.org/jira/browse/GEODE-2749
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I installed new versions of Eclipse and IntelliJ and created geode projects 
> in both using the defaults for IDE output of compiled classes. They created 
> bin/ and out/ which were then failing rat and also showing up as untracked 
> files by git.
> 
> I added both to .gitignore and the ignore list in gradle/rat.gradle and 
> tested with git status and ./gradlew rat.
> 
> 
> Diffs
> -
> 
>   .gitignore 38c813196f5 
>   gradle/rat.gradle c97a9e9dc78 
> 
> 
> Diff: https://reviews.apache.org/r/58158/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 58158: GEODE-2749: ignore bin/ and out/ which are commonly created by IDEs

[Avinash Dongre]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58158/#review171017
---


Ship it!




Ship It!

- Avinash Dongre


On April 3, 2017, 7:57 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58158/
> ---
> 
> (Updated April 3, 2017, 7:57 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick 
> Rhomberg.
> 
> 
> Bugs: GEODE-2749
> https://issues.apache.org/jira/browse/GEODE-2749
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I installed new versions of Eclipse and IntelliJ and created geode projects 
> in both using the defaults for IDE output of compiled classes. They created 
> bin/ and out/ which were then failing rat and also showing up as untracked 
> files by git.
> 
> I added both to .gitignore and the ignore list in gradle/rat.gradle and 
> tested with git status and ./gradlew rat.
> 
> 
> Diffs
> -
> 
>   .gitignore 38c813196f5 
>   gradle/rat.gradle c97a9e9dc78 
> 
> 
> Diff: https://reviews.apache.org/r/58158/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 58162: GEM-1351: Move a test to the open side and fix the other tests

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58162/#review171018
---


Fix it, then Ship it!




Please consider making vars and method private and then ShipIt!


geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java
Lines 43 (patched)


Can we make these vars private? I've seen previous dunit tests become 
entwined by accessing each others variables and other craziness.



geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java
Lines 80 (patched)


Can we make this private too?


- Kirk Lund


On April 3, 2017, 9:43 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58162/
> ---
> 
> (Updated April 3, 2017, 9:43 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * move ImportClusterConfigDistributedTest to open side
> * remove @Ignore from other two tests.
> * force the isGfshVM flag to be false before exeuting the command since class 
> loading issue still contaminate the close
> side test environment.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  2d648bd599c57b91252aaf37bce4bf0635c4eda6 
> 
> 
> Diff: https://reviews.apache.org/r/58162/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[jira] [Commented] (GEODE-2749) git and rat should ignore out/ and bin/ directories created by IDEs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955657#comment-15955657
 ] 

ASF subversion and git services commented on GEODE-2749:


Commit 4a09e88b691b3d6cffe551f4ff08648e62082475 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4a09e88 ]

GEODE-2749: ignore bin/ and out/ which are commonly created by IDEs


> git and rat should ignore out/ and bin/ directories created by IDEs
> ---
>
> Key: GEODE-2749
> URL: https://issues.apache.org/jira/browse/GEODE-2749
> Project: Geode
>  Issue Type: Wish
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Eclipse and IntelliJ default to creating out/ and bin/ directories. I'd like 
> to configure git and rat to ignore these directories.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2748) geode-web web.xml specifies the wrong xml namespace

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955656#comment-15955656
 ] 

ASF subversion and git services commented on GEODE-2748:


Commit abb27b34a0c5aa382a25a5506e4bb4f32c6605c4 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=abb27b3 ]

GEODE-2748: fix xmlns to specify javaee instead of j2ee


> geode-web web.xml specifies the wrong xml namespace
> ---
>
> Key: GEODE-2748
> URL: https://issues.apache.org/jira/browse/GEODE-2748
> Project: Geode
>  Issue Type: Bug
>  Components: rest (admin)
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Here's the current content which refers to ns/j2ee:
> {noformat}
> http://java.sun.com/xml/ns/j2ee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";
>  version="3.0">
> {noformat}
> Eclipse immediately repots that this is in error (the correct namespace is 
> now ns/javaee).
> Review http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd, shows that Eclipse 
> is indeed correct:
> {noformat}
> http://www.w3.org/2001/XMLSchema";
> targetNamespace="http://java.sun.com/xml/ns/javaee";
> xmlns:javaee="http://java.sun.com/xml/ns/javaee";
> xmlns:xsd="http://www.w3.org/2001/XMLSchema";
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2749) git and rat should ignore out/ and bin/ directories created by IDEs

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-2749.
--
   Resolution: Fixed
Fix Version/s: 1.2.0

> git and rat should ignore out/ and bin/ directories created by IDEs
> ---
>
> Key: GEODE-2749
> URL: https://issues.apache.org/jira/browse/GEODE-2749
> Project: Geode
>  Issue Type: Wish
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Fix For: 1.2.0
>
>
> Eclipse and IntelliJ default to creating out/ and bin/ directories. I'd like 
> to configure git and rat to ignore these directories.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2748) geode-web web.xml specifies the wrong xml namespace

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-2748.
--
   Resolution: Fixed
Fix Version/s: 1.2.0

> geode-web web.xml specifies the wrong xml namespace
> ---
>
> Key: GEODE-2748
> URL: https://issues.apache.org/jira/browse/GEODE-2748
> Project: Geode
>  Issue Type: Bug
>  Components: rest (admin)
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Fix For: 1.2.0
>
>
> Here's the current content which refers to ns/j2ee:
> {noformat}
> http://java.sun.com/xml/ns/j2ee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";
>  version="3.0">
> {noformat}
> Eclipse immediately repots that this is in error (the correct namespace is 
> now ns/javaee).
> Review http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd, shows that Eclipse 
> is indeed correct:
> {noformat}
> http://www.w3.org/2001/XMLSchema";
> targetNamespace="http://java.sun.com/xml/ns/javaee";
> xmlns:javaee="http://java.sun.com/xml/ns/javaee";
> xmlns:xsd="http://www.w3.org/2001/XMLSchema";
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: GEODE-2749: ignore bin/ and out/ which are commonly created by IDEs

[Kirk Lund]

Thanks for the reviews!


On Tue, Apr 4, 2017 at 11:33 AM, Kirk Lund  wrote:

> Can someone please review my review request:
>
> https://reviews.apache.org/r/58158/
>
> Thanks,
> Kirk
>
>

[GitHub] geode-native issue #74: GEODE-2713: Wrap result collector lock in shared_ptr...

[PivotalSarge]

Github user PivotalSarge commented on the issue:

https://github.com/apache/geode-native/pull/74
  
To quote Montgomery Scott, "I did what I could, Captain!"

> On 4 Apr, 2017, at 11:40, Ernie Burghardt  
wrote:
> 
> @PivotalSarge  need to clean up this PR, 
should not have all of the docs commits included, TIA
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
> 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955702#comment-15955702
 ] 

ASF GitHub Bot commented on GEODE-2713:
---

Github user PivotalSarge commented on the issue:

https://github.com/apache/geode-native/pull/74
  
To quote Montgomery Scott, "I did what I could, Captain!"

> On 4 Apr, 2017, at 11:40, Ernie Burghardt  
wrote:
> 
> @PivotalSarge  need to clean up this PR, 
should not have all of the docs commits included, TIA
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
> 




> Function execution can lead to passing the address of a stack variable
> --
>
> Key: GEODE-2713
> URL: https://issues.apache.org/jira/browse/GEODE-2713
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>
> In ThinClientRegion::executeFunctionSH(), the address of a stack variable 
> (the result collector lock) is passed to the workers. If an exception occurs 
> with any of the workers, the function will return, causing the stack variable 
> to be destructed. Since the workers have the raw address, it is now a 
> dangling pointer situation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58080/
---

(Updated April 4, 2017, 8:41 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk Lund, 
and Patrick Rhomberg.


Changes
---

Finally got test SizeExportLogsFunctionCacheTest.noFiles_returnsZeroResult to 
pass in precheckin. Thanks to Jinmei for help properly applying rules to ensure 
clean server startup and shutdown in the tests.


Repository: geode


Description
---

- New Function class added with tests
- Code to invoke new function added, but disabled, in ExportLogsCommand
- New option added, but disabled, for specifying size limit for exported
  logs
- Refactoring: extracted the interceptor from ExportLogsCommand
- Refactoring: renamed ExportLogCommand to ExportLogsCommand
- New Serializable class to return the log size estimate to the command
- Tests for the log sizing related classes

This is work-in-progress that is adds sizing estimation for exported logs, but 
the code is currently not called by ExportLogsCommand. Follow-on work will use 
the new sizing estimation to provide warnings to the user if exporting logs may 
fill up disks on servers or the locator.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java
 3f147c19a128dce78c51c31e6758e517cd2ab496 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptor.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
 cbdf1c4bc28554a8fbec3740c566ee07c69b4ac9 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfo.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunction.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 5b1f089c18c404f64929398f6015839eb783ccb4 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogSizer.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
 95edd426da8b8f39bb1486661d8c307d43f170d6 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsFileSizeLimitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptorJUnitTest.java
 573701fd7f48c8c1b72c0f71993a4adea7bdbe8b 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
 5a4d274a751a6e22fcfbc0c5e6bd5dff39e3b938 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsTestSuite.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LogLevelInterceptorTest.java
 41b971534fd83c87f33751fa46454e158315f6ae 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfoTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionCacheTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionFileTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsTestSuite.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogSizerTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 6ae82da58923fdf3a44217c1773a40d8ff1001bc 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
 2f5a5cdf8c59e90625fe01c3306462e9277ab4e1 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
 397ec14c0bbbea277d378eefcaecfdb90cc9e224 


Diff: https://reviews.apache.org/r/58080/diff/3/

Changes: https://reviews.apache.org/r/58080/diff/2-3/


Testing
---

Precheckin is running

I need to debug one test of the new class that is still failing:

org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest
 > withFunctionError_shouldThrow FAILED
org.apache.geode.GemFireConfigException: The locators attribute can not be 
empty when the mcast-port attribute is non-zero.
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:558)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:299)
at 
org.apache.geode.distributed.Dist

Review Request 58187: GEODE-2732 after auto-reconnect a server is restarted on the default port of 40404

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58187/
---

Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Repository: geode


Description
---

Gfsh command line parameters were put into ThreadLocals to make them available 
to the XML parser.  These are now held in non-thread-local variables so that 
all threads, including the auto-reconnect thread, can see them when building 
the cache.

This diff also includes some minor refactoring in 
org.apache.geode.internal.tcp.  It primarily removes some 
"this.owner.getConduit().doSomething" with "this.conduit.doSomething" and 
removes dead code.


Diffs
-

  
extensions/geode-modules-tomcat8/src/test/java/org/apache/geode/modules/session/Tomcat8SessionsClientServerDUnitTest.java
 e475f40339e294ad48b403db1afa7aa624d5e80c 
  geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
9435bd8178248c4fa34f6867d15a7cdfdec06d6b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerLauncher.java
 760abd3d946281d474502a9af2e8fe823a011329 
  
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
 1c3c93314841f5623c0e6387500af88f106328d9 
  geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java 
a0af24501a5081fe483160c5bf4fc7671545684e 
  geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java 
08a90096c0cf0348c0fa34b7ff8e18806810ab68 
  geode-core/src/main/java/org/apache/geode/internal/tcp/DirectReplySender.java 
3872ee98ec24fe95894c0def538e3752136b05c3 
  geode-core/src/main/java/org/apache/geode/internal/tcp/MsgReader.java 
fc5627112ac8dd456976139d3750fd951812879b 
  geode-core/src/main/java/org/apache/geode/internal/tcp/NIOMsgReader.java 
50f5faedba056ec4f57124aefd56477dc11c1cf6 
  
geode-core/src/test/java/org/apache/geode/cache30/ReconnectWithCacheXMLDUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/cache30/ReconnectWithCacheXMLDUnitTest.xml
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58187/diff/1/


Testing
---

new test, precheckin


Thanks,

Bruce Schuchardt

[jira] [Updated] (GEODE-2684) org.apache.geode.internal.tcp.Connection & ConnectionTable cleanup

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-2684:

Issue Type: Task  (was: Bug)

> org.apache.geode.internal.tcp.Connection & ConnectionTable cleanup
> --
>
> Key: GEODE-2684
> URL: https://issues.apache.org/jira/browse/GEODE-2684
> Project: Geode
>  Issue Type: Task
>  Components: membership
>Reporter: Bruce Schuchardt
>
> These classes contain a lot of commented-out code, poorly named methods and 
> incorrect calculations that need to be cleaned up.  For instance, Connection 
> contains this:
> short aShort = -1;
> bytes[x] = (byte)(aShort & 0xff / 0x100);
> bytes[x+1] = (byte)(aShort & 0xff);
> which is incorrect and results in bytes[x] being zero when the intent is for 
> it to be 255.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2751) UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer fails on Jenkins

[Hitesh Khamesra (JIRA)]

Hitesh Khamesra created GEODE-2751:
--

 Summary: 
UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer 
fails on Jenkins
 Key: GEODE-2751
 URL: https://issues.apache.org/jira/browse/GEODE-2751
 Project: Geode
  Issue Type: Bug
  Components: membership
Reporter: Hitesh Khamesra


Error Message

org.junit.ComparisonFailure: expected:<[67.195.81.156](15619):32...> 
but was:<[asf912](15619):32...>
Stacktrace

org.junit.ComparisonFailure: expected:<[67.195.81.156](15619):32...> 
but was:<[asf912](15619):32...>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.doTestSystemClientEventsInServer(UniversalMembershipListenerAdapterDUnitTest.java:946)
at 
org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer(UniversalMembershipListenerAdapterDUnitTest.java:731)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at sun.reflect.GeneratedMethodAccessor352.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at 
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)

[GitHub] geode-native issue #86: Feature/geode 2513 security props

[davebarnes97]

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/86
  
Whoa! Thought I fixed that...

On Tue, Apr 4, 2017 at 12:46 PM, PivotalSarge 
wrote:

> *@PivotalSarge* approved this pull request.
>
> Perhaps "appropreate" is missing an 'i'...
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (GEODE-2752) FixedPRSinglehopDUnitTest.test_FPAmetadataFetch fails on Jenkins

[Hitesh Khamesra (JIRA)]

Hitesh Khamesra created GEODE-2752:
--

 Summary: FixedPRSinglehopDUnitTest.test_FPAmetadataFetch fails on 
Jenkins
 Key: GEODE-2752
 URL: https://issues.apache.org/jira/browse/GEODE-2752
 Project: Geode
  Issue Type: Bug
  Components: client/server
Reporter: Hitesh Khamesra


org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest$$Lambda$90/1893223347.call
 in VM 0 running on Host asf912.gq1.ygridcore.net with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
at org.apache.geode.test.dunit.VM.invoke(VM.java:315)
at 
org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest.test_FPAmetadataFetch(FixedPRSinglehopDUnitTest.java:283)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at 
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at 
java.util.conc

[GitHub] geode-native issue #86: Feature/geode 2513 security props

[davebarnes97]

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/86
  
I _did_ fix it. Not sure why the old misspelling was visible to you,
@pivotalsarge.

On Tue, Apr 4, 2017 at 1:55 PM, Dave Barnes  wrote:

> Whoa! Thought I fixed that...
>
> On Tue, Apr 4, 2017 at 12:46 PM, PivotalSarge 
> wrote:
>
>> *@PivotalSarge* approved this pull request.
>>
>> Perhaps "appropreate" is missing an 'i'...
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> 
,
>> or mute the thread
>> 

>> .
>>
>
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2752) FixedPRSinglehopDUnitTest.test_FPAmetadataFetch fails on Jenkins

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-2752:
---
Issue Type: Improvement  (was: Bug)

> FixedPRSinglehopDUnitTest.test_FPAmetadataFetch fails on Jenkins
> 
>
> Key: GEODE-2752
> URL: https://issues.apache.org/jira/browse/GEODE-2752
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Hitesh Khamesra
>
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest$$Lambda$90/1893223347.call
>  in VM 0 running on Host asf912.gq1.ygridcore.net with 4 VMs
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:315)
>   at 
> org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest.test_FPAmetadataFetch(FixedPRSinglehopDUnitTest.java:283)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.remote.internal.hub.MessageHub$Han

[jira] [Updated] (GEODE-2752) FixedPRSinglehopDUnitTest.test_FPAmetadataFetch fails on Jenkins

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-2752:
---
Issue Type: Bug  (was: Improvement)

> FixedPRSinglehopDUnitTest.test_FPAmetadataFetch fails on Jenkins
> 
>
> Key: GEODE-2752
> URL: https://issues.apache.org/jira/browse/GEODE-2752
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Hitesh Khamesra
>
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest$$Lambda$90/1893223347.call
>  in VM 0 running on Host asf912.gq1.ygridcore.net with 4 VMs
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:315)
>   at 
> org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest.test_FPAmetadataFetch(FixedPRSinglehopDUnitTest.java:283)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run

[GitHub] geode-native pull request #86: Feature/geode 2513 security props

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/86


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2581) New Client/Server Protocol Design Proposal

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-2581:
---
Description: 
The goal here is the create a high-level design document that outlines the 
foundational design choices of the new protocol.

As part of this story, we should have a document that describes the basics of 
writing a new client using the new client/server protocol.

  was:The goal here is the create a high-level design document that outlines 
the foundational design choices of the new protocol.


> New Client/Server Protocol Design Proposal
> --
>
> Key: GEODE-2581
> URL: https://issues.apache.org/jira/browse/GEODE-2581
> Project: Geode
>  Issue Type: Sub-task
>  Components: messaging
>Reporter: Addison
>
> The goal here is the create a high-level design document that outlines the 
> foundational design choices of the new protocol.
> As part of this story, we should have a document that describes the basics of 
> writing a new client using the new client/server protocol.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2691) Function execution failure with property disable-chunk-handler-thread enabled.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955892#comment-15955892
 ] 

ASF subversion and git services commented on GEODE-2691:


Commit 962efc7d59606e687082c041739bdcfd0b0b0c53 in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=962efc7 ]

GEODE-2691: Fix function execution attributes mismatch

Fixes function execution invocation which previously passed in attributes that
function execute would compare to the server's view of the registered function
attributes. Since the previously passed in attributes were deprecated there is
nothing to compare. Instead we should accept the attributes that the server
returns.

Testing: Function execution tests pass


> Function execution failure with property disable-chunk-handler-thread enabled.
> --
>
> Key: GEODE-2691
> URL: https://issues.apache.org/jira/browse/GEODE-2691
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>Priority: Critical
>
> If property {{disable-chunk-handler-thread}} enabled the function execution 
> fails with
> {{Unknown message type 61 in response, possible serialization mismatch}} 
> message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58080/#review171044
---




geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsTestSuite.java
Lines 23 (patched)


you probably don't want to check in this suite. these tests will be run 
twice if you do.



geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
Line 95 (original), 95 (patched)


why is this change necessary?


- Jinmei Liao


On April 4, 2017, 8:41 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58080/
> ---
> 
> (Updated April 4, 2017, 8:41 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk 
> Lund, and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - New Function class added with tests
> - Code to invoke new function added, but disabled, in ExportLogsCommand
> - New option added, but disabled, for specifying size limit for exported
>   logs
> - Refactoring: extracted the interceptor from ExportLogsCommand
> - Refactoring: renamed ExportLogCommand to ExportLogsCommand
> - New Serializable class to return the log size estimate to the command
> - Tests for the log sizing related classes
> 
> This is work-in-progress that is adds sizing estimation for exported logs, 
> but the code is currently not called by ExportLogsCommand. Follow-on work 
> will use the new sizing estimation to provide warnings to the user if 
> exporting logs may fill up disks on servers or the locator.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java
>  3f147c19a128dce78c51c31e6758e517cd2ab496 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptor.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
>  cbdf1c4bc28554a8fbec3740c566ee07c69b4ac9 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfo.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunction.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
>  5b1f089c18c404f64929398f6015839eb783ccb4 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogSizer.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
>  95edd426da8b8f39bb1486661d8c307d43f170d6 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsFileSizeLimitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptorJUnitTest.java
>  573701fd7f48c8c1b72c0f71993a4adea7bdbe8b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
>  5a4d274a751a6e22fcfbc0c5e6bd5dff39e3b938 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsTestSuite.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LogLevelInterceptorTest.java
>  41b971534fd83c87f33751fa46454e158315f6ae 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfoTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionCacheTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionFileTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsTestSuite.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogSizerTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  6ae82da58923fdf3a44217c1773a40d8ff1001bc 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
>  2f5a5cdf8c59e90625fe01c3306462e9277ab4e1 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
>  397ec14c0bbbea277d378eefcaecfdb90cc9e224 
> 
> 
> Diff: h

[jira] [Commented] (GEODE-2726) Add Packer Build Files for VS 2017

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955918#comment-15955918
 ] 

ASF subversion and git services commented on GEODE-2726:


Commit 95cdd6c7da644c3e53167262c2422f7097b16d1e in geode-native's branch 
refs/heads/develop from [~mmartell]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=95cdd6c ]

GEODE-2726: Add Packer Build Scripts for VS 2017


> Add Packer Build Files for VS 2017
> --
>
> Key: GEODE-2726
> URL: https://issues.apache.org/jira/browse/GEODE-2726
> Project: Geode
>  Issue Type: New Feature
>  Components: native client
>Reporter: Michael Martell
>
> As a developer I want to setup an image to build nativeclient products using 
> Visual Studio 2017.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2420) Warn a user if they try to export too much data

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955925#comment-15955925
 ] 

ASF subversion and git services commented on GEODE-2420:


Commit c61cab97cca37012888ecd2d385b6580413d05f8 in geode's branch 
refs/heads/develop from [~khowe]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c61cab9 ]

GEODE-2420: Updates from review

Rewrote server startup and shutdown in SizeExportLogsFunctionCacheTest
to use rules that ensure clean cache server shutdown after each test.


> Warn a user if they try to export too much data
> ---
>
> Key: GEODE-2420
> URL: https://issues.apache.org/jira/browse/GEODE-2420
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, docs, gfsh
>Reporter: Jared Stewart
>Assignee: Kirk Lund
>
> We should warn a user and prompt for confirmation before trying to perform an 
> `export logs` operation that would result in a file over some threshold.  
> (Logs and stats have the potential to be very large.)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2420) Warn a user if they try to export too much data

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955923#comment-15955923
 ] 

ASF subversion and git services commented on GEODE-2420:


Commit 0c15c6e01e7095f61e0e2df9866534f1cf6489cc in geode's branch 
refs/heads/develop from [~khowe]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0c15c6e ]

GEODE-2420: Add classes to estimated the size of exported logs

- New Function class added with tests
- Code to invoke new function added, but disabled, in ExportLogsCommand
- New option added, but disabled, for specifying size limit for exported
  logs
- Refactoring: extracted the interceptor from ExportLogsCommand
- Refactoring: renamed ExportLogCommand to ExportLogsCommand
- New Serializable class to return the log size estimate to the command
- Tests for the log sizing related classes


> Warn a user if they try to export too much data
> ---
>
> Key: GEODE-2420
> URL: https://issues.apache.org/jira/browse/GEODE-2420
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, docs, gfsh
>Reporter: Jared Stewart
>Assignee: Kirk Lund
>
> We should warn a user and prompt for confirmation before trying to perform an 
> `export logs` operation that would result in a file over some threshold.  
> (Logs and stats have the potential to be very large.)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #83: GEODE-2691: Fix function execution attributes mismat...

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/83
  
@dgkimura merged, please close


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2691) Function execution failure with property disable-chunk-handler-thread enabled.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955927#comment-15955927
 ] 

ASF GitHub Bot commented on GEODE-2691:
---

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/83
  
@dgkimura merged, please close


> Function execution failure with property disable-chunk-handler-thread enabled.
> --
>
> Key: GEODE-2691
> URL: https://issues.apache.org/jira/browse/GEODE-2691
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>Priority: Critical
>
> If property {{disable-chunk-handler-thread}} enabled the function execution 
> fails with
> {{Unknown message type 61 in response, possible serialization mismatch}} 
> message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #76: GEODE-2726: Add Packer Build Files for VS 2017

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/76
  
@mmartell merged, please close


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2726) Add Packer Build Files for VS 2017

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955928#comment-15955928
 ] 

ASF GitHub Bot commented on GEODE-2726:
---

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/76
  
@mmartell merged, please close


> Add Packer Build Files for VS 2017
> --
>
> Key: GEODE-2726
> URL: https://issues.apache.org/jira/browse/GEODE-2726
> Project: Geode
>  Issue Type: New Feature
>  Components: native client
>Reporter: Michael Martell
>
> As a developer I want to setup an image to build nativeclient products using 
> Visual Studio 2017.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #83: GEODE-2691: Fix function execution attributes...

[dgkimura]

Github user dgkimura closed the pull request at:

https://github.com/apache/geode-native/pull/83


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2691) Function execution failure with property disable-chunk-handler-thread enabled.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955929#comment-15955929
 ] 

ASF GitHub Bot commented on GEODE-2691:
---

Github user dgkimura closed the pull request at:

https://github.com/apache/geode-native/pull/83


> Function execution failure with property disable-chunk-handler-thread enabled.
> --
>
> Key: GEODE-2691
> URL: https://issues.apache.org/jira/browse/GEODE-2691
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>Priority: Critical
>
> If property {{disable-chunk-handler-thread}} enabled the function execution 
> fails with
> {{Unknown message type 61 in response, possible serialization mismatch}} 
> message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58162: GEM-1351: Move a test to the open side and fix the other tests

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58162/
---

(Updated April 4, 2017, 10:02 p.m.)


Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
Rhomberg.


Repository: geode


Description
---

* move ImportClusterConfigDistributedTest to open side
* remove @Ignore from other two tests.
* force the isGfshVM flag to be false before exeuting the command since class 
loading issue still contaminate the close
side test environment.


Diffs (updated)
-

  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 6ae82da58923fdf3a44217c1773a40d8ff1001bc 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 2d648bd599c57b91252aaf37bce4bf0635c4eda6 


Diff: https://reviews.apache.org/r/58162/diff/2/

Changes: https://reviews.apache.org/r/58162/diff/1-2/


Testing
---

precheckin running


Thanks,

Jinmei Liao

[jira] [Commented] (GEODE-2420) Warn a user if they try to export too much data

[Kenneth Howe (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955948#comment-15955948
 ] 

Kenneth Howe commented on GEODE-2420:
-

The commit above adds the classes needed for estimating the size of exported 
logs but with the functionality not yet enabled at the gfsh command level.

> Warn a user if they try to export too much data
> ---
>
> Key: GEODE-2420
> URL: https://issues.apache.org/jira/browse/GEODE-2420
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, docs, gfsh
>Reporter: Jared Stewart
>Assignee: Kirk Lund
>
> We should warn a user and prompt for confirmation before trying to perform an 
> `export logs` operation that would result in a file over some threshold.  
> (Logs and stats have the potential to be very large.)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2739) Identify all globals we want to refactor

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison resolved GEODE-2739.

Resolution: Won't Do

> Identify all globals we want to refactor
> 
>
> Key: GEODE-2739
> URL: https://issues.apache.org/jira/browse/GEODE-2739
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Addison
>
> Create a list of all global singletons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2740) Refactor cache factory and immediate relationships

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-2740:
---
Summary: Refactor cache factory and immediate relationships  (was: Refactor 
cache singleton in factor of well encapsulated objects)

> Refactor cache factory and immediate relationships
> --
>
> Key: GEODE-2740
> URL: https://issues.apache.org/jira/browse/GEODE-2740
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Addison
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2740) Refactor cache factory and immediate relationships

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-2740:
---
Description: 
Definition of Done
All existing tests should still pass when refactor is done.

> Refactor cache factory and immediate relationships
> --
>
> Key: GEODE-2740
> URL: https://issues.apache.org/jira/browse/GEODE-2740
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Addison
>
> Definition of Done
> All existing tests should still pass when refactor is done.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2753) Create class diagram

[Addison (JIRA)]

Addison created GEODE-2753:
--

 Summary: Create class diagram
 Key: GEODE-2753
 URL: https://issues.apache.org/jira/browse/GEODE-2753
 Project: Geode
  Issue Type: Sub-task
  Components: native client
Reporter: Addison


Create a mapping of classes in the Native Client



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #514 was SUCCESSFUL (with 1843 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #514 was successful.
---
Scheduled
1845 tests in total.

https://build.spring.io/browse/SGF-NAG-514/





--
This message is automatically generated by Atlassian Bamboo

[jira] [Updated] (GEODE-2581) New Client/Server Protocol Design Proposal

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2581:
---
Description: 
The goal here is to create a high-level design document that outlines the 
foundational design choices of the new protocol.

As part of this story, we should have a document that describes the basics of 
writing a new client using the new client/server protocol.

  was:
The goal here is the create a high-level design document that outlines the 
foundational design choices of the new protocol.

As part of this story, we should have a document that describes the basics of 
writing a new client using the new client/server protocol.


> New Client/Server Protocol Design Proposal
> --
>
> Key: GEODE-2581
> URL: https://issues.apache.org/jira/browse/GEODE-2581
> Project: Geode
>  Issue Type: Sub-task
>  Components: messaging
>Reporter: Addison
>
> The goal here is to create a high-level design document that outlines the 
> foundational design choices of the new protocol.
> As part of this story, we should have a document that describes the basics of 
> writing a new client using the new client/server protocol.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58155: GEODE-2653: fix a flaky test.

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58155/#review171071
---


Ship it!




Ship It!

- Hitesh Khamesra


On April 3, 2017, 6:31 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58155/
> ---
> 
> (Updated April 3, 2017, 6:31 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> And do some cleanup while I'm here:
>  * Change Mockito's `any` to `isA`.
>  * Replace some `Thread.sleep()` calls with Awaitility calls.
>  * Remove our `MethodExecuted` class -- this can be done with Mockito's 
> `verify()`.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  05ab6f7e5 
> 
> 
> Diff: https://reviews.apache.org/r/58155/diff/1/
> 
> 
> Testing
> ---
> 
> Running precheckin.
> 
> Ran the test suite in IntelliJ a few hundred times on my machine.
> 
> 
> Thanks,
> 
> Galen O'Sullivan
> 
>

[jira] [Commented] (GEODE-2750) Lucene destroy index should destroy the index on remote members before destroying it in the local member

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956058#comment-15956058
 ] 

ASF subversion and git services commented on GEODE-2750:


Commit 99e61ffa09158ad60164368805b4052614b806c8 in geode's branch 
refs/heads/develop from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=99e61ff ]

GEODE-2750: The lucene index is now destroyed on remote members before the 
initiating member


> Lucene destroy index should destroy the index on remote members before 
> destroying it in the local member
> 
>
> Key: GEODE-2750
> URL: https://issues.apache.org/jira/browse/GEODE-2750
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>
> Destroying the AsyncEventQueue is partially a local and partially a 
> distributed operation. The local part is the stopping and destroying the 
> actual AsyncEventQueue and GatewaySender instances. Also, removing the 
> AsyncEventQueue id from the data Region. The distributed part is the 
> underlying co-located AsyncEventQueue  and fileAndChunk PartitionedRegions. 
> Co-located PRs cannot be locally destroyed, so they have to be distributed 
> destroys.
> Destroying the local parts of the index in remote members first followed by 
> the local parts in the initiating member and finally the co-located regions 
> should help with RegionDestroyedExceptions occurring when regions are 
> destroyed out from under the index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58162: GEM-1351: Move a test to the open side and fix the other tests

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58162/#review171074
---


Ship it!




Ship It!

- Kirk Lund


On April 4, 2017, 10:02 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58162/
> ---
> 
> (Updated April 4, 2017, 10:02 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * move ImportClusterConfigDistributedTest to open side
> * remove @Ignore from other two tests.
> * force the isGfshVM flag to be false before exeuting the command since class 
> loading issue still contaminate the close
> side test environment.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  6ae82da58923fdf3a44217c1773a40d8ff1001bc 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  2d648bd599c57b91252aaf37bce4bf0635c4eda6 
> 
> 
> Diff: https://reviews.apache.org/r/58162/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[jira] [Resolved] (GEODE-2750) Lucene destroy index should destroy the index on remote members before destroying it in the local member

[Barry Oglesby (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barry Oglesby resolved GEODE-2750.
--
   Resolution: Fixed
Fix Version/s: 1.2.0

> Lucene destroy index should destroy the index on remote members before 
> destroying it in the local member
> 
>
> Key: GEODE-2750
> URL: https://issues.apache.org/jira/browse/GEODE-2750
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> Destroying the AsyncEventQueue is partially a local and partially a 
> distributed operation. The local part is the stopping and destroying the 
> actual AsyncEventQueue and GatewaySender instances. Also, removing the 
> AsyncEventQueue id from the data Region. The distributed part is the 
> underlying co-located AsyncEventQueue  and fileAndChunk PartitionedRegions. 
> Co-located PRs cannot be locally destroyed, so they have to be distributed 
> destroys.
> Destroying the local parts of the index in remote members first followed by 
> the local parts in the initiating member and finally the co-located regions 
> should help with RegionDestroyedExceptions occurring when regions are 
> destroyed out from under the index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)