[jira] [Commented] (GEODE-2788) Add official Socket timeout parameter when connecting to servers/locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972043#comment-15972043
 ] 

ASF GitHub Bot commented on GEODE-2788:
---

Github user masaki-yamakawa commented on the issue:

https://github.com/apache/geode/pull/458
  
Thank you very much for your reply.

> I'm uneasy about having this client-specific setting in the distributed 
system properties. These properties generally apply to DistributedSystem and 
its sub-components like DistributionManager and MembershipManager. 

I think so, too. Then, what do you think about the idea to add to the 
attribute of pool?
For example, cache.xml like this:
`
  

  
`
API like this:
`
  ClientCacheFactory().addPoolLocator("localhost", 
10334).setConnecTimeout(15000)
`
* Default:59000 ms


> Add official Socket timeout parameter when connecting to servers/locators
> -
>
> Key: GEODE-2788
> URL: https://issues.apache.org/jira/browse/GEODE-2788
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, docs
>Reporter: Masaki Yamakawa
>Priority: Minor
>  Labels: patch
>
> When connecting from the client to the servers/locators, if the 
> servers/locators is not started, the connection can not be established and a 
> Socket timeout occurs.
> This timeout value is 59 seconds by default. This timeout value is too long. 
> This timeout value can be changed by specifying the unofficial parameter 
> "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I 
> corresponded so that it can be specified by official parameters.
> Like the NativeClient, the official parameters should be specified by 
> "connect-timeout" in gemfire.properties.
> Timeout values ​​are determined in the following order of priority.
> 1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
> 2. java system property:gemfire.connect-timeout
> 3. gemfire.properties:connect-timeout
> 4. default:59000 milli seconds
> As another idea, there is also an idea to make it possible to specify it as 
> an attribute of Pool. In that case NativeClient needs the same modification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #458: GEODE-2788: Add official Socket timeout parameter when con...

[masaki-yamakawa]

Github user masaki-yamakawa commented on the issue:

https://github.com/apache/geode/pull/458
  
Thank you very much for your reply.

> I'm uneasy about having this client-specific setting in the distributed 
system properties. These properties generally apply to DistributedSystem and 
its sub-components like DistributionManager and MembershipManager. 

I think so, too. Then, what do you think about the idea to add to the 
attribute of pool?
For example, cache.xml like this:
`
  

  
`
API like this:
`
  ClientCacheFactory().addPoolLocator("localhost", 
10334).setConnecTimeout(15000)
`
* Default:59000 ms


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2792) Server has concurrencyChecksEnabled log message has the booleans switched

[Darrel Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971876#comment-15971876
 ] 

Darrel Schneider commented on GEODE-2792:
-

Here is a refactoring of the code that would fix this:
{code}
  private void concurrencyConfigurationCheck(VersionTag tag) {
if (this.concurrencyMessageIssued) {
  return;
}
boolean serverConcurrencyChecksEnabled = this.concurrencyChecksEnabled;
boolean clientConcurrencyChecksEnabled = tag != null;
if (clientConcurrencyChecksEnabled != serverConcurrencyChecksEnabled) {
  this.concurrencyMessageIssued = true;
  logger.info(LocalizedMessage.create(
  
LocalizedStrings.LocalRegion_SERVER_HAS_CONCURRENCY_CHECKS_ENABLED_0_BUT_CLIENT_HAS_1_FOR_REGION_2,
  new Object[] {serverConcurrencyChecksEnabled, 
clientConcurrencyChecksEnabled, this}));
}
  }
{code}

> Server has concurrencyChecksEnabled log message has the booleans switched
> -
>
> Key: GEODE-2792
> URL: https://issues.apache.org/jira/browse/GEODE-2792
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Darrel Schneider
>Priority: Trivial
>
> The log message: "Server has concurrencyChecksEnabled {0} but client has {1}" 
> should instead be:  "Server has concurrencyChecksEnabled {1} but client has 
> {0}".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2792) Server has concurrencyChecksEnabled log message has the booleans switched

[Darrel Schneider (JIRA)]

Darrel Schneider created GEODE-2792:
---

 Summary: Server has concurrencyChecksEnabled log message has the 
booleans switched
 Key: GEODE-2792
 URL: https://issues.apache.org/jira/browse/GEODE-2792
 Project: Geode
  Issue Type: Bug
  Components: regions
Reporter: Darrel Schneider


The log message: "Server has concurrencyChecksEnabled {0} but client has {1}" 
should instead be:  "Server has concurrencyChecksEnabled {1} but client has 
{0}".




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #527 was SUCCESSFUL (with 1843 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #527 was successful.
---
Scheduled
1845 tests in total.

https://build.spring.io/browse/SGF-NAG-527/





--
This message is automatically generated by Atlassian Bamboo

Review Request 58484: GEODE-2632: refactoring part 2

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58484/
---

Review request for geode, Bruce Schuchardt, Darrel Schneider, Jinmei Liao, 
Jared Stewart, Ken Howe, Udo Kohlmeyer, and Dan Smith.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

Purpose: Refactoring code in steps to eventually fix security/client-server 
performance
Part 1: https://reviews.apache.org/r/58460/

Refactor code to use internal interfaces

* refactor code to use InternalCache instead of GemFireCacheImpl
* refactor code to use getInternalDistributedSystem
* delete dead code, unused code, unused imports, extra whitespace,
useless javadocs and comments, fix typos

The end goals of multiple iterations of refactoring: 1) write high-level 
benchmark for client put to server [done], 2) change internal dependencies from 
impl class to interface (including GemFireCacheImpl to InternalCache), 3) fix 
constructors and invert dependencies of internal classes (including 
AcceptorImpl and client Command classes), 4) write low-level benchmark(s) for 
client commands, 5) fix any performance issues involving SecurityService.

I'd like to commit each iteration of refactoring as I go to keep the number of 
merge conflicts and number of modified files lower.


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
 0103cf6d8d6f088b4bd3ffc30f8e52b977a82621 
  
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
 b2881082278bdb53a8553a7fd31c47c304eb1ef6 
  
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java
 03f079964c5e12c1ba44ba240f12025a5b098a09 
  
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java
 08a5b003d6e3c5cdec8ad22b74153f2c31cde9f7 
  geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegion.java 
e69f801d4f307c3ce98c105d6d2e38460d0d4a67 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
a3c4a931b95fb3a8ea6463bb027aadd1bc8fdd32 
  
geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreFactoryImpl.java
 71be7ec00deb6dc774f84e0fcca291a310ba09e4 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
b97f4286b6e2352a4ec5637477641d868cb05a6c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreMonitor.java 
2bb510720f2374ae1159095bff293f88465e600c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/DistTXStateProxyImplOnCoordinator.java
 52d155f5eebff2dd6eb50fbada159aca6629c1ec 
  
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java 
68fdbebac6a50efb7092717d56243c7b88a47ec5 
  geode-core/src/main/java/org/apache/geode/internal/cache/ExpiryTask.java 
e12622d070b932979a6ca400d47eeff36c142f21 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
869181432a64c2683e1b606e621cb5dbd1b42589 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
ee80014b393ba5d625cb78cf12a2a6e2c2fc24b3 
  geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
55ee6a8e1ba7351c87d6f63f530469699efa8ee2 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java 
8db89699ceb2e23fd4ae8ce62b0fad76421656b0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionHelper.java
 99ab281052b11e1a1168d99f8e1047fb4f822ca2 
  
geode-core/src/main/java/org/apache/geode/internal/cache/ProxyBucketRegion.java 
27f73c7514b3ff6f20041ac6c8ce72d3c1798977 
  
geode-core/src/main/java/org/apache/geode/internal/cache/SearchLoadAndWriteProcessor.java
 2a10792a7a26ead58fcf941fe4190117f552a6c5 
  
geode-core/src/main/java/org/apache/geode/internal/cache/ServerPingMessage.java 
0e468912614292d23cda0fd32e4126a0e0235a59 
  geode-core/src/main/java/org/apache/geode/internal/cache/TXMessage.java 
08ce99ba1b58d2f80815807a97ab943589b64e5f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java
 0de41bf7da6731df146749571bb3e951764a3444 
  
geode-core/src/main/java/org/apache/geode/internal/cache/ha/HARegionQueue.java 
70224f2e4884cf9769ab9dce3b8c4a248aba7ef2 
  
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java
 deb53cbc6efb081ac4da4d4b89be57d4899f46dc 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 3b0c2ff5786a8af13e9501ba481533f84319 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tx/ClientTXStateStub.java
 ad3f103e5823cc8806e62ff0b240b8abbc77076a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java
 

[jira] [Assigned] (GEODE-2791) LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero fails intermittently with AssertionError

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-2791:


Assignee: Kirk Lund

> LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero 
> fails intermittently with AssertionError
> 
>
> Key: GEODE-2791
> URL: https://issues.apache.org/jira/browse/GEODE-2791
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherAssemblyIntegrationTest > 
> testLocatorStopsWhenJmxPortIsNonZero[1] FAILED
> java.lang.AssertionError: expected:<4> but was:<15>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.distributed.LocatorLauncherAssemblyIntegrationTest.performTest(LocatorLauncherAssemblyIntegrationTest.java:148)
> at 
> org.apache.geode.distributed.LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero(LocatorLauncherAssemblyIntegrationTest.java:89)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2791) LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero fails intermittently with AssertionError

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-2791:


 Summary: 
LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero 
fails intermittently with AssertionError
 Key: GEODE-2791
 URL: https://issues.apache.org/jira/browse/GEODE-2791
 Project: Geode
  Issue Type: Bug
  Components: gfsh, tests
Reporter: Kirk Lund


{noformat}
org.apache.geode.distributed.LocatorLauncherAssemblyIntegrationTest > 
testLocatorStopsWhenJmxPortIsNonZero[1] FAILED
java.lang.AssertionError: expected:<4> but was:<15>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at 
org.apache.geode.distributed.LocatorLauncherAssemblyIntegrationTest.performTest(LocatorLauncherAssemblyIntegrationTest.java:148)
at 
org.apache.geode.distributed.LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero(LocatorLauncherAssemblyIntegrationTest.java:89)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2790) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyphen fails intermittently with ComparisonFailure

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-2790:


Assignee: Kirk Lund

> DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyphen 
> fails intermittently with ComparisonFailure
> --
>
> Key: GEODE-2790
> URL: https://issues.apache.org/jira/browse/GEODE-2790
> Project: Geode
>  Issue Type: Bug
>  Components: statistics, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest > 
> aboveZeroDeletesPreviousFiles_nameWithHyphen FAILED
> org.junit.ComparisonFailure: [Unexpected files: 
> [/tmp/junit88809687228487/psin8p724_cache1-statistics-02-01.gfs, 
> /tmp/junit88809687228487/psin8p724_cache1-statistics-02-02.gfs, 
> /tmp/junit88809687228487/psin8p724_cache1-statistics.gfs]] expected:<[2]> 
> but was:<[3]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.validateNumberFiles(DiskSpaceLimitIntegrationTest.java:263)
> at 
> org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyphen(DiskSpaceLimitIntegrationTest.java:251)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2790) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyphen fails intermittently with ComparisonFailure

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-2790:


 Summary: 
DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyphen 
fails intermittently with ComparisonFailure
 Key: GEODE-2790
 URL: https://issues.apache.org/jira/browse/GEODE-2790
 Project: Geode
  Issue Type: Bug
  Components: statistics, tests
Reporter: Kirk Lund


{noformat}
org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest > 
aboveZeroDeletesPreviousFiles_nameWithHyphen FAILED
org.junit.ComparisonFailure: [Unexpected files: 
[/tmp/junit88809687228487/psin8p724_cache1-statistics-02-01.gfs, 
/tmp/junit88809687228487/psin8p724_cache1-statistics-02-02.gfs, 
/tmp/junit88809687228487/psin8p724_cache1-statistics.gfs]] expected:<[2]> 
but was:<[3]>
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at 
org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.validateNumberFiles(DiskSpaceLimitIntegrationTest.java:263)
at 
org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyphen(DiskSpaceLimitIntegrationTest.java:251)
{noformat}




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971636#comment-15971636
 ] 

ASF subversion and git services commented on GEODE-2632:


Commit 1156011729834f9e4bcb3329112d622f04656be7 in geode's branch 
refs/heads/feature/GEODE-2632-1 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1156011 ]

GEODE-2632: refactor code to use InternalCache and InternalResourceManager

* add operations to InternalCache interface
* rename getter for InternalResourceManager getInternalResourceManager
* add @Override annotations
* fixup TODO comments
* delete superfluous comments and dead-code
* filed GEODE-2789 and will follow-up with fix for that ticket


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2789) Rewrite AutoBalancerJUnitTest to allow refactoring of GemFireCacheImpl

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971630#comment-15971630
 ] 

ASF subversion and git services commented on GEODE-2789:


Commit 1156011729834f9e4bcb3329112d622f04656be7 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1156011 ]

GEODE-2632: refactor code to use InternalCache and InternalResourceManager

* add operations to InternalCache interface
* rename getter for InternalResourceManager getInternalResourceManager
* add @Override annotations
* fixup TODO comments
* delete superfluous comments and dead-code
* filed GEODE-2789 and will follow-up with fix for that ticket


> Rewrite AutoBalancerJUnitTest to allow refactoring of GemFireCacheImpl
> --
>
> Key: GEODE-2789
> URL: https://issues.apache.org/jira/browse/GEODE-2789
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Kirk Lund
>
> This test is so brittle that any changes to GemFireCacheImpl results in a 
> bunch of JMock failures:
> {noformat}
> java.lang.IllegalArgumentException
>   at net.sf.cglib.asm.ClassReader.(Unknown Source)
>   at net.sf.cglib.asm.ClassReader.(Unknown Source)
>   at net.sf.cglib.asm.ClassReader.(Unknown Source)
>   at 
> net.sf.cglib.proxy.BridgeMethodResolver.resolveAll(BridgeMethodResolver.java:61)
>   at net.sf.cglib.proxy.Enhancer.emitMethods(Enhancer.java:911)
>   at net.sf.cglib.proxy.Enhancer.generateClass(Enhancer.java:498)
>   at 
> net.sf.cglib.core.DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25)
>   at 
> net.sf.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:216)
>   at net.sf.cglib.proxy.Enhancer.createHelper(Enhancer.java:377)
>   at net.sf.cglib.proxy.Enhancer.createClass(Enhancer.java:317)
>   at 
> org.jmock.lib.legacy.ClassImposteriser.proxyClass(ClassImposteriser.java:121)
>   at 
> org.jmock.lib.legacy.ClassImposteriser.imposterise(ClassImposteriser.java:66)
>   at org.jmock.Mockery.mock(Mockery.java:148)
>   at org.jmock.Mockery.mock(Mockery.java:124)
>   at 
> org.apache.geode.cache.util.AutoBalancerJUnitTest.testFacadeCollectMemberDetails2Regions(AutoBalancerJUnitTest.java:427)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
>   at 
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
>   at 
> com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
>   at 
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:237)
>   at 
> com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> {noformat}
> {noformat}
> java.lang.IllegalArgumentException
>   at net.sf.cglib.asm.ClassReader.(Unknown Source)
>   at net.sf.cglib.asm.ClassReader.(Unknown Source)
>   at net.sf.cglib.asm.ClassReader.(Unknown Source)
>   at 
> net.sf.cglib.proxy.BridgeMethodResolver.resolveAll(BridgeMethodResolver.java:61)
>   at net.sf.cglib.proxy.Enhancer.emitMethods(Enhancer.java:911)
>   at 

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971629#comment-15971629
 ] 

ASF subversion and git services commented on GEODE-2632:


Commit 1156011729834f9e4bcb3329112d622f04656be7 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1156011 ]

GEODE-2632: refactor code to use InternalCache and InternalResourceManager

* add operations to InternalCache interface
* rename getter for InternalResourceManager getInternalResourceManager
* add @Override annotations
* fixup TODO comments
* delete superfluous comments and dead-code
* filed GEODE-2789 and will follow-up with fix for that ticket


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58388: GEODE-2730: refactor rules

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58388/#review172124
---


Ship it!




Ship It!

- Kirk Lund


On April 13, 2017, 10:13 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58388/
> ---
> 
> (Updated April 13, 2017, 10:13 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Finally the reviewboard is behaving now. This is good for review now. I will 
> close the PR.
> 
> * consolidated the two sets of rules.
> * do not allow member start up at test initialization time.
> * validate properties in @Before
> * use provider in the chained rules to get the appropriate ports in @Before
> 
> Jared and I tried to use ServerLauncher/LocatorLauncher to start the 
> respective member in the rules, but precheckin yields many failures. Looks 
> like it has two problems:
> 1) by passing in the workingDir in the launcher alone does not make all the 
> logs go there. I still have to set the user.dir env variable to make some 
> tests pass.
> 2) launcher.stop does not stop the cache/locator/server cleanly. Subsequent 
> tests fail due to insufficient cleanup.
> Due to the above two reasons, I reverted back to use the old way to start 
> server/locator. This looks like a lean and mean way to get what we needed.
> 
> We also investigated the use of Builder in the rules. At least for now, it 
> doesn't buy us much since we need to do validation/startup servers in @Before 
> of the rules. And it yeilds some duplication code and make the usage not that 
> intuitive.
> 
> As for using AvailablePort.Keeper, Jared and I found out it doesn't really 
> keep the ports, so revert that back as well.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityWithSSLTest.java
>  4d142bd6b7aa91b162a4fdf4e546df2d3285290e 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/EmbeddedPulseRule.java
>  e41d0fea9a1a89ec247f3f2750cc944083056a87 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
>  dc24a57dcf3243962c27d349da136f09d49b1250 
> 
> 
> Diff: https://reviews.apache.org/r/58388/diff/4/
> 
> 
> Testing
> ---
> 
> precheckin successful.
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Fixed: apache/geode#2371 (develop - 2c5e519)

[Travis CI]

Build Update for apache/geode
-

Build: #2371
Status: Fixed

Duration: 8 minutes and 20 seconds
Commit: 2c5e519 (develop)
Author: Jared Stewart
Message: GEODE-2290: Add license headers to rest resources

View the changeset: 
https://github.com/apache/geode/compare/3423f6f5a910...2c5e519c80a3

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/222839982

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: Review Request 58460: GEODE-2632: refactoring part 1

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58460/#review172121
---


Ship it!




Ship It!

- Ken Howe


On April 17, 2017, 7:09 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58460/
> ---
> 
> (Updated April 17, 2017, 7:09 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
> Howe, Patrick Rhomberg, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Begin refactoring (baby steps)
> 
> * add operations to InternalCache interface
> * rename getter for InternalResourceManager getInternalResourceManager
> * add @Override annotations
> * fixup TODO comments
> * delete superfluous comments and dead-code
> 
> The end goals of multiple iterations of refactoring: 1) write high-level 
> benchmark for client put to server [done], 2) change internal dependencies 
> from impl class to interface (including GemFireCacheImpl to InternalCache), 
> 3) fix constructors and invert dependencies of internal classes (including 
> AcceptorImpl and client Command classes), 4) write low-level benchmark(s) for 
> client commands, 5) fix any performance issues involving SecurityService.
> 
> I'd like to commit each iteration of refactoring as I go to keep the number 
> of merge conflicts and number of modified files lower.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/partition/PartitionRegionHelper.java
>  6b52e1ce49f133daf61a2f06343940890648ef61 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java
>  4d5bb871908f87243b8d9a3c0652cfb360c86a83 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java
>  926f36dbb547bf8dac54ad8bc28b7add0c70b7f2 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  59aeac472b35b6b234f1974cb8dfe32f62b0a3b3 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> bcb381482a98a4c372613cba7aabd77f150780aa 
>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
> 4b1786fe5ca2f4a9a0ac85e3bdff240662648f6e 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PRHARedundancyProvider.java
>  258a82e04c7b9d2d09af124cd024d231a55a4d02 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
>  614de4daf41cad53a09f9555ad651bae9bff98e8 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/control/RebalanceOperationImpl.java
>  42622d534ae1f52a354bd0e71e3c23bd318425ce 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/control/ResourceAdvisor.java
>  f79a72902def061e6e22c8521b8fd3fb2eb33e0b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/execute/MemberFunctionExecutor.java
>  1952c2aba2f3dcb4107ae1f4da2188d3dab9b85a 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/execute/MultiRegionFunctionExecutor.java
>  16baf46cafb2c6ddb8412f28ef54b771c5048fbe 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/execute/PartitionedRegionFunctionExecutor.java
>  1f655695703c58609c1c76283ab025cacbf06fa6 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapLRUCapacityController.java
>  cc2cd7e031f70bfd2702c2350e78723c3c297bd9 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionRebalanceOp.java
>  51be10fca7e62e46aa2124959472eb6665677ef6 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
>  a0810d9ae2616903228966331dab329bfa699034 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBeanBridge.java
>  d7bf9d009164b5f9a5cad2ecef98d07e02e4c063 
>   
> geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsDUnitTest.java
>  ed32be8f463b9012c6171403322800ba43faa3dc 
>   
> geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java
>  d3b963cdbe3ac45a25ded1916491ba6370772a8f 
>   
> geode-core/src/test/java/org/apache/geode/cache/management/ResourceManagerDUnitTest.java
>  076254770fa11d263b0d7f461d3680ea92fa98d6 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/ResourceManagerWithQueryMonitorDUnitTest.java
>  8e3888f8c43211607737cdaf01556d7a19191e25 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/EvictionTestBase.java
>  8b1e87fe8993808e7a8a052cdb7a23b01d1fcad7 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/OffHeapEvictionDUnitTest.java
>  3770f4b9c5962f593a6438ee8d97044c5db18027 
>   
> 

Re: Review Request 58460: GEODE-2632: refactoring part 1

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58460/
---

(Updated April 17, 2017, 7:09 p.m.)


Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
Howe, Patrick Rhomberg, and Udo Kohlmeyer.


Changes
---

Updating testing details


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

Begin refactoring (baby steps)

* add operations to InternalCache interface
* rename getter for InternalResourceManager getInternalResourceManager
* add @Override annotations
* fixup TODO comments
* delete superfluous comments and dead-code

The end goals of multiple iterations of refactoring: 1) write high-level 
benchmark for client put to server [done], 2) change internal dependencies from 
impl class to interface (including GemFireCacheImpl to InternalCache), 3) fix 
constructors and invert dependencies of internal classes (including 
AcceptorImpl and client Command classes), 4) write low-level benchmark(s) for 
client commands, 5) fix any performance issues involving SecurityService.

I'd like to commit each iteration of refactoring as I go to keep the number of 
merge conflicts and number of modified files lower.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/cache/partition/PartitionRegionHelper.java
 6b52e1ce49f133daf61a2f06343940890648ef61 
  
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java
 4d5bb871908f87243b8d9a3c0652cfb360c86a83 
  
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java 
926f36dbb547bf8dac54ad8bc28b7add0c70b7f2 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
59aeac472b35b6b234f1974cb8dfe32f62b0a3b3 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
bcb381482a98a4c372613cba7aabd77f150780aa 
  geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
4b1786fe5ca2f4a9a0ac85e3bdff240662648f6e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PRHARedundancyProvider.java
 258a82e04c7b9d2d09af124cd024d231a55a4d02 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java 
614de4daf41cad53a09f9555ad651bae9bff98e8 
  
geode-core/src/main/java/org/apache/geode/internal/cache/control/RebalanceOperationImpl.java
 42622d534ae1f52a354bd0e71e3c23bd318425ce 
  
geode-core/src/main/java/org/apache/geode/internal/cache/control/ResourceAdvisor.java
 f79a72902def061e6e22c8521b8fd3fb2eb33e0b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/MemberFunctionExecutor.java
 1952c2aba2f3dcb4107ae1f4da2188d3dab9b85a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/MultiRegionFunctionExecutor.java
 16baf46cafb2c6ddb8412f28ef54b771c5048fbe 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/PartitionedRegionFunctionExecutor.java
 1f655695703c58609c1c76283ab025cacbf06fa6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapLRUCapacityController.java
 cc2cd7e031f70bfd2702c2350e78723c3c297bd9 
  
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionRebalanceOp.java
 51be10fca7e62e46aa2124959472eb6665677ef6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
 a0810d9ae2616903228966331dab329bfa699034 
  
geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBeanBridge.java
 d7bf9d009164b5f9a5cad2ecef98d07e02e4c063 
  
geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsDUnitTest.java
 ed32be8f463b9012c6171403322800ba43faa3dc 
  
geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java
 d3b963cdbe3ac45a25ded1916491ba6370772a8f 
  
geode-core/src/test/java/org/apache/geode/cache/management/ResourceManagerDUnitTest.java
 076254770fa11d263b0d7f461d3680ea92fa98d6 
  
geode-core/src/test/java/org/apache/geode/cache/query/dunit/ResourceManagerWithQueryMonitorDUnitTest.java
 8e3888f8c43211607737cdaf01556d7a19191e25 
  
geode-core/src/test/java/org/apache/geode/internal/cache/EvictionTestBase.java 
8b1e87fe8993808e7a8a052cdb7a23b01d1fcad7 
  
geode-core/src/test/java/org/apache/geode/internal/cache/OffHeapEvictionDUnitTest.java
 3770f4b9c5962f593a6438ee8d97044c5db18027 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionEvictionDUnitTest.java
 cc6616a610ff40592698ae2eeb192f82502f3ea1 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionOffHeapEvictionDUnitTest.java
 a6d86ec6fa1733233bfd6a22b525563d43bf59d7 
  
geode-core/src/test/java/org/apache/geode/internal/cache/control/MemoryMonitorJUnitTest.java
 54145e13778de97c6ab3d217732606b62744d4dc 
  

Re: Review Request 58460: GEODE-2632: refactoring part 1

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58460/
---

(Updated April 17, 2017, 7:08 p.m.)


Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
Howe, Patrick Rhomberg, and Udo Kohlmeyer.


Changes
---

Fixed issues found during review. New Diff uploaded.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

Begin refactoring (baby steps)

* add operations to InternalCache interface
* rename getter for InternalResourceManager getInternalResourceManager
* add @Override annotations
* fixup TODO comments
* delete superfluous comments and dead-code

The end goals of multiple iterations of refactoring: 1) write high-level 
benchmark for client put to server [done], 2) change internal dependencies from 
impl class to interface (including GemFireCacheImpl to InternalCache), 3) fix 
constructors and invert dependencies of internal classes (including 
AcceptorImpl and client Command classes), 4) write low-level benchmark(s) for 
client commands, 5) fix any performance issues involving SecurityService.

I'd like to commit each iteration of refactoring as I go to keep the number of 
merge conflicts and number of modified files lower.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/cache/partition/PartitionRegionHelper.java
 6b52e1ce49f133daf61a2f06343940890648ef61 
  
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java
 4d5bb871908f87243b8d9a3c0652cfb360c86a83 
  
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java 
926f36dbb547bf8dac54ad8bc28b7add0c70b7f2 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
59aeac472b35b6b234f1974cb8dfe32f62b0a3b3 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
bcb381482a98a4c372613cba7aabd77f150780aa 
  geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
4b1786fe5ca2f4a9a0ac85e3bdff240662648f6e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PRHARedundancyProvider.java
 258a82e04c7b9d2d09af124cd024d231a55a4d02 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java 
614de4daf41cad53a09f9555ad651bae9bff98e8 
  
geode-core/src/main/java/org/apache/geode/internal/cache/control/RebalanceOperationImpl.java
 42622d534ae1f52a354bd0e71e3c23bd318425ce 
  
geode-core/src/main/java/org/apache/geode/internal/cache/control/ResourceAdvisor.java
 f79a72902def061e6e22c8521b8fd3fb2eb33e0b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/MemberFunctionExecutor.java
 1952c2aba2f3dcb4107ae1f4da2188d3dab9b85a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/MultiRegionFunctionExecutor.java
 16baf46cafb2c6ddb8412f28ef54b771c5048fbe 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/PartitionedRegionFunctionExecutor.java
 1f655695703c58609c1c76283ab025cacbf06fa6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapLRUCapacityController.java
 cc2cd7e031f70bfd2702c2350e78723c3c297bd9 
  
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionedRegionRebalanceOp.java
 51be10fca7e62e46aa2124959472eb6665677ef6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
 a0810d9ae2616903228966331dab329bfa699034 
  
geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBeanBridge.java
 d7bf9d009164b5f9a5cad2ecef98d07e02e4c063 
  
geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsDUnitTest.java
 ed32be8f463b9012c6171403322800ba43faa3dc 
  
geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java
 d3b963cdbe3ac45a25ded1916491ba6370772a8f 
  
geode-core/src/test/java/org/apache/geode/cache/management/ResourceManagerDUnitTest.java
 076254770fa11d263b0d7f461d3680ea92fa98d6 
  
geode-core/src/test/java/org/apache/geode/cache/query/dunit/ResourceManagerWithQueryMonitorDUnitTest.java
 8e3888f8c43211607737cdaf01556d7a19191e25 
  
geode-core/src/test/java/org/apache/geode/internal/cache/EvictionTestBase.java 
8b1e87fe8993808e7a8a052cdb7a23b01d1fcad7 
  
geode-core/src/test/java/org/apache/geode/internal/cache/OffHeapEvictionDUnitTest.java
 3770f4b9c5962f593a6438ee8d97044c5db18027 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionEvictionDUnitTest.java
 cc6616a610ff40592698ae2eeb192f82502f3ea1 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionOffHeapEvictionDUnitTest.java
 a6d86ec6fa1733233bfd6a22b525563d43bf59d7 
  
geode-core/src/test/java/org/apache/geode/internal/cache/control/MemoryMonitorJUnitTest.java
 54145e13778de97c6ab3d217732606b62744d4dc 
  

[jira] [Commented] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971490#comment-15971490
 ] 

ASF GitHub Bot commented on GEODE-728:
--

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/457
  
+1
Reviewed the doc changes, they correctly reflect the code changes and the 
book builds without error.


> Rename Execution.withArgs to Execution.setArguments
> ---
>
> Key: GEODE-728
> URL: https://issues.apache.org/jira/browse/GEODE-728
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, functions
>Reporter: Dan Smith
>Assignee: Alyssa Kim
>
> FunctionContext has a getArguments method. withArgs should be renamed to 
> match.
> See this discussion on the mailing list.
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201512.mbox/browser



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #457: GEODE-728 : Rename Execution.withArgs to Execution.setArgu...

[davebarnes97]

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/457
  
+1
Reviewed the doc changes, they correctly reflect the code changes and the 
book builds without error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEODE-2764) Index entry not entered into cluster config xml if region name contains a function call like entrySet()

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun resolved GEODE-2764.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Index entry not entered into cluster config xml if region name contains a 
> function call like entrySet()
> ---
>
> Key: GEODE-2764
> URL: https://issues.apache.org/jira/browse/GEODE-2764
> Project: Geode
>  Issue Type: Bug
>Reporter: nabarun
> Fix For: 1.2.0
>
>
> Steps to recreate the issue type the following in a gfsh instance:
> 1. start locator --name=locator
> 2. start server --name=server
> 3. create region --name=regionName --type=REPLICATE_PERSISTENT 
> 4. create index --name=regionIndex --region="regionName.entrySet() r" 
> --expression=r.key
> -- this will result in an error message 
> {noformat}
> Failed to create index "regionIndex" due to following reasons
> null
> {noformat}
> Cause:
> The index is created but while putting the entry into the clusterconfig it 
> tries to put the region name as regionName.entrySet() which does not exist. 
> cache.getRegion(regionName.entrySet()) will result in null and no xml entry 
> is added to the clusterconfig. So when the server is restarted, there is no 
> index entry in the cluster config xml hence the index is not re-created.
> Solution:
> If the region name contains the character '(' and ')' spilt the region name 
> at the index of '.' and check if the region exists. 
> If the check returns successful only then enter the entry into the cluster 
> config.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2789) Rewrite AutoBalancerJUnitTest to allow refactoring of GemFireCacheImpl

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-2789:


 Summary: Rewrite AutoBalancerJUnitTest to allow refactoring of 
GemFireCacheImpl
 Key: GEODE-2789
 URL: https://issues.apache.org/jira/browse/GEODE-2789
 Project: Geode
  Issue Type: Bug
  Components: tests
Reporter: Kirk Lund


This test is so brittle that any changes to GemFireCacheImpl results in a bunch 
of JMock failures:
{noformat}
java.lang.IllegalArgumentException
at net.sf.cglib.asm.ClassReader.(Unknown Source)
at net.sf.cglib.asm.ClassReader.(Unknown Source)
at net.sf.cglib.asm.ClassReader.(Unknown Source)
at 
net.sf.cglib.proxy.BridgeMethodResolver.resolveAll(BridgeMethodResolver.java:61)
at net.sf.cglib.proxy.Enhancer.emitMethods(Enhancer.java:911)
at net.sf.cglib.proxy.Enhancer.generateClass(Enhancer.java:498)
at 
net.sf.cglib.core.DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25)
at 
net.sf.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:216)
at net.sf.cglib.proxy.Enhancer.createHelper(Enhancer.java:377)
at net.sf.cglib.proxy.Enhancer.createClass(Enhancer.java:317)
at 
org.jmock.lib.legacy.ClassImposteriser.proxyClass(ClassImposteriser.java:121)
at 
org.jmock.lib.legacy.ClassImposteriser.imposterise(ClassImposteriser.java:66)
at org.jmock.Mockery.mock(Mockery.java:148)
at org.jmock.Mockery.mock(Mockery.java:124)
at 
org.apache.geode.cache.util.AutoBalancerJUnitTest.testFacadeCollectMemberDetails2Regions(AutoBalancerJUnitTest.java:427)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at 
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at 
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
at 
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:237)
at 
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
{noformat}

{noformat}
java.lang.IllegalArgumentException
at net.sf.cglib.asm.ClassReader.(Unknown Source)
at net.sf.cglib.asm.ClassReader.(Unknown Source)
at net.sf.cglib.asm.ClassReader.(Unknown Source)
at 
net.sf.cglib.proxy.BridgeMethodResolver.resolveAll(BridgeMethodResolver.java:61)
at net.sf.cglib.proxy.Enhancer.emitMethods(Enhancer.java:911)
at net.sf.cglib.proxy.Enhancer.generateClass(Enhancer.java:498)
at 
net.sf.cglib.core.DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25)
at 
net.sf.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:216)
at net.sf.cglib.proxy.Enhancer.createHelper(Enhancer.java:377)
at net.sf.cglib.proxy.Enhancer.createClass(Enhancer.java:317)
at 
org.jmock.lib.legacy.ClassImposteriser.proxyClass(ClassImposteriser.java:121)
at 
org.jmock.lib.legacy.ClassImposteriser.imposterise(ClassImposteriser.java:66)
at org.jmock.Mockery.mock(Mockery.java:148)
at org.jmock.Mockery.mock(Mockery.java:124)
at 
org.apache.geode.cache.util.AutoBalancerJUnitTest.getFacadeForResourceManagerOps(AutoBalancerJUnitTest.java:366)
at 

[jira] [Resolved] (GEODE-2773) AssertionError shown in GIIDeltaDUnitTest.testFullGIITriggeredByHigherRVVGC

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone resolved GEODE-2773.
---
Resolution: Fixed

> AssertionError shown in GIIDeltaDUnitTest.testFullGIITriggeredByHigherRVVGC
> ---
>
> Key: GEODE-2773
> URL: https://issues.apache.org/jira/browse/GEODE-2773
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Eric Shu
>Assignee: Eric Shu
> Fix For: 1.2.0
>
>
> Though the test is passing, the following Assertion was thrown in one of the 
> VM.invokeAysc call.
> {noformat}
> [vm0] [info 2017/04/11 16:42:03.214 PDT  
> tid=72] Got result: EXCEPTION_OCCURRED
> [vm0] java.lang.AssertionError: expected:<5> but was:<6>
> [vm0] at org.junit.Assert.fail(Assert.java:88)
> [vm0] at org.junit.Assert.failNotEquals(Assert.java:834)
> [vm0] at org.junit.Assert.assertEquals(Assert.java:645)
> [vm0] at org.junit.Assert.assertEquals(Assert.java:631)
> [vm0] at 
> org.apache.geode.internal.cache.GIIDeltaDUnitTest$55.run(GIIDeltaDUnitTest.java:2587)
> [vm0] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [vm0] at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [vm0] at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [vm0] at java.lang.reflect.Method.invoke(Method.java:498)
> [vm0] at hydra.MethExecutor.executeObject(MethExecutor.java:245)
> [vm0] at 
> org.apache.geode.test.dunit.standalone.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:73)
> [vm0] at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
> [vm0] at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [vm0] at java.lang.reflect.Method.invoke(Method.java:498)
> [vm0] at 
> sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:324)
> [vm0] at sun.rmi.transport.Transport$1.run(Transport.java:200)
> [vm0] at sun.rmi.transport.Transport$1.run(Transport.java:197)
> [vm0] at java.security.AccessController.doPrivileged(Native Method)
> [vm0] at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> [vm0] at 
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
> [vm0] at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
> [vm0] at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683)
> [vm0] at java.security.AccessController.doPrivileged(Native Method)
> [vm0] at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
> [vm0] at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [vm0] at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [vm0] at java.lang.Thread.run(Thread.java:745)
> [vm0]  from org.apache.geode.internal.cache.GIIDeltaDUnitTest$55.run with 0 
> args on object: "destroy key5" (took 682 ms)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2784) Geode client docs: Cmake reqires the --config option when a generator is specified

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2784:
---
Fix Version/s: 1.2.0

> Geode client docs: Cmake reqires the --config option when a generator is 
> specified
> --
>
> Key: GEODE-2784
> URL: https://issues.apache.org/jira/browse/GEODE-2784
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
> Fix For: 1.2.0
>
>
> When generating for IDEs such as VisualStudio or Xcode, CMAKE_BUILD_TYPE is a 
> no-op on config step 
> and on the build step one MUST specify --config [Debug|Release]. For example: 
> cmake -G"Visual Studio 12 2013 Win64" c:\install\templates\security 
> -DGFCPP=c:\install
> cmake --build . --config Release
> cmake --build . --config Release --target install



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2784) Geode client docs: Cmake reqires the --config option when a generator is specified

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-2784.

Resolution: Fixed

> Geode client docs: Cmake reqires the --config option when a generator is 
> specified
> --
>
> Key: GEODE-2784
> URL: https://issues.apache.org/jira/browse/GEODE-2784
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> When generating for IDEs such as VisualStudio or Xcode, CMAKE_BUILD_TYPE is a 
> no-op on config step 
> and on the build step one MUST specify --config [Debug|Release]. For example: 
> cmake -G"Visual Studio 12 2013 Win64" c:\install\templates\security 
> -DGFCPP=c:\install
> cmake --build . --config Release
> cmake --build . --config Release --target install



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2788) Add official Socket timeout parameter when connecting to servers/locators

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller updated GEODE-2788:
---
Component/s: docs

> Add official Socket timeout parameter when connecting to servers/locators
> -
>
> Key: GEODE-2788
> URL: https://issues.apache.org/jira/browse/GEODE-2788
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, docs
>Reporter: Masaki Yamakawa
>Priority: Minor
>  Labels: patch
>
> When connecting from the client to the servers/locators, if the 
> servers/locators is not started, the connection can not be established and a 
> Socket timeout occurs.
> This timeout value is 59 seconds by default. This timeout value is too long. 
> This timeout value can be changed by specifying the unofficial parameter 
> "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I 
> corresponded so that it can be specified by official parameters.
> Like the NativeClient, the official parameters should be specified by 
> "connect-timeout" in gemfire.properties.
> Timeout values ​​are determined in the following order of priority.
> 1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
> 2. java system property:gemfire.connect-timeout
> 3. gemfire.properties:connect-timeout
> 4. default:59000 milli seconds
> As another idea, there is also an idea to make it possible to specify it as 
> an attribute of Pool. In that case NativeClient needs the same modification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2768) Lucene Queries executed before index is fully created should be retried

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971396#comment-15971396
 ] 

ASF GitHub Bot commented on GEODE-2768:
---

Github user jhuynh1 closed the pull request at:

https://github.com/apache/geode/pull/451


> Lucene Queries executed before index is fully created should be retried
> ---
>
> Key: GEODE-2768
> URL: https://issues.apache.org/jira/browse/GEODE-2768
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> With the feature to destroy a Lucene Index, parts of the querying function 
> were changed to handle the event where we execute a query on an index that is 
> no longer present.  However, the scenario where we execute a query on an 
> index that is defined but has not been created can also arise. 
> We want to handle the case where we have defined the index, but have yet to 
> create it due to a brief window in restart.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #451: GEODE-2768: Lucene Queries executed before index is...

[jhuynh1]

Github user jhuynh1 closed the pull request at:

https://github.com/apache/geode/pull/451


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEODE-2768) Lucene Queries executed before index is fully created should be retried

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh resolved GEODE-2768.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Lucene Queries executed before index is fully created should be retried
> ---
>
> Key: GEODE-2768
> URL: https://issues.apache.org/jira/browse/GEODE-2768
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> With the feature to destroy a Lucene Index, parts of the querying function 
> were changed to handle the event where we execute a query on an index that is 
> no longer present.  However, the scenario where we execute a query on an 
> index that is defined but has not been created can also arise. 
> We want to handle the case where we have defined the index, but have yet to 
> create it due to a brief window in restart.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2737) PulseAuthTest failures

[Kenneth Howe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe resolved GEODE-2737.
-
Resolution: Fixed

The fix that was checked in does fix the test failures in PulseAuthTest and 
PulseNoAuthTest.

> PulseAuthTest failures
> --
>
> Key: GEODE-2737
> URL: https://issues.apache.org/jira/browse/GEODE-2737
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Affects Versions: 1.1.0
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
> Fix For: 1.2.0
>
>
> Tests are failing in the PulseAuthTest (UITest category) with the error:
> {code}
> org.apache.geode.tools.pulse.tests.ui.PulseAuthTest > testTopologyPopUpData 
> FAILED
> org.openqa.selenium.TimeoutException: Expected condition failed: waiting 
> for org.apache.geode.tools.pulse.tests.rules.WebDriverRule$1@4d7af88e (tried 
> for 30 second(s) with 500 MILLISECONDS interval)
> Build info: version: '3.0.1', revision: '1969d75', time: '2016-10-18 
> 09:49:13 -0700'
> System info: host: 'Kens-MacBook-Pro-2.local', ip: '127.0.0.1', os.name: 
> 'Mac OS X', os.arch: 'x86_64', os.version: '10.12.3', java.version: 
> '1.8.0_111'
> Driver info: org.openqa.selenium.phantomjs.PhantomJSDriver
> Capabilities [{applicationCacheEnabled=false, rotatable=false, 
> handlesAlerts=false, databaseEnabled=false, version=2.1.1, platform=MAC, 
> browserConnectionEnabled=false, proxy={proxyType=direct}, nativeEvents=true, 
> acceptSslCerts=false, driverVersion=1.2.0, 
> phantomjs.page.settings.userAgent=Mozilla/5.0 (Windows NT 6.1; Win64; x64; 
> rv:16.0) Gecko/20121026 Firefox/16.0, locationContextEnabled=false, 
> webStorageEnabled=false, browserName=phantomjs, takesScreenshot=true, 
> driverName=ghostdriver, javascriptEnabled=true, cssSelectorsEnabled=true}]
> Session ID: abd2bc60-1593-11e7-922e-d790ba7a8581
> Caused by:
> org.openqa.selenium.NoSuchElementException: {"errorMessage":"Unable 
> to find element with id 
> 'userName'","request":{"headers":{"Accept-Encoding":"gzip,deflate","Connection":"Keep-Alive","Content-Length":"33","Content-Type":"application/json;
>  
> charset=utf-8","Host":"localhost:43794","User-Agent":"Apache-HttpClient/4.5.2 
> (Java/1.8.0_111)"},"httpVersion":"1.1","method":"POST","post":"{\"using\":\"id\",\"value\":\"userName\"}","url":"/element","urlParsed":{"anchor":"","query":"","file":"element","directory":"/","path":"/element","relative":"/element","port":"","host":"","password":"","user":"","userInfo":"","authority":"","protocol":"","source":"/element","queryKey":{},"chunks":["element"]},"urlOriginal":"/session/abd2bc60-1593-11e7-922e-d790ba7a8581/element"}}
> Command duration or timeout: 10.13 seconds
> For documentation on this error, please visit: 
> http://seleniumhq.org/exceptions/no_such_element.html
> Build info: version: '3.0.1', revision: '1969d75', time: '2016-10-18 
> 09:49:13 -0700'
> System info: host: 'Kens-MacBook-Pro-2.local', ip: '127.0.0.1', 
> os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.12.3', java.version: 
> '1.8.0_111'
> Driver info: org.openqa.selenium.phantomjs.PhantomJSDriver
> Capabilities [{applicationCacheEnabled=false, rotatable=false, 
> handlesAlerts=false, databaseEnabled=false, version=2.1.1, platform=MAC, 
> browserConnectionEnabled=false, proxy={proxyType=direct}, nativeEvents=true, 
> acceptSslCerts=false, driverVersion=1.2.0, 
> phantomjs.page.settings.userAgent=Mozilla/5.0 (Windows NT 6.1; Win64; x64; 
> rv:16.0) Gecko/20121026 Firefox/16.0, locationContextEnabled=false, 
> webStorageEnabled=false, browserName=phantomjs, takesScreenshot=true, 
> driverName=ghostdriver, javascriptEnabled=true, cssSelectorsEnabled=true}]
> Session ID: abd2bc60-1593-11e7-922e-d790ba7a8581
> *** Element info: {Using=id, value=userName}
> Caused by:
> org.openqa.selenium.remote.ScreenshotException: Screen shot has 
> been taken
> Build info: version: '3.0.1', revision: '1969d75', time: 
> '2016-10-18 09:49:13 -0700'
> System info: host: 'Kens-MacBook-Pro-2.local', ip: '127.0.0.1', 
> os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.12.3', java.version: 
> '1.8.0_111'
> Driver info: driver.version: RemoteWebDriver
> Caused by:
> org.openqa.selenium.NoSuchElementException: 
> {"errorMessage":"Unable to find element with id 
> 'userName'","request":{"headers":{"Accept-Encoding":"gzip,deflate","Connection":"Keep-Alive","Content-Length":"33","Content-Type":"application/json;
>  
> charset=utf-8","Host":"localhost:43794","User-Agent":"Apache-HttpClient/4.5.2 
> 

Re: Conditional bug in LocalRegion.concurrencyConfigurationCheck

[Bruce Schuchardt]

+1
I think that code makes the method easier to understand but I don't 
think the current message would be incorrect.  The log message is only 
issued if the server's setting doesn't match the client's setting, so 
!clientCCEnabled is going to equal the serverCCEnabled that you've 
introduced.


Le 4/17/2017 à 9:58 AM, Darrel Schneider a écrit :

The first part of the condition "!this.concurrencyMessageIssued" is just
simply to make sure we only log this message once.
The second part "(tag != null) != this.concurrencyChecksEnabled" could be
changed to this:
   boolean serverCCEnabled = this.concurrencyChecksEnabled;
   boolean clientCCEnabled = tag != null;
   if (clientCCEnabled != serverCCEnabled)
 log message

The only bug I see in this method is in the actual log message.
Arg 0 describes how the server has CC configured and arg 1 describes how
the client has CC configured.
But by passing "!this.concurrencyChecksEnabled" as arg 0 the message will
actually tell you how the server is NOT configured.
And by passing "this.concurrencyChecksEnabled" as arg 1 the message will
actually tell you how the client is NOT configured.

If the code was changed to use these two booleans then they could also be
passed as the args to the log message and I think this method would be
easier to understand.

The new code would be this:


   private void concurrencyConfigurationCheck(VersionTag tag) {
 if (this.concurrencyMessageIssued) {
   return;
 }
 boolean serverConcurrencyChecksEnabled = this.concurrencyChecksEnabled;
 boolean clientConcurrencyChecksEnabled = tag != null;
 if (clientConcurrencyChecksEnabled != serverConcurrencyChecksEnabled) {
   this.concurrencyMessageIssued = true;
   logger.info(LocalizedMessage.create(

LocalizedStrings.LocalRegion_SERVER_HAS_CONCURRENCY_CHECKS_ENABLED_0_BUT_CLIENT_HAS_1_FOR_REGION_2,
   new Object[] {serverConcurrencyChecksEnabled,
clientConcurrencyChecksEnabled, this}));
 }
   }

What do you think?


On Fri, Apr 14, 2017 at 6:50 PM, Kirk Lund  wrote:


I can't quite make out what the conditional is actually supposed to be
checking in the second half but it definitely looks wrong to me. Anyone
familiar with this method or what it's supposed to be doing?

private void concurrencyConfigurationCheck(VersionTag tag) {
   // TODO: double negative in next line must be a bug
   if (!this.concurrencyMessageIssued && *((tag != null) !=
this.concurrencyChecksEnabled)*) {
 this.concurrencyMessageIssued = true;
 logger.info(LocalizedMessage.create(

LocalizedStrings.LocalRegion_SERVER_HAS_CONCURRENCY_CHECKS_
ENABLED_0_BUT_CLIENT_HAS_1_FOR_REGION_2,
 new Object[] {!this.concurrencyChecksEnabled,
this.concurrencyChecksEnabled, this}));
   }
}

[jira] [Commented] (GEODE-2290) Provide way to limit scanning of deployed jars

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971341#comment-15971341
 ] 

ASF subversion and git services commented on GEODE-2290:


Commit 510049845cddff4ab63c9482dff7519f26300b39 in geode's branch 
refs/heads/develop from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5100498 ]

GEODE-2290: Fix DeployCommandRedeployDUnitTest


> Provide way to limit scanning of deployed jars
> --
>
> Key: GEODE-2290
> URL: https://issues.apache.org/jira/browse/GEODE-2290
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh, management
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>  Labels: ClassLoader, DeployCommand, deploy, gfsh
> Fix For: 1.2.0
>
>
> Currently if you use the GFSH command "deploy jar" the deployed jar will be 
> scanned in such a way that the deployer will load and resolve every .class 
> file in the jar file. The original intention of "deploy jar" was that only 
> Functions would be deployed. Any .class that is found to be a Function is 
> automatically registered with the FunctionService. 
> You can also include implementations of other Apache Geode callbacks such as 
> CacheListener. If you then follow up the deploy with "alter region" you can 
> alter the region to add the CacheListener or other callback.
> Some users have reported trying to deploy a jar with much more than just 
> Functions or CacheListeners or domain classes used for Region Entries. If the 
> jar includes a class that the callbacks or domain classes don't directly use 
> but that class requires a missing transitive dependency, then the deployer 
> will generate a NoClassDefFoundError when it tries to load and resolve that 
> class.
> Along with the potential NoClassDefFoundError, forcing every .class to be 
> loaded and resolved can consume a lot of PermGen memory.
> Various ideas have been tossed around to allow someone to deploy such a jar 
> without having the deployer generate NoClassDefFoundError. This requires 
> something like one of the following approaches:
> 1) add a new --do-not-deploy option flag
> 2) comma-delimited list of classes to load and deploy
> 3) regex list of classes to load and deploy
> 4) have I missed something?
> This would give the User better control over which classes to actually load 
> and resolve.
> [NOTE: I'll update this ticket based on feedback and discussion on 
> dev@geode.apache.org]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Conditional bug in LocalRegion.concurrencyConfigurationCheck

[Darrel Schneider]

The first part of the condition "!this.concurrencyMessageIssued" is just
simply to make sure we only log this message once.
The second part "(tag != null) != this.concurrencyChecksEnabled" could be
changed to this:
  boolean serverCCEnabled = this.concurrencyChecksEnabled;
  boolean clientCCEnabled = tag != null;
  if (clientCCEnabled != serverCCEnabled)
log message

The only bug I see in this method is in the actual log message.
Arg 0 describes how the server has CC configured and arg 1 describes how
the client has CC configured.
But by passing "!this.concurrencyChecksEnabled" as arg 0 the message will
actually tell you how the server is NOT configured.
And by passing "this.concurrencyChecksEnabled" as arg 1 the message will
actually tell you how the client is NOT configured.

If the code was changed to use these two booleans then they could also be
passed as the args to the log message and I think this method would be
easier to understand.

The new code would be this:

>   private void concurrencyConfigurationCheck(VersionTag tag) {
> if (this.concurrencyMessageIssued) {
>   return;
> }
> boolean serverConcurrencyChecksEnabled = this.concurrencyChecksEnabled;
> boolean clientConcurrencyChecksEnabled = tag != null;
> if (clientConcurrencyChecksEnabled != serverConcurrencyChecksEnabled) {
>   this.concurrencyMessageIssued = true;
>   logger.info(LocalizedMessage.create(
>
> LocalizedStrings.LocalRegion_SERVER_HAS_CONCURRENCY_CHECKS_ENABLED_0_BUT_CLIENT_HAS_1_FOR_REGION_2,
>   new Object[] {serverConcurrencyChecksEnabled,
> clientConcurrencyChecksEnabled, this}));
> }
>   }

What do you think?


On Fri, Apr 14, 2017 at 6:50 PM, Kirk Lund  wrote:

> I can't quite make out what the conditional is actually supposed to be
> checking in the second half but it definitely looks wrong to me. Anyone
> familiar with this method or what it's supposed to be doing?
>
> private void concurrencyConfigurationCheck(VersionTag tag) {
>   // TODO: double negative in next line must be a bug
>   if (!this.concurrencyMessageIssued && *((tag != null) !=
> this.concurrencyChecksEnabled)*) {
> this.concurrencyMessageIssued = true;
> logger.info(LocalizedMessage.create(
>
> LocalizedStrings.LocalRegion_SERVER_HAS_CONCURRENCY_CHECKS_
> ENABLED_0_BUT_CLIENT_HAS_1_FOR_REGION_2,
> new Object[] {!this.concurrencyChecksEnabled,
> this.concurrencyChecksEnabled, this}));
>   }
> }
>

Build failed in Jenkins: Geode-nightly #810

[Apache Jenkins Server]

See 


Changes:

[jstewart] GEODE-2686: Remove JarClassLoader

[jstewart] GEODE-2705: Jars undeployed from cluster configuration will not be

[jstewart] GEODE-2686: Add more logging to JarDeployer

[jstewart] GEODE-2290: Limit scanning of deployed jars

--
[...truncated 110.98 KB...]
at 
org.apache.geode.internal.DeployedJar.loadClassesAndRegisterFunctions(DeployedJar.java:175)
at 
org.apache.geode.internal.JarDeployer.registerNewVersions(JarDeployer.java:477)
at org.apache.geode.internal.JarDeployer.deploy(JarDeployer.java:516)
at 
org.apache.geode.management.internal.cli.functions.DeployFunction.execute(DeployFunction.java:68)
at 
org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:191)
at 
org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
at 
org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:442)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at 
org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:621)
at 
org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1067)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.RuntimeException: java.nio.file.NoSuchFileException: 
/tmp/junit82542385908112464/server-1
at 
io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:217)
at 
io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:61)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
... 1 more
Caused by: java.nio.file.NoSuchFileException: 
/tmp/junit82542385908112464/server-1
at 
sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
at sun.nio.fs.UnixPath.toRealPath(UnixPath.java:876)
at 
io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:215)
... 5 more

org.apache.geode.management.internal.cli.commands.DeployCommandRedeployDUnitTest
 > redeployJarsWithNewVersionsOfFunctions FAILED
java.io.IOException: Compilation error: Line 7 - class FUNCTION_A is 
public, should be declared in a file named FUNCTION_A.java
Compilation error: Line -1 - 
/jddunit/function/DeployCommandRedeployDUnitFunctionB.java uses unchecked or 
unsafe operations.
Compilation error: Line -1 - Recompile with -Xlint:unchecked for details.
at 
org.apache.geode.internal.ClassBuilder.compileClass(ClassBuilder.java:210)
at 
org.apache.geode.internal.ClassBuilder.writeJarFromContent(ClassBuilder.java:157)
at 
org.apache.geode.internal.ClassBuilder.writeJarFromContent(ClassBuilder.java:74)
at 
org.apache.geode.management.internal.cli.commands.DeployCommandRedeployDUnitTest.createJarWithFunctionB(DeployCommandRedeployDUnitTest.java:136)
at 
org.apache.geode.management.internal.cli.commands.DeployCommandRedeployDUnitTest.setup(DeployCommandRedeployDUnitTest.java:71)

6852 tests completed, 3 failed, 603 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck

[jira] [Reopened] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[Joey McAllister (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joey McAllister reopened GEODE-2103:

  Assignee: Joey McAllister  (was: Deepak Dixit)

Needs documentation updates for gfsh Commands > Start Server and Start Locator 
sections.

> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Joey McAllister
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2788) Add official Socket timeout parameter when connecting to servers/locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971294#comment-15971294
 ] 

ASF GitHub Bot commented on GEODE-2788:
---

GitHub user masaki-yamakawa opened a pull request:

https://github.com/apache/geode/pull/459

GEODE-2788: Add official Socket timeout parameter when connecting to 
servers/locators

When connecting from the client to the servers/locators, if the 
servers/locators is not started, the connection can not be established and a 
Socket timeout occurs.
This timeout value is 59 seconds by default. This timeout value is too 
long. This timeout value can be changed by specifying the unofficial parameter 
"gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I 
corresponded so that it can be specified by official parameters.
Like the NativeClient, the official parameters should be specified by 
"connect-timeout" in gemfire.properties.

Timeout values are determined in the following order of priority.

1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
2. java system property:gemfire.connect-timeout
3. gemfire.properties:connect-timeout
4. default:59000 milli seconds

As another idea, there is also an idea to make it possible to specify it as 
an attribute of Pool. In that case NativeClient needs the same modification.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaki-yamakawa/geode feature/GEODE-2788

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #459


commit d35aa6b0e96572be9aa129bb825d6f9d9b6c9256
Author: masaki.yamakawa 
Date:   2017-04-17T15:05:48Z

GEODE-2788: Add official Socket timeout parameter when connecting to
servers/locators

When connecting from the client to the servers/locators, if the
servers/locators is not started, the connection can not be established
and a Socket timeout occurs.
This timeout value is 59 seconds by default. This timeout value is too
long. This timeout value can be changed by specifying the unofficial
parameter "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property,
but I corresponded so that it can be specified by official parameters.
Like the NativeClient, the official parameters should be specified by
"connect-timeout" in gemfire.properties.

Timeout values are determined in the following order of priority.

1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
2. java system property:gemfire.connect-timeout
3. gemfire.properties:connect-timeout
4. default:59000 milli seconds

commit f0e5f45a72d0f6f8c8be816ffd3516a3bfdc10ab
Author: masaki.yamakawa 
Date:   2017-04-17T15:36:29Z

GEODE-2788: Add official Socket timeout parameter when connecting to
servers/locators

When connecting from the client to the servers/locators, if the
servers/locators is not started, the connection can not be established
and a Socket timeout occurs.
This timeout value is 59 seconds by default. This timeout value is too
long. This timeout value can be changed by specifying the unofficial
parameter "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property,
but I corresponded so that it can be specified by official parameters.
Like the NativeClient, the official parameters should be specified by
"connect-timeout" in gemfire.properties.

Timeout values are determined in the following order of priority.

1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
2. java system property:gemfire.connect-timeout
3. gemfire.properties:connect-timeout
4. default:59000 milli seconds




> Add official Socket timeout parameter when connecting to servers/locators
> -
>
> Key: GEODE-2788
> URL: https://issues.apache.org/jira/browse/GEODE-2788
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Masaki Yamakawa
>Priority: Minor
>  Labels: patch
>
> When connecting from the client to the servers/locators, if the 
> servers/locators is not started, the connection can not be established and a 
> Socket timeout occurs.
> This timeout value is 59 seconds by default. This timeout value is too long. 
> This timeout value can be changed by specifying the unofficial parameter 
> "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I 
> corresponded so that it can be specified by official parameters.
> Like 

[GitHub] geode pull request #459: GEODE-2788: Add official Socket timeout parameter w...

[masaki-yamakawa]

GitHub user masaki-yamakawa opened a pull request:

https://github.com/apache/geode/pull/459

GEODE-2788: Add official Socket timeout parameter when connecting to 
servers/locators

When connecting from the client to the servers/locators, if the 
servers/locators is not started, the connection can not be established and a 
Socket timeout occurs.
This timeout value is 59 seconds by default. This timeout value is too 
long. This timeout value can be changed by specifying the unofficial parameter 
"gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I 
corresponded so that it can be specified by official parameters.
Like the NativeClient, the official parameters should be specified by 
"connect-timeout" in gemfire.properties.

Timeout values are determined in the following order of priority.

1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
2. java system property:gemfire.connect-timeout
3. gemfire.properties:connect-timeout
4. default:59000 milli seconds

As another idea, there is also an idea to make it possible to specify it as 
an attribute of Pool. In that case NativeClient needs the same modification.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaki-yamakawa/geode feature/GEODE-2788

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #459


commit d35aa6b0e96572be9aa129bb825d6f9d9b6c9256
Author: masaki.yamakawa 
Date:   2017-04-17T15:05:48Z

GEODE-2788: Add official Socket timeout parameter when connecting to
servers/locators

When connecting from the client to the servers/locators, if the
servers/locators is not started, the connection can not be established
and a Socket timeout occurs.
This timeout value is 59 seconds by default. This timeout value is too
long. This timeout value can be changed by specifying the unofficial
parameter "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property,
but I corresponded so that it can be specified by official parameters.
Like the NativeClient, the official parameters should be specified by
"connect-timeout" in gemfire.properties.

Timeout values are determined in the following order of priority.

1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
2. java system property:gemfire.connect-timeout
3. gemfire.properties:connect-timeout
4. default:59000 milli seconds

commit f0e5f45a72d0f6f8c8be816ffd3516a3bfdc10ab
Author: masaki.yamakawa 
Date:   2017-04-17T15:36:29Z

GEODE-2788: Add official Socket timeout parameter when connecting to
servers/locators

When connecting from the client to the servers/locators, if the
servers/locators is not started, the connection can not be established
and a Socket timeout occurs.
This timeout value is 59 seconds by default. This timeout value is too
long. This timeout value can be changed by specifying the unofficial
parameter "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property,
but I corresponded so that it can be specified by official parameters.
Like the NativeClient, the official parameters should be specified by
"connect-timeout" in gemfire.properties.

Timeout values are determined in the following order of priority.

1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
2. java system property:gemfire.connect-timeout
3. gemfire.properties:connect-timeout
4. default:59000 milli seconds




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2290) Provide way to limit scanning of deployed jars

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971290#comment-15971290
 ] 

ASF subversion and git services commented on GEODE-2290:


Commit 2c5e519c80a3beb79425af523d9014ee37c70cdc in geode's branch 
refs/heads/develop from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=2c5e519 ]

GEODE-2290: Add license headers to rest resources


> Provide way to limit scanning of deployed jars
> --
>
> Key: GEODE-2290
> URL: https://issues.apache.org/jira/browse/GEODE-2290
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh, management
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>  Labels: ClassLoader, DeployCommand, deploy, gfsh
> Fix For: 1.2.0
>
>
> Currently if you use the GFSH command "deploy jar" the deployed jar will be 
> scanned in such a way that the deployer will load and resolve every .class 
> file in the jar file. The original intention of "deploy jar" was that only 
> Functions would be deployed. Any .class that is found to be a Function is 
> automatically registered with the FunctionService. 
> You can also include implementations of other Apache Geode callbacks such as 
> CacheListener. If you then follow up the deploy with "alter region" you can 
> alter the region to add the CacheListener or other callback.
> Some users have reported trying to deploy a jar with much more than just 
> Functions or CacheListeners or domain classes used for Region Entries. If the 
> jar includes a class that the callbacks or domain classes don't directly use 
> but that class requires a missing transitive dependency, then the deployer 
> will generate a NoClassDefFoundError when it tries to load and resolve that 
> class.
> Along with the potential NoClassDefFoundError, forcing every .class to be 
> loaded and resolved can consume a lot of PermGen memory.
> Various ideas have been tossed around to allow someone to deploy such a jar 
> without having the deployer generate NoClassDefFoundError. This requires 
> something like one of the following approaches:
> 1) add a new --do-not-deploy option flag
> 2) comma-delimited list of classes to load and deploy
> 3) regex list of classes to load and deploy
> 4) have I missed something?
> This would give the User better control over which classes to actually load 
> and resolve.
> [NOTE: I'll update this ticket based on feedback and discussion on 
> dev@geode.apache.org]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Geode build is broken

[Jared Stewart]

My mistake, I will fix this.

- Jared
> On Apr 17, 2017, at 8:49 AM, Bruce Schuchardt  wrote:
> 
> The "rat" task is failing
> Unapproved licenses:
> 
>   
> C:/devel/gfdev/open/geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest_FunctionATemplate
>   
> C:/devel/gfdev/open/geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest_FunctionBTemplate
> These were added late last week in this commit:
> commit 6f7f943998153de1f00b1446eb80fa6d304ac40f
> Author: Jared Stewart  
> Date:   Wed Apr 12 10:53:13 2017 -0700
> 
> GEODE-2290: Limit scanning of deployed jars
> 
>  - Uses fast-classpath-scanner to scan jars for classes containing 
> Functions without eagerly loading all classes in the jar.
> 

[GitHub] geode pull request #458: GEODE-2788: Add official Socket timeout parameter w...

[masaki-yamakawa]

Github user masaki-yamakawa closed the pull request at:

https://github.com/apache/geode/pull/458


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2788) Add official Socket timeout parameter when connecting to servers/locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971275#comment-15971275
 ] 

ASF GitHub Bot commented on GEODE-2788:
---

Github user masaki-yamakawa closed the pull request at:

https://github.com/apache/geode/pull/458


> Add official Socket timeout parameter when connecting to servers/locators
> -
>
> Key: GEODE-2788
> URL: https://issues.apache.org/jira/browse/GEODE-2788
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Masaki Yamakawa
>Priority: Minor
>  Labels: patch
>
> When connecting from the client to the servers/locators, if the 
> servers/locators is not started, the connection can not be established and a 
> Socket timeout occurs.
> This timeout value is 59 seconds by default. This timeout value is too long. 
> This timeout value can be changed by specifying the unofficial parameter 
> "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I 
> corresponded so that it can be specified by official parameters.
> Like the NativeClient, the official parameters should be specified by 
> "connect-timeout" in gemfire.properties.
> Timeout values ​​are determined in the following order of priority.
> 1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
> 2. java system property:gemfire.connect-timeout
> 3. gemfire.properties:connect-timeout
> 4. default:59000 milli seconds
> As another idea, there is also an idea to make it possible to specify it as 
> an attribute of Pool. In that case NativeClient needs the same modification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Geode build is broken

[Bruce Schuchardt]

The "rat" task is failing

   Unapproved licenses:

   
C:/devel/gfdev/open/geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest_FunctionATemplate
   
C:/devel/gfdev/open/geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest_FunctionBTemplate

These were added late last week in this commit:

   commit 6f7f943998153de1f00b1446eb80fa6d304ac40f
   Author: Jared Stewart 
   Date:   Wed Apr 12 10:53:13 2017 -0700

GEODE-2290: Limit scanning of deployed jars

 - Uses fast-classpath-scanner to scan jars for classes
   containing Functions without eagerly loading all classes in the jar.

[jira] [Commented] (GEODE-2775) Pulse is not using certificate to connect to JMX when ssl is turned for jmx connection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971131#comment-15971131
 ] 

ASF GitHub Bot commented on GEODE-2775:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/454


> Pulse is not using certificate to connect to JMX when ssl is turned for jmx 
> connection
> --
>
> Key: GEODE-2775
> URL: https://issues.apache.org/jira/browse/GEODE-2775
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Affects Versions: 1.1.1
>Reporter: Jinmei Liao
>
> Steps to reproduce:
> 1) start a locator with a SecurityManager and with this property: 
> ssl-enabled-components=jmx
> 2) start a browser and tries to login to pulse.
> Actual result: not able to log in using valid username/password



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2775) Pulse is not using certificate to connect to JMX when ssl is turned for jmx connection

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971130#comment-15971130
 ] 

ASF subversion and git services commented on GEODE-2775:


Commit 3423f6f5a9102859fdae8a95c7715dfd64dacc75 in geode's branch 
refs/heads/develop from [~prhomberg]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3423f6f ]

GEODE-2775: Corrected setting of Pulse SSL Manager flag from System properties 
instead of pulse.properties when running in embedded mode.

* this closes #454


> Pulse is not using certificate to connect to JMX when ssl is turned for jmx 
> connection
> --
>
> Key: GEODE-2775
> URL: https://issues.apache.org/jira/browse/GEODE-2775
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Affects Versions: 1.1.1
>Reporter: Jinmei Liao
>
> Steps to reproduce:
> 1) start a locator with a SecurityManager and with this property: 
> ssl-enabled-components=jmx
> 2) start a browser and tries to login to pulse.
> Actual result: not able to log in using valid username/password



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #454: GEODE-2775: Corrected setting of Pulse SSL Manager ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/454


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2770) When using the REST API it is possible for the API to be accepting requests after the system has shutdown

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971127#comment-15971127
 ] 

ASF GitHub Bot commented on GEODE-2770:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/455


> When using the REST API it is possible for the API to be accepting requests 
> after the system has shutdown
> -
>
> Key: GEODE-2770
> URL: https://issues.apache.org/jira/browse/GEODE-2770
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (dev)
>Reporter: Charlie Black
>
> When using the REST API it is possible for the API to be accepting requests 
> after the system has shutdown.   The shutdown sequence for the REST API 
> should be next to the other APIs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #455: GEODE-2770 - Move the shutdown of the rest interfac...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/455


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2763) Remove of nonSingleHopsCount stat in client

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970732#comment-15970732
 ] 

ASF GitHub Bot commented on GEODE-2763:
---

Github user ameybarve15 commented on the issue:

https://github.com/apache/geode-native/pull/90
  
@echobravopapa I am following 
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
I can squash commits post pull request is approved.



> Remove of nonSingleHopsCount stat in client
> ---
>
> Key: GEODE-2763
> URL: https://issues.apache.org/jira/browse/GEODE-2763
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Michael Dodge
>Assignee: Amey Barve
>
> A pre-existing issue (GEODE-2017) required the removal of the 
> nonSingleHopsCount statistic in the clients. Whilst marked for the native 
> client as well, it was not addressed in the native client. It should be.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #90: GEODE-2763: Remove of nonSingleHopsCount stat in cli...

[ameybarve15]

Github user ameybarve15 commented on the issue:

https://github.com/apache/geode-native/pull/90
  
@echobravopapa I am following 
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
I can squash commits post pull request is approved.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---