JMX documentation

[Nitin Lamba]

Hi,

Recently, I was asked for definitions of various JMX metrics available in
Geode and what stats/ values are expected to change during what operations.

Looked around and found time statistics [1] but couldn't find a good doc
that explains JMX Beans; only some API docs [2] and the wiki describing
info to extend MBeans [3]. Also, the MBean attributes in JConsole (or Java
Mission Control) do not show any descriptions, rather just repeat the value
of the attribute name.

So, following are my questions:
- Is the lack of descriptions/ definitions intentional or just a miss?
- Any JIRA created for fixing this? If not, I can create one

It would be good to polish this out to improve the operator (monitoring)
experience.

Thanks,
Nitin

[1]
http://geode.apache.org/docs/guide/11/reference/statistics/statistics_list.html
[2]
http://geode.apache.org/releases/latest/javadoc/org/apache/geode/management/package-summary.html
[3] https://cwiki.apache.org/confluence/display/GEODE/Geode+JMX+MBeans

[GitHub] geode pull request #625: GEODE-1988: Increased the readTimeout

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/625

GEODE-1988: Increased the readTimeout

* Increased the readTimeout to 20 seconds to prevent test failures in 
slower systems

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-1988

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/625.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #625


commit 1d0a6d8ba473d5586921ca9c0e548844923e6bf6
Author: nabarun 
Date:   2017-07-12T02:20:54Z

GEODE-1988: Increased the readTimeout

* Increased the readTimeout to 20 seconds to prevent test failures in 
slower systems




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #625: GEODE-1988: Increased the readTimeout

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/625
  
Potential reviewers
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #622: GEODE-1731: Modifying region size check to be more ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/622


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/622
  
Merging into develop


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-release #77

[Apache Jenkins Server]

See 


Changes:

[upthewaterspout] GEODE-3172: Fix serialization errors copying queue between 
1.0 and 1.2

--
[...truncated 105.57 KB...]
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:checkMissedTests
:geode-wan:spotlessJavaCheck
:geode-wan:spotlessCheck
:geode-wan:test
:geode-wan:check
:geode-wan:build
:geode-wan:distributedTest

org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest
 > 
testReplicatedSerialPropagationWithRemoteReceiverRestarted_Sen

Fixed: apache/geode#3127 (develop - c48b538)

[Travis CI]

Build Update for apache/geode
-

Build: #3127
Status: Fixed

Duration: 22 minutes and 32 seconds
Commit: c48b538 (develop)
Author: Hitesh Khamesra
Message: GEODE-3121 Applied spotless

View the changeset: 
https://github.com/apache/geode/compare/1c35f866591c...c48b5381cef3

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/252615226?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Broken: apache/geode#3126 (develop - 1c35f86)

[Travis CI]

Build Update for apache/geode
-

Build: #3126
Status: Broken

Duration: 8 minutes and 42 seconds
Commit: 1c35f86 (develop)
Author: Udo Kohlmeyer
Message: GEODE-3121: Merge due to rebase. This now closes #612

View the changeset: 
https://github.com/apache/geode/compare/aef89129626d...1c35f866591c

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/252605025?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #613 was SUCCESSFUL (with 1908 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #613 was successful.
---
Scheduled
1910 tests in total.

https://build.spring.io/browse/SGF-NAG-613/





--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode pull request #612: GEODE-3121: ensure that the protobuf protocol works...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/612


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #624: GEODE-2998: Add remove operation

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/107#discussion_r126792525
  
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,11 @@ int32_t StructSetImpl::getFieldIndex(const char* 
fieldname) {
   }
 }
 
-const char* StructSetImpl::getFieldName(int32_t index) {
-  for (std::map::iterator iter =
-   m_fieldNameIndexMap.begin();
-   iter != m_fieldNameIndexMap.end(); ++iter) {
-if (iter->second == index) return iter->first.c_str();
+const std::string& StructSetImpl::getFieldName(int32_t index) {
+  for (const auto& iter : m_fieldNameIndexMap) {
+if (iter.second == index) return (iter.first);
   }
-  return nullptr;
+  return std::string("");
--- End diff --

`std::out_of_range`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/107#discussion_r126792435
  
--- Diff: src/cppcache/src/Struct.cpp ---
@@ -96,16 +99,16 @@ Serializable* Struct::fromData(DataInput& input) {
   return this;
 }
 
-const char* Struct::getFieldName(const int32_t index) const {
+const std::string& Struct::getFieldName(const int32_t index) const {
   if (m_parent != nullptr) {
 return m_parent->getFieldName(index);
   } else {
 for (const auto& iter : m_fieldNames) {
-  if ((iter.second)->value() == index) return iter.first->asChar();
+  if (iter.second == index) return (iter.first);
 }
   }
 
-  return nullptr;
+  return std::string("");
--- End diff --

What about throwing 
[`std::out_of_range`](http://en.cppreference.com/w/cpp/error/out_of_range). I 
don't like the idea of checking for empty string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #107: GEODE-3019: Refactor Struct class

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/107
  
@dgkimura @pivotal-jbarrett I squashed the latest so you won't get 
notified, which is a bummer, but please have a look when you have a minute.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : Geode-nightly-flaky #62

[Apache Jenkins Server]

See 

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review180212
---




geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
Lines 138 (patched)


need to validate the response's value here


- Bruce Schuchardt


On July 7, 2017, 2:18 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
> 
> (Updated July 7, 2017, 2:18 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2997
> https://issues.apache.org/jira/browse/GEODE-2997
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed get response to indicate if LookupFailure was a missing key or key 
> with null value, added test
> Added GetAllRequestOperationHandler and unit test
> Added PutAllRequestOperationHandler and unit test
> Added an integration test covering the putAll and getAll operations
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  ebd5c6a0a 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
>  b96f478d1 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
>  2114fdbf7 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
>  924979329 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  31a873658 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
>  b7d52019e 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60718/diff/1/
> 
> 
> Testing
> ---
> 
> Added unit tests for new operation handlers
> Added integration test covering new operations
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

Build failed in Jenkins: Geode-nightly #893

[Apache Jenkins Server]

See 


Changes:

[dcavender] GEODE-3109: Publish modules distribution artifacts to maven

[eshu] GEODE-3015: Fix a flaky test by adding wait.

[jdeppe] GEODE-3109: Keep module zip file names with an Apache_Geode prefix

[bschuchardt] GEODE-3175 backward-compatibility tests fail with bad classpath

[bschuchardt] GEODE-3177 RollingUpgradeDUnitTest & RollingUpgrade2DUnitTest 
suspect

[upthewaterspout] GEODE-2901: Resolving possible session testing concurrency 
issues

--
[...truncated 123.03 KB...]
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-protobuf:assemble
:geode-protobuf:extractIncludeTestProto
:geode-protobuf:extractTestProto UP-TO-DATE
:geode-protobuf:generateTestProto UP-TO-DATE
:geode-protobuf:compileTestJavaNote: Some input files use unchecked or unsafe 
operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-protobuf:processTestResources UP-TO-DATE
:geode-protobuf:testClasses
:geode-protobuf:checkMissedTests
:geode-protobuf:spotlessJavaCheck
:geode-protobuf:spotlessCheck
:geode-protobuf:test
:geode-protobuf:check
:geode-protobuf:build
:geode-protobuf:distributedTest
:geode-protobuf:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files u

Re: Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60526/#review180208
---


Ship it!




Ship It!

- Bruce Schuchardt


On July 7, 2017, 3:16 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60526/
> ---
> 
> (Updated July 7, 2017, 3:16 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-3121
> https://issues.apache.org/jira/browse/GEODE-3121
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding a new test to run the protobuf integration test over a SSL connection.
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  31a873658 
>   
> geode-protobuf/src/test/resources/org/apache/geode/protocol/default.keystore 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60526/diff/3/
> 
> 
> Testing
> ---
> 
> This change is just adding a test.
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Brian Rowe]

> On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
> > Lines 48-50 (patched)
> > 
> >
> > I don't think we should return an error here... If they send us an 
> > empty list of keys, they get an empty response back.

Fixed


> On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
> > Lines 41 (patched)
> > 
> >
> > I'm really not a big fan of a 60 line long method. Maybe we can break 
> > this into smaller methods?

Broke out several sub-methods.


> On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
> > Lines 48-51 (patched)
> > 
> >
> > Empty putAll does nothing. I don't believe we should log an error.

Fixed.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review179967
---


On July 7, 2017, 9:18 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
> 
> (Updated July 7, 2017, 9:18 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2997
> https://issues.apache.org/jira/browse/GEODE-2997
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed get response to indicate if LookupFailure was a missing key or key 
> with null value, added test
> Added GetAllRequestOperationHandler and unit test
> Added PutAllRequestOperationHandler and unit test
> Added an integration test covering the putAll and getAll operations
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  ebd5c6a0a 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
>  b96f478d1 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
>  2114fdbf7 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
>  924979329 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  31a873658 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
>  b7d52019e 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60718/diff/1/
> 
> 
> Testing
> ---
> 
> Added unit tests for new operation handlers
> Added integration test covering new operations
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

[GitHub] geode pull request #624: GEODE-2998: Add remove operation

[pivotal-amurmann]

GitHub user pivotal-amurmann opened a pull request:

https://github.com/apache/geode/pull/624

GEODE-2998: Add remove operation

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
  GEODE-2998

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
does not apply

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-amurmann/geode GEODE-2998

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd1844d95d106d13328756dfeaea5f7731e0a089
Author: Brian Rowe 
Date:   2017-07-06T23:36:51Z

GEODE-2998: Add remove operation

Signed-off-by: Alexander Murmann 
Signed-off-by: Matt Kalinowski 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

[Alexander Murmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60526/#review180205
---


Ship it!




Ship It!

- Alexander Murmann


On July 7, 2017, 10:16 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60526/
> ---
> 
> (Updated July 7, 2017, 10:16 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-3121
> https://issues.apache.org/jira/browse/GEODE-3121
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding a new test to run the protobuf integration test over a SSL connection.
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  31a873658 
>   
> geode-protobuf/src/test/resources/org/apache/geode/protocol/default.keystore 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60526/diff/3/
> 
> 
> Testing
> ---
> 
> This change is just adding a test.
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

Re: slf4j-jdk

[Kirk Lund]

Thanks David! Searching git history for slf4j-jdk wasn't yielding much for
me.

On Mon, Jul 10, 2017 at 4:03 PM, David Anuta 
wrote:

> It looks like that might have been caused by my commit for GEODE-2901.
> slf4j-jdk.jar is included in the Tomcat zip folder located within the
> geode-assembly/build/install/apache-geode/tools/Modules/ modules directory
> and the change extracts that folder.
>
> I've created GEODE-3179 
> to
> resolve the issue and will work on fixing it shortly.
>
> On Mon, Jul 10, 2017 at 10:53 AM, Kirk Lund  wrote:
>
> > Does anyone know how and where "slf4j-jdk" was added as a dependency and
> > bundled jar?
> >
> > I get the feeling that everyone is expecting someone else (the person who
> > added it?) is going to fix it. Was it added in a PR maybe?
> >
> > Error
> > java.lang.AssertionError: The bundled jars have changed. Please make sure
> > you update the licence and notice
> > as described in
> > https://cwiki.apache.org/confluence/display/GEODE/
> > License+Guide+for+Contributors
> > When fixed, copy geode-assembly/build/test/bundled_jars.txt
> > to src/test/resources/expected_jars.txt
> > Removed Jars
> > --
> > Added Jars
> > --
> > slf4j-jdk
> > Stacktrace
> > java.lang.AssertionError: The bundled jars have changed. Please make sure
> > you update the licence and notice
> > as described in
> > https://cwiki.apache.org/confluence/display/GEODE/
> > License+Guide+for+Contributors
> > When fixed, copy geode-assembly/build/test/bundled_jars.txt
> > to src/test/resources/expected_jars.txt
> > Removed Jars
> > --
> > Added Jars
> > --
> > slf4j-jdk
> > at org.junit.Assert.fail(Assert.java:88)
> > at org.junit.Assert.assertTrue(Assert.java:41)
> > at
> > org.apache.geode.BundledJarsJUnitTest.verifyBundledJarsHaveNotChange
> > d(BundledJarsJUnitTest.java:81)
> >
>
>
>
> --
> David Anuta
>

RE: want to encrypt default username/password in properties files or xml with default encrypted values.

[Dinesh Akhand]

Hi Below is the example using it ,We are able to encrypt password for pulse. 
Change the entry as per below





   

   

  

 

 



   




 

  

   





But not able to find a standard way to encrypt pulse.jmxUserPassword.



If anyone know it kindly share it.



Thanks,

Dinesh Akhand





-Original Message-
From: Jinmei Liao [mailto:jil...@pivotal.io]
Sent: Wednesday, June 28, 2017 9:18 PM
To: dev@geode.apache.org
Subject: Re: want to encrypt default username/password in properties files or 
xml with default encrypted values.



Hi, if you are using the Geode1.1, Pulse uses the integrated security from your 
cluster now instead of having to resort to its own security. So the admin/admin 
username/password is only used when your cluster is not secured. If your 
cluster has a security manager, when logging into Pulse, you should use 
whatever username/password that can be authenticated by that security manager.



On Wed, Jun 28, 2017 at 1:27 AM, Dinesh Akhand 
mailto:dines...@amdocs.com>> wrote:



> Hi team,

>

>

> Is there any way to encrypted default username/password  in

> pulse.properties:

>

> # JMX User Properties

> pulse.jmxUserName=admin

> pulse.jmxUserPassword=admin

>

> spring-security.xml:

>

> 

> 

> 

> 

> 

> 

>   authorities="ROLE_CLUSTER:READ,ROLE_DATA:READ"/>

> 

> 

>  I want to set default

> username/password to be in encrypted from in above file.

> Please suggest.

>

> Thanks,

> Dinesh Akhand

>

>

> -Original Message-

> From: Dinesh Akhand

> Sent: Tuesday, June 27, 2017 12:34 PM

> To: dev@geode.apache.org

> Subject: want to encrypt default username/password in properties files

> or xml with default encrypted values.

>

> Hi Team,

>

> Default user name /password are defined in spring-security.xml  and

> pulse.properties file.

> As below.

>

> ./geode/locator0/GemFire_anmuser/services/http/0.0.0.0_

> 20248_pulse/webapp/WEB-INF/spring-security.xml:

>  ./geode/locator0/GemFire_anmuser/services/http/0.0.0.0_

> 20248_pulse/webapp/WEB-INF/classes/pulse.properties:

> pulse.jmxUserPassword=admin

>

> What is the correct way to set the default encrypted username/password

> in these config files.

>

> Please suggest.

>

> Thanks,

> Dinesh Akhand

> This message and the information contained herein is proprietary and

> confidential and subject to the Amdocs policy statement,

>

> you may review at https://www.amdocs.com/about/email-disclaimer <

> https://www.amdocs.com/about/email-disclaimer>

> This message and the information contained herein is proprietary and

> confidential and subject to the Amdocs policy statement,

>

> you may review at https://www.amdocs.com/about/email-disclaimer <

> https://www.amdocs.com/about/email-disclaimer>

>

>





--

Cheers



Jinmei
This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at https://www.amdocs.com/about/email-disclaimer 

Jenkins build is back to normal : Geode-release-flaky #25

[Apache Jenkins Server]

See 

Build failed in Jenkins: Geode-release #76

[Apache Jenkins Server]

See 


Changes:

[hkhamesra] GEODE-3153 Client receives duplicate events during rolling upgrade

[hkhamesra] GEODE-3153 applied spotless

--
[...truncated 53.12 KB...]
:extensions/geode-modules-session:signArchives SKIPPED
:extensions/geode-modules-session:assemble
:extensions/geode-modules-assembly:distAppServer
:extensions/geode-modules-tomcat7:compileJava
:extensions/geode-modules-tomcat7:processResources UP-TO-DATE
:extensions/geode-modules-tomcat7:classes
:extensions/geode-modules-tomcat7:jar
:extensions/geode-modules-tomcat7:javadoc
:extensions/geode-modules-tomcat7:javadocJar
:extensions/geode-modules-tomcat7:sourcesJar
:extensions/geode-modules-tomcat7:signArchives SKIPPED
:extensions/geode-modules-tomcat7:assemble
:extensions/geode-modules-tomcat8:compileJava
:extensions/geode-modules-tomcat8:processResources UP-TO-DATE
:extensions/geode-modules-tomcat8:classes
:extensions/geode-modules-tomcat8:jar
:extensions/geode-modules-tomcat8:javadoc
:extensions/geode-modules-tomcat8:javadocJar
:extensions/geode-modules-tomcat8:sourcesJar
:extensions/geode-modules-tomcat8:signArchives SKIPPED
:extensions/geode-modules-tomcat8:assemble
:extensions/geode-modules-assembly:distTcServer
:extensions/geode-modules-assembly:distTcServer30
:extensions/geode-modules-assembly:distTomcat
:extensions/geode-modules-assembly:dist
:extensions/geode-modules-assembly:build
:extensions/geode-modules-assembly:distributedTest UP-TO-DATE
:extensions/geode-modules-assembly:integrationTest UP-TO-DATE
:extensions/geode-modules-session:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:extensions/geode-modules-session:processTestResources
:extensions/geode-modules-session:testClasses
:extensions/geode-modules-session:checkMissedTests
:extensions/geode-modules-session:spotlessJavaCheck
:extensions/geode-modules-session:spotlessCheck
:extensions/geode-modules-session:test
:extensions/geode-modules-session:check
:extensions/geode-modules-session:build
:extensions/geode-modules-session:distributedTest
:extensions/geode-modules-session:integrationTest
:extensions/geode-modules-session-internal:javadocJar
:extensions/geode-modules-session-internal:sourcesJar
:extensions/geode-modules-session-internal:signArchives SKIPPED
:extensions/geode-modules-session-internal:assemble
:extensions/geode-modules-session-internal:compileTestJava UP-TO-DATE
:extensions/geode-modules-session-internal:processTestResources UP-TO-DATE
:extensions/geode-modules-session-internal:testClasses UP-TO-DATE
:extensions/geode-modules-session-internal:checkMissedTests UP-TO-DATE
:extensions/geode-modules-session-internal:spotlessJavaCheck
:extensions/geode-modules-session-internal:spotlessCheck
:extensions/geode-modules-session-internal:test UP-TO-DATE
:extensions/geode-modules-session-internal:check
:extensions/geode-modules-session-internal:build
:extensions/geode-modules-session-internal:distributedTest UP-TO-DATE
:extensions/geode-modules-session-internal:integrationTest UP-TO-DATE
:extensions/geode-modules-tomcat7:compileTestJava
:extensions/geode-modules-tomcat7:processTestResources
:extensions/geode-modules-tomcat7:testClasses
:extensions/geode-modules-tomcat7:checkMissedTests
:extensions/geode-modules-tomcat7:spotlessJavaCheck
:extensions/geode-modules-tomcat7:spotlessCheck
:extensions/geode-modules-tomcat7:test
:extensions/geode-modules-tomcat7:check
:extensions/geode-modules-tomcat7:build
:extensions/geode-modules-tomcat7:distributedTest
:extensions/geode-modules-tomcat7:integrationTest
:extensions/geode-modules-tomcat8:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:extensions/geode-modules-tomcat8:processTestResources
:extensions/geode-modules-tomcat8:testClasses
:extensions/geode-modules-tomcat8:checkMissedTests
:extensions/geode-modules-tomcat8:spotlessJavaCheck
:extensions/geode-modules-tomcat8:spotlessCheck
:extensions/geode-modules-tomcat8:test
:extensions/geode-modules-tomcat8:check
:extensions/geode-modules-tomcat8:build
:extensions/geode-modules-tomcat8:distributedTest
:extensions/geode-modules-tomcat8:integrationTest
:geode-assembly:compileJava UP-TO-DATE
:geode-assembly:processResources UP-TO-DATE
:geode-assembly:classes UP-TO-DATE
:geode-assembly:defaultCacheConfig
:geode-assembly:defaultDistributionConfig
:geode-assembly:depsJar
:geode-benchmarks:compileJava UP-TO-DATE
:geode-benchmarks:processResources UP-TO-DATE
:geode-benchmarks:classes UP-TO-DATE
:geode-cq:compileJavaNote: Some input files use