Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Galen O'Sullivan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review180369
---



Tests could use a little thoughtful addition of whitespace. Grouping related 
statements with empty lines between them helps a lot with readability.

It would be nice to see some tests that used more varied datatypes, and I think 
this might be a good case for property-based (quickcheck) testing. Since I know 
y'all in person, let's chat in person about this.
It would also be nice to see some tests of failure cases and malformed messages 
-- that may come later, but might be a good thing to do now. Maybe this can be 
tied in with custom generators for property-based testing. Let's talk about 
this too.


geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
Lines 59 (patched)


It looks like this will throw `ClassCastException` if the key type doesn't 
satisfy key constraints. `LocalRegion`'s implementation calls `basicGetAll` to 
`accessEntry` to `validateKey`.

I also followed `DataSetRegion`'s implementation through the code to 
```
LocalRegion.get(Object key, Object aCallbackArgument, boolean 
generateCallbacks,
  boolean disableCopyOnRead, boolean preferCD, ClientProxyMembershipID 
requestingClient,
  EntryEventImpl clientEvent, boolean returnTombstones, boolean 
opScopeIsLocal,
  boolean retainResult) throws TimeoutException, CacheLoaderException {
```
which calls `validateKey`, which can throw a `ClassCastException`.



geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
Lines 38 (patched)


I had thought of operation handlers as being stateless. Is this not the 
case?



geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
Lines 59 (patched)


This looks wrong. Shouldn't it be putting the keys somewhere?



geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
Line 40 (original), 38 (patched)


Looks like we're creating error messages in this changeset, but not 
actually implementing the error message codes?



geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
Lines 155 (patched)


I wonder if it would make sense to extracted this block to a method in a 
`ProtobufTestUtilities` class, or if that's overkill.

In general, these tests look really noisy to me, but I'm not sure what the 
best way to improve that would be.



geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
Lines 57 (patched)


It seems to me that you're going to a lot of work to make the mock here. 
Would a spy be easier to understand?



geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
Lines 68 (patched)


The serialization service is stateless. Would a spy make more sense here?


- Galen O'Sullivan


On July 12, 2017, 6:27 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
> 
> (Updated July 12, 2017, 6:27 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2997
> https://issues.apache.org/jira/browse/GEODE-2997
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed get response to indicate if LookupFailure was a missing key or key 
> with null value, added test
> Added GetAllRequestOperationHandler and unit test
> Added PutAllRequestOperationHandler and unit test
> Added an integration test covering the putAll and getAll operations
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  714639274 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  13b156f99 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
>  PRE-CREATION 
>   

[GitHub] geode pull request #631: GEODE-3051: Remove unreachable exception handling i...

[WireBaron]

GitHub user WireBaron opened a pull request:

https://github.com/apache/geode/pull/631

GEODE-3051: Remove unreachable exception handling in AcceptorImpl.accept

This removes handling of SSL exceptions from the AccepterImpl.accept call, 
as the SSL handling code is now all done in another thread.
The exception handling being done in the other thread appears to be 
correct, as validated by CacheServerSSLConnectionDUnitTest.testNonSSLClient

Signed-off-by: Brian Rowe 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/WireBaron/geode feature/GEODE-3051

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/631.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #631


commit fa922141344ba1bddb6fc7203e23a886af8d93fa
Author: Alexander Murmann 
Date:   2017-07-13T00:16:10Z

GEODE-3051: Remove unreachable exception handling in AcceptorImpl.accept

This removes handling of SSL exceptions from the AccepterImpl.accept call, 
as the SSL handling code is now all done in another thread.
The exception handling being done in the other thread appears to be 
correct, as validated by CacheServerSSLConnectionDUnitTest.testNonSSLClient

Signed-off-by: Brian Rowe 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 60834: GEODE-3051: Remove unreachable exception handling in AcceptorImpl.accept

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60834/
---

Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-3051
https://issues.apache.org/jira/browse/GEODE-3051


Repository: geode


Description
---

This removes handling of SSL exceptions from the AccepterImpl.accept call, as 
the SSL handling code is now all done in another thread.
The exception handling being done in the other thread appears to be correct, as 
validated by CacheServerSSLConnectionDUnitTest.testNonSSLClient


Diffs
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 3c424d397 


Diff: https://reviews.apache.org/r/60834/diff/1/


Testing
---


Thanks,

Brian Rowe

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

[kohlmu-pivotal]

GitHub user kohlmu-pivotal opened a pull request:

https://github.com/apache/geode/pull/630

GEODE-3141: GetRegion Operation implemented

Added OperationHandlerJUnitTest.java as parents class of all 
OperationHandler tests.
General clean up of all `public static final` fields

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [x ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.
@galen-pivotal @hiteshk25 @bschuchardt @WireBaron @pivotal-amurmann 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3141

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/630.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #630


commit 0f0fa0c08b5a66200055a5fc1a008881f5be95ab
Author: Udo Kohlmeyer 
Date:   2017-07-13T00:22:55Z

GEODE-3141: GetRegion Operation implemented
Added OperationHandlerJUnitTest.java as parents class of all 
OperationHandler tests.
General clean up of all `public static final` fields




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #629: GEODE-2997: New flow getAll/putAll

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/629


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #629: GEODE-2997: New flow getAll/putAll

[WireBaron]

GitHub user WireBaron opened a pull request:

https://github.com/apache/geode/pull/629

GEODE-2997: New flow getAll/putAll

Changed get response to indicate if LookupFailure was a missing key or key 
with null value, added test
Added GetAllRequestOperationHandler and unit test
Added PutAllRequestOperationHandler and unit test
Added an integration test covering the putAll and getAll operations
Removed serverInternal and retriable fields from ErrorResponse, replaced 
with errorCode field

Signed-off-by: Brian Rowe 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/WireBaron/geode feature/GEODE-2997

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/629.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #629


commit 510d579788abdd04e49b6ee7748fe0953e972e99
Author: Alexander Murmann 
Date:   2017-07-06T00:36:20Z

GEODE-2997: New flow getAll/putAll

Changed get response to indicate if LookupFailure was a missing key or key 
with null value, added test
Added GetAllRequestOperationHandler and unit test
Added PutAllRequestOperationHandler and unit test
Added an integration test covering the putAll and getAll operations
Removed serverInternal and retriable fields from ErrorResponse, replaced 
with errorCode field

Signed-off-by: Brian Rowe 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Requesting wiki edit privileges

[Diane Hardman]

Thanks!

On Wed, Jul 12, 2017 at 10:17 AM, Dan Smith  wrote:

> I added you, you should have access now.
>
> Thanks!
> -Dan
>
> On Wed, Jul 12, 2017 at 10:12 AM, Diane Hardman 
> wrote:
>
> > Will someone please give me edit privileges for Geode wiki pages?
> >
> > Thanks!
> > Diane Hardman
> >
>

[GitHub] geode-examples issue #9: GEODE-3199: Make signing with a gpg key optional

[upthewaterspout]

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode-examples/pull/9
  
@metatype - I updated the PR. Travis is now stuck on find a 1.2 geode 
distribution, but it got past the signing check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review180371
---


Ship it!




Ship It!

- Udo Kohlmeyer


On July 12, 2017, 6:27 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
> 
> (Updated July 12, 2017, 6:27 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2997
> https://issues.apache.org/jira/browse/GEODE-2997
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed get response to indicate if LookupFailure was a missing key or key 
> with null value, added test
> Added GetAllRequestOperationHandler and unit test
> Added PutAllRequestOperationHandler and unit test
> Added an integration test covering the putAll and getAll operations
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  714639274 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  13b156f99 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
>  fecf01d7b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
>  e1fef85b4 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
>  b246a501b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
>  d6ef2788e 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
>  924979329 
>   geode-protobuf/src/main/proto/clientProtocol.proto d94c0f312 
>   geode-protobuf/src/main/proto/region_API.proto 3108cb7c3 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> fee9448af 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  612b9c9a4 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
>  b7d52019e 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60718/diff/4/
> 
> 
> Testing
> ---
> 
> Added unit tests for new operation handlers
> Added integration test covering new operations
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #614 was SUCCESSFUL (with 1953 tests). Change made by John Blum.

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #614 was successful.
---
Scheduled with changes by John Blum.
1955 tests in total.

https://build.spring.io/browse/SGF-NAG-614/




--
Code Changes
--
John Blum (70eea5f68db64b43598552e344c9858a7b33e338):

>DATAGEODE-16 - Add support for Geode JCA ResourceAdapter.



--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode-examples issue #9: GEODE-3199: Make signing with a gpg key optional

[upthewaterspout]

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode-examples/pull/9
  
Sure, I'll change it. I was using askpass just because that mirrored what 
the main geode repo uses, but I think signArtifacts or something like that is 
clearer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review180365
---


Ship it!




Ship It!

- Bruce Schuchardt


On July 12, 2017, 11:27 a.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
> 
> (Updated July 12, 2017, 11:27 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2997
> https://issues.apache.org/jira/browse/GEODE-2997
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed get response to indicate if LookupFailure was a missing key or key 
> with null value, added test
> Added GetAllRequestOperationHandler and unit test
> Added PutAllRequestOperationHandler and unit test
> Added an integration test covering the putAll and getAll operations
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  714639274 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  13b156f99 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
>  fecf01d7b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
>  e1fef85b4 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
>  b246a501b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
>  d6ef2788e 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
>  924979329 
>   geode-protobuf/src/main/proto/clientProtocol.proto d94c0f312 
>   geode-protobuf/src/main/proto/region_API.proto 3108cb7c3 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> fee9448af 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  612b9c9a4 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
>  b7d52019e 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60718/diff/4/
> 
> 
> Testing
> ---
> 
> Added unit tests for new operation handlers
> Added integration test covering new operations
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

[GitHub] geode-examples pull request #9: GEODE-3199: Make signing with a gpg key opti...

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/9#discussion_r127090456
  
--- Diff: gradle/release.gradle ---
@@ -41,17 +41,19 @@ gradle.taskGraph.whenReady( { graph ->
 })
 
 gradle.taskGraph.whenReady { taskGraph ->
-  if (!version.endsWith('SNAPSHOT')) {
-if(!project.hasProperty('signing.keyId') || 
!project.hasProperty('signing.secretKeyRingFile')) {
-  println "You must configure your signing.keyId and 
signing.secretKeyRingFile"
-  println "in ~/.gradle/gradle.properties in order to sign jars\n"
-  println "See 
https://cwiki.apache.org/confluence/display/GEODE/Release+Steps;
-  throw new GradleException("Signing key/keyring is missing")
-}
+  if (project.hasProperty('askpass')) {
--- End diff --

Should this be called `signReleaseArtifacts` since it guards signing (which 
may cause the password dialog to appear depending on your environment)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples pull request #7: GEODE-3196: Fixing the format of the .md5 an...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-examples/pull/7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples pull request #9: GEODE-3199: Make signing with a gpg key opti...

[upthewaterspout]

GitHub user upthewaterspout opened a pull request:

https://github.com/apache/geode-examples/pull/9

GEODE-3199: Make signing with a gpg key optional

Make it optional to sign the archives with a gpg key, to avoid annoying
users trying to build the examples.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/upthewaterspout/geode-examples 
feature/GEODE-3199

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-examples/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit c6b110abece7b0801054e8f44b0f430155391e90
Author: Dan Smith 
Date:   2017-07-12T22:30:13Z

GEODE-3199: Make signing with a gpg key optional

Make it optional to sign the archives with a gpg key, to avoid annoying
users trying to build the examples.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Geode release - v1.2.0 RC2

[Dan Smith]

I created GEODE-3199 for the gpg prompting issue with geode-examples.

-Dan

On Wed, Jul 12, 2017 at 2:04 PM, Dan Smith  wrote:

> Travis was actually trying to tell us something was wrong with the
> geode-examples on the release branch as well:
>
> https://travis-ci.org/apache/geode-examples/builds/244002605
>
> You must configure your signing.keyId and signing.secretKeyRingFile
>
> in ~/.gradle/gradle.properties in order to sign jars
>
> See https://cwiki.apache.org/confluence/display/GEODE/Release+Steps
>
> FAILURE: Build failed with an exception.
> -Dan
>
>
> On Wed, Jul 12, 2017 at 1:28 PM, Dan Smith  wrote:
>
>> +0
>>
>> I ran geode-release-check
>>  against this
>> project. It all looks good except that the md5sum and sha256 sums tasks
>> don't pass because the .md5 and .sha256 files are in the wrong format. I
>> created GEODE-3196. I don't think that should hold up the release.
>>
>> There's another issue with the example source though. It looks like
>> trying to build an example is prompting me for me gpg key so it can sign
>> the artifacts. Given that our README is telling users to run ../gradlew
>> build this is a bit annoying.
>>
>> Awesome job making the examples build point at 1.2 but allowing me to
>> override the repo url so we can actually test them!
>>
>> -Dan
>>
>> On Wed, Jul 12, 2017 at 7:58 AM, Anthony Baker  wrote:
>>
>>> This is the second release candidate for Apache Geode, version 1.2.0.
>>> Thanks to all the community members for their contributions to this
>>> release!  This release candidate fixes a number of backwards
>>> compatibility
>>> and rolling upgrade issues found in RC1.
>>>
>>> *** Please download, test and vote by Saturday, July 15, 0800 hrs
>>> US Pacific. ***
>>>
>>> It fixes the following issues:
>>>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>>> ctId=12318420=12339257
>>>
>>> Note that we are voting upon the source tags:  rel/v1.2.0.RC2
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit
>>> ;h=964f2749065ce9c6898fd27983b43f1bd9fc77d0
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=geode-examples.git
>>> ;a=commit;h=7f93d95ad06a6f2afee54312585f48435fff11e8
>>>
>>> Commit ID:
>>>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
>>>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)
>>>
>>> Source and binary files:
>>>   https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2
>>>
>>> Maven staging repo:
>>>   https://repository.apache.org/content/repositories/orgapachegeode-1020
>>>
>>> Geode's KEYS file containing PGP keys we use to sign the release:
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_p
>>> lain;f=KEYS;hb=HEAD
>>>
>>> pub  4096R/C72CFB64 2015-10-01
>>>   Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64
>>>
>>> Anthony
>>>
>>
>>
>

[GitHub] geode pull request #628: GEODE-3131: Replaced Thread.sleep

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/628


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #603: GEODE-3128: Changed the batch size to 1000 when cre...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/603


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples issue #8: GEODE-3195 Add querying example to the geode-exampl...

[davebarnes97]

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-examples/pull/8
  
Encountered one problem: initial run failed rat check. I commented out the 
rat check in build.gradle "/* apply from: "gradle/rat.gradle"*/".
After that, I followed instructions and successfully ran the example from 
start to finish.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #628: GEODE-3131: Replaced Thread.sleep

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/628
  
Thank you @ladyVader .
Fixed the typo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/8#discussion_r127074360
  
--- Diff: queries/scripts/new_startAll.sh ---
@@ -0,0 +1,48 @@
+#!/bin/bash
--- End diff --

How is this file used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/8#discussion_r127074639
  
--- Diff: 
queries/src/main/java/org/apache/geode/examples/queries/Example.java ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.queries;
+
+import java.util.function.Consumer;
+import java.util.Iterator;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.cache.query.Query;
+import org.apache.geode.cache.query.QueryService;
+import org.apache.geode.cache.query.SelectResults;
+
+
+public class Example implements Consumer> {
+  public static void main(String[] args) {
+// connect to the locator using default port 10334
+ClientCache cache = new 
ClientCacheFactory().addPoolLocator("127.0.0.1", 10334)
+.set("log-level", "WARN").create();
+
+// create a local region that matches the server region
+Region region =
+cache.createClientRegionFactory(ClientRegionShortcut.CACHING_PROXY)
+.create("example-region");
+
+Example e = new Example();
+e.accept(region);
+e.doQueries(cache, region);
--- End diff --

I think `doQueries` should be called from `accept` to make it easier to 
unit test the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #628: GEODE-3131: Replaced Thread.sleep

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/628
  
Potential Reviewers:
@ladyVader @boglesby @jhuynh1 @upthewaterspout @gesterzhou @DivineEnder 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/8#discussion_r127073923
  
--- Diff: 
queries/src/main/java/org/apache/geode/examples/queries/EmployeeData.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.queries;
+
+import java.io.Serializable;
+
+public class EmployeeData implements Serializable {
+  private static final long serialVersionUID = 1L;
+
+  // private EmployeeKey nameAndNumber;
+  private String firstName;
+  private String lastName;
+  private int emplNumber;
+  private String email;
+  private int salary;
+  private int hoursPerWeek;
+
+  // public EmployeeData(EmployeeKey nameAndNumber, int salary, int 
hoursPerWeek) {
--- End diff --

Delete this dead code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/8#discussion_r127073986
  
--- Diff: 
queries/src/main/java/org/apache/geode/examples/queries/EmployeeData.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.queries;
+
+import java.io.Serializable;
+
+public class EmployeeData implements Serializable {
+  private static final long serialVersionUID = 1L;
+
+  // private EmployeeKey nameAndNumber;
+  private String firstName;
+  private String lastName;
+  private int emplNumber;
+  private String email;
+  private int salary;
+  private int hoursPerWeek;
+
+  // public EmployeeData(EmployeeKey nameAndNumber, int salary, int 
hoursPerWeek) {
+  // this.nameAndNumber = nameAndNumber;
+  // this.salary = salary;
+  // this.hoursPerWeek = hoursPerWeek;
+  // }
+
+  public EmployeeData(String firstName, String lastName, int emplNumber, 
String email, int salary,
+  int hoursPerWeek) {
+this.firstName = firstName;
+this.lastName = lastName;
+this.emplNumber = emplNumber;
+this.email = email;
+this.salary = salary;
+this.hoursPerWeek = hoursPerWeek;
+  }
+
+  public String getFirstName() {
+return firstName;
+  }
+
+  public String getLastName() {
+return lastName;
+  }
+
+  public int getEmplNumber() {
+return emplNumber;
+  }
+
+  public String getEmail() {
+return email;
+  }
+
+  public int getSalary() {
+return salary;
+  }
+
+  public int getHoursPerWeek() {
+return hoursPerWeek;
+  }
+
+  @Override
+  // public String toString() {
--- End diff --

// delete me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/8#discussion_r127073565
  
--- Diff: 
queries/src/main/java/org/apache/geode/examples/queries/Example.java ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.queries;
+
+import java.util.function.Consumer;
+import java.util.Iterator;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.cache.query.Query;
+import org.apache.geode.cache.query.QueryService;
+import org.apache.geode.cache.query.SelectResults;
+
+
+public class Example implements Consumer> {
+  public static void main(String[] args) {
+// connect to the locator using default port 10334
+ClientCache cache = new 
ClientCacheFactory().addPoolLocator("127.0.0.1", 10334)
+.set("log-level", "WARN").create();
+
+// create a local region that matches the server region
+Region region =
+cache.createClientRegionFactory(ClientRegionShortcut.CACHING_PROXY)
+.create("example-region");
+
+Example e = new Example();
+e.accept(region);
+e.doQueries(cache, region);
+cache.close();
+  }
+
+  @Override
+  public void accept(Region region) {
+// put entries in the region
+String[] firstNames =
+
"Alex,Bertie,Kris,Dale,Frankie,Jamie,Morgan,Pat,Ricky,Taylor,Casey,Jessie,Ryan,Skyler"
+.split(",");
+String[] lastNames =
+
"Able,Bell,Call,Driver,Forth,Jive,Minnow,Puts,Reliable,Tack,Catch,Jam,Redo,Skip".split(",");
+int salaries[] = new int[] {6, 8, 75000, 9, 10};
+int hours[] = new int[] {40, 40, 40, 40, 30, 20};
+int emplNumber = 1;
+for (int index = 0; index < firstNames.length; index++) {
+  emplNumber = emplNumber + index;
+  Integer key = emplNumber;
+  String email = firstNames[index] + "." + lastNames[index] + 
"@example.com";
+  int salary = salaries[index % 5];
+  int hoursPerWeek = hours[index % 6];
+  EmployeeData value = new EmployeeData(firstNames[index], 
lastNames[index], emplNumber, email,
+  salary, hoursPerWeek);
+  region.put(key, value);
+}
+
+// count the values in the region
+int inserted = region.keySetOnServer().size();
+System.out.println(String.format("Counted %d keys in region %s", 
inserted, region.getName()));
+
+// fetch and print all values in the region (without using a query)
+region.keySetOnServer().forEach(key -> 
System.out.println(region.get(key)));
+
+  }
+
+  // Query using the API
+  private void doQueries(ClientCache cache, Region 
region) {
+String regionName = region.getName();
+QueryService queryService = cache.getQueryService();
+
+// query for every entry in the region, and print query results
+String queryString1 = "SELECT DISTINCT * FROM /" + regionName;
+System.out.println(String.format("\nQuery: %s", queryString1));
+Query query = queryService.newQuery(queryString1);
+SelectResults results = null;
+try {
+  results = (SelectResults) query.execute();
+} catch (Exception e) {
+  e.printStackTrace();
--- End diff --

I think you should use a single `catch` block.  It simplifies the code and 
you probably want to abort if there's an error instead of trying to continue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please

[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/8#discussion_r127073236
  
--- Diff: replicated/scripts/start.gfsh ---
@@ -19,7 +19,9 @@ start locator --name=locator --bind-address=127.0.0.1
 start server --name=server1 --locators=127.0.0.1[10334] --server-port=0
 start server --name=server2 --locators=127.0.0.1[10334] --server-port=0
 
+#connect
--- End diff --

Is this needed?  I think it should be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #628: GEODE-3131: Replaced Thread.sleep

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/628

GEODE-3131: Replaced Thread.sleep

* Replaced sleeps with an Awaitility clause which waits for the region 
sizes to be correct before starting validation.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3131

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/628.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #628


commit 5d3d3cc8f5cf7bb69f28bd55024f6906fc41040a
Author: nabarun 
Date:   2017-07-12T21:07:48Z

GEODE-3131: Replaced Thread.sleep

* Replaced sleeps with an Awaitility clause which waits for the region 
sizes to be correct before starting validation.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples issue #7: GEODE-3196: Fixing the format of the .md5 and .sha2...

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode-examples/pull/7
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Geode release - v1.2.0 RC2

[Dan Smith]

Travis was actually trying to tell us something was wrong with the
geode-examples on the release branch as well:

https://travis-ci.org/apache/geode-examples/builds/244002605

You must configure your signing.keyId and signing.secretKeyRingFile

in ~/.gradle/gradle.properties in order to sign jars

See https://cwiki.apache.org/confluence/display/GEODE/Release+Steps

FAILURE: Build failed with an exception.
-Dan


On Wed, Jul 12, 2017 at 1:28 PM, Dan Smith  wrote:

> +0
>
> I ran geode-release-check
>  against this
> project. It all looks good except that the md5sum and sha256 sums tasks
> don't pass because the .md5 and .sha256 files are in the wrong format. I
> created GEODE-3196. I don't think that should hold up the release.
>
> There's another issue with the example source though. It looks like trying
> to build an example is prompting me for me gpg key so it can sign the
> artifacts. Given that our README is telling users to run ../gradlew build
> this is a bit annoying.
>
> Awesome job making the examples build point at 1.2 but allowing me to
> override the repo url so we can actually test them!
>
> -Dan
>
> On Wed, Jul 12, 2017 at 7:58 AM, Anthony Baker  wrote:
>
>> This is the second release candidate for Apache Geode, version 1.2.0.
>> Thanks to all the community members for their contributions to this
>> release!  This release candidate fixes a number of backwards compatibility
>> and rolling upgrade issues found in RC1.
>>
>> *** Please download, test and vote by Saturday, July 15, 0800 hrs
>> US Pacific. ***
>>
>> It fixes the following issues:
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12318420=12339257
>>
>> Note that we are voting upon the source tags:  rel/v1.2.0.RC2
>>
>> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit
>> ;h=964f2749065ce9c6898fd27983b43f1bd9fc77d0
>>
>> https://git-wip-us.apache.org/repos/asf?p=geode-examples.git
>> ;a=commit;h=7f93d95ad06a6f2afee54312585f48435fff11e8
>>
>> Commit ID:
>>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
>>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)
>>
>> Source and binary files:
>>   https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2
>>
>> Maven staging repo:
>>   https://repository.apache.org/content/repositories/orgapachegeode-1020
>>
>> Geode's KEYS file containing PGP keys we use to sign the release:
>>
>> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_p
>> lain;f=KEYS;hb=HEAD
>>
>> pub  4096R/C72CFB64 2015-10-01
>>   Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64
>>
>> Anthony
>>
>
>

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Brian Rowe]

> On July 12, 2017, 8:07 p.m., Bruce Schuchardt wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
> > Lines 55 (patched)
> > 
> >
> > I think we should change getAll to send an ordered collection of keys.  
> > Then the server only has to respond with the corresponding values & doesn't 
> > have to send the keys back to the client.  This is what the current java 
> > client getAll command does.

Good idea, but this will be a fairly dramatic change at this point.  We're 
going to create a new bug for this and then later on discuss this change with 
everyone and potentially implement it then.


> On July 12, 2017, 8:07 p.m., Bruce Schuchardt wrote:
> > geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
> > Line 30 (original), 29 (patched)
> > 
> >
> > We're not supposed to use wildcard imports
> > 
> > 
> > https://google.github.io/styleguide/javaguide.html#s3.3.1-wildcard-imports
> > 
> > You can configure IntelliJ to do this by setting # of imports that 
> > triggers use of wildcard to 99.

Fixed.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review180349
---


On July 12, 2017, 6:27 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
> 
> (Updated July 12, 2017, 6:27 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2997
> https://issues.apache.org/jira/browse/GEODE-2997
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed get response to indicate if LookupFailure was a missing key or key 
> with null value, added test
> Added GetAllRequestOperationHandler and unit test
> Added PutAllRequestOperationHandler and unit test
> Added an integration test covering the putAll and getAll operations
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  714639274 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  13b156f99 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
>  fecf01d7b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
>  e1fef85b4 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
>  b246a501b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
>  d6ef2788e 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
>  924979329 
>   geode-protobuf/src/main/proto/clientProtocol.proto d94c0f312 
>   geode-protobuf/src/main/proto/region_API.proto 3108cb7c3 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> fee9448af 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  612b9c9a4 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
>  b7d52019e 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60718/diff/4/
> 
> 
> Testing
> ---
> 
> Added unit tests for new operation handlers
> Added integration test covering new operations
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Brian Rowe]

> On July 11, 2017, 5:17 p.m., Bruce Schuchardt wrote:
> > geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
> > Lines 138 (patched)
> > 
> >
> > need to validate the response's value here

Good catch, fixed


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review180212
---


On July 12, 2017, 6:27 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
> 
> (Updated July 12, 2017, 6:27 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2997
> https://issues.apache.org/jira/browse/GEODE-2997
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed get response to indicate if LookupFailure was a missing key or key 
> with null value, added test
> Added GetAllRequestOperationHandler and unit test
> Added PutAllRequestOperationHandler and unit test
> Added an integration test covering the putAll and getAll operations
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  714639274 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  13b156f99 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
>  fecf01d7b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
>  e1fef85b4 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
>  b246a501b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
>  d6ef2788e 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
>  924979329 
>   geode-protobuf/src/main/proto/clientProtocol.proto d94c0f312 
>   geode-protobuf/src/main/proto/region_API.proto 3108cb7c3 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> fee9448af 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  612b9c9a4 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
>  b7d52019e 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60718/diff/4/
> 
> 
> Testing
> ---
> 
> Added unit tests for new operation handlers
> Added integration test covering new operations
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Alexander Murmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review180353
---


Ship it!




Ship It!

- Alexander Murmann


On July 12, 2017, 6:27 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
> 
> (Updated July 12, 2017, 6:27 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2997
> https://issues.apache.org/jira/browse/GEODE-2997
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed get response to indicate if LookupFailure was a missing key or key 
> with null value, added test
> Added GetAllRequestOperationHandler and unit test
> Added PutAllRequestOperationHandler and unit test
> Added an integration test covering the putAll and getAll operations
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  714639274 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  13b156f99 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
>  fecf01d7b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
>  e1fef85b4 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
>  b246a501b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
>  d6ef2788e 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
>  924979329 
>   geode-protobuf/src/main/proto/clientProtocol.proto d94c0f312 
>   geode-protobuf/src/main/proto/region_API.proto 3108cb7c3 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> fee9448af 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  612b9c9a4 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
>  b7d52019e 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60718/diff/4/
> 
> 
> Testing
> ---
> 
> Added unit tests for new operation handlers
> Added integration test covering new operations
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

Re: [VOTE] Apache Geode release - v1.2.0 RC2

[Dan Smith]

+0

I ran geode-release-check
 against this
project. It all looks good except that the md5sum and sha256 sums tasks
don't pass because the .md5 and .sha256 files are in the wrong format. I
created GEODE-3196. I don't think that should hold up the release.

There's another issue with the example source though. It looks like trying
to build an example is prompting me for me gpg key so it can sign the
artifacts. Given that our README is telling users to run ../gradlew build
this is a bit annoying.

Awesome job making the examples build point at 1.2 but allowing me to
override the repo url so we can actually test them!

-Dan

On Wed, Jul 12, 2017 at 7:58 AM, Anthony Baker  wrote:

> This is the second release candidate for Apache Geode, version 1.2.0.
> Thanks to all the community members for their contributions to this
> release!  This release candidate fixes a number of backwards compatibility
> and rolling upgrade issues found in RC1.
>
> *** Please download, test and vote by Saturday, July 15, 0800 hrs
> US Pacific. ***
>
> It fixes the following issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318420=12339257
>
> Note that we are voting upon the source tags:  rel/v1.2.0.RC2
>
> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=
> 964f2749065ce9c6898fd27983b43f1bd9fc77d0
>
> https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;a=commit;h=
> 7f93d95ad06a6f2afee54312585f48435fff11e8
>
> Commit ID:
>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)
>
> Source and binary files:
>   https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2
>
> Maven staging repo:
>   https://repository.apache.org/content/repositories/orgapachegeode-1020
>
> Geode's KEYS file containing PGP keys we use to sign the release:
>
> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_
> plain;f=KEYS;hb=HEAD
>
> pub  4096R/C72CFB64 2015-10-01
>   Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64
>
> Anthony
>

[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-examples/pull/8

GEODE-3195 Add querying example to the geode-examples

Here is a new geode-example that presents very simple queries on a single 
region done 2 ways: API calls and issued via gfsh.  My goal was to keep this 
example as simple as possible, focusing on demonstrating an introduction to 
queries. Please review.

Note: I tested this example using Geode built-from-source from the 
release/1.2.0 branch. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-examples 
feature/GEODE-3195

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-examples/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit c7e510158b8288cb8a231cfe7cb9c9ac8c9a0f9c
Author: Karen Miller 
Date:   2017-07-12T20:00:07Z

GEODE-3195 Add querying example to the geode-examples




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review180349
---




geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
Lines 55 (patched)


I think we should change getAll to send an ordered collection of keys.  
Then the server only has to respond with the corresponding values & doesn't 
have to send the keys back to the client.  This is what the current java client 
getAll command does.



geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
Line 30 (original), 29 (patched)


We're not supposed to use wildcard imports

https://google.github.io/styleguide/javaguide.html#s3.3.1-wildcard-imports

You can configure IntelliJ to do this by setting # of imports that triggers 
use of wildcard to 99.


- Bruce Schuchardt


On July 12, 2017, 11:27 a.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
> 
> (Updated July 12, 2017, 11:27 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2997
> https://issues.apache.org/jira/browse/GEODE-2997
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed get response to indicate if LookupFailure was a missing key or key 
> with null value, added test
> Added GetAllRequestOperationHandler and unit test
> Added PutAllRequestOperationHandler and unit test
> Added an integration test covering the putAll and getAll operations
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  714639274 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  13b156f99 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
>  fecf01d7b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
>  e1fef85b4 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
>  b246a501b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
>  d6ef2788e 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
>  924979329 
>   geode-protobuf/src/main/proto/clientProtocol.proto d94c0f312 
>   geode-protobuf/src/main/proto/region_API.proto 3108cb7c3 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> fee9448af 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  612b9c9a4 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
>  b7d52019e 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60718/diff/4/
> 
> 
> Testing
> ---
> 
> Added unit tests for new operation handlers
> Added integration test covering new operations
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

[GitHub] geode-examples pull request #7: GEODE-3196: Fixing the format of the .md5 an...

[upthewaterspout]

GitHub user upthewaterspout opened a pull request:

https://github.com/apache/geode-examples/pull/7

GEODE-3196: Fixing the format of the .md5 and .sha256 files



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/upthewaterspout/geode-examples 
feature/GEODE-3196

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-examples/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #7


commit 2ee271b134e6c49e0b7920bb147c475c03722c03
Author: Dan Smith 
Date:   2017-07-12T20:05:03Z

GEODE-3196: Fixing the format of the .md5 and .sha256 files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Errored: jinmeiliao/geode#14 (refactor-rebased - 401f91b)

[Travis CI]

Build Update for jinmeiliao/geode
-

Build: #14
Status: Errored

Duration: 8 minutes and 46 seconds
Commit: 401f91b (refactor-rebased)
Author: Jinmei Liao
Message: Merge branch 'refactor-week2-day3' into refactor-week2-friday

View the changeset: 
https://github.com/jinmeiliao/geode/compare/adab0c469053^...401f91b9f2f5

View the full build log and details: 
https://travis-ci.org/jinmeiliao/geode/builds/252882677?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: Requesting edit permissions for Geode tickets

[Fred Krone]

Easy peasy.

On Wed, Jul 12, 2017 at 3:28 PM, Dan Smith  wrote:

> I don't see that user. I think you probably need to create an account on
> the wiki first.
>
> -Dan
>
> On Wed, Jul 12, 2017 at 12:09 PM, Fred Krone  wrote:
>
> > I don't think I have access. I thought I did.  fkrone ?
> >
> > On Wed, Jul 12, 2017 at 2:36 PM, Dan Smith  wrote:
> >
> > > Hi Fred,
> > >
> > > What's your username on the wiki?
> > >
> > > -Dan
> > >
> > > On Wed, Jul 12, 2017 at 11:32 AM, Fred Krone 
> wrote:
> > >
> > > > Could someone give me karma on the wiki?
> > > >
> > > > Thanks,
> > > > -Fred
> > > >
> > > > On Thu, Mar 30, 2017 at 1:20 PM, Kirk Lund  wrote:
> > > >
> > > > > I gave you permissions for Jira. Someone else still needs to give
> you
> > > > karma
> > > > > on the Wiki.
> > > > >
> > > > > -Kirk
> > > > >
> > > > > On Thu, Mar 30, 2017 at 9:22 AM, Fred Krone 
> > wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > Could I get editing permissions for Geode tickets?  I can only
> edit
> > > > mine
> > > > > > and I'd like to reword some descriptions etc on other tickets.
> I'd
> > > > also
> > > > > > like to edit some wikis if needed.
> > > > > >
> > > > > > Both ASF and JIRA IDs are fkrone.
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > -Fred
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Brian Rowe]

We will still return ErrorResponses for any failures or invalid messages,
we've just removed the serverInternal and retriable fields from this
message in favor a errorCode integer.

On Wed, Jul 12, 2017 at 11:45 AM, Michael Stolz  wrote:

> We removed error feedback?
> So how is an application programmer supposed to determine what failed now?
> Without that information we may have rendered putAll unusable for some
> cases.
>
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: +1-631-835-4771 <(631)%20835-4771>
>
> On Wed, Jul 12, 2017 at 1:45 PM, Brian Rowe  wrote:
>
>>
>>
>> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
>> > > geode-protobuf/src/main/java/org/apache/geode/protocol/proto
>> buf/operations/PutAllRequestOperationHandler.java
>> > > Lines 81 (patched)
>> > > > e1771594line81>
>> > >
>> > > I'm sure that we can use `region.putAll(entries)` for this.
>>
>> Fixed.  This also resulted in us not being able to determine the state of
>> a partially succeeded PutAll, so we updated the PutAllResponse to remove
>> the failedKeys field.
>>
>>
>> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
>> > > geode-protobuf/src/main/java/org/apache/geode/protocol/proto
>> buf/utilities/ProtobufRequestUtilities.java
>> > > Lines 76 (patched)
>> > > > e1771595line76>
>> > >
>> > > maybe this variable name should be `getAllRequestBuilder`... not
>> advocate of generic `builder`
>>
>> Fixed
>>
>>
>> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
>> > > geode-protobuf/src/main/java/org/apache/geode/protocol/proto
>> buf/utilities/ProtobufRequestUtilities.java
>> > > Lines 78-80 (patched)
>> > > > e1771595line78>
>> > >
>> > > Could we replace this with `addAllKey(java.lang.Iterable> extends org.apache.geode.protocol.protobuf.BasicTypes.EncodedValue>
>> values)`
>>
>> Nice, good catch.
>>
>>
>> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
>> > > geode-protobuf/src/main/java/org/apache/geode/protocol/proto
>> buf/utilities/ProtobufRequestUtilities.java
>> > > Lines 95-97 (patched)
>> > > > e1771595line95>
>> > >
>> > > Could we replace this with `addAllEntry(java.lang.Iterable> extends org.apache.geode.protocol.protobuf.BasicTypes.Entry> values)`
>>
>> Fixed
>>
>>
>> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
>> > > geode-protobuf/src/main/java/org/apache/geode/protocol/proto
>> buf/utilities/ProtobufResponseUtilities.java
>> > > Lines 125-127 (patched)
>> > > > e1771596line125>
>> > >
>> > > Could we replace this with `addAllEntries(java.lang.Iterable> extends org.apache.geode.protocol.protobuf.BasicTypes.Entry> values)`
>>
>> Fixed
>>
>>
>> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
>> > > geode-protobuf/src/main/java/org/apache/geode/protocol/proto
>> buf/utilities/ProtobufResponseUtilities.java
>> > > Lines 141-143 (patched)
>> > > > e1771596line141>
>> > >
>> > > could we possibly use `addAllFailedKeys(java.lang.Iterable> extends org.apache.geode.protocol.protobuf.BasicTypes.EncodedValue>
>> values)`
>>
>> This got removed with the failed keys field.
>>
>>
>> - Brian
>>
>>
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/60718/#review179967
>> ---
>>
>>
>> On July 7, 2017, 9:18 p.m., Brian Rowe wrote:
>> >
>> > ---
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/60718/
>> > ---
>> >
>> > (Updated July 7, 2017, 9:18 p.m.)
>> >
>> >
>> > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen
>> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
>> >
>> >
>> > Bugs: GEODE-2997
>> > https://issues.apache.org/jira/browse/GEODE-2997
>> >
>> >
>> > Repository: geode
>> >
>> >
>> > Description
>> > ---
>> >
>> > Changed get response to indicate if LookupFailure was a missing key or
>> key with null value, added test
>> > Added GetAllRequestOperationHandler and unit test
>> > Added PutAllRequestOperationHandler and unit test
>> > Added an integration test covering the putAll and getAll operations
>> >
>> >
>> > Diffs
>> > -
>> >
>> >   geode-protobuf/src/main/java/org/apache/geode/protocol/prot
>> obuf/ProtobufStreamProcessor.java ebd5c6a0a
>> >   geode-protobuf/src/main/java/org/apache/geode/protocol/prot
>> obuf/operations/GetAllRequestOperationHandler.java PRE-CREATION
>> >   

Re: Requesting edit permissions for Geode tickets

[Dan Smith]

I don't see that user. I think you probably need to create an account on
the wiki first.

-Dan

On Wed, Jul 12, 2017 at 12:09 PM, Fred Krone  wrote:

> I don't think I have access. I thought I did.  fkrone ?
>
> On Wed, Jul 12, 2017 at 2:36 PM, Dan Smith  wrote:
>
> > Hi Fred,
> >
> > What's your username on the wiki?
> >
> > -Dan
> >
> > On Wed, Jul 12, 2017 at 11:32 AM, Fred Krone  wrote:
> >
> > > Could someone give me karma on the wiki?
> > >
> > > Thanks,
> > > -Fred
> > >
> > > On Thu, Mar 30, 2017 at 1:20 PM, Kirk Lund  wrote:
> > >
> > > > I gave you permissions for Jira. Someone else still needs to give you
> > > karma
> > > > on the Wiki.
> > > >
> > > > -Kirk
> > > >
> > > > On Thu, Mar 30, 2017 at 9:22 AM, Fred Krone 
> wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > Could I get editing permissions for Geode tickets?  I can only edit
> > > mine
> > > > > and I'd like to reword some descriptions etc on other tickets.  I'd
> > > also
> > > > > like to edit some wikis if needed.
> > > > >
> > > > > Both ASF and JIRA IDs are fkrone.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > -Fred
> > > > >
> > > >
> > >
> >
>

Re: Requesting wiki edit privileges

[Dan Smith]

I added you, you should have access now.

Thanks!
-Dan

On Wed, Jul 12, 2017 at 10:12 AM, Diane Hardman  wrote:

> Will someone please give me edit privileges for Geode wiki pages?
>
> Thanks!
> Diane Hardman
>

Re: Requesting edit permissions for Geode tickets

[Fred Krone]

I don't think I have access. I thought I did.  fkrone ?

On Wed, Jul 12, 2017 at 2:36 PM, Dan Smith  wrote:

> Hi Fred,
>
> What's your username on the wiki?
>
> -Dan
>
> On Wed, Jul 12, 2017 at 11:32 AM, Fred Krone  wrote:
>
> > Could someone give me karma on the wiki?
> >
> > Thanks,
> > -Fred
> >
> > On Thu, Mar 30, 2017 at 1:20 PM, Kirk Lund  wrote:
> >
> > > I gave you permissions for Jira. Someone else still needs to give you
> > karma
> > > on the Wiki.
> > >
> > > -Kirk
> > >
> > > On Thu, Mar 30, 2017 at 9:22 AM, Fred Krone  wrote:
> > >
> > > > Hi,
> > > >
> > > > Could I get editing permissions for Geode tickets?  I can only edit
> > mine
> > > > and I'd like to reword some descriptions etc on other tickets.  I'd
> > also
> > > > like to edit some wikis if needed.
> > > >
> > > > Both ASF and JIRA IDs are fkrone.
> > > >
> > > > Thanks,
> > > >
> > > > -Fred
> > > >
> > >
> >
>

Re: Requesting edit permissions for Geode tickets

[Dan Smith]

Hi Fred,

What's your username on the wiki?

-Dan

On Wed, Jul 12, 2017 at 11:32 AM, Fred Krone  wrote:

> Could someone give me karma on the wiki?
>
> Thanks,
> -Fred
>
> On Thu, Mar 30, 2017 at 1:20 PM, Kirk Lund  wrote:
>
> > I gave you permissions for Jira. Someone else still needs to give you
> karma
> > on the Wiki.
> >
> > -Kirk
> >
> > On Thu, Mar 30, 2017 at 9:22 AM, Fred Krone  wrote:
> >
> > > Hi,
> > >
> > > Could I get editing permissions for Geode tickets?  I can only edit
> mine
> > > and I'd like to reword some descriptions etc on other tickets.  I'd
> also
> > > like to edit some wikis if needed.
> > >
> > > Both ASF and JIRA IDs are fkrone.
> > >
> > > Thanks,
> > >
> > > -Fred
> > >
> >
>

[GitHub] geode pull request #625: GEODE-1988: Increased the readTimeout

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/625


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Michael Stolz]

We removed error feedback?
So how is an application programmer supposed to determine what failed now?
Without that information we may have rendered putAll unusable for some
cases.

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: +1-631-835-4771

On Wed, Jul 12, 2017 at 1:45 PM, Brian Rowe  wrote:

>
>
> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > > geode-protobuf/src/main/java/org/apache/geode/protocol/
> protobuf/operations/PutAllRequestOperationHandler.java
> > > Lines 81 (patched)
> > >  file1771594line81>
> > >
> > > I'm sure that we can use `region.putAll(entries)` for this.
>
> Fixed.  This also resulted in us not being able to determine the state of
> a partially succeeded PutAll, so we updated the PutAllResponse to remove
> the failedKeys field.
>
>
> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > > geode-protobuf/src/main/java/org/apache/geode/protocol/
> protobuf/utilities/ProtobufRequestUtilities.java
> > > Lines 76 (patched)
> > >  file1771595line76>
> > >
> > > maybe this variable name should be `getAllRequestBuilder`... not
> advocate of generic `builder`
>
> Fixed
>
>
> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > > geode-protobuf/src/main/java/org/apache/geode/protocol/
> protobuf/utilities/ProtobufRequestUtilities.java
> > > Lines 78-80 (patched)
> > >  file1771595line78>
> > >
> > > Could we replace this with `addAllKey(java.lang.Iterable extends org.apache.geode.protocol.protobuf.BasicTypes.EncodedValue>
> values)`
>
> Nice, good catch.
>
>
> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > > geode-protobuf/src/main/java/org/apache/geode/protocol/
> protobuf/utilities/ProtobufRequestUtilities.java
> > > Lines 95-97 (patched)
> > >  file1771595line95>
> > >
> > > Could we replace this with `addAllEntry(java.lang.Iterable extends org.apache.geode.protocol.protobuf.BasicTypes.Entry> values)`
>
> Fixed
>
>
> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > > geode-protobuf/src/main/java/org/apache/geode/protocol/
> protobuf/utilities/ProtobufResponseUtilities.java
> > > Lines 125-127 (patched)
> > >  file1771596line125>
> > >
> > > Could we replace this with `addAllEntries(java.lang.Iterable extends org.apache.geode.protocol.protobuf.BasicTypes.Entry> values)`
>
> Fixed
>
>
> > On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > > geode-protobuf/src/main/java/org/apache/geode/protocol/
> protobuf/utilities/ProtobufResponseUtilities.java
> > > Lines 141-143 (patched)
> > >  file1771596line141>
> > >
> > > could we possibly use `addAllFailedKeys(java.lang.Iterable extends org.apache.geode.protocol.protobuf.BasicTypes.EncodedValue>
> values)`
>
> This got removed with the failed keys field.
>
>
> - Brian
>
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/#review179967
> ---
>
>
> On July 7, 2017, 9:18 p.m., Brian Rowe wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/60718/
> > ---
> >
> > (Updated July 7, 2017, 9:18 p.m.)
> >
> >
> > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> >
> >
> > Bugs: GEODE-2997
> > https://issues.apache.org/jira/browse/GEODE-2997
> >
> >
> > Repository: geode
> >
> >
> > Description
> > ---
> >
> > Changed get response to indicate if LookupFailure was a missing key or
> key with null value, added test
> > Added GetAllRequestOperationHandler and unit test
> > Added PutAllRequestOperationHandler and unit test
> > Added an integration test covering the putAll and getAll operations
> >
> >
> > Diffs
> > -
> >
> >   
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
> ebd5c6a0a
> >   geode-protobuf/src/main/java/org/apache/geode/protocol/
> protobuf/operations/GetAllRequestOperationHandler.java PRE-CREATION
> >   geode-protobuf/src/main/java/org/apache/geode/protocol/
> protobuf/operations/PutAllRequestOperationHandler.java PRE-CREATION
> >   geode-protobuf/src/main/java/org/apache/geode/protocol/
> protobuf/utilities/ProtobufRequestUtilities.java b96f478d1
> >   geode-protobuf/src/main/java/org/apache/geode/protocol/
> protobuf/utilities/ProtobufResponseUtilities.java 2114fdbf7
> >   geode-protobuf/src/main/java/org/apache/geode/protocol/
> 

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/
---

(Updated July 12, 2017, 6:01 p.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-2997
https://issues.apache.org/jira/browse/GEODE-2997


Repository: geode


Description
---

Changed get response to indicate if LookupFailure was a missing key or key with 
null value, added test
Added GetAllRequestOperationHandler and unit test
Added PutAllRequestOperationHandler and unit test
Added an integration test covering the putAll and getAll operations


Diffs (updated)
-

  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
 714639274 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
 b246a501b 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
 d6ef2788e 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
 924979329 
  geode-protobuf/src/main/proto/region_API.proto 3108cb7c3 
  geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
fee9448af 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 612b9c9a4 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
 PRE-CREATION 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
 b7d52019e 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60718/diff/2/

Changes: https://reviews.apache.org/r/60718/diff/1-2/


Testing
---

Added unit tests for new operation handlers
Added integration test covering new operations


Thanks,

Brian Rowe

Re: Requesting edit permissions for Geode tickets

[Fred Krone]

Could someone give me karma on the wiki?

Thanks,
-Fred

On Thu, Mar 30, 2017 at 1:20 PM, Kirk Lund  wrote:

> I gave you permissions for Jira. Someone else still needs to give you karma
> on the Wiki.
>
> -Kirk
>
> On Thu, Mar 30, 2017 at 9:22 AM, Fred Krone  wrote:
>
> > Hi,
> >
> > Could I get editing permissions for Geode tickets?  I can only edit mine
> > and I'd like to reword some descriptions etc on other tickets.  I'd also
> > like to edit some wikis if needed.
> >
> > Both ASF and JIRA IDs are fkrone.
> >
> > Thanks,
> >
> > -Fred
> >
>

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/
---

(Updated July 12, 2017, 6:27 p.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Changes
---

Incorporated all feedback and updated ErrorResponse.


Bugs: GEODE-2997
https://issues.apache.org/jira/browse/GEODE-2997


Repository: geode


Description
---

Changed get response to indicate if LookupFailure was a missing key or key with 
null value, added test
Added GetAllRequestOperationHandler and unit test
Added PutAllRequestOperationHandler and unit test
Added an integration test covering the putAll and getAll operations


Diffs (updated)
-

  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
 714639274 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
 13b156f99 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
 fecf01d7b 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
 e1fef85b4 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
 b246a501b 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
 d6ef2788e 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
 924979329 
  geode-protobuf/src/main/proto/clientProtocol.proto d94c0f312 
  geode-protobuf/src/main/proto/region_API.proto 3108cb7c3 
  geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
fee9448af 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 612b9c9a4 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
 PRE-CREATION 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
 b7d52019e 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60718/diff/4/

Changes: https://reviews.apache.org/r/60718/diff/3-4/


Testing
---

Added unit tests for new operation handlers
Added integration test covering new operations


Thanks,

Brian Rowe

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/
---

(Updated July 12, 2017, 6:23 p.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-2997
https://issues.apache.org/jira/browse/GEODE-2997


Repository: geode


Description
---

Changed get response to indicate if LookupFailure was a missing key or key with 
null value, added test
Added GetAllRequestOperationHandler and unit test
Added PutAllRequestOperationHandler and unit test
Added an integration test covering the putAll and getAll operations


Diffs (updated)
-

  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
 714639274 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
 b246a501b 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
 d6ef2788e 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
 924979329 
  geode-protobuf/src/main/proto/region_API.proto 3108cb7c3 
  geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
fee9448af 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 612b9c9a4 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
 PRE-CREATION 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
 b7d52019e 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60718/diff/3/

Changes: https://reviews.apache.org/r/60718/diff/2-3/


Testing
---

Added unit tests for new operation handlers
Added integration test covering new operations


Thanks,

Brian Rowe

Re: Review Request 60808: GEODE-3178 Fix a flaky JTA test

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60808/#review180325
---




geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
Lines 107 (patched)


exceptionLogged?


- anilkumar gingade


On July 12, 2017, 5:12 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60808/
> ---
> 
> (Updated July 12, 2017, 5:12 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Nick Reich.
> 
> 
> Bugs: GEODE-3178
> https://issues.apache.org/jira/browse/GEODE-3178
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Test now will retry until TX locks are released.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
>  ddf08d0 
> 
> 
> Diff: https://reviews.apache.org/r/60808/diff/1/
> 
> 
> Testing
> ---
> 
> UnitTest.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

[GitHub] geode pull request #626: GEODE-3179: Fixing bundled jars test finding slf4j-...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/626


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Brian Rowe]

> On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
> > Lines 81 (patched)
> > 
> >
> > I'm sure that we can use `region.putAll(entries)` for this.

Fixed.  This also resulted in us not being able to determine the state of a 
partially succeeded PutAll, so we updated the PutAllResponse to remove the 
failedKeys field.


> On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
> > Lines 76 (patched)
> > 
> >
> > maybe this variable name should be `getAllRequestBuilder`... not 
> > advocate of generic `builder`

Fixed


> On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
> > Lines 78-80 (patched)
> > 
> >
> > Could we replace this with `addAllKey(java.lang.Iterable > org.apache.geode.protocol.protobuf.BasicTypes.EncodedValue> values)`

Nice, good catch.


> On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
> > Lines 95-97 (patched)
> > 
> >
> > Could we replace this with `addAllEntry(java.lang.Iterable > org.apache.geode.protocol.protobuf.BasicTypes.Entry> values)`

Fixed


> On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
> > Lines 125-127 (patched)
> > 
> >
> > Could we replace this with `addAllEntries(java.lang.Iterable > org.apache.geode.protocol.protobuf.BasicTypes.Entry> values)`

Fixed


> On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
> > Lines 141-143 (patched)
> > 
> >
> > could we possibly use `addAllFailedKeys(java.lang.Iterable > org.apache.geode.protocol.protobuf.BasicTypes.EncodedValue> values)`

This got removed with the failed keys field.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review179967
---


On July 7, 2017, 9:18 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
> 
> (Updated July 7, 2017, 9:18 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2997
> https://issues.apache.org/jira/browse/GEODE-2997
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed get response to indicate if LookupFailure was a missing key or key 
> with null value, added test
> Added GetAllRequestOperationHandler and unit test
> Added PutAllRequestOperationHandler and unit test
> Added an integration test covering the putAll and getAll operations
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  ebd5c6a0a 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
>  b96f478d1 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
>  2114fdbf7 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
>  924979329 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  31a873658 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
>  b7d52019e 
>   
> 

Proposal: Lucene indexing/searching for nested objects

[Diane Hardman]

The Geode 1.2.0 release includes Lucene text search fully integrated and
tested (no longer experimental). We are now proposing enhancements to
improve Lucene usability in Geode.

Some Geode users create data models that include nested and complex
objects. The current Geode Lucene integration supports indexing and
querying only the top-level fields in the data object. The objective of
this proposal is to support indexing and querying an arbitrary depth of
nested objects.


Please review the proposal in the following wiki page and give us your
feedback.

https://cwiki.apache.org/confluence/display/GEODE/Lucene+Text+Search+on+Nested+Object

[GitHub] geode pull request #627: GEODE-3194: cleanup disk store on failed initial re...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/627


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #626: GEODE-3179: Fixing bundled jars test finding slf4j-jdk jar

[upthewaterspout]

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/626
  
+1 I'll merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60808: GEODE-3178 Fix a flaky JTA test

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60808/#review180320
---


Ship it!




Ship It!

- Darrel Schneider


On July 12, 2017, 10:12 a.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60808/
> ---
> 
> (Updated July 12, 2017, 10:12 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Nick Reich.
> 
> 
> Bugs: GEODE-3178
> https://issues.apache.org/jira/browse/GEODE-3178
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Test now will retry until TX locks are released.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
>  ddf08d0 
> 
> 
> Diff: https://reviews.apache.org/r/60808/diff/1/
> 
> 
> Testing
> ---
> 
> UnitTest.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Requesting wiki edit privileges

[Diane Hardman]

Will someone please give me edit privileges for Geode wiki pages?

Thanks!
Diane Hardman

Review Request 60808: GEODE-3178 Fix a flaky JTA test

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60808/
---

Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
and Nick Reich.


Bugs: GEODE-3178
https://issues.apache.org/jira/browse/GEODE-3178


Repository: geode


Description
---

Test now will retry until TX locks are released.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
 ddf08d0 


Diff: https://reviews.apache.org/r/60808/diff/1/


Testing
---

UnitTest.


Thanks,

Eric Shu

[GitHub] geode issue #626: GEODE-3179: Fixing bundled jars test finding slf4j-jdk jar

[DivineEnder]

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/626
  
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #627: GEODE-3194: cleanup disk store on failed initial recovery

[dschneider-pivotal]

Github user dschneider-pivotal commented on the issue:

https://github.com/apache/geode/pull/627
  
This looks good. I will pull it in.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #627: GEODE-3194: cleanup disk store on failed initial re...

[nreich]

GitHub user nreich opened a pull request:

https://github.com/apache/geode/pull/627

GEODE-3194: cleanup disk store on failed initial recovery

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [NA] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nreich/geode feature/GEODE-3194

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/627.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #627


commit dc59af8721654a6fcaff3ad0bce80e390746fab3
Author: Nick Reich 
Date:   2017-07-12T16:54:07Z

GEODE-3194: cleanup disk store on failed initial recovery




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #894

[Apache Jenkins Server]

See 


Changes:

[bschuchardt] GEODE-3175 backward-compatibility tests fail with bad classpath

[hkhamesra] GEODE-2998: Add remove operation

[ukohlmeyer] GEODE-3121: ensure that the protobuf protocol works over SSL

[ukohlmeyer] GEODE-3121: Merge due to rebase. This now closes #612

[hkhamesra] GEODE-3121 Applied spotless

[nnag] GEODE-1731: Modifying region size check to be more accurate

--
[...truncated 174.82 KB...]
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJava
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.4.1/lucene-test-framework-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.4.1/lucene-codecs-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-analyzers-phonetic/6.4.1/lucene-analyzers-phonetic-6.4.1.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.4.0/randomizedtesting-runner-2.4.0.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-parent/2.4.0/randomizedtesting-parent-2.4.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.4.1/lucene-test-framework-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.4.1/lucene-codecs-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-analyzers-phonetic/6.4.1/lucene-analyzers-phonetic-6.4.1.jar
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.4.0/randomizedtesting-runner-2.4.0.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-protobuf:assemble
:geode-protobuf:extractIncludeTestProto
Download 
https://repo1.maven.org/maven2/org/powermock/powermock-api-mockito/1.7.0RC4/powermock-api-mockito-1.7.0RC4.pom
Download 
https://repo1.maven.org/maven2/org/powermock/powermock-api-mockito/1.7.0RC4/powermock-api-mockito-1.7.0RC4.jar
:geode-protobuf:extractTestProto
:geode-protobuf:generateTestProto UP-TO-DATE
:geode-protobuf:compileTestJavaNote: Some input files use unchecked or unsafe 
operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-protobuf:processTestResources
:geode-protobuf:testClasses
:geode-protobuf:checkMissedTests
:geode-protobuf:spotlessJavaCheck
:geode-protobuf:spotlessCheck
:geode-protobuf:test
:geode-protobuf:check
:geode-protobuf:build
:geode-protobuf:distributedTest
:geode-protobuf:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJava
Download 
https://repo1.maven.org/maven2/com/codeborne/phantomjsdriver/1.3.0/phantomjsdriver-1.3.0.pom
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-api/3.0.1/selenium-api-3.0.1.pom
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-remote-driver/3.0.1/selenium-remote-driver-3.0.1.pom
Download 

[GitHub] geode pull request #626: GEODE-3179: Fixing bundled jars test finding slf4j-...

[DivineEnder]

GitHub user DivineEnder opened a pull request:

https://github.com/apache/geode/pull/626

GEODE-3179: Fixing bundled jars test finding slf4j-jdk jar

This fixes the failing verify bundled jars test, caused by an unexpected 
slf4j-jdk jar coming from the tomcat module folder when extracted.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DivineEnder/geode feature/GEODE-3179

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/626.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #626


commit b662c9b08537ebffadf3427f616f6aad5f2a8daf
Author: David Anuta 
Date:   2017-07-10T23:40:07Z

GEODE-3179: Changed extract directory of the Tomcat module

This fixes the failing verify bundled jars test, caused by an unexpected 
slf4j-jdk jar coming from the tomcat module folder when extracted.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-release-flaky #27

[Apache Jenkins Server]

See 

--
[...truncated 90.00 KB...]
Download 
https://repo1.maven.org/maven2/org/springframework/security/spring-security-config/4.2.1.RELEASE/spring-security-config-4.2.1.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/spring-framework-bom/4.3.5.RELEASE/spring-framework-bom-4.3.5.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/security/spring-security-ldap/4.2.1.RELEASE/spring-security-ldap-4.2.1.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/security/spring-security-web/4.2.1.RELEASE/spring-security-web-4.2.1.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/spring-tx/4.3.6.RELEASE/spring-tx-4.3.6.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/security/spring-security-core/4.2.1.RELEASE/spring-security-core-4.2.1.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/ldap/spring-ldap-core/2.3.1.RELEASE/spring-ldap-core-2.3.1.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/security/spring-security-config/4.2.1.RELEASE/spring-security-config-4.2.1.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/security/spring-security-ldap/4.2.1.RELEASE/spring-security-ldap-4.2.1.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/security/spring-security-web/4.2.1.RELEASE/spring-security-web-4.2.1.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/spring-tx/4.3.6.RELEASE/spring-tx-4.3.6.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/security/spring-security-core/4.2.1.RELEASE/spring-security-core-4.2.1.RELEASE.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-pulse:copyGemFireVersionFile
:geode-pulse:processResources
:geode-pulse:classes
:geode-rebalancer:compileJava
:geode-rebalancer:processResources UP-TO-DATE
:geode-rebalancer:classes
:geode-wan:compileJava
:geode-wan:processResources
:geode-wan:classes
:geode-web:compileJava UP-TO-DATE
:geode-web:processResources UP-TO-DATE
:geode-web:classes UP-TO-DATE
:geode-web-api:compileJava
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-scala_2.10/2.8.6/jackson-module-scala_2.10-2.8.6.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger2/2.6.1/springfox-swagger2-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-ui/2.6.1/springfox-swagger-ui-2.6.1.pom
Download 
https://repo1.maven.org/maven2/org/springframework/hateoas/spring-hateoas/0.23.0.RELEASE/spring-hateoas-0.23.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-paranamer/2.8.6/jackson-module-paranamer-2.8.6.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-modules-base/2.8.6/jackson-modules-base-2.8.6.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-bom/2.8.6/jackson-bom-2.8.6.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spi/2.6.1/springfox-spi-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-schema/2.6.1/springfox-schema-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-common/2.6.1/springfox-swagger-common-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spring-web/2.6.1/springfox-spring-web-2.6.1.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/classmate/1.3.1/classmate-1.3.1.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-core/1.2.0.RELEASE/spring-plugin-core-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin/1.2.0.RELEASE/spring-plugin-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-metadata/1.2.0.RELEASE/spring-plugin-metadata-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct/1.0.0.Final/mapstruct-1.0.0.Final.pom
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct-parent/1.0.0.Final/mapstruct-parent-1.0.0.Final.pom
Download 
https://repo1.maven.org/maven2/com/thoughtworks/paranamer/paranamer/2.8/paranamer-2.8.pom
Download 
https://repo1.maven.org/maven2/com/thoughtworks/paranamer/paranamer-parent/2.8/paranamer-parent-2.8.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-core/2.6.1/springfox-core-2.6.1.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-scala_2.10/2.8.6/jackson-module-scala_2.10-2.8.6.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger2/2.6.1/springfox-swagger2-2.6.1.jar
Download 

[VOTE] Apache Geode release - v1.2.0 RC2

[Anthony Baker]

This is the second release candidate for Apache Geode, version 1.2.0.
Thanks to all the community members for their contributions to this
release!  This release candidate fixes a number of backwards compatibility
and rolling upgrade issues found in RC1.

*** Please download, test and vote by Saturday, July 15, 0800 hrs
US Pacific. ***

It fixes the following issues:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12339257

Note that we are voting upon the source tags:  rel/v1.2.0.RC2

https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=964f2749065ce9c6898fd27983b43f1bd9fc77d0

https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;a=commit;h=7f93d95ad06a6f2afee54312585f48435fff11e8

Commit ID:
  7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
  7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)

Source and binary files:
  https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2

Maven staging repo:
  https://repository.apache.org/content/repositories/orgapachegeode-1020

Geode's KEYS file containing PGP keys we use to sign the release:

https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_plain;f=KEYS;hb=HEAD

pub  4096R/C72CFB64 2015-10-01
  Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64

Anthony

Re: Geode-Native Windows build

[Jacob Barrett]

While we wait for your config output there is something else that might bite 
you if it isn't what is biting you now. Some of the third part libraries built 
as part of Geode native have deep directory structures. Your deep directory 
structure to your sources combine with that may result in paths over the 
windows limit. 

Consider using something more shallow on windows, like C:\build. Your source 
can be anywhere since CMake builds are outside the source tree.

-Jake


Sent from my iPhone

> On Jul 12, 2017, at 6:52 AM, Daniel Farcovich  
> wrote:
> 
> Hi,
> I'm failing to build geode native cpp client on windows, although followed 
> the instructions on BUILDING.md
> Looks like there are slash/backslash fixes should be done in the paths in 
> cmake files.
> After overcoming cmake  failures the build fails on stage "cmake --build . -- 
> /m" with compilation errors for example:
> 
> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
>  error C2144: syntax error : 'bool' should be preceded by ';' 
> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>   cpp) 
> [C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode-static.vcxproj]
> 
> 4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
>  error C2144: syntax error : 'bool' should be preceded by ';' 
> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>   cpp) 
> [C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode.vcxproj]
>31>ClCompile:
> 
> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(61)
>  : see reference to class template instantiation 
> 'apache::geode::client::dereference_equal_to>' being 
> compiled
> 4>ClCompile:
> 
> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(61)
>  : see reference to class template instantiation 
> 'apache::geode::client::dereference_equal_to>' being 
> compiled
>
> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
>  error C4430: missing type specifier - int assumed. Note: C++ does not 
> support default-int (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppc
>   ache\src\FunctionServiceImpl.cpp) 
> [C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode-static.vcxproj]
> 
> 4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
>  error C4430: missing type specifier - int assumed. Note: C++ does not 
> support default-int (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppc
>   ache\src\FunctionServiceImpl.cpp) 
> [C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode.vcxproj]
>
> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(67):
>  error C2144: syntax error : 'bool' should be preceded by ';' 
> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>   cpp) 
> [C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode-static.vcxproj]
> 
> 4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(67):
>  error C2144: syntax error : 'bool' should be preceded by ';' 
> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>   cpp) 
> [C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode.vcxproj]
>31>ClCompile:
> 
> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(71)
>  : see reference to class template instantiation 
> 'apache::geode::client::dereference_equal_to<_T*>' being compiled
> 4>ClCompile:
> 
> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(71)
>  : see reference to class template instantiation 
> 'apache::geode::client::dereference_equal_to<_T*>' being compiled
> 
> 
> Is the windows native client build stable?
> 
> Thanks,
> Daniel
> 
> This message and the information contained herein is proprietary and 
> confidential and subject to the Amdocs policy statement,
> 
> you may review at https://www.amdocs.com/about/email-disclaimer 
> 

Re: Geode-Native Windows build

[Jacob Barrett]

And output from the config phase.

Sent from my iPhone

> On Jul 12, 2017, at 7:01 AM, Ernest Burghardt  wrote:
> 
> Hi Daniel,
> 
> Would you please share your config step command line?
> 
> EB
> 
> On Wed, Jul 12, 2017 at 7:52 AM, Daniel Farcovich <
> daniel.farcov...@amdocs.com> wrote:
> 
>> Hi,
>> I'm failing to build geode native cpp client on windows, although followed
>> the instructions on BUILDING.md
>> Looks like there are slash/backslash fixes should be done in the paths in
>> cmake files.
>> After overcoming cmake  failures the build fails on stage "cmake --build .
>> -- /m" with compilation errors for example:
>> 
>> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
>> cppcache\include\geode/utils.hpp(57): error C2144: syntax error : 'bool'
>> should be preceded by ';' (C:\Users\Fdaniel\Source\
>> Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>>   cpp) [C:\Users\Fdaniel\Source\Repos\geode-native2\build\
>> cppcache\src\apache-geode-static.vcxproj]
>> 4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
>> cppcache\include\geode/utils.hpp(57): error C2144: syntax error : 'bool'
>> should be preceded by ';' (C:\Users\Fdaniel\Source\
>> Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>>   cpp) [C:\Users\Fdaniel\Source\Repos\geode-native2\build\
>> cppcache\src\apache-geode.vcxproj]
>>31>ClCompile:
>> 
>> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(61)
>> : see reference to class template instantiation 'apache::geode::client::
>> dereference_equal_to>' being compiled
>> 4>ClCompile:
>> 
>> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(61)
>> : see reference to class template instantiation 'apache::geode::client::
>> dereference_equal_to>' being compiled
>>31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
>> cppcache\include\geode/utils.hpp(57): error C4430: missing type specifier
>> - int assumed. Note: C++ does not support default-int
>> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppc
>>   ache\src\FunctionServiceImpl.cpp) [C:\Users\Fdaniel\Source\
>> Repos\geode-native2\build\cppcache\src\apache-geode-static.vcxproj]
>> 4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
>> cppcache\include\geode/utils.hpp(57): error C4430: missing type specifier
>> - int assumed. Note: C++ does not support default-int
>> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppc
>>   ache\src\FunctionServiceImpl.cpp) [C:\Users\Fdaniel\Source\
>> Repos\geode-native2\build\cppcache\src\apache-geode.vcxproj]
>>31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
>> cppcache\include\geode/utils.hpp(67): error C2144: syntax error : 'bool'
>> should be preceded by ';' (C:\Users\Fdaniel\Source\
>> Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>>   cpp) [C:\Users\Fdaniel\Source\Repos\geode-native2\build\
>> cppcache\src\apache-geode-static.vcxproj]
>> 4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
>> cppcache\include\geode/utils.hpp(67): error C2144: syntax error : 'bool'
>> should be preceded by ';' (C:\Users\Fdaniel\Source\
>> Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>>   cpp) [C:\Users\Fdaniel\Source\Repos\geode-native2\build\
>> cppcache\src\apache-geode.vcxproj]
>>31>ClCompile:
>> 
>> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(71)
>> : see reference to class template instantiation 
>> 'apache::geode::client::dereference_equal_to<_T*>'
>> being compiled
>> 4>ClCompile:
>> 
>> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(71)
>> : see reference to class template instantiation 
>> 'apache::geode::client::dereference_equal_to<_T*>'
>> being compiled
>> 
>> 
>> Is the windows native client build stable?
>> 
>> Thanks,
>> Daniel
>> 
>> This message and the information contained herein is proprietary and
>> confidential and subject to the Amdocs policy statement,
>> 
>> you may review at https://www.amdocs.com/about/email-disclaimer <
>> https://www.amdocs.com/about/email-disclaimer>
>> 

Re: Geode-Native Windows build

[Ernest Burghardt]

Hi Daniel,

Would you please share your config step command line?

EB

On Wed, Jul 12, 2017 at 7:52 AM, Daniel Farcovich <
daniel.farcov...@amdocs.com> wrote:

> Hi,
> I'm failing to build geode native cpp client on windows, although followed
> the instructions on BUILDING.md
> Looks like there are slash/backslash fixes should be done in the paths in
> cmake files.
> After overcoming cmake  failures the build fails on stage "cmake --build .
> -- /m" with compilation errors for example:
>
> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
> cppcache\include\geode/utils.hpp(57): error C2144: syntax error : 'bool'
> should be preceded by ';' (C:\Users\Fdaniel\Source\
> Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>cpp) [C:\Users\Fdaniel\Source\Repos\geode-native2\build\
> cppcache\src\apache-geode-static.vcxproj]
>  4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
> cppcache\include\geode/utils.hpp(57): error C2144: syntax error : 'bool'
> should be preceded by ';' (C:\Users\Fdaniel\Source\
> Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>cpp) [C:\Users\Fdaniel\Source\Repos\geode-native2\build\
> cppcache\src\apache-geode.vcxproj]
> 31>ClCompile:
>  
> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(61)
> : see reference to class template instantiation 'apache::geode::client::
> dereference_equal_to>' being compiled
>  4>ClCompile:
>  
> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(61)
> : see reference to class template instantiation 'apache::geode::client::
> dereference_equal_to>' being compiled
> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
> cppcache\include\geode/utils.hpp(57): error C4430: missing type specifier
> - int assumed. Note: C++ does not support default-int
> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppc
>ache\src\FunctionServiceImpl.cpp) [C:\Users\Fdaniel\Source\
> Repos\geode-native2\build\cppcache\src\apache-geode-static.vcxproj]
>  4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
> cppcache\include\geode/utils.hpp(57): error C4430: missing type specifier
> - int assumed. Note: C++ does not support default-int
> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppc
>ache\src\FunctionServiceImpl.cpp) [C:\Users\Fdaniel\Source\
> Repos\geode-native2\build\cppcache\src\apache-geode.vcxproj]
> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
> cppcache\include\geode/utils.hpp(67): error C2144: syntax error : 'bool'
> should be preceded by ';' (C:\Users\Fdaniel\Source\
> Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>cpp) [C:\Users\Fdaniel\Source\Repos\geode-native2\build\
> cppcache\src\apache-geode-static.vcxproj]
>  4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\
> cppcache\include\geode/utils.hpp(67): error C2144: syntax error : 'bool'
> should be preceded by ';' (C:\Users\Fdaniel\Source\
> Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>cpp) [C:\Users\Fdaniel\Source\Repos\geode-native2\build\
> cppcache\src\apache-geode.vcxproj]
> 31>ClCompile:
>  
> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(71)
> : see reference to class template instantiation 
> 'apache::geode::client::dereference_equal_to<_T*>'
> being compiled
>  4>ClCompile:
>  
> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(71)
> : see reference to class template instantiation 
> 'apache::geode::client::dereference_equal_to<_T*>'
> being compiled
>
>
> Is the windows native client build stable?
>
> Thanks,
> Daniel
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
>

Geode-Native Windows build

[Daniel Farcovich]

Hi,
I'm failing to build geode native cpp client on windows, although followed the 
instructions on BUILDING.md
Looks like there are slash/backslash fixes should be done in the paths in cmake 
files.
After overcoming cmake  failures the build fails on stage "cmake --build . -- 
/m" with compilation errors for example:

31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
 error C2144: syntax error : 'bool' should be preceded by ';' 
(C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
   cpp) 
[C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode-static.vcxproj]
 
4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
 error C2144: syntax error : 'bool' should be preceded by ';' 
(C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
   cpp) 
[C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode.vcxproj]
31>ClCompile:
 
C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(61)
 : see reference to class template instantiation 
'apache::geode::client::dereference_equal_to>' being 
compiled
 4>ClCompile:
 
C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(61)
 : see reference to class template instantiation 
'apache::geode::client::dereference_equal_to>' being 
compiled

31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
 error C4430: missing type specifier - int assumed. Note: C++ does not support 
default-int (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppc
   ache\src\FunctionServiceImpl.cpp) 
[C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode-static.vcxproj]
 
4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
 error C4430: missing type specifier - int assumed. Note: C++ does not support 
default-int (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppc
   ache\src\FunctionServiceImpl.cpp) 
[C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode.vcxproj]

31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(67):
 error C2144: syntax error : 'bool' should be preceded by ';' 
(C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
   cpp) 
[C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode-static.vcxproj]
 
4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(67):
 error C2144: syntax error : 'bool' should be preceded by ';' 
(C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
   cpp) 
[C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode.vcxproj]
31>ClCompile:
 
C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(71)
 : see reference to class template instantiation 
'apache::geode::client::dereference_equal_to<_T*>' being compiled
 4>ClCompile:
 
C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(71)
 : see reference to class template instantiation 
'apache::geode::client::dereference_equal_to<_T*>' being compiled


Is the windows native client build stable?

Thanks,
Daniel

This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at https://www.amdocs.com/about/email-disclaimer 

Jenkins build is back to normal : Geode-release #78

[Apache Jenkins Server]

See