Re: Adding GEODE-7412 to 1.11 release

2019-11-08 Thread Udo Kohlmeyer

@Mark,

@Robert is working on this change... I will leave it to him to provide 
the SHA.


--Udi

On 11/8/19 3:35 PM, Mark Hanson wrote:

Hi,

Can someone give me a known good sha?

I will add it in.

Thanks,
Mark


On Nov 8, 2019, at 2:20 PM, Jens Deppe  wrote:

Hmm, I thought this was implicitly fixed by various build refactorings that
went into 1.11.0. I see that we're creating local maven artifacts for
geode-pulse-1.11.0.war. The next question is then whether we're actually
publishing those.

--Jens

On Fri, Nov 8, 2019 at 12:56 PM Owen Nichols  wrote:


+1


On Nov 8, 2019, at 12:54 PM, Udo Kohlmeyer  wrote:

@Owen,

I did not specifically check all web archives for this issue. Yes, I

*should* have been caught in that ticket.

On 11/8/19 11:03 AM, Owen Nichols wrote:

I’m curious, how was this missed in

https://issues.apache.org/jira/browse/GEODE-7241 <
https://issues.apache.org/jira/browse/GEODE-7241> ?

On Nov 8, 2019, at 10:56 AM, Udo Kohlmeyer  wrote:

Hi there Geode Dev,

I would like to request that we add

https://issues.apache.org/jira/browse/GEODE-7412 <
https://issues.apache.org/jira/browse/GEODE-7412> to the 1.11 release.

This change is a build change that has crept in since 1.8. The issue

that is to be fixed is that the web archive, (geode-pulse) has since 1.8
been uploaded as a jar file to maven central.

I would like to fix this by having the WAR artifact being pushed to

maven central again.

--Udo





Re: Adding GEODE-7412 to 1.11 release

2019-11-08 Thread Mark Hanson
Hi,

Can someone give me a known good sha?

I will add it in.

Thanks,
Mark

> On Nov 8, 2019, at 2:20 PM, Jens Deppe  wrote:
> 
> Hmm, I thought this was implicitly fixed by various build refactorings that
> went into 1.11.0. I see that we're creating local maven artifacts for
> geode-pulse-1.11.0.war. The next question is then whether we're actually
> publishing those.
> 
> --Jens
> 
> On Fri, Nov 8, 2019 at 12:56 PM Owen Nichols  wrote:
> 
>> +1
>> 
>>> On Nov 8, 2019, at 12:54 PM, Udo Kohlmeyer  wrote:
>>> 
>>> @Owen,
>>> 
>>> I did not specifically check all web archives for this issue. Yes, I
>> *should* have been caught in that ticket.
>>> 
>>> On 11/8/19 11:03 AM, Owen Nichols wrote:
 I’m curious, how was this missed in
>> https://issues.apache.org/jira/browse/GEODE-7241 <
>> https://issues.apache.org/jira/browse/GEODE-7241> ?
 
> On Nov 8, 2019, at 10:56 AM, Udo Kohlmeyer  wrote:
> 
> Hi there Geode Dev,
> 
> I would like to request that we add
>> https://issues.apache.org/jira/browse/GEODE-7412 <
>> https://issues.apache.org/jira/browse/GEODE-7412> to the 1.11 release.
> 
> This change is a build change that has crept in since 1.8. The issue
>> that is to be fixed is that the web archive, (geode-pulse) has since 1.8
>> been uploaded as a jar file to maven central.
> 
> I would like to fix this by having the WAR artifact being pushed to
>> maven central again.
> 
> --Udo
> 
 
>> 
>> 



Re: Adding GEODE-7412 to 1.11 release

2019-11-08 Thread Jens Deppe
Hmm, I thought this was implicitly fixed by various build refactorings that
went into 1.11.0. I see that we're creating local maven artifacts for
geode-pulse-1.11.0.war. The next question is then whether we're actually
publishing those.

--Jens

On Fri, Nov 8, 2019 at 12:56 PM Owen Nichols  wrote:

> +1
>
> > On Nov 8, 2019, at 12:54 PM, Udo Kohlmeyer  wrote:
> >
> > @Owen,
> >
> > I did not specifically check all web archives for this issue. Yes, I
> *should* have been caught in that ticket.
> >
> > On 11/8/19 11:03 AM, Owen Nichols wrote:
> >> I’m curious, how was this missed in
> https://issues.apache.org/jira/browse/GEODE-7241 <
> https://issues.apache.org/jira/browse/GEODE-7241> ?
> >>
> >>> On Nov 8, 2019, at 10:56 AM, Udo Kohlmeyer  wrote:
> >>>
> >>> Hi there Geode Dev,
> >>>
> >>> I would like to request that we add
> https://issues.apache.org/jira/browse/GEODE-7412 <
> https://issues.apache.org/jira/browse/GEODE-7412> to the 1.11 release.
> >>>
> >>> This change is a build change that has crept in since 1.8. The issue
> that is to be fixed is that the web archive, (geode-pulse) has since 1.8
> been uploaded as a jar file to maven central.
> >>>
> >>> I would like to fix this by having the WAR artifact being pushed to
> maven central again.
> >>>
> >>> --Udo
> >>>
> >>
>
>


Re: Adding GEODE-7412 to 1.11 release

2019-11-08 Thread Owen Nichols
+1

> On Nov 8, 2019, at 12:54 PM, Udo Kohlmeyer  wrote:
> 
> @Owen,
> 
> I did not specifically check all web archives for this issue. Yes, I *should* 
> have been caught in that ticket.
> 
> On 11/8/19 11:03 AM, Owen Nichols wrote:
>> I’m curious, how was this missed in 
>> https://issues.apache.org/jira/browse/GEODE-7241 
>>  ?
>> 
>>> On Nov 8, 2019, at 10:56 AM, Udo Kohlmeyer  wrote:
>>> 
>>> Hi there Geode Dev,
>>> 
>>> I would like to request that we add 
>>> https://issues.apache.org/jira/browse/GEODE-7412 
>>>  to the 1.11 release.
>>> 
>>> This change is a build change that has crept in since 1.8. The issue that 
>>> is to be fixed is that the web archive, (geode-pulse) has since 1.8 been 
>>> uploaded as a jar file to maven central.
>>> 
>>> I would like to fix this by having the WAR artifact being pushed to maven 
>>> central again.
>>> 
>>> --Udo
>>> 
>> 



Re: Adding GEODE-7412 to 1.11 release

2019-11-08 Thread Udo Kohlmeyer

@Owen,

I did not specifically check all web archives for this issue. Yes, I 
*should* have been caught in that ticket.


On 11/8/19 11:03 AM, Owen Nichols wrote:

I’m curious, how was this missed in https://issues.apache.org/jira/browse/GEODE-7241 
 ?


On Nov 8, 2019, at 10:56 AM, Udo Kohlmeyer  wrote:

Hi there Geode Dev,

I would like to request that we add https://issues.apache.org/jira/browse/GEODE-7412 
 to the 1.11 release.

This change is a build change that has crept in since 1.8. The issue that is to 
be fixed is that the web archive, (geode-pulse) has since 1.8 been uploaded as 
a jar file to maven central.

I would like to fix this by having the WAR artifact being pushed to maven 
central again.

--Udo





Jira issue 7155 isRunning in Locator

2019-11-08 Thread Szu-Yu Lo
Hi all,

Good afternoon. I assigned myself to Jira issue 7155 (
https://issues.apache.org/jira/browse/GEODE-7155?jql=project%20%3D%20GEODE%20AND%20status%20%3D%20Open%20AND%20assignee%20in%20(EMPTY)%20ORDER%20BY%20priority%20ASC).
We noticed that there is a isStop method in the code (
https://github.com/apache/geode/blob/f30f9367bd7334a4e9f191d80568d7a1e0c13536/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java#L956).
I am wondering would this isStop method be sufficient for this issue to
close out?

Thank you and have a great weekend!

Regards,
Szu-Yu Lo


Re: Adding GEODE-7412 to 1.11 release

2019-11-08 Thread John Blum
+1

On Fri, Nov 8, 2019 at 10:59 AM Patrick Johnson  wrote:

> +1
>
> > On Nov 8, 2019, at 10:56 AM, Udo Kohlmeyer  wrote:
> >
> > Hi there Geode Dev,
> >
> > I would like to request that we add
> https://issues.apache.org/jira/browse/GEODE-7412 <
> https://issues.apache.org/jira/browse/GEODE-7412> to the 1.11 release.
> >
> > This change is a build change that has crept in since 1.8. The issue
> that is to be fixed is that the web archive, (geode-pulse) has since 1.8
> been uploaded as a jar file to maven central.
> >
> > I would like to fix this by having the WAR artifact being pushed to
> maven central again.
> >
> > --Udo
> >
>
>

-- 
-John
john.blum10101 (skype)


Re: Adding GEODE-7412 to 1.11 release

2019-11-08 Thread Owen Nichols
I’m curious, how was this missed in 
https://issues.apache.org/jira/browse/GEODE-7241 
 ?

> On Nov 8, 2019, at 10:56 AM, Udo Kohlmeyer  wrote:
> 
> Hi there Geode Dev,
> 
> I would like to request that we add 
> https://issues.apache.org/jira/browse/GEODE-7412 
>  to the 1.11 release.
> 
> This change is a build change that has crept in since 1.8. The issue that is 
> to be fixed is that the web archive, (geode-pulse) has since 1.8 been 
> uploaded as a jar file to maven central.
> 
> I would like to fix this by having the WAR artifact being pushed to maven 
> central again.
> 
> --Udo
> 



Re: Adding GEODE-7412 to 1.11 release

2019-11-08 Thread Patrick Johnson
+1

> On Nov 8, 2019, at 10:56 AM, Udo Kohlmeyer  wrote:
> 
> Hi there Geode Dev,
> 
> I would like to request that we add 
> https://issues.apache.org/jira/browse/GEODE-7412 
>  to the 1.11 release.
> 
> This change is a build change that has crept in since 1.8. The issue that is 
> to be fixed is that the web archive, (geode-pulse) has since 1.8 been 
> uploaded as a jar file to maven central.
> 
> I would like to fix this by having the WAR artifact being pushed to maven 
> central again.
> 
> --Udo
> 



Adding GEODE-7412 to 1.11 release

2019-11-08 Thread Udo Kohlmeyer

Hi there Geode Dev,

I would like to request that we add 
https://issues.apache.org/jira/browse/GEODE-7412 
 to the 1.11 release.


This change is a build change that has crept in since 1.8. The issue 
that is to be fixed is that the web archive, (geode-pulse) has since 1.8 
been uploaded as a jar file to maven central.


I would like to fix this by having the WAR artifact being pushed to 
maven central again.


--Udo



Odg: gateway sender queue

2019-11-08 Thread Mario Ivanac
Hi all,

one more clarification regarding 3rd question:

"*   Could we add extra option in gfsh command  "start gateway sender"
 that allows to control queues reset (for instance --cleanQueues)"

This option will indicate, when gateway sender is started, should we 
discard/clean existing queue, or should we use existing queue.
By default it will be to discard/clean existing queue.

Best Regards,
Mario

Šalje: Mario Ivanac 
Poslano: 7. studenog 2019. 9:01
Prima: Dan Smith ; dev@geode.apache.org 

Predmet: Odg: gateway sender queue

Hi,

thanks for answers.

Some more details regarding 1st question.

Is this behavior same (for serial and parallel gateway sender) in case queue is 
persistent?
Meaning, should queue (persistent) be purged if we restart gateway sender?


Thanks,
Mario


Šalje: Dan Smith 
Poslano: 5. studenog 2019. 18:52
Prima: dev@geode.apache.org 
Predmet: Re: gateway sender queue

Some replies, inline:

  *   During testing we have observed, different behavior in parallel and
> serial gateway senders. In case we manually stop, than start gateway
> senders, for parallel gateway senders, queue is purged, but for serial
> gateway senders this is not the case. Is this normal behavior or bug?
>

Hmm, I also think stop is supposed to clear the queue. I think if you are
seeing that it doesn't clear the queue, that might be a bug.



>   *   What happens with the queues when whole cluster is stopped and later
> started (In our tests with persistent queues, the events are kept)?
>

Persistent queues will keep all of the events when you restart.


>   *   Could we add extra option in gfsh command  "start gateway sender"
> that allows to control queues reset (for instance --cleanQueues)?
>

If stop does clear the queue, would this be needed? It might still be
reasonable - I've heard folks request a way to clear running queues as well.

-Dan