Re: GitHub notifications?

[Nicholas Vallely]

No, but it's annoying:)

On Mon, Apr 20, 2020 at 7:48 AM Anthony Baker  wrote:

> Hmmm, it looks like GitHub notifications are coming to dev@ instead of
> notifications@.
>
> Did anyone request this change?
>
> Anthony
>
>

Re: Website Banner Graphic

[Nicholas Vallely]

I feel like maybe this was talked about previously, but does Apache have a
registered Trademark for Geode? I don't see it on this list:
http://www.apache.org/foundation/marks/list/ which is fine for a TM from
what I know, but could we potentially be stepping on another TM'd thing
called Geode? Is there an ASF process for securing a registered TM, have we
already had this discussion and I am just late to the party?

+1 to fixing the awfulness of that image though :)

On Thu, Nov 14, 2019 at 11:06 AM Alberto Bustamante Reyes
 wrote:

> +1
>
> 
> De: Helena Bales 
> Enviado: jueves, noviembre 14, 2019 7:52 p. m.
> Para: dev@geode.apache.org
> Asunto: Re: Website Banner Graphic
>
> +1
>
> On Thu, Nov 14, 2019 at 10:47 AM Jacob Barrett 
> wrote:
>
> > Does anyone know who is responsible for our website’s graphics. The
> > recently added “TM” to the Geode logo needs to be redone. My design brain
> > can’t handle that the text is in the wrong font, the wrong color and
> isn’t
> > anti-aliased like the rest of the text and graphic components.
> >
> > https://geode.apache.org 
> > https://geode.apache.org/img/apache_geode_logo.png <
> > https://geode.apache.org/img/apache_geode_logo.png>
> >
> > The “TM" should be added to the original vector graphic and a new raster
> > should be generated from that.
> >
> > -Jake
> >
> >
>

[DISCUSS] Geode dependency update process (review by 8/28/2019)

[Nicholas Vallely]

https://cwiki.apache.org/confluence/display/GEODE/%5BDraft%5D+Geode+dependency+update+process

Here is the content of the wiki proposal above for a discussion:
Problem

We recently updated the dependencies for the log4j version used in Geode to
keep up with Spring Boot Data Geode's logging dependencies. As far as I
know, we do not have a process to keep dependencies up to date or regularly
scheduled updates to them. Currently, I believe this is handled ad-hoc
which hasn't necessarily caused any major issues but could.
Anti-GoalsSolution

*Directly after GA release of Geode minor version:*
The release manager for the most recently released version of Geode would
review any dependencies in the Geode project (presumably this will/could be
automated).

   - For a minor release, only minor version dependency updates should be
   considered
   - For a major release, major versions should be considered

The release manager would submit a PR to update dependencies and then the
community should pitch in to tackle any subsequent issues that arise from
the updating of dependencies. *Note the first time this happens maybe
painful*

*In-between releases:*
We keep doing what we are doing:

   - Ad-hoc dependency updates as necessary

*When a new release manager is chosen:*
The release manager would send out an email as the last call for dependency
updates that would coincide with a proposed release branch cut date. This
would give everyone a reminder that if they need to update a dependency
prior to the release there is limited time left in order to do so.
Changes and Additions to Public Interfaces

*n/a*
Performance Impact

*Potentially a new version of a dependency could cause a performance impact
and we should run a performance test suite on the recently released version
vs the updated dependency version*
Backwards Compatibility and Upgrade Path

*In a minor release, minor version dependency updates shouldn't cause
compatibility issues.*
Prior Art

*What would be the alternatives to the proposed solution? What would happen
if we don’t solve the problem? Why should this proposal be preferred?*

*If we continue to do this ad-hoc, there is a greater likelihood of CVE's
or mismatching versions of conflicts between Geode and dependent projects.*


*Nick*

Re: [DISCUSS] Wrapping log calls in Conditionals like isDebugEnabled, isTraceEnabled, etc.

[Nicholas Vallely]

I was just randomly looking into this a couple of days ago as a tangent to
'observability' and came across this Stack Overflow:
https://stackoverflow.com/questions/6504407/is-there-a-need-to-do-a-iflog-isdebugenabled-check
where the first answer is the most succinct in my opinion.

In the geode code that I searched, we are not consistent with our use of
the if(statement) wrapper for debug, though most do have the wrapper.

Nick

On Fri, Sep 7, 2018 at 11:35 AM Jacob Barrett  wrote:

> Checking with logger.isDebugEnabled() it still a good practice for hot
> paths to avoid the construction of intermediate object arrays to hold the
> var-args. Some logging libraries have fixed argument optimizations for
> var-args up to a specific limit. In very hot paths it is nice to
> check logger.isDebugEnabled() once into a temp boolean value and then check
> that in all the subsequent debug logging statements in the hot path.
>
> -Jake
>
>
> On Fri, Sep 7, 2018 at 11:18 AM Dan Smith  wrote:
>
> > I think this pattern is a holdover from using log4j 1. In that version,
> you
> > added an if check to avoid unnecessary string concatenation if debug was
> > enabled.
> >
> >
> >1. if (logger.isDebugEnabled()) {
> >2. logger.debug("Logging in user " + user.getName() + " with
> > birthday " + user.getBirthdayCalendar());
> >3. }
> >
> >
> > Log4j2 lets you pass a format string, so you can just do this:
> >
> > logger.debug("Logging in user {} with birthday {}", user.getName(),
> > user.getBirthdayCalendar());
> >
> >
> > These examples come from the log4j2 docs:
> >
> > https://logging.apache.org/log4j/2.0/manual/api.html
> >
> > -Dan
> >
> > On Fri, Sep 7, 2018 at 10:50 AM, Galen O'Sullivan  >
> > wrote:
> >
> > > Hi all,
> > >
> > > I've noticed a pattern in Geode where we wrap a log call in a check at
> > the
> > > same level, such as:
> > >
> > > if (logger.isDebugEnabled()) {
> > >   logger.debug("cleaning up incompletely started
> > > DistributionManager due to exception", r);
> > > }
> > >
> > > Is there any reason to do this? To my mind, it's an extra conditional
> > that
> > > should essentially be the first check inside `logger.debug(...)`
> anyways,
> > > and it complicates the code and makes it less readable. I've even seen
> > > places in the code which have `if (logger.isDebugEnabled())
> > > logger.trace(...))` and such.
> > >
> > > I would like to propose that unless there is a compelling reason to use
> > > this pattern, we remove all extra checks entirely.
> > >
> > > Galen
> > >
> >
>

Re: Spring Boot for Apache Geode 1.0.0.M1 Released!

[Nicholas Vallely]

Congrats, this is awesome! I'll take a look later today and provide
feedback.

Nick

On Mon, Jun 25, 2018, 9:42 PM John Blum  wrote:

> Apache Geode Community-
>
> It is my please to announce the first milestone release of Spring Boot for
> Apache Geode, version 1.0.0.M1.
>
> See the official Spring Blog Post [1] for more details.
>
> Documentation [2] is available as are a couple of Examples [3].
>
> Feedback appreciated and welcomed.
>
> Much more to follow soon; stay tuned!
>
> Regards,
>
> --
> -John
>
> [1]
>
> https://spring.io/blog/2018/06/26/spring-boot-for-apache-geode-pivotal-gemfire-1-0-0-m1-released
> [2]
>
> https://spring.io/blog/2018/06/26/spring-boot-for-apache-geode-pivotal-gemfire-1-0-0-m1-released#documentation
> [3]
>
> https://spring.io/blog/2018/06/26/spring-boot-for-apache-geode-pivotal-gemfire-1-0-0-m1-released#examples
>

Re: JIRA and Wiki Access

[Nicholas Vallely]

Thanks everyone for getting me signed up!

On Thu, May 10, 2018 at 4:45 PM Dan Smith  wrote:

> Hi Nick,
>
> I gave you access on confluence to edit pages. Sorry about the delay there.
>
> Thanks!
> -Dan
>
> On Thu, May 10, 2018 at 4:12 PM, Kirk Lund  wrote:
>
> > I remembered how to edit permissions in the wiki, but I can't find user
> > "nvpivot" in the wiki. If you haven't already, please create your userId
> > for the wiki as well (it's a separate account from Jira).
> >
> > Thanks,
> > Kirk
> >
> > On Thu, May 10, 2018 at 4:07 PM, Kirk Lund  wrote:
> >
> > > Hi Nick,
> > >
> > > I gave you permissions in Jira so you can create/edit/assign tickets.
> I'm
> > > not sure how to give you permissions in the wiki (anyone know?).
> > >
> > > Thanks,
> > > Kirk
> > >
> > >
> > > On Tue, May 8, 2018 at 10:12 AM, Nicholas Vallely  >
> > > wrote:
> > >
> > >> Update on this request:
> > >>
> > >> I now have a JIRA user name of: nvpivot
> > >>
> > >> Please allow me access to JIRA projects and the wiki.
> > >>
> > >> thanks!
> > >> Nick
> > >>
> > >>
> > >> On Mon, May 7, 2018 at 11:00 AM Nicholas Vallely  >
> > >> wrote:
> > >>
> > >> > Hello!
> > >> >
> > >> > I am new to Pivotal and need to get access to JIRA and the Wiki for
> my
> > >> > user:
> > >> > nvallely
> > >> >
> > >> > Please let me know what other information you may need.
> > >> >
> > >> > Nick
> > >> >
> > >>
> > >
> > >
> >
>

Re: JIRA and Wiki Access

[Nicholas Vallely]

For the confluence wiki, I will need edit access on the Geode Wiki.  My
confluence username is: nvallely

Thanks!

On Tue, May 8, 2018 at 10:12 AM Nicholas Vallely 
wrote:

> Update on this request:
>
> I now have a JIRA user name of: nvpivot
>
> Please allow me access to JIRA projects and the wiki.
>
> thanks!
> Nick
>
>
> On Mon, May 7, 2018 at 11:00 AM Nicholas Vallely 
> wrote:
>
>> Hello!
>>
>> I am new to Pivotal and need to get access to JIRA and the Wiki for my
>> user:
>> nvallely
>>
>> Please let me know what other information you may need.
>>
>> Nick
>>
>

Re: JIRA and Wiki Access

[Nicholas Vallely]

Update on this request:

I now have a JIRA user name of: nvpivot

Please allow me access to JIRA projects and the wiki.

thanks!
Nick


On Mon, May 7, 2018 at 11:00 AM Nicholas Vallely 
wrote:

> Hello!
>
> I am new to Pivotal and need to get access to JIRA and the Wiki for my
> user:
> nvallely
>
> Please let me know what other information you may need.
>
> Nick
>

JIRA and Wiki Access

[Nicholas Vallely]

Hello!

I am new to Pivotal and need to get access to JIRA and the Wiki for my user:
nvallely

Please let me know what other information you may need.

Nick