[GitHub] geode issue #395: GEODE-2430: Fix failing tests
Github user kjduling commented on the issue: https://github.com/apache/geode/pull/395 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #361: GEODE-2325: Improve tests for JarDeployer
Github user kjduling commented on the issue: https://github.com/apache/geode/pull/361 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #327: GEODE-2236: Remove all cache-listners using Gfsh
Github user kjduling commented on the issue: https://github.com/apache/geode/pull/327 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #316: GEODE-2188: ExampleSecurityManager references Sampl...
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/geode/pull/316#discussion_r93109555
--- Diff:
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
---
@@ -257,15 +257,65 @@ private void readUsers(final Map
rolesToUsers, final JsonNode node
return roleMap;
}
- static class Role {
+ public static class Role {
List permissions = new ArrayList<>();
+
--- End diff --
Originally, yes, they were in the same package. Then, after
SampleSecurityManager was moved to ExampleSecurityManager and
TestSecurityManger, the test was testing TestSecurityManager, which is silly.
A test to test a test? By changing the test to point to
ExampleSecurityManager, scope became an issue.
We could also just move the test to the same package as the example and
remove the accessors and public scope on the inner classes. Either is fine
with me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #316: GEODE-2188: ExampleSecurityManager references Sampl...
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/geode/pull/316#discussion_r93079596
--- Diff:
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
---
@@ -257,15 +257,65 @@ private void readUsers(final Map
rolesToUsers, final JsonNode node
return roleMap;
}
- static class Role {
+ public static class Role {
List permissions = new ArrayList<>();
+
--- End diff --
They are actually needed by the test. I can either set the fields public,
move the test to the same package, or leave the accessor methods. Which is
preferred?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #316: GEODE-2188: ExampleSecurityManager references Sampl...
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/geode/pull/316#discussion_r93077824
--- Diff:
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
---
@@ -257,15 +257,65 @@ private void readUsers(final Map
rolesToUsers, final JsonNode node
return roleMap;
}
- static class Role {
+ public static class Role {
List permissions = new ArrayList<>();
+
--- End diff --
Oh, I see. Yes, because I made the object public, it's been a habit of
mine to then make accessor methods for the protected fields. I'll remove them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #316: GEODE-2188: ExampleSecurityManager references Sampl...
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/geode/pull/316#discussion_r92662419
--- Diff:
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
---
@@ -257,15 +257,65 @@ private void readUsers(final Map
rolesToUsers, final JsonNode node
return roleMap;
}
- static class Role {
+ public static class Role {
List permissions = new ArrayList<>();
+
--- End diff --
I didn't add them, I just marked them public so that the Test could reach
them. It didn't make sense to me for TestSecurityManagerTest to be testing
TestSecurityManager. It makes slightly more sense to test the
ExampleSecurityManager. The two security managers are identical code at this
point (RE: GEODE-2092), but I'm sure that'll change in the near future as we
build out Geode examples.
If we were to remove Roles and Users, we'd also remove about 95% of the
code in ExampleSecurityManager, not leaving much example left. We should have
a separate ticket to refactor the example. This one really is only supposed to
address some Javadoc and System.out messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #316: GEODE-2188: ExampleSecurityManager references Sampl...
GitHub user kjduling opened a pull request: https://github.com/apache/geode/pull/316 GEODE-2188: ExampleSecurityManager references SampleSecurityManager i⦠â¦n javadoc This corrects some output messages and javadoc entries after the ExampleSecurityManager was moved. It also points the old SampleSecurityManagerTest at ExampleSecurityManager. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kjduling/apache-geode feature/GEODE-2188 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/316.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #316 commit 135c2c7d268f1b985fc07bac855bc4c2df680281 Author: Kevin J. Duling Date: 2016-12-14T21:23:19Z GEODE-2188: ExampleSecurityManager references SampleSecurityManager in javadoc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #311: GEODE-2119: gfsh user and password in clear text
Github user kjduling commented on a diff in the pull request: https://github.com/apache/geode/pull/311#discussion_r91999625 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java --- @@ -14,38 +14,10 @@ */ --- End diff -- Found it. It's an option in IDEA under 'reformat code' to 'rearrange code' and 'optimize imports'. Those were turned off, but the upgrade to 2016.3 seemed to re-enable them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #311: GEODE-2119: gfsh user and password in clear text
GitHub user kjduling opened a pull request: https://github.com/apache/geode/pull/311 GEODE-2119: gfsh user and password in clear text You can merge this pull request into a Git repository by running: $ git pull https://github.com/kjduling/apache-geode feature/GEODE-2119 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/311.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #311 commit f5860798b3eee0eadffdc78709a9f985a161fb6a Author: Kevin J. Duling Date: 2016-12-07T21:23:38Z GEODE-2119: gfsh user and password visible in clear text Made changes to suppress the password from being displayed in the log files and on the console. commit 7d175d352b12c9e331842cf8cc3335e722c41e2f Author: Kevin J. Duling Date: 2016-12-08T17:05:02Z Avoid null=** scenario commit db450c5895a278c4a43aeb8ba7533ccddf8cb108 Author: Kevin J. Duling Date: 2016-12-09T20:52:01Z GEODE-2119: gfsh user and password visible in clear text Added tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #302: GEODE-2196: Subclasses of OperationContex...
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/302 GEODE-2196: Subclasses of OperationContext should also be deprecated. precheckin running You can merge this pull request into a Git repository by running: $ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2169 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/302.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #302 commit af988dcf9dddb64f322bbb69364d5bb4cbaf68f9 Author: Kevin J. Duling Date: 2016-12-02T18:31:41Z GEODE-2196: Subclasses of OperationContext should also be deprecated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #290: GEODE-2092: Security examples should not be in t...
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/290 @metatype Yes, precheckin ran clean. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #290: GEODE-2092: Security examples should not be in t...
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/290 Confict fixed. Precheckin running. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #290: GEODE-2092: Security examples should not be in t...
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/290 Merged in latest develop branch. Precheckin running. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #290: GEODE-2092: Security examples should not ...
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/290 GEODE-2092: Security examples should not be in the product code Moved examples to geode-core/src/main/java/org/apache/geode/examples/security/ Copied old Sample/Simple code to test packages as many tests rely on these classes. Deleted SimpleSecurityManager example class You can merge this pull request into a Git repository by running: $ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2092 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/290.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #290 commit a3bb5aa6d2de757ae2a9a9f461c852dfa8731141 Author: Kevin Duling Date: 2016-11-17T18:57:00Z GEODE-2092: Security examples should not be in the product code Moved examples to geode-core/src/main/java/org/apache/geode/examples/security/ Copied old Sample/Simple code to test packages as many tests rely on these classes. Deleted SimpleSecurityManager example class --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #288: GEODE-2092 - Security examples should not be in ...
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/288 Cancelling this one to resubmit as a single, clean commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #288: GEODE-2092 - Security examples should not...
Github user kjduling closed the pull request at: https://github.com/apache/incubator-geode/pull/288 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #288: GEODE-2092 - Security examples should not be in ...
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/288 I moved the examples in to geode-examples/utils/src/main/java/org/apache/geode/example/security/ so it looks like I misunderstood and jumped the gun. So, I'll undo that, and move them to geode-core/src/main/java/org/apache/geode/examples/security/ #2 should be correct. No test should depend on any production code in geode-core. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #288: GEODE-2092 - Security examples should not...
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/288 GEODE-2092 - Security examples should not be in the product code Moved examples to geode-examples project Copied old Sample/Simple code to test packages as many tests rely on these classes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2092 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/288.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #288 commit 1099d9cbc868d0ad93f76b18de82e69400339e5a Author: Kevin Duling Date: 2016-11-17T18:57:00Z GEODE-2092 - Security examples should not be in the product code Moved examples to geode-examples project Copied old Sample/Simple code to test packages as many tests rely on these classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
