[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...

2017-03-15 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/54
  
@dgkimura I will pull this and work on some of the tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...

2017-03-14 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/54
  
@dgkimura It will give the CI something to chew on to prove that this 
message actually works with the server now. ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...

2017-03-14 Thread dgkimura
Github user dgkimura commented on the issue:

https://github.com/apache/geode-native/pull/54
  
@pivotal-jbarrett Okay. Fair enough. That's going to add some cycles to 
this pull-request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...

2017-03-14 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/54
  
@dgkimura I would suggest getting a few of those integration tests updated 
to test this. They were marked flaky a long time ago when the tests ran through 
several iterations with different configurations. Now that we don't do that 
anymore it should be easy to stabilize the tests.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...

2017-03-14 Thread dgkimura
Github user dgkimura commented on the issue:

https://github.com/apache/geode-native/pull/54
  
@echobravopapa We're only human.

Our unittest didn't catch it originally because the output that's written 
to DataOutput in the constructor is the same with/without this variable set.  
It's likely when the message is sent that client checks this variable and 
performs some magic.  I'm guessing our integration-tests that cover this aren't 
running.  Else we might have had a chance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---