[GitHub] geode-native pull request #15: GEODE-2484: Fix snprintf error. Need #include...
Github user mmartell closed the pull request at: https://github.com/apache/geode-native/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #15: GEODE-2484: Fix snprintf error. Need #include...
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101662122
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1113,12 +1117,11 @@ class TcrMessageHelper {
return NULL_OBJECT;
} else if (!isObj) {
// otherwise we're currently always expecting an object
- char exMsg[256];
- std::snprintf(exMsg, 255,
-"TcrMessageHelper::readChunkPartHeader: "
-"%s: part is not object",
-methodName);
- LOGDEBUG("%s ", exMsg);
+
+ std::stringstream s;
+ s << "TcrMessageHelper::readChunkPartHeader: " << methodName << ":
part is not object\n";
+ LOGDEBUG("%s ", s.str().c_str());
--- End diff --
Good question. I am still fascinated as to why std::snprintf isn't working
correctly on Windows too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #15: GEODE-2484: Fix snprintf error. Need #include...
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/15#discussion_r101652960 --- Diff: src/cppcache/src/TcrMessage.hpp --- @@ -20,6 +20,10 @@ * limitations under the License. */ +//#include --- End diff -- No need for this line in current revision. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #15: GEODE-2484: Fix snprintf error. Need #include...
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101655637
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1113,12 +1117,11 @@ class TcrMessageHelper {
return NULL_OBJECT;
} else if (!isObj) {
// otherwise we're currently always expecting an object
- char exMsg[256];
- std::snprintf(exMsg, 255,
-"TcrMessageHelper::readChunkPartHeader: "
-"%s: part is not object",
-methodName);
- LOGDEBUG("%s ", exMsg);
+
+ std::stringstream s;
+ s << "TcrMessageHelper::readChunkPartHeader: " << methodName << ":
part is not object\n";
+ LOGDEBUG("%s ", s.str().c_str());
--- End diff --
I find this line a little suspicious. If I understand correctly,
`stringstream.str()` will return a temporary string object and then `c_str()`
will return a pointer to that temporary object. Then it seems like it may be
possible that temporary string is freed after the expression is evaluated. And
then we would be referencing a freed object inside `LOGDEBUG` which would lead
to undefined behavior. If I am misunderstanding then please educate me how
this works and why you chose to do it! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #15: GEODE-2484: Fix snprintf error. Need #include...
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101610701
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1114,10 +1116,10 @@ class TcrMessageHelper {
} else if (!isObj) {
// otherwise we're currently always expecting an object
char exMsg[256];
- std::snprintf(exMsg, 255,
-"TcrMessageHelper::readChunkPartHeader: "
-"%s: part is not object",
-methodName);
+ snprintf(exMsg, 255,
--- End diff --
If you had to remove std:: to make this work then it isn't working like you
think it is. Let's figure out why and fix correctly,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #15: GEODE-2484: Fix snprintf error. Need #include...
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101580799
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1135,7 +1137,7 @@ class TcrMessageHelper {
return EXCEPTION;
} else {
char exMsg[256];
-std::snprintf(
+snprintf(
--- End diff --
Why are you removing the namespace specifier here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #15: GEODE-2484: Fix snprintf error. Need #include...
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/15 GEODE-2484: Fix snprintf error. Need #include . You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode-native feature/GEODE-2484 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 commit 5a215532d13d903b8c0a229c0d6fccbe8c0ef809 Author: Mike Martell Date: 2017-02-16T15:57:11Z GEODE-2484: Fix snprintf error. Need #include . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
