[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102539038
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
for (int i = 0; i < PATH_MAX && path[i] != 0; i++) {
path[i] = ::tolower(path[i]);
}
- dllNamePtr = strstr(path, "apache-geode.dll");
+ std::string cppName = PRODUCT_LIB_NAME;
+ cppName += ".dll";
+ std::string dotNetName = PRODUCT_DLL_NAME;
+ dotNetName += ".dll";
+ dllNamePtr = strstr(path, cppName.c_str());
--- End diff --
fair nit ð will change it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102538789
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
$
)
add_dependencies(client-libraries apache-geode)
-set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER
"${PUBLIC_HEADERS}")
+set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER
"${PUBLIC_HEADERS}" OUTPUT_NAME ${PRODUCT_LIB_NAME} )
--- End diff --
will adjust that. cmake did not like duplicate calls to
set_target_properites
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102532340
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
for (int i = 0; i < PATH_MAX && path[i] != 0; i++) {
path[i] = ::tolower(path[i]);
}
- dllNamePtr = strstr(path, "apache-geode.dll");
+ std::string cppName = PRODUCT_LIB_NAME;
+ cppName += ".dll";
+ std::string dotNetName = PRODUCT_DLL_NAME;
+ dotNetName += ".dll";
+ dllNamePtr = strstr(path, cppName.c_str());
--- End diff --
Nit: `strstr` seems old-school. If you turn `path` into a `std::string`
then you can use `std::basic_string::find` and do something like.
```cpp
if (pathAsString.find(cppName) == std::string::npos)
{
// ...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102517638
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
$
)
add_dependencies(client-libraries apache-geode)
-set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER
"${PUBLIC_HEADERS}")
+set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER
"${PUBLIC_HEADERS}" OUTPUT_NAME ${PRODUCT_LIB_NAME} )
--- End diff --
I would only suggest avoiding long lines in the CMake files by putting each
property on a new line.
```
set_target_properties(apache-geode PROPERTIES
PUBLIC_HEADER "${PUBLIC_HEADERS}"
OUTPUT_NAME ${PRODUCT_LIB_NAME})
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode-native/pull/24 GEODE-2508: Initial work on new approach to generic lib naming. Keeping the changes to CppCacheLibrary.cpp - did not, yet, find a CMake way to do it more seamlessly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode-native feature/GEODE-2508 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/24.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #24 commit c3936e60af42b8a7287ac3554b73f0d6892ef764 Author: Ernest Burghardt Date: 2017-02-22T16:52:13Z GEODE-2508: Initial work on new approach to generic lib naming. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
