[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread metatype
Github user metatype closed the pull request at:

https://github.com/apache/geode/pull/394


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99889754
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
+  - sudo apt-get install -y cmake
+  - sudo apt-get install -y doxygen
+  - sudo apt-get install -y git
+  - sudo apt-get install -y openjdk-8-jdk
+  - sudo apt-get install -y wget
+  - sudo apt-get install -y zlib1g-dev
+
+install: mkdir build && cd build && cmake ../src && cmake --build . -- -j 8
--- End diff --

It is needed to build the javaobject(s)...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread dgkimura
Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99882331
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
+  - sudo apt-get install -y cmake
--- End diff --

What CMake version does this install?  We need version 3.4 or higher.  If 
that's not the case, then we may need to `wget` and install manually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread dgkimura
Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99881517
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
--- End diff --

We need GCC 4.8+ for full C++11 support.  Build #1992 looks like it has GCC 
4.6.  I think the easiest way to fix is to add `dist: trusty`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread PivotalSarge
Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99872593
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
+  - sudo apt-get install -y cmake
+  - sudo apt-get install -y doxygen
+  - sudo apt-get install -y git
+  - sudo apt-get install -y openjdk-8-jdk
+  - sudo apt-get install -y wget
+  - sudo apt-get install -y zlib1g-dev
+
+install: mkdir build && cd build && cmake ../src && cmake --build . -- -j 8
--- End diff --

I don't believe the unit tests require GEODE to run. They certainly 
shouldn't.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread metatype
Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99871967
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
+  - sudo apt-get install -y cmake
+  - sudo apt-get install -y doxygen
+  - sudo apt-get install -y git
+  - sudo apt-get install -y openjdk-8-jdk
+  - sudo apt-get install -y wget
+  - sudo apt-get install -y zlib1g-dev
+
+install: mkdir build && cd build && cmake ../src && cmake --build . -- -j 8
--- End diff --

Do the unit tests require a GEODE install?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode/pull/394#discussion_r99858609
  
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: cpp
+sudo: required
+
+before_install:
+  - sudo apt-get -qq update
+  - sudo apt-get -y build-essential
+  - sudo apt-get install -y cmake
+  - sudo apt-get install -y doxygen
+  - sudo apt-get install -y git
+  - sudo apt-get install -y openjdk-8-jdk
+  - sudo apt-get install -y wget
+  - sudo apt-get install -y zlib1g-dev
+
+install: mkdir build && cd build && cmake ../src && cmake --build . -- -j 8
--- End diff --

The configuration step will need to be like so: 
`make ../src -DGEODE_ROOT= `
optionally one could add:
`-DCMAKE_BUILD_TYPE=Debug` Debug is default unless Release is specified
`-DPRODUCT_VERSION=maj.min.patch-build.N`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file

2017-02-07 Thread metatype
GitHub user metatype opened a pull request:

https://github.com/apache/geode/pull/394

GEODE-2437 Add travis-ci file

Configure travis-ci to build cppcache on linux and run unit
tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/metatype/incubator-geode feature/GEODE-2437

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #394






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---