[GitHub] geode pull request #421: GEODE-2595: Change LuceneService.createIndex to use...

2017-03-08 Thread upthewaterspout 
GitHub user upthewaterspout opened a pull request:

https://github.com/apache/geode/pull/421

GEODE-2595: Change LuceneService.createIndex to use a factory

Changing LuceneService.createIndex to createIndexFactory and
using a factory pattern to create the index.

This allows us to introduce new options to the index create without
breaking backwards compatibility in the future.

@ladyVader @nabarunnag @boglesby

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/upthewaterspout/incubator-geode 
feature/GEODE-2595

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #421


commit f912be793ff7a73855df903148d4b74dfdc415b9
Author: Dan Smith 
Date:   2017-03-09T01:15:44Z

GEODE-2595: Change LuceneService.createIndex to use a factory

Changing LuceneService.createIndex to createIndexFactory and
using a factory pattern to create the index.

This allows us to introduce new options to the index create without
breaking backwards compatibility in the future.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #421: GEODE-2595: Change LuceneService.createIndex to use...

2017-03-10 Thread gesterzhou 
Github user gesterzhou commented on a diff in the pull request:

https://github.com/apache/geode/pull/421#discussion_r105441883
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java ---
@@ -37,15 +36,17 @@
  * 
  * 
  * Lucene indexes can be created using gfsh, xml, or the java API. Below 
is an example of creating a
- * Lucene index with the java API. The Lucene index created on each member 
that will host data for
- * the region.
+ * Lucene index with the java API. The Lucene index should be created on 
each member that has the
+ * region that is being indexed.
  * 
  * 
  * 
  * {
  *   @code
- *   LuceneIndex index =
- *   luceneService.createIndex(indexName, regionName, "field1", 
"field2", "field3");
+*   luceneService.createCreateIndexFactory()
--- End diff --

I don't like the name "createCreateIndexFactory". 2 create?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #421: GEODE-2595: Change LuceneService.createIndex to use...

2017-03-10 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/421


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---