[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011070#comment-16011070 ] Kirk Lund commented on GEODE-1930: -- RegionManagementDUnitTest has multiple flaky tests and is failing intermittently. In particular testRegionAggregate and testLruStats. {noformat} org.apache.geode.test.dunit.RMIException: While invoking org.apache.geode.test.dunit.NamedRunnable.run in VM 0 running on Host 10.118.33.232 with 4 VMs at org.apache.geode.test.dunit.VM.invoke(VM.java:377) at org.apache.geode.test.dunit.VM.invoke(VM.java:347) at org.apache.geode.test.dunit.VM.invoke(VM.java:280) at org.apache.geode.management.RegionManagementDUnitTest.verifySystemNotifications(RegionManagementDUnitTest.java:617) at org.apache.geode.management.RegionManagementDUnitTest.testRegionAggregate(RegionManagementDUnitTest.java:259) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70) Caused by: java.lang.AssertionError: Expected size:<5> but was:<6> in: <[javax.management.Notification[source=10.118.33.232(62116)-32771][type=gemfire.distributedsystem.cache.region.created][message=Region Created With Name /MANAGEMENT_TEST_REGION], javax.management.Notification[source=10.118.33.232(62115)-32770][type=gemfire.distributedsystem.cache.region.created][message=Region Created With Name /MANAGEMENT_TEST_REGION], javax.management.Notification[source=10.118.33.232(62116)-32771][type=gemfire.distributedsystem.cache.region.closed][message=Region Destroyed/Closed With Name /MANAGEMENT_TEST_REGION], javax.management.Notification[source=10.118.33.232(62117)-32772][type=gemfire.distributedsystem.cache.region.closed][message=Region Destroyed/Closed With Name /MANAGEMENT_TEST_REGION], javax.management.Notification[source=10.118.33.232(62118)-32773][type=gemfire.distributedsystem.cache.region.closed][message=Region Destroyed/Closed With Name /MANAGEMENT_TEST_REGION], javax.management.Notification[source=10.118.33.232(62115)-32770][type=gemfire.distributedsystem.cache.region.closed][message=Region Destroyed/Closed With Name /MANAGEMENT_TEST_REGION]]> at org.apache.geode.management.RegionManagementDUnitTest.lambda$verifySystemNotifications$3d0515b3$1(RegionManagementDUnitTest.java:619) at org.apache.geode.test.dunit.NamedRunnable.run(NamedRunnable.java:31) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodA
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011083#comment-16011083 ] ASF subversion and git services commented on GEODE-1930: Commit 9a1aeddca94216725920b2fe467e6dff6ae7cd81 in geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9a1aedd ] GEODE-1930: add FlakyTest categories to flickering tests > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018080#comment-16018080 ] ASF subversion and git services commented on GEODE-1930: Commit 88631957e9bc570115ed150eceed9a1b8b470a01 in geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8863195 ] GEODE-1930: temporarily disable verifySystemNotifications * verifySystemNotifications is very flaky and we need to determine what async state to Await for > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018090#comment-16018090 ] ASF subversion and git services commented on GEODE-1930: Commit 88631957e9bc570115ed150eceed9a1b8b470a01 in geode's branch refs/heads/feature/GEODE-2632-16 from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8863195 ] GEODE-1930: temporarily disable verifySystemNotifications * verifySystemNotifications is very flaky and we need to determine what async state to Await for > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019970#comment-16019970 ] ASF subversion and git services commented on GEODE-1930: Commit 88631957e9bc570115ed150eceed9a1b8b470a01 in geode's branch refs/heads/feature/GEODE-2580 from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8863195 ] GEODE-1930: temporarily disable verifySystemNotifications * verifySystemNotifications is very flaky and we need to determine what async state to Await for > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838802#comment-15838802 ] ASF subversion and git services commented on GEODE-1930: Commit e3eb92712ae4ad98d27c1a62698dc0f710b92d01 in geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e3eb927 ] GEODE-1930: apply build and dunit changes to support JMX tests > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838891#comment-15838891 ] ASF subversion and git services commented on GEODE-1930: Commit e3eb92712ae4ad98d27c1a62698dc0f710b92d01 in geode's branch refs/heads/feature/GEODE-1930-2 from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e3eb927 ] GEODE-1930: apply build and dunit changes to support JMX tests > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840552#comment-15840552 ] ASF subversion and git services commented on GEODE-1930: Commit ca9cfd4132631c4d47710f1af8768f4755f0143b in geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ca9cfd4 ] GEODE-1930: fix exception messages in DUnitLauncher > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840622#comment-15840622 ] ASF subversion and git services commented on GEODE-1930: Commit ca9cfd4132631c4d47710f1af8768f4755f0143b in geode's branch refs/heads/feature/GEODE-1930-2 from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ca9cfd4 ] GEODE-1930: fix exception messages in DUnitLauncher > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842342#comment-15842342 ] ASF subversion and git services commented on GEODE-1930: Commit ca9cfd4132631c4d47710f1af8768f4755f0143b in geode's branch refs/heads/feature/GEODE-2367 from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ca9cfd4 ] GEODE-1930: fix exception messages in DUnitLauncher > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855009#comment-15855009 ] ASF subversion and git services commented on GEODE-1930: Commit a232cdcf84ad7f036aa5329f86e771b25b0ef5b8 in geode's branch refs/heads/feature/GEODE-1930-2 from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a232cdc ] GEODE-1930: Convert from ManagementTestCase to ManagementTestRule > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856961#comment-15856961 ] ASF subversion and git services commented on GEODE-1930: Commit 72ad9f4344aa0eab478d0a5f216197ffa0538fc4 in geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=72ad9f4 ] GEODE-1930: Convert from ManagementTestCase to ManagementTestRule > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856984#comment-15856984 ] Kirk Lund commented on GEODE-1930: -- Overhauling RegionManagementDUnitTest is incomplete and still needs to be completed. I had originally overhauled LocatorManagementDUnitTest on the feature branch, but other changes to Locator and LocatorManagementDUnitTest develop caused conflicts bad enough to cause me to abandon my changes. So LocatorManagementDUnitTest still needs to be overhauled as well. There is redundant code within these tests to await for the existence of certain Geode mbeans. This should also be refactored. Leaving this ticket open for these additional changes to eventually be made. > JMX DistributedTests are in need of overhauling > --- > > Key: GEODE-1930 > URL: https://issues.apache.org/jira/browse/GEODE-1930 > Project: Geode > Issue Type: Improvement > Components: management >Reporter: Kirk Lund >Assignee: Kirk Lund > > In particular the DistributedTests that extend ManagementTestBase are really > lacking. Most of these have system outs instead of assertions, broken > AsyncInvocations and a host of other problems. > Before working on anything in JMX or GFSH, these tests should be fixed up so > that keeping them green actually means something. -- This message was sent by Atlassian JIRA (v6.3.15#6346)