[jira] [Commented] (GEODE-2294) When executing a function, error messages are being lost

2017-01-11 Thread Kevin Duling (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819105#comment-15819105
 ] 

Kevin Duling commented on GEODE-2294:
-

This problem is not related to the function itself or gfsh.  It's with the REST 
controller, which is why the component is marked as {{rest (dev)}}.  It is in 
the execute() method in 
org.apache.geode.rest.internal.web.controllers.FunctionAccessController.  The 
only way to reproduce this is via a REST client, be it Swagger, Postman, curl 
or whatever.

When an exception is thrown, it is caught and wrapped in to a 
GemfireRestException, assigned a text error, and rethrown.

What should be happening is that the exception should be captured by 
BaseControllerAdvice and properly wrapped in to a well-formed JSON response.

The specific error doesn't matter, it's the fact that GemFireRestExeption isn't 
being handled properly by the REST framework to return a well-formed error code 
and message.

> When executing a function, error messages are being lost
> 
>
> Key: GEODE-2294
> URL: https://issues.apache.org/jira/browse/GEODE-2294
> Project: Geode
>  Issue Type: Bug
>  Components: rest (dev)
>Reporter: Kevin Duling
>
> In FunctionAccessController:
> While debugging the execution of a function via the REST API, a null-pointer 
> exception was thrown and should have returned the error:
> {{Specified key is null and this region does not permit null keys!}}
> instead, an error code of 0 is returned with the message:
> {code}
> {
>   "error": "no response from server"
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-2294) When executing a function, error messages are being lost

2017-01-11 Thread Kirk Lund (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819023#comment-15819023
 ] 

Kirk Lund commented on GEODE-2294:
--

It would also be good to try executing the Function in multiple ways (from a 
Client, from a peer application, from GFSH) and compare the error handling of 
those different approaches.


> When executing a function, error messages are being lost
> 
>
> Key: GEODE-2294
> URL: https://issues.apache.org/jira/browse/GEODE-2294
> Project: Geode
>  Issue Type: Bug
>  Components: rest (dev)
>Reporter: Kevin Duling
>
> In FunctionAccessController:
> While debugging the execution of a function via the REST API, a null-pointer 
> exception was thrown and should have returned the error:
> {{Specified key is null and this region does not permit null keys!}}
> instead, an error code of 0 is returned with the message:
> {code}
> {
>   "error": "no response from server"
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)