[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872609#comment-15872609
 ] 

ASF subversion and git services commented on GEODE-2309:


Commit 0657197f5099dc2e5d7735079ab7ef5165ec8947 in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=0657197 ]

GEODE-2309: Remove or ignore apache-rat flagged files

This closes #12.


> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872611#comment-15872611
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/12


> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871043#comment-15871043
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/12#discussion_r101671763
  
--- Diff: .ratignore ---
@@ -23,10 +23,12 @@
 
 # expect script
 .*changepasswd$
+.*winrm.cloud-init$
 
 # doxygen
 .*package-list$
 .*testframeworkdox.txt$
+docs
--- End diff --

Hmm.. ok.


> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870916#comment-15870916
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/12#discussion_r101658884
  
--- Diff: .ratignore ---
@@ -23,10 +23,12 @@
 
 # expect script
 .*changepasswd$
+.*winrm.cloud-init$
 
 # doxygen
 .*package-list$
 .*testframeworkdox.txt$
+docs
--- End diff --

This will match any file with "docs" in it. Seems like a rather greedy 
regex.


> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868561#comment-15868561
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

GitHub user dgkimura opened a pull request:

https://github.com/apache/geode-native/pull/12

GEODE-2309: Remove or ignore apache-rat flagged files

`resolv.config` used to work around Solaris SPARC networking issues on a 
local OpenStack instance.  It should not be needed going forward.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dgkimura/geode-native feature/GEODE-2309

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12


commit 8d29d42869b4df5a83ef83c8e2c8992074b378ef
Author: David Kimura 
Date:   2017-02-15T20:58:33Z

GEODE-2309: Remove or ignore apache-rat flagged files




> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833124#comment-15833124
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

Github user pivotal-jbarrett closed the pull request at:

https://github.com/apache/geode/pull/342


> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832176#comment-15832176
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

Github user scmbuildguy commented on the issue:

https://github.com/apache/geode/pull/342
  
+1 for this round


> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832150#comment-15832150
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/342
  
LGTM, these changes typically take multiple iterations to get right.


> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826950#comment-15826950
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/342
  
Looks good so far, but there are still a lot of files missing apache 
headers. I don't know how easy it will be to integrate [apache 
rat](https://creadur.apache.org/rat/) into the cmake build, but for now you can 
run it from the command line to get a list of files that are missing licenses:

java -jar /path/to/apache-rat-0.12.jar  .

I see a few java files, shell scripts, text files, and a lot of xml files 
without apache headers.

[missing_licences.txt](https://github.com/apache/geode/files/712483/missing_licences.txt)



> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826875#comment-15826875
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode/pull/342

GEODE-2309: Replace Pivotal Copyright and add Apache License notice.

Can I please get quick review of the copyright and license changes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode feature/GEODE-2309

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/342.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #342


commit 698e46b3e1071fa0ff4135de28173b5dbd394e4e
Author: Jacob Barrett 
Date:   2017-01-17T06:45:45Z

GEODE-2309: Replace Pivotal Copyright and add Apache License notice.




> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)