[jira] [Commented] (GEODE-2326) Fix broken integration test testLogger

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832166#comment-15832166
 ] 

ASF GitHub Bot commented on GEODE-2326:
---

Github user dgkimura closed the pull request at:

https://github.com/apache/geode/pull/346


> Fix broken integration test testLogger
> --
>
> Key: GEODE-2326
> URL: https://issues.apache.org/jira/browse/GEODE-2326
> Project: Geode
>  Issue Type: Test
>  Components: native client
>Reporter: David Kimura
>
> Banner length is hardcoded in this test.  This led to test broking after 
> changing to banner to Apache License.
> Test can be fixed by adjusting the hardcoded length like so..
> {noformat}
> $ git diff
> diff --git a/src/cppcache/integration-test/testLogger.cpp 
> b/src/cppcache/integration-test/testLogger.cpp
> index 6de4e68..8695bf1 100644
> --- a/src/cppcache/integration-test/testLogger.cpp
> +++ b/src/cppcache/integration-test/testLogger.cpp
> @@ -24,7 +24,7 @@
>  #include 
>  #endif
> -#define LENGTH_OF_BANNER 9
> +#define LENGTH_OF_BANNER 16
>  using namespace gemfire;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2326) Fix broken integration test testLogger

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832144#comment-15832144
 ] 

ASF subversion and git services commented on GEODE-2326:


Commit d777525b93e9bb1f6b66af2a2873c06eb0c54c52 in geode's branch 
refs/heads/next-gen-native-client-software-grant from [~dkimura]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d777525 ]

GEODE-2326: Adjust testLogger hardcoded value

This closes #346


> Fix broken integration test testLogger
> --
>
> Key: GEODE-2326
> URL: https://issues.apache.org/jira/browse/GEODE-2326
> Project: Geode
>  Issue Type: Test
>  Components: native client
>Reporter: David Kimura
>
> Banner length is hardcoded in this test.  This led to test broking after 
> changing to banner to Apache License.
> Test can be fixed by adjusting the hardcoded length like so..
> {noformat}
> $ git diff
> diff --git a/src/cppcache/integration-test/testLogger.cpp 
> b/src/cppcache/integration-test/testLogger.cpp
> index 6de4e68..8695bf1 100644
> --- a/src/cppcache/integration-test/testLogger.cpp
> +++ b/src/cppcache/integration-test/testLogger.cpp
> @@ -24,7 +24,7 @@
>  #include 
>  #endif
> -#define LENGTH_OF_BANNER 9
> +#define LENGTH_OF_BANNER 16
>  using namespace gemfire;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2326) Fix broken integration test testLogger

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832136#comment-15832136
 ] 

ASF GitHub Bot commented on GEODE-2326:
---

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/346
  
LGTM


> Fix broken integration test testLogger
> --
>
> Key: GEODE-2326
> URL: https://issues.apache.org/jira/browse/GEODE-2326
> Project: Geode
>  Issue Type: Test
>  Components: native client
>Reporter: David Kimura
>
> Banner length is hardcoded in this test.  This led to test broking after 
> changing to banner to Apache License.
> Test can be fixed by adjusting the hardcoded length like so..
> {noformat}
> $ git diff
> diff --git a/src/cppcache/integration-test/testLogger.cpp 
> b/src/cppcache/integration-test/testLogger.cpp
> index 6de4e68..8695bf1 100644
> --- a/src/cppcache/integration-test/testLogger.cpp
> +++ b/src/cppcache/integration-test/testLogger.cpp
> @@ -24,7 +24,7 @@
>  #include 
>  #endif
> -#define LENGTH_OF_BANNER 9
> +#define LENGTH_OF_BANNER 16
>  using namespace gemfire;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2326) Fix broken integration test testLogger

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830310#comment-15830310
 ] 

ASF GitHub Bot commented on GEODE-2326:
---

GitHub user dgkimura opened a pull request:

https://github.com/apache/geode/pull/346

GEODE-2326: Adjust testLogger hardcoded value

Fixes the failing logger integration test.  This was caused when we changed 
the log header to the Apache License.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dgkimura/geode wip/GEODE-2326

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #346


commit 3fd93acf3252f6ec8502a0840e906610f236f509
Author: David Kimura 
Date:   2017-01-19T02:14:26Z

GEODE-2326: Adjust testLogger hardcoded value




> Fix broken integration test testLogger
> --
>
> Key: GEODE-2326
> URL: https://issues.apache.org/jira/browse/GEODE-2326
> Project: Geode
>  Issue Type: Test
>  Components: native client
>Reporter: David Kimura
>
> Banner length is hardcoded in this test.  This led to test broking after 
> changing to banner to Apache License.
> Test can be fixed by adjusting the hardcoded length like so..
> {noformat}
> $ git diff
> diff --git a/src/cppcache/integration-test/testLogger.cpp 
> b/src/cppcache/integration-test/testLogger.cpp
> index 6de4e68..8695bf1 100644
> --- a/src/cppcache/integration-test/testLogger.cpp
> +++ b/src/cppcache/integration-test/testLogger.cpp
> @@ -24,7 +24,7 @@
>  #include 
>  #endif
> -#define LENGTH_OF_BANNER 9
> +#define LENGTH_OF_BANNER 16
>  using namespace gemfire;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)