[jira] [Commented] (GEODE-236) Remove deprecated CacheEvent methods
[ https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003276#comment-16003276 ] ASF subversion and git services commented on GEODE-236: --- Commit 250c818940ad9fa1c773ce17c85bf02388d2 in geode's branch refs/heads/develop from [~dschneider] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=250c818 ] GEODE-236: fix javadoc warnings Also removed two implementations of the deprecated methods that had been removed. > Remove deprecated CacheEvent methods > > > Key: GEODE-236 > URL: https://issues.apache.org/jira/browse/GEODE-236 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Darrel Schneider > Original Estimate: 4h > Remaining Estimate: 4h > > The following methods need to be removed: > - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration > - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed > This should be a pretty easy task to complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-236) Remove deprecated CacheEvent methods
[ https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003249#comment-16003249 ] Darrel Schneider commented on GEODE-236: The previous fix introduced these javadocs warnings. I will check in a fix for these soon: {noformat} :geode-core:javadoc/tmp/gemfire-build/geode/geode-core/src/main/java/org/apache/geode/internal/cache/RegionEventImpl.java:193: warning - Tag @see: can't find isExpiration() in org.apache.geode.cache.CacheEvent /tmp/gemfire-build/geode/geode-core/src/main/java/org/apache/geode/internal/cache/RegionEventImpl.java:200: warning - Tag @see: can't find isDistributed() in org.apache.geode.cache.CacheEvent {noformat} > Remove deprecated CacheEvent methods > > > Key: GEODE-236 > URL: https://issues.apache.org/jira/browse/GEODE-236 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Darrel Schneider > Original Estimate: 4h > Remaining Estimate: 4h > > The following methods need to be removed: > - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration > - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed > This should be a pretty easy task to complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-236) Remove deprecated CacheEvent methods
[ https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983340#comment-15983340 ] ASF subversion and git services commented on GEODE-236: --- Commit b7b02e04b47a7b3b775ea9909a7029fc9f3eb1b4 in geode's branch refs/heads/feature/GEODE-2632-6-1 from [~adongre] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b7b02e0 ] GEODE-236: Removed deprecated CacheEvent methods Signed-off-by: adongreGEODE-236: Spotless error fix. This closes #463 Signed-off-by: adongre > Remove deprecated CacheEvent methods > > > Key: GEODE-236 > URL: https://issues.apache.org/jira/browse/GEODE-236 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Avinash Dongre > Original Estimate: 4h > Remaining Estimate: 4h > > The following methods need to be removed: > - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration > - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed > This should be a pretty easy task to complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-236) Remove deprecated CacheEvent methods
[ https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983341#comment-15983341 ] ASF subversion and git services commented on GEODE-236: --- Commit b7b02e04b47a7b3b775ea9909a7029fc9f3eb1b4 in geode's branch refs/heads/feature/GEODE-2632-6-1 from [~adongre] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b7b02e0 ] GEODE-236: Removed deprecated CacheEvent methods Signed-off-by: adongreGEODE-236: Spotless error fix. This closes #463 Signed-off-by: adongre > Remove deprecated CacheEvent methods > > > Key: GEODE-236 > URL: https://issues.apache.org/jira/browse/GEODE-236 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Avinash Dongre > Original Estimate: 4h > Remaining Estimate: 4h > > The following methods need to be removed: > - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration > - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed > This should be a pretty easy task to complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-236) Remove deprecated CacheEvent methods
[ https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982539#comment-15982539 ] ASF subversion and git services commented on GEODE-236: --- Commit b7b02e04b47a7b3b775ea9909a7029fc9f3eb1b4 in geode's branch refs/heads/develop from [~adongre] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b7b02e0 ] GEODE-236: Removed deprecated CacheEvent methods Signed-off-by: adongreGEODE-236: Spotless error fix. This closes #463 Signed-off-by: adongre > Remove deprecated CacheEvent methods > > > Key: GEODE-236 > URL: https://issues.apache.org/jira/browse/GEODE-236 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Avinash Dongre > Original Estimate: 4h > Remaining Estimate: 4h > > The following methods need to be removed: > - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration > - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed > This should be a pretty easy task to complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-236) Remove deprecated CacheEvent methods
[ https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982541#comment-15982541 ] ASF GitHub Bot commented on GEODE-236: -- Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/463 > Remove deprecated CacheEvent methods > > > Key: GEODE-236 > URL: https://issues.apache.org/jira/browse/GEODE-236 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Avinash Dongre > Original Estimate: 4h > Remaining Estimate: 4h > > The following methods need to be removed: > - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration > - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed > This should be a pretty easy task to complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-236) Remove deprecated CacheEvent methods
[ https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982540#comment-15982540 ] ASF subversion and git services commented on GEODE-236: --- Commit b7b02e04b47a7b3b775ea9909a7029fc9f3eb1b4 in geode's branch refs/heads/develop from [~adongre] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b7b02e0 ] GEODE-236: Removed deprecated CacheEvent methods Signed-off-by: adongreGEODE-236: Spotless error fix. This closes #463 Signed-off-by: adongre > Remove deprecated CacheEvent methods > > > Key: GEODE-236 > URL: https://issues.apache.org/jira/browse/GEODE-236 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Avinash Dongre > Original Estimate: 4h > Remaining Estimate: 4h > > The following methods need to be removed: > - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration > - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed > This should be a pretty easy task to complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-236) Remove deprecated CacheEvent methods
[ https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977278#comment-15977278 ] ASF GitHub Bot commented on GEODE-236: -- GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/463 GEODE-236: Removed deprecated CacheEvent methods Removed deprecated CacheEvent methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-236 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/463.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #463 commit f9cd9793efcfa8fb40c0fef03b88ee8689114a2a Author: adongreDate: 2017-04-19T10:19:43Z GEODE-236: Removed deprecated CacheEvent methods > Remove deprecated CacheEvent methods > > > Key: GEODE-236 > URL: https://issues.apache.org/jira/browse/GEODE-236 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Avinash Dongre > Original Estimate: 4h > Remaining Estimate: 4h > > The following methods need to be removed: > - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration > - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed > This should be a pretty easy task to complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)