[jira] [Commented] (GEODE-255) Remove deprecated DataSerializer.register(Class,byte)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984731#comment-15984731
 ] 

ASF GitHub Bot commented on GEODE-255:
--

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/466


> Remove deprecated DataSerializer.register(Class,byte)
> -
>
> Key: GEODE-255
> URL: https://issues.apache.org/jira/browse/GEODE-255
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Remove the deprecated DataSerializer.register(Class,byte) method.
> It should be simple to change all callers to DataSerializer.register(Class) 
> since the current implementation does that.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-255) Remove deprecated DataSerializer.register(Class,byte)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984730#comment-15984730
 ] 

ASF subversion and git services commented on GEODE-255:
---

Commit 384970dabbcb8476a074b83f50052339ebba5bae in geode's branch 
refs/heads/develop from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=384970d ]

GEODE-255: Removed deprecated DataSerializer.register(Class,byte)
This closes #466

Signed-off-by: adongre 


> Remove deprecated DataSerializer.register(Class,byte)
> -
>
> Key: GEODE-255
> URL: https://issues.apache.org/jira/browse/GEODE-255
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Remove the deprecated DataSerializer.register(Class,byte) method.
> It should be simple to change all callers to DataSerializer.register(Class) 
> since the current implementation does that.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-255) Remove deprecated DataSerializer.register(Class,byte)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983909#comment-15983909
 ] 

ASF GitHub Bot commented on GEODE-255:
--

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/466
  
I think it's good to merge!


> Remove deprecated DataSerializer.register(Class,byte)
> -
>
> Key: GEODE-255
> URL: https://issues.apache.org/jira/browse/GEODE-255
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Remove the deprecated DataSerializer.register(Class,byte) method.
> It should be simple to change all callers to DataSerializer.register(Class) 
> since the current implementation does that.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-255) Remove deprecated DataSerializer.register(Class,byte)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982547#comment-15982547
 ] 

ASF GitHub Bot commented on GEODE-255:
--

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/466
  
Thanks @upthewaterspout  for review

Is this PR OK to merge ?


> Remove deprecated DataSerializer.register(Class,byte)
> -
>
> Key: GEODE-255
> URL: https://issues.apache.org/jira/browse/GEODE-255
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Remove the deprecated DataSerializer.register(Class,byte) method.
> It should be simple to change all callers to DataSerializer.register(Class) 
> since the current implementation does that.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-255) Remove deprecated DataSerializer.register(Class,byte)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977285#comment-15977285
 ] 

ASF GitHub Bot commented on GEODE-255:
--

GitHub user davinash opened a pull request:

https://github.com/apache/geode/pull/466

GEODE-255: Removed deprecated DataSerializer.register(Class,byte)

Removed deprecated DataSerializer.register(Class,byte)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davinash/geode feature/GEODE-255

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #466






> Remove deprecated DataSerializer.register(Class,byte)
> -
>
> Key: GEODE-255
> URL: https://issues.apache.org/jira/browse/GEODE-255
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Remove the deprecated DataSerializer.register(Class,byte) method.
> It should be simple to change all callers to DataSerializer.register(Class) 
> since the current implementation does that.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)