[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016332#comment-16016332 ] ASF subversion and git services commented on GEODE-2587: Commit b3fc0c814948cdfeb3181fcb57d07886aba8691e in geode's branch refs/heads/feature/GEODE-2929-1 from nabarunnag [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b3fc0c8 ] GEODE-2587: Refactored the OrderByComparator's compare method * This prevents creation of extra data structures like arrays of arrays * Hence let number of GC, faster execution of queries with ORDER BY This closes #517 > Refactor OrderByComparator's compare method > --- > > Key: GEODE-2587 > URL: https://issues.apache.org/jira/browse/GEODE-2587 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun > Fix For: 1.2.0 > > > OrderByComparator's compare method creates a lot of objects / arrays with the > intention of comparing two objects. > But allocation of memory for these objects results in GC to kick in. > The additional time consumed in GC results in increased execution time for > queries with ORDER BY clause. > This method must be refactored to require less memory allocations in order to > compare and thus speed up ORDER BY clause. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014952#comment-16014952 ] ASF GitHub Bot commented on GEODE-2587: --- Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/517 > Refactor OrderByComparator's compare method > --- > > Key: GEODE-2587 > URL: https://issues.apache.org/jira/browse/GEODE-2587 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun > > OrderByComparator's compare method creates a lot of objects / arrays with the > intention of comparing two objects. > But allocation of memory for these objects results in GC to kick in. > The additional time consumed in GC results in increased execution time for > queries with ORDER BY clause. > This method must be refactored to require less memory allocations in order to > compare and thus speed up ORDER BY clause. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014951#comment-16014951 ] ASF subversion and git services commented on GEODE-2587: Commit b3fc0c814948cdfeb3181fcb57d07886aba8691e in geode's branch refs/heads/develop from nabarunnag [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b3fc0c8 ] GEODE-2587: Refactored the OrderByComparator's compare method * This prevents creation of extra data structures like arrays of arrays * Hence let number of GC, faster execution of queries with ORDER BY This closes #517 > Refactor OrderByComparator's compare method > --- > > Key: GEODE-2587 > URL: https://issues.apache.org/jira/browse/GEODE-2587 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun > > OrderByComparator's compare method creates a lot of objects / arrays with the > intention of comparing two objects. > But allocation of memory for these objects results in GC to kick in. > The additional time consumed in GC results in increased execution time for > queries with ORDER BY clause. > This method must be refactored to require less memory allocations in order to > compare and thus speed up ORDER BY clause. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014797#comment-16014797 ] ASF GitHub Bot commented on GEODE-2587: --- Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 Yes, we are opening a new ticket for eliminating the repeated code. Analyzing the testcode for ORDER BY queries. > Refactor OrderByComparator's compare method > --- > > Key: GEODE-2587 > URL: https://issues.apache.org/jira/browse/GEODE-2587 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun > > OrderByComparator's compare method creates a lot of objects / arrays with the > intention of comparing two objects. > But allocation of memory for these objects results in GC to kick in. > The additional time consumed in GC results in increased execution time for > queries with ORDER BY clause. > This method must be refactored to require less memory allocations in order to > compare and thus speed up ORDER BY clause. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014782#comment-16014782 ] ASF GitHub Bot commented on GEODE-2587: --- Github user jhuynh1 commented on the issue: https://github.com/apache/geode/pull/517 We definitely have order by in the tests, whether or not they are adequate I am not sure. doing a find on "order by" will show a log of queries in the tests... The changes look good to me, if in the future we could collapse common code or extract some into smaller methods that would be great. > Refactor OrderByComparator's compare method > --- > > Key: GEODE-2587 > URL: https://issues.apache.org/jira/browse/GEODE-2587 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun > > OrderByComparator's compare method creates a lot of objects / arrays with the > intention of comparing two objects. > But allocation of memory for these objects results in GC to kick in. > The additional time consumed in GC results in increased execution time for > queries with ORDER BY clause. > This method must be refactored to require less memory allocations in order to > compare and thus speed up ORDER BY clause. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014670#comment-16014670 ] ASF GitHub Bot commented on GEODE-2587: --- Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 @ladyVader I am assuming that there should be tests already present testing the functional aspect. One of the tests did fail and caught an issue in my fix. @jhuynh1 what do you think? > Refactor OrderByComparator's compare method > --- > > Key: GEODE-2587 > URL: https://issues.apache.org/jira/browse/GEODE-2587 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun > > OrderByComparator's compare method creates a lot of objects / arrays with the > intention of comparing two objects. > But allocation of memory for these objects results in GC to kick in. > The additional time consumed in GC results in increased execution time for > queries with ORDER BY clause. > This method must be refactored to require less memory allocations in order to > compare and thus speed up ORDER BY clause. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014520#comment-16014520 ] ASF GitHub Bot commented on GEODE-2587: --- Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 Potential Reviewers @ladyVader @jhuynh1 @boglesby @upthewaterspout @gesterzhou > Refactor OrderByComparator's compare method > --- > > Key: GEODE-2587 > URL: https://issues.apache.org/jira/browse/GEODE-2587 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun > > OrderByComparator's compare method creates a lot of objects / arrays with the > intention of comparing two objects. > But allocation of memory for these objects results in GC to kick in. > The additional time consumed in GC results in increased execution time for > queries with ORDER BY clause. > This method must be refactored to require less memory allocations in order to > compare and thus speed up ORDER BY clause. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014514#comment-16014514 ] ASF GitHub Bot commented on GEODE-2587: --- GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/517 GEODE-2587: Refactored the OrderByComparator's compare method Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2587 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/517.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #517 commit 5a2a36e05cb0dbf88a527091797da256780a1cc4 Author: nabarunnag Date: 2017-05-15T05:19:26Z GEODE-2587: Refactored the OrderByComparator's compare method > Refactor OrderByComparator's compare method > --- > > Key: GEODE-2587 > URL: https://issues.apache.org/jira/browse/GEODE-2587 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun > > OrderByComparator's compare method creates a lot of objects / arrays with the > intention of comparing two objects. > But allocation of memory for these objects results in GC to kick in. > The additional time consumed in GC results in increased execution time for > queries with ORDER BY clause. > This method must be refactored to require less memory allocations in order to > compare and thus speed up ORDER BY clause. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014494#comment-16014494 ] ASF GitHub Bot commented on GEODE-2587: --- Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/516 > Refactor OrderByComparator's compare method > --- > > Key: GEODE-2587 > URL: https://issues.apache.org/jira/browse/GEODE-2587 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun > > OrderByComparator's compare method creates a lot of objects / arrays with the > intention of comparing two objects. > But allocation of memory for these objects results in GC to kick in. > The additional time consumed in GC results in increased execution time for > queries with ORDER BY clause. > This method must be refactored to require less memory allocations in order to > compare and thus speed up ORDER BY clause. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014488#comment-16014488 ] ASF GitHub Bot commented on GEODE-2587: --- GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/516 GEODE-2587: Refactored the OrderByComparator's compare method Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2587 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/516.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #516 commit edf70471a8efc963d3086e663918a67b039b2efd Author: nabarunnag Date: 2017-05-15T05:19:26Z GEODE-2587: Refactored the OrderByComparator's compare method > Refactor OrderByComparator's compare method > --- > > Key: GEODE-2587 > URL: https://issues.apache.org/jira/browse/GEODE-2587 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun > > OrderByComparator's compare method creates a lot of objects / arrays with the > intention of comparing two objects. > But allocation of memory for these objects results in GC to kick in. > The additional time consumed in GC results in increased execution time for > queries with ORDER BY clause. > This method must be refactored to require less memory allocations in order to > compare and thus speed up ORDER BY clause. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
