[jira] [Commented] (GEODE-2636) Update exemplary code to follow library renaming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905817#comment-15905817
 ] 

ASF GitHub Bot commented on GEODE-2636:
---

GitHub user PivotalSarge opened a pull request:

https://github.com/apache/geode-native/pull/51

GEODE-2636: Fix C# quickstarts.

The C# quickstarts do not use CMake so the Visual Studio project files also 
needed to be updated with the product DLL name.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PivotalSarge/geode-native feature/GEODE-2636

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit ec8de9ee6e583447e5c1c06b64dc590e6bfad423
Author: Sarge 
Date:   2017-03-10T21:59:51Z

GEODE-2636: Switch to variable in VS projects.

commit ed46520bef1b013acc441f169684ef800319df86
Author: Sarge 
Date:   2017-03-10T22:24:29Z

GEODE-2636: Revert change to assembly name.




> Update exemplary code to follow library renaming
> 
>
> Key: GEODE-2636
> URL: https://issues.apache.org/jira/browse/GEODE-2636
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The work done for GEODE-2508 needs to be accommodated in the template and 
> quickstart code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2636) Update exemplary code to follow library renaming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903939#comment-15903939
 ] 

ASF GitHub Bot commented on GEODE-2636:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/50


> Update exemplary code to follow library renaming
> 
>
> Key: GEODE-2636
> URL: https://issues.apache.org/jira/browse/GEODE-2636
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The work done for GEODE-2508 needs to be accommodated in the template and 
> quickstart code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2636) Update exemplary code to follow library renaming

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903938#comment-15903938
 ] 

ASF subversion and git services commented on GEODE-2636:


Commit 7836549522817c97b6a319b19353265eaf3257c5 in geode-native's branch 
refs/heads/develop from [~PivotalSarge]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=7836549 ]

GEODE-2636: Ensure reasonable default library names.

This closes #50


> Update exemplary code to follow library renaming
> 
>
> Key: GEODE-2636
> URL: https://issues.apache.org/jira/browse/GEODE-2636
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The work done for GEODE-2508 needs to be accommodated in the template and 
> quickstart code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2636) Update exemplary code to follow library renaming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903867#comment-15903867
 ] 

ASF GitHub Bot commented on GEODE-2636:
---

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/50#discussion_r105272239
  
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,6 +26,9 @@ elseif(UNIX)
 set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${NATIVECLIENT_DIR}/lib)
 endif()
 
+set(PRODUCT_LIB_NAME "apache-geode" CACHE STRING "Binary name")
--- End diff --

Ah, makes sense.  I was wondering how that got set.


> Update exemplary code to follow library renaming
> 
>
> Key: GEODE-2636
> URL: https://issues.apache.org/jira/browse/GEODE-2636
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The work done for GEODE-2508 needs to be accommodated in the template and 
> quickstart code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2636) Update exemplary code to follow library renaming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903827#comment-15903827
 ] 

ASF GitHub Bot commented on GEODE-2636:
---

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/50#discussion_r105266335
  
--- Diff: src/quickstart/cpp/PdxSerializer.cpp ---
@@ -165,15 +165,15 @@ int main(int argc, char** argv) {
 LOGINFO("Registered Person Query Objects");
 
 // Populate the Region with some Person objects.
-Person* p1 = new Person("John", 1 /*ID*/, 23 /*age*/);
+Person* p1 = new Person((char *)"John", 1 /*ID*/, 23 /*age*/);
--- End diff --

Those methods pass a string literal to a method whose first parameter is 
char *. An alternative would be to modify the type of the parameter but that 
was a more invasive change when the goal was to reduce the clutter in the log 
that got in the way of determining the root cause.


> Update exemplary code to follow library renaming
> 
>
> Key: GEODE-2636
> URL: https://issues.apache.org/jira/browse/GEODE-2636
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The work done for GEODE-2508 needs to be accommodated in the template and 
> quickstart code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2636) Update exemplary code to follow library renaming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903825#comment-15903825
 ] 

ASF GitHub Bot commented on GEODE-2636:
---

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/50#discussion_r105265184
  
--- Diff: src/quickstart/cpp/PdxSerializer.cpp ---
@@ -165,15 +165,15 @@ int main(int argc, char** argv) {
 LOGINFO("Registered Person Query Objects");
 
 // Populate the Region with some Person objects.
-Person* p1 = new Person("John", 1 /*ID*/, 23 /*age*/);
+Person* p1 = new Person((char *)"John", 1 /*ID*/, 23 /*age*/);
--- End diff --

What led to adding this cast?


> Update exemplary code to follow library renaming
> 
>
> Key: GEODE-2636
> URL: https://issues.apache.org/jira/browse/GEODE-2636
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The work done for GEODE-2508 needs to be accommodated in the template and 
> quickstart code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2636) Update exemplary code to follow library renaming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903802#comment-15903802
 ] 

ASF GitHub Bot commented on GEODE-2636:
---

GitHub user PivotalSarge opened a pull request:

https://github.com/apache/geode-native/pull/50

GEODE-2636: Switch to CMake variable for library name.

- Parameterize the name of the library for which the quickstarts look.
- Fix warnings that obfuscate when the quickstarts can not find a library.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PivotalSarge/geode-native feature/GEODE-2636

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/50.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #50


commit e897dd59a4f03eb22483bb41b8db38bb84686132
Author: Sarge 
Date:   2017-03-08T22:28:52Z

GEODE-2636: Switch to CMake variable for library name.




> Update exemplary code to follow library renaming
> 
>
> Key: GEODE-2636
> URL: https://issues.apache.org/jira/browse/GEODE-2636
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The work done for GEODE-2508 needs to be accommodated in the template and 
> quickstart code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)