[jira] [Commented] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

2017-05-01 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991725#comment-15991725
 ] 

ASF subversion and git services commented on GEODE-2723:


Commit a5af405693a6ccd0e7124a9d9b912f1a653d79f9 in geode's branch 
refs/heads/feature/GEODE-2632-10 from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a5af405 ]

GEODE-2723: Removed localCacheEnabled field, and associated dead code.
This closes #440

Signed-off-by: adongre 


> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
> Fix For: 1.2.0
>
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

2017-05-01 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991639#comment-15991639
 ] 

ASF subversion and git services commented on GEODE-2723:


Commit a5af405693a6ccd0e7124a9d9b912f1a653d79f9 in geode's branch 
refs/heads/feature/GEM-1353 from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a5af405 ]

GEODE-2723: Removed localCacheEnabled field, and associated dead code.
This closes #440

Signed-off-by: adongre 


> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
> Fix For: 1.2.0
>
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

2017-04-28 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989615#comment-15989615
 ] 

ASF subversion and git services commented on GEODE-2723:


Commit 8dd87ed9b7449c77b751689ebf19f8ff5f025157 in geode's branch 
refs/heads/feature/GEODE-2852 from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8dd87ed ]

GEODE-2723: Removed localCacheEnabled field, and associated dead code.
This closes #440

Signed-off-by: adongre 


> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
> Fix For: 1.2.0
>
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

2017-04-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988101#comment-15988101
 ] 

ASF GitHub Bot commented on GEODE-2723:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/440


> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

2017-04-27 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988100#comment-15988100
 ] 

ASF subversion and git services commented on GEODE-2723:


Commit a5af405693a6ccd0e7124a9d9b912f1a653d79f9 in geode's branch 
refs/heads/develop from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a5af405 ]

GEODE-2723: Removed localCacheEnabled field, and associated dead code.
This closes #440

Signed-off-by: adongre 


> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

2017-04-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987222#comment-15987222
 ] 

ASF GitHub Bot commented on GEODE-2723:
---

Github user dschneider-pivotal commented on the issue:

https://github.com/apache/geode/pull/440
  
Looks good to merge


> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

2017-04-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987000#comment-15987000
 ] 

ASF GitHub Bot commented on GEODE-2723:
---

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/440
  
Is this ok to merge ?


> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

2017-04-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959267#comment-15959267
 ] 

ASF GitHub Bot commented on GEODE-2723:
---

GitHub user davinash opened a pull request:

https://github.com/apache/geode/pull/440

GEODE-2723: Removed localCacheEnabled field, and associated dead code.

- Removed localCacheEnabled field, and associated dead code.
- Ran pre-checkin, no failures.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davinash/geode feature/GEODE-2723

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #440






> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)