[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032177#comment-16032177 ] ASF subversion and git services commented on GEODE-2957: Commit 806751805cb47877b609ee35cbfa21b362a3d7b3 in geode's branch refs/heads/feature/GEODE-2632-19 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8067518 ] GEODE-2957 gfsh create lucene index "null" becomes "DEFAULT" This closes #543 > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031527#comment-16031527 ] ASF subversion and git services commented on GEODE-2957: Commit 806751805cb47877b609ee35cbfa21b362a3d7b3 in geode's branch refs/heads/feature/GEODE-1279 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8067518 ] GEODE-2957 gfsh create lucene index "null" becomes "DEFAULT" This closes #543 > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031522#comment-16031522 ] ASF subversion and git services commented on GEODE-2957: Commit 1ee19c759c4bdd4133f7dcf7df648f3437234a7d in geode's branch refs/heads/feature/GEODE-1279 from [~DivineEnder] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1ee19c7 ] GEODE-2957: Create Lucene index analyzer help updated to include keyword DEFAULT This closes #547 > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031520#comment-16031520 ] ASF subversion and git services commented on GEODE-2957: Commit 96665fafbcc06948b7152ca9ad7344ab938f27ff in geode's branch refs/heads/feature/GEODE-1279 from [~DivineEnder] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=96665fa ] GEODE-2957: Create Lucene index analyzer help updated to include keyword DEFAULT > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031521#comment-16031521 ] ASF subversion and git services commented on GEODE-2957: Commit 5b2cdf8c1499c8fdc1f76ad9351c30876f6623b2 in geode's branch refs/heads/feature/GEODE-1279 from [~nnag] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5b2cdf8 ] Revert "GEODE-2957: Create Lucene index analyzer help updated to include keyword DEFAULT" This reverts commit 96665fafbcc06948b7152ca9ad7344ab938f27ff. > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030295#comment-16030295 ] ASF subversion and git services commented on GEODE-2957: Commit 806751805cb47877b609ee35cbfa21b362a3d7b3 in geode's branch refs/heads/develop from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8067518 ] GEODE-2957 gfsh create lucene index "null" becomes "DEFAULT" This closes #543 > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030296#comment-16030296 ] ASF GitHub Bot commented on GEODE-2957: --- Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/543 > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030285#comment-16030285 ] ASF GitHub Bot commented on GEODE-2957: --- Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/543#discussion_r119232692 --- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb --- @@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName --region=/orders --field=customer,tags ``` pre // Create an index, specifying a custom analyzer for the second field -// Note: "null" in the first analyzer position uses the default analyzer +// Note: "DEFAULT" in the first analyzer position uses the default analyzer // for the first field gfsh>create lucene index --name=indexName --region=/orders - --field=customer,tags --analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer + --field=customer,tags --analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer ``` To use the entire value as a single field set the required `--field` --- End diff -- Cool. LGTM, then. +1 > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030274#comment-16030274 ] ASF GitHub Bot commented on GEODE-2957: --- Github user karensmolermiller commented on a diff in the pull request: https://github.com/apache/geode/pull/543#discussion_r119231641 --- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb --- @@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName --region=/orders --field=customer,tags ``` pre // Create an index, specifying a custom analyzer for the second field -// Note: "null" in the first analyzer position uses the default analyzer +// Note: "DEFAULT" in the first analyzer position uses the default analyzer // for the first field gfsh>create lucene index --name=indexName --region=/orders - --field=customer,tags --analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer + --field=customer,tags --analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer ``` To use the entire value as a single field set the required `--field` --- End diff -- The sentence that needs the comma has been completely rewritten for GEODE-3002. See PR https://github.com/apache/geode/pull/550 for the rewrite. Not implementing, as it would only cause a conflict upon merging in GEODE-3002. > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030156#comment-16030156 ] ASF GitHub Bot commented on GEODE-2957: --- Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/543#discussion_r119218480 --- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb --- @@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName --region=/orders --field=customer,tags ``` pre // Create an index, specifying a custom analyzer for the second field -// Note: "null" in the first analyzer position uses the default analyzer +// Note: "DEFAULT" in the first analyzer position uses the default analyzer // for the first field gfsh>create lucene index --name=indexName --region=/orders - --field=customer,tags --analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer + --field=customer,tags --analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer ``` To use the entire value as a single field set the required `--field` --- End diff -- Add a comma between "field" and "set" > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030135#comment-16030135 ] ASF GitHub Bot commented on GEODE-2957: --- Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/543 Looks good đź‘Ť > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029983#comment-16029983 ] ASF subversion and git services commented on GEODE-2957: Commit 1ee19c759c4bdd4133f7dcf7df648f3437234a7d in geode's branch refs/heads/develop from [~DivineEnder] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1ee19c7 ] GEODE-2957: Create Lucene index analyzer help updated to include keyword DEFAULT This closes #547 > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029985#comment-16029985 ] ASF GitHub Bot commented on GEODE-2957: --- Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/547 > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029969#comment-16029969 ] ASF subversion and git services commented on GEODE-2957: Commit 5b2cdf8c1499c8fdc1f76ad9351c30876f6623b2 in geode's branch refs/heads/develop from [~nnag] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5b2cdf8 ] Revert "GEODE-2957: Create Lucene index analyzer help updated to include keyword DEFAULT" This reverts commit 96665fafbcc06948b7152ca9ad7344ab938f27ff. > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029964#comment-16029964 ] ASF subversion and git services commented on GEODE-2957: Commit 96665fafbcc06948b7152ca9ad7344ab938f27ff in geode's branch refs/heads/develop from [~DivineEnder] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=96665fa ] GEODE-2957: Create Lucene index analyzer help updated to include keyword DEFAULT > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029915#comment-16029915 ] ASF GitHub Bot commented on GEODE-2957: --- Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/547 I will be merging this. > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029914#comment-16029914 ] ASF GitHub Bot commented on GEODE-2957: --- Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/543 I will be merging this. > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029758#comment-16029758 ] ASF GitHub Bot commented on GEODE-2957: --- Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/547 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029757#comment-16029757 ] ASF GitHub Bot commented on GEODE-2957: --- GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/547 GEODE-2957: Create Lucene index analyzer help updated to include keyw… …ord DEFAULT Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2957 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/547.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #547 commit 0e37c14c01dd5ceb853f337c6c45c6287e6ccd7f Author: David Anuta Date: 2017-05-30T16:27:11Z GEODE-2957: Create Lucene index analyzer help updated to include keyword DEFAULT > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026686#comment-16026686 ] ASF GitHub Bot commented on GEODE-2957: --- GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/543 GEODE-2957 gfsh create lucene index "null" becomes "DEFAULT" @DivineEnder @nabarunnag @ladyVader @boglesby @joeymcallister @davebarnes97 Please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/karensmolermiller/geode feature/GEODE-2957 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/543.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #543 commit fd7dfd0f61f8e46ff8b3a157ffa8f8dacdf74d31 Author: Karen Miller Date: 2017-05-26T18:57:49Z GEODE-2957 gfsh create lucene index "null" becomes "DEFAULT" > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Assignee: David Anuta > Fix For: 1.2.0 > > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025572#comment-16025572 ] ASF GitHub Bot commented on GEODE-2957: --- Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/537 > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025571#comment-16025571 ] ASF subversion and git services commented on GEODE-2957: Commit 29ea88a23ef0feb29e8d7684c4061ac54dc66874 in geode's branch refs/heads/develop from [~DivineEnder] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=29ea88a ] GEODE-2957: Lucene create index DEFAULT keyword added for standardAnalyzer This closes #537 > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025236#comment-16025236 ] ASF GitHub Bot commented on GEODE-2957: --- Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/537 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
[ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025235#comment-16025235 ] ASF GitHub Bot commented on GEODE-2957: --- GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/537 GEODE-2957: Added DEFAULT as a standardAnalyzer keyword specifier whe… …n creating Lucene index Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2957 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/537.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #537 commit 7b0543a7325ee08fb9b91710c9b406cc41f75451 Author: David Anuta Date: 2017-05-25T19:03:43Z GEODE-2957: Added DEFAULT as a standardAnalyzer keyword specifier when creating Lucene index > null used as a default parameter when specifying analyzers > -- > > Key: GEODE-2957 > URL: https://issues.apache.org/jira/browse/GEODE-2957 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh > > null seems to be the way to specify using the default > StandardKeywordAnalyzer. This can be used when specifying a long list of > field/analyzers. > So the line may look like > --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer} > We should probably change that to default or some other keyword. null seems > a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)