GfshConsoleModeUnitTest is failing in UnitTest
Did someone break unit tests? I have 3 PRs with unit tests failing in GfshConsoleModeUnitTest: org.apache.geode.management.internal.cli.shell.GfshConsoleModeUnitTest > consoleModeShouldRedirectOnlyJDKLoggers FAILED java.lang.AssertionError: Expecting: <"org.apache.geode.management.internal.cli.LogWrapper"> not to end with: <"LogWrapper"> at org.apache.geode.management.internal.cli.shell.GfshConsoleModeUnitTest.consoleModeShouldRedirectOnlyJDKLoggers(GfshConsoleModeUnitTest.java:54) Does anyone know which commit broke this test? Can we please revert that commit?
Re: GfshConsoleModeUnitTest is failing in UnitTest
There is a ticket for this, https://issues.apache.org/jira/browse/GEODE-6370 The problem “seems" to have started with this change: commit 7f10f3a297eeeb473c3f16fff9465df9b404a21c Date: Wed Feb 6 08:33:53 2019 -0800 GEODE-6364: Deploy of invalid jar file does not write file contents to config on locator (#3164) However, the unit test failure we’re seeing consistently now never appeared in the precheckin runs for PR 3164... > On Feb 6, 2019, at 4:20 PM, Kirk Lund wrote: > > Did someone break unit tests? > > I have 3 PRs with unit tests failing in GfshConsoleModeUnitTest: > > org.apache.geode.management.internal.cli.shell.GfshConsoleModeUnitTest > > consoleModeShouldRedirectOnlyJDKLoggers FAILED >java.lang.AssertionError: >Expecting: > <"org.apache.geode.management.internal.cli.LogWrapper"> >not to end with: > <"LogWrapper"> >at > org.apache.geode.management.internal.cli.shell.GfshConsoleModeUnitTest.consoleModeShouldRedirectOnlyJDKLoggers(GfshConsoleModeUnitTest.java:54) > > Does anyone know which commit broke this test? Can we please revert that > commit?
Re: GfshConsoleModeUnitTest is failing in UnitTest
I didn't touch anything in this area, but nevertheless I reverted my commit which preceded this failure (referenced in Owen's message). However, the failure is still happening. --Jens On Wed, Feb 6, 2019 at 6:20 PM Owen Nichols wrote: > There is a ticket for this, > https://issues.apache.org/jira/browse/GEODE-6370 > > The problem “seems" to have started with this change: > > commit 7f10f3a297eeeb473c3f16fff9465df9b404a21c > Date: Wed Feb 6 08:33:53 2019 -0800 > > GEODE-6364: Deploy of invalid jar file does not write file contents to > config on locator (#3164) > > However, the unit test failure we’re seeing consistently now never > appeared in the precheckin runs for PR 3164... > > > > On Feb 6, 2019, at 4:20 PM, Kirk Lund wrote: > > > > Did someone break unit tests? > > > > I have 3 PRs with unit tests failing in GfshConsoleModeUnitTest: > > > > org.apache.geode.management.internal.cli.shell.GfshConsoleModeUnitTest > > > consoleModeShouldRedirectOnlyJDKLoggers FAILED > >java.lang.AssertionError: > >Expecting: > > <"org.apache.geode.management.internal.cli.LogWrapper"> > >not to end with: > > <"LogWrapper"> > >at > > > org.apache.geode.management.internal.cli.shell.GfshConsoleModeUnitTest.consoleModeShouldRedirectOnlyJDKLoggers(GfshConsoleModeUnitTest.java:54) > > > > Does anyone know which commit broke this test? Can we please revert that > > commit? > >
Re: GfshConsoleModeUnitTest is failing in UnitTest
The problem is caused by some change in test ordering (unit tests are running in parallel) which is resulting in environmental pollution. Probably Government shutdown related... :P On Wed, Feb 6, 2019 at 7:31 PM Jens Deppe wrote: > I didn't touch anything in this area, but nevertheless I reverted my > commit which preceded this failure (referenced in Owen's message). However, > the failure is still happening. > > --Jens > > On Wed, Feb 6, 2019 at 6:20 PM Owen Nichols wrote: > >> There is a ticket for this, >> https://issues.apache.org/jira/browse/GEODE-6370 >> >> The problem “seems" to have started with this change: >> >> commit 7f10f3a297eeeb473c3f16fff9465df9b404a21c >> Date: Wed Feb 6 08:33:53 2019 -0800 >> >> GEODE-6364: Deploy of invalid jar file does not write file contents >> to config on locator (#3164) >> >> However, the unit test failure we’re seeing consistently now never >> appeared in the precheckin runs for PR 3164... >> >> >> > On Feb 6, 2019, at 4:20 PM, Kirk Lund wrote: >> > >> > Did someone break unit tests? >> > >> > I have 3 PRs with unit tests failing in GfshConsoleModeUnitTest: >> > >> > org.apache.geode.management.internal.cli.shell.GfshConsoleModeUnitTest > >> > consoleModeShouldRedirectOnlyJDKLoggers FAILED >> >java.lang.AssertionError: >> >Expecting: >> > <"org.apache.geode.management.internal.cli.LogWrapper"> >> >not to end with: >> > <"LogWrapper"> >> >at >> > >> org.apache.geode.management.internal.cli.shell.GfshConsoleModeUnitTest.consoleModeShouldRedirectOnlyJDKLoggers(GfshConsoleModeUnitTest.java:54) >> > >> > Does anyone know which commit broke this test? Can we please revert that >> > commit? >> >>
Re: GfshConsoleModeUnitTest is failing in UnitTest
Oh, feel free to review https://github.com/apache/geode/pull/3172. Better suggestions on how to 'fix' the problem are most welcome. On Thu, Feb 7, 2019 at 6:49 AM Jens Deppe wrote: > The problem is caused by some change in test ordering (unit tests are > running in parallel) which is resulting in environmental pollution. > > Probably Government shutdown related... :P > > On Wed, Feb 6, 2019 at 7:31 PM Jens Deppe wrote: > >> I didn't touch anything in this area, but nevertheless I reverted my >> commit which preceded this failure (referenced in Owen's message). However, >> the failure is still happening. >> >> --Jens >> >> On Wed, Feb 6, 2019 at 6:20 PM Owen Nichols wrote: >> >>> There is a ticket for this, >>> https://issues.apache.org/jira/browse/GEODE-6370 >>> >>> The problem “seems" to have started with this change: >>> >>> commit 7f10f3a297eeeb473c3f16fff9465df9b404a21c >>> Date: Wed Feb 6 08:33:53 2019 -0800 >>> >>> GEODE-6364: Deploy of invalid jar file does not write file contents >>> to config on locator (#3164) >>> >>> However, the unit test failure we’re seeing consistently now never >>> appeared in the precheckin runs for PR 3164... >>> >>> >>> > On Feb 6, 2019, at 4:20 PM, Kirk Lund wrote: >>> > >>> > Did someone break unit tests? >>> > >>> > I have 3 PRs with unit tests failing in GfshConsoleModeUnitTest: >>> > >>> > org.apache.geode.management.internal.cli.shell.GfshConsoleModeUnitTest >>> > >>> > consoleModeShouldRedirectOnlyJDKLoggers FAILED >>> >java.lang.AssertionError: >>> >Expecting: >>> > <"org.apache.geode.management.internal.cli.LogWrapper"> >>> >not to end with: >>> > <"LogWrapper"> >>> >at >>> > >>> org.apache.geode.management.internal.cli.shell.GfshConsoleModeUnitTest.consoleModeShouldRedirectOnlyJDKLoggers(GfshConsoleModeUnitTest.java:54) >>> > >>> > Does anyone know which commit broke this test? Can we please revert >>> that >>> > commit? >>> >>>
