Re: Odg: enable-time-statistics

2020-01-13 Thread Jacob Barrett
Enabling on the client does not effect the server. Very little work has gone 
into the native stats. I would suggest benchmarking them of performance is a 
concern. It’s been a while since I’ve been in the stats source so let me take a 
peek later to see what’s up with the option not working:

> On Jan 12, 2020, at 11:34 PM, Mario Kevo  wrote:
> 
> Thank you all for confirming this! 
> 
> Does anyone tried to enable it on geode native side?
> We tried, but without success. Do we need to change anything else except 
> enable-time-statistics to true as this not working?
> 
> BR,
> Mario
> 
> Šalje: Charlie Black 
> Poslano: 10. siječnja 2020. 23:00
> Prima: dev@geode.apache.org 
> Predmet: Re: enable-time-statistics
> 
> David,
> 
> I would say remove the caveat.Thanks for offering.
> 
> Charlie
> 
>> On Fri, Jan 10, 2020 at 1:55 PM Dave Barnes  wrote:
>> 
>> Sounds like the caveat could be dropped from the user guide. If we have
>> consensus on that (am I understanding correctly?), I'll initiate a JIRA
>> ticket.
>> 
>>> On Fri, Jan 10, 2020 at 1:47 PM Jacob Barrett  wrote:
>>> 
>>> The biggest impact was in recording all the additional stats in the old
>>> blocking stats implementation. As of 9.8 the stats internals are mostly
>>> non-blocking. Enabling time stats has very little of any impact now.
>>> 
 On Jan 10, 2020, at 12:45 PM, Dan Smith  wrote:
 
 I personally wouldn't be too worried about enabling time based
>>> statistics
 in production. I think we segregated the time statistics because they
>> do
 have to call System.nanoTime to measure the elapsed time. At one point
>> in
 the history with old JDKs they called System.currentTimeMillis, which
>> was
 really expensive. But now I'm not sure the nanoTime calls really have
>>> that
 much of an impact compared to the rest of the processing time.
 
 -Dan
 
 
> On Fri, Jan 10, 2020 at 11:25 AM Mario Kevo 
>>> wrote:
> 
> Hi geode-dev,
> 
> We have executed some traffic against Geode servers with time-based
> statistics enabled and disabled and we didn't see any performance
> difference.
> The documentation says:
> 
> 
> If you need time-based statistics, enable that. Time-based statistics
> require statistics sampling and archival. Example:
> 
> statistic-sampling-enabled=true
> statistic-archive-file=myStatisticsArchiveFile.gfs
> enable-time-statistics=true
> 
> 
> Note: Time-based statistics can impact system performance and is not
> recommended for production environments.
> 
> 
> Do you know on which part this note referring to?
> 
> 
> Also we tried to enable time statistics on geode native but without
> success.
> 
> We change in geode.properties file this parameter to true but didn't
>> get
> any additional statistics in statistics archive file.
> 
> Do we need also to change something else to enable it or this is not
> working for geode-native?
> 
> 
> BR,
> 
> Mario
> 
> 
>>> 
>> 
> 
> 
> --
> Charlie Black | cbl...@pivotal.io


Odg: enable-time-statistics

2020-01-12 Thread Mario Kevo
Thank you all for confirming this! 

Does anyone tried to enable it on geode native side?
We tried, but without success. Do we need to change anything else except 
enable-time-statistics to true as this not working?

BR,
Mario

Šalje: Charlie Black 
Poslano: 10. siječnja 2020. 23:00
Prima: dev@geode.apache.org 
Predmet: Re: enable-time-statistics

David,

I would say remove the caveat.Thanks for offering.

Charlie

On Fri, Jan 10, 2020 at 1:55 PM Dave Barnes  wrote:

> Sounds like the caveat could be dropped from the user guide. If we have
> consensus on that (am I understanding correctly?), I'll initiate a JIRA
> ticket.
>
> On Fri, Jan 10, 2020 at 1:47 PM Jacob Barrett  wrote:
>
> > The biggest impact was in recording all the additional stats in the old
> > blocking stats implementation. As of 9.8 the stats internals are mostly
> > non-blocking. Enabling time stats has very little of any impact now.
> >
> > > On Jan 10, 2020, at 12:45 PM, Dan Smith  wrote:
> > >
> > > I personally wouldn't be too worried about enabling time based
> > statistics
> > > in production. I think we segregated the time statistics because they
> do
> > > have to call System.nanoTime to measure the elapsed time. At one point
> in
> > > the history with old JDKs they called System.currentTimeMillis, which
> was
> > > really expensive. But now I'm not sure the nanoTime calls really have
> > that
> > > much of an impact compared to the rest of the processing time.
> > >
> > > -Dan
> > >
> > >
> > >> On Fri, Jan 10, 2020 at 11:25 AM Mario Kevo 
> > wrote:
> > >>
> > >> Hi geode-dev,
> > >>
> > >> We have executed some traffic against Geode servers with time-based
> > >> statistics enabled and disabled and we didn't see any performance
> > >> difference.
> > >> The documentation says:
> > >>
> > >>
> > >> If you need time-based statistics, enable that. Time-based statistics
> > >> require statistics sampling and archival. Example:
> > >>
> > >> statistic-sampling-enabled=true
> > >> statistic-archive-file=myStatisticsArchiveFile.gfs
> > >> enable-time-statistics=true
> > >>
> > >>
> > >> Note: Time-based statistics can impact system performance and is not
> > >> recommended for production environments.
> > >>
> > >>
> > >> Do you know on which part this note referring to?
> > >>
> > >>
> > >> Also we tried to enable time statistics on geode native but without
> > >> success.
> > >>
> > >> We change in geode.properties file this parameter to true but didn't
> get
> > >> any additional statistics in statistics archive file.
> > >>
> > >> Do we need also to change something else to enable it or this is not
> > >> working for geode-native?
> > >>
> > >>
> > >> BR,
> > >>
> > >> Mario
> > >>
> > >>
> >
>


--
Charlie Black | cbl...@pivotal.io