Re: Pullrequest required checks
I have a PR that makes required checks on master same as develop. Need approval. Once github actions are merged, then I will add back in the required checks. https://github.com/apache/geode/pull/7875 On Sun, 22 Jan 2023 at 12:40, Owen Nichols wrote: > Try updating .asf.yaml on master branch to same contents as develop. > > > > *From: *Sai Boorlagadda > *Date: *Sunday, January 22, 2023 at 8:30 AM > *To: *dev@geode.apache.org > *Subject: *Pullrequest required checks > > !! External Email > > Could someone have info regarding how the required checks are enabled on a > Pull Request? > > In the process of setting up the Github Actions, I see there are still > Concourse CI checks as "required" eg: on this PR[1] > > [1] > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7870&data=05%7C01%7Conichols%40vmware.com%7C618fc3c1c60b470a337108dafc95ebdb%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638100018100622080%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=f0X9PKhKPxJY%2BMEidZAqYnDAj3Q8Z3F5OzDH%2BgiuSLE%3D&reserved=0 > > Thanks > Sai > > !! External Email: This email originated from outside of the organization. > Do not click links or open attachments unless you recognize the sender. >
Re: Pullrequest required checks
Thanks, Owen and Michael. Will check the .asf.yaml file. On Mon, 23 Jan 2023 at 10:05, Michael Oleske wrote: > Quick addendum, it looks like you would have to update the master branch > as well as develop. As the master branch< > https://github.com/apache/geode/blob/master/.asf.yaml#L39> has more > required checks for reason. > > -michael > > From: Michael Oleske > Sent: Monday, January 23, 2023 09:20 > To: dev@geode.apache.org > Subject: Re: Pullrequest required checks > > !! External Email > > I believe the required checks are setup in the .asf.yaml file here< > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fblob%2Fdevelop%2F.asf.yaml%23L35&data=05%7C01%7Cmoleske%40vmware.com%7Ca08669bc99d24832dd5e08dafd662876%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638100912455129730%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5bKCtDt7LEO1WxYwtH5rtFCch5wJzjuk6uHGx3yQ9lY%3D&reserved=0>. > I would hope just deleting those lines would remove the existing checks and > in your migrate to github actions pr you could change the required checks. > I would hope this doesn't need a vote as those current required check's > pipelines seem to all have been removed. > > -michael > > From: Sai Boorlagadda > Sent: Sunday, January 22, 2023 08:28 > To: dev@geode.apache.org > Subject: Pullrequest required checks > > !! External Email > > Could someone have info regarding how the required checks are enabled on a > Pull Request? > > In the process of setting up the Github Actions, I see there are still > Concourse CI checks as "required" eg: on this PR[1] > > [1] > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7870&data=05%7C01%7Cmoleske%40vmware.com%7Ca08669bc99d24832dd5e08dafd662876%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638100912455129730%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4OndODLKhyumfbU330712kWLSgrc%2FkcGRh%2Fu4GQeLcs%3D&reserved=0 > > Thanks > Sai > > !! External Email: This email originated from outside of the organization. > Do not click links or open attachments unless you recognize the sender. >
Re: Pullrequest required checks
Quick addendum, it looks like you would have to update the master branch as well as develop. As the master branch<https://github.com/apache/geode/blob/master/.asf.yaml#L39> has more required checks for reason. -michael From: Michael Oleske Sent: Monday, January 23, 2023 09:20 To: dev@geode.apache.org Subject: Re: Pullrequest required checks !! External Email I believe the required checks are setup in the .asf.yaml file here<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fblob%2Fdevelop%2F.asf.yaml%23L35&data=05%7C01%7Cmoleske%40vmware.com%7Ca08669bc99d24832dd5e08dafd662876%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638100912455129730%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5bKCtDt7LEO1WxYwtH5rtFCch5wJzjuk6uHGx3yQ9lY%3D&reserved=0>. I would hope just deleting those lines would remove the existing checks and in your migrate to github actions pr you could change the required checks. I would hope this doesn't need a vote as those current required check's pipelines seem to all have been removed. -michael From: Sai Boorlagadda Sent: Sunday, January 22, 2023 08:28 To: dev@geode.apache.org Subject: Pullrequest required checks !! External Email Could someone have info regarding how the required checks are enabled on a Pull Request? In the process of setting up the Github Actions, I see there are still Concourse CI checks as "required" eg: on this PR[1] [1] https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7870&data=05%7C01%7Cmoleske%40vmware.com%7Ca08669bc99d24832dd5e08dafd662876%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638100912455129730%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4OndODLKhyumfbU330712kWLSgrc%2FkcGRh%2Fu4GQeLcs%3D&reserved=0 Thanks Sai !! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
Re: Pullrequest required checks
I believe the required checks are setup in the .asf.yaml file here<https://github.com/apache/geode/blob/develop/.asf.yaml#L35>. I would hope just deleting those lines would remove the existing checks and in your migrate to github actions pr you could change the required checks. I would hope this doesn't need a vote as those current required check's pipelines seem to all have been removed. -michael From: Sai Boorlagadda Sent: Sunday, January 22, 2023 08:28 To: dev@geode.apache.org Subject: Pullrequest required checks !! External Email Could someone have info regarding how the required checks are enabled on a Pull Request? In the process of setting up the Github Actions, I see there are still Concourse CI checks as "required" eg: on this PR[1] [1] https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7870&data=05%7C01%7Cmoleske%40vmware.com%7C64eff0f8ae934a67e2b608dafc95eb87%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638100018086696005%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4w0XLfg0ks8bVEwQRYIfsl5q1CKGpXy0pAUl7KUO2io%3D&reserved=0 Thanks Sai !! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
Pullrequest required checks
Could someone have info regarding how the required checks are enabled on a Pull Request? In the process of setting up the Github Actions, I see there are still Concourse CI checks as "required" eg: on this PR[1] [1] https://github.com/apache/geode/pull/7870 Thanks Sai
